@gajae-code/coding-agent 0.4.1 → 0.4.3

package/src/harness-control-plane/types.ts

@@ -8,9 +8,27 @@
  * v1 implements the gajae-code adapter only. omx/codex/remote/auth are deferred seams.
  */
 
+import type { AgentWireObservedSignal } from "../modes/shared/agent-wire/event-contract";
+
 /** Harnesses the control plane can operate. v1 implements `gajae-code` only. */
 export type Harness = "gajae-code" | "codex" | "omx";
 
+/** Operating mode of a session. `implement` builds/changes code; `review` produces a read-only verdict. */
+export type SessionMode = "implement" | "review";
+
+/** Closed vocabulary of terminal review verdicts a review-only session may emit. */
+export type ReviewVerdict = "APPROVE_MERGE_READY" | "REQUEST_CHANGES" | "OWNER_CONFIRMATION_REQUIRED";
+
+export const REVIEW_VERDICTS: readonly ReviewVerdict[] = [
+	"APPROVE_MERGE_READY",
+	"REQUEST_CHANGES",
+	"OWNER_CONFIRMATION_REQUIRED",
+];
+
+export function isReviewVerdict(value: unknown): value is ReviewVerdict {
+	return typeof value === "string" && (REVIEW_VERDICTS as readonly string[]).includes(value);
+}
+
 /** Lifecycle states of an operated session. */
 export type HarnessLifecycle =
 	| "new"
@@ -44,7 +62,13 @@ export type RecoveryClassification =
 	| "human-check";
 
 /** Receipt families persisted under the session storage dir. */
-export type ReceiptFamily = "vanish" | "prompt-acceptance" | "validation" | "completion";
+export type ReceiptFamily =
+	| "vanish"
+	| "prompt-acceptance"
+	| "validation"
+	| "completion"
+	| "review-verdict"
+	| "review-failure";
 
 /** The CLI verbs / primitives exposed by `gjc harness <verb>`. */
 export type HarnessVerb =
@@ -95,6 +119,8 @@ export interface PrimitiveResponse<E = Record<string, unknown>> {
 export interface SessionHandle {
 	sessionId: string;
 	harness: Harness;
+	/** Operating mode; absent on legacy records means `implement`. */
+	mode?: SessionMode;
 	repo: string | null;
 	workspace: string;
 	branch: string | null;
@@ -123,17 +149,12 @@ export interface SessionState {
 	updatedAt: string;
 }
 
-/** Bounded observed-signal vocabulary surfaced by `observe` (the owner only ever emits these). */
-export type ObservedSignal =
-	| "SessionStart"
-	| "prompt-accepted"
-	| "tool-call"
-	| "test-running"
-	| "commit-created"
-	| "completed"
-	| "error"
-	| "streaming"
-	| "idle";
+/**
+ * Bounded observed-signal vocabulary surfaced by `observe` (the owner only ever
+ * emits these). Aliased to the canonical agent-wire signal vocabulary so there
+ * is a single source of truth shared with the observation core.
+ */
+export type ObservedSignal = AgentWireObservedSignal;
 
 export const OBSERVED_SIGNALS: readonly ObservedSignal[] = [
 	"SessionStart",