@gajae-code/coding-agent 0.18.11 → 0.19.0

package/src/sdk/protocol/adapter-validation.ts

@@ -1,24 +1,59 @@
+import { MAX_STAGED_PROMPT_IMAGES } from "../../utils/image-limits";
+
 const RELOAD_COMPONENTS = new Set(["config", "models", "skills", "extensions", "tools"]);
-const SERVICE_TIERS = new Set(["none", "auto", "default", "flex", "scale", "priority", "openai-only", "claude-only"]);
+const SERVICE_TIERS = new Set([
+	"none",
+	"auto",
+	"default",
+	"flex",
+	"scale",
+	"priority",
+	"ultrafast",
+	"openai-only",
+	"claude-only",
+]);
 
 type Input = Record<string, unknown>;
 
 type SecretInputError = { code: "secret_field_forbidden"; message: string };
 const SECRET_FIELD = /(?:secret|token|password|credential|authorization|api[_-]?key)/i;
 
+type UltrafastRestrictionError = { code: "ultrafast_tier_forbidden"; message: string };
+
+function containsUltrafastServiceTier(value: unknown): boolean {
+	if (Array.isArray(value)) return value.some(containsUltrafastServiceTier);
+	if (!value || typeof value !== "object") return false;
+	return Object.entries(value as Record<string, unknown>).some(
+		([key, nested]) =>
+			((key === "serviceTier" || key.endsWith(".serviceTier")) && nested === "ultrafast") ||
+			containsUltrafastServiceTier(nested),
+	);
+}
+
 function containsSecretField(value: unknown): boolean {
 	if (Array.isArray(value)) return value.some(containsSecretField);
 	if (!value || typeof value !== "object") return false;
 	return Object.entries(value).some(([key, nested]) => SECRET_FIELD.test(key) || containsSecretField(nested));
 }
 
-/** Rejects secret-bearing config patches from model-facing adapter inputs. */
-export function validateAdapterSecretFields(operation: string, input: Input): SecretInputError | undefined {
-	if (operation === "config.patch" && containsSecretField(input)) {
-		return {
-			code: "secret_field_forbidden",
-			message: "config.patch secret fields are not available through this adapter.",
-		};
+/** Rejects secret-bearing and ultrafast-tier config patches from model-facing adapter inputs. */
+export function validateAdapterSecretFields(
+	operation: string,
+	input: Input,
+): SecretInputError | UltrafastRestrictionError | undefined {
+	if (operation === "config.patch") {
+		if (containsSecretField(input)) {
+			return {
+				code: "secret_field_forbidden",
+				message: "config.patch secret fields are not available through this adapter.",
+			};
+		}
+		if (containsUltrafastServiceTier(input)) {
+			return {
+				code: "ultrafast_tier_forbidden",
+				message: "config.patch serviceTier ultrafast is restricted to trusted local sources.",
+			};
+		}
 	}
 	return undefined;
 }
@@ -40,10 +75,35 @@ function hasUsablePromptImage(value: unknown): boolean {
 	);
 }
 
+function hasValidStagedPromptImages(value: unknown): boolean {
+	if (!Array.isArray(value) || value.length === 0 || value.length > MAX_STAGED_PROMPT_IMAGES) return false;
+	const ids = new Set<string>();
+	return value.every(descriptor => {
+		if (!descriptor || typeof descriptor !== "object" || Array.isArray(descriptor)) return false;
+		const image = descriptor as Record<string, unknown>;
+		if (Object.keys(image).some(key => key !== "id") || typeof image.id !== "string" || image.id.trim().length === 0)
+			return false;
+		if (ids.has(image.id)) return false;
+		ids.add(image.id);
+		return true;
+	});
+}
+
 /** Rejects instruction-bearing controls before correlation or provider work. */
 export function validateRequiredPromptText(operation: string, input: Input): AdapterValidationError | undefined {
+	if (operation === "turn.prompt" && input.stagedImages !== undefined) {
+		if (input.images !== undefined)
+			return { code: "invalid_input", message: "Direct and staged images cannot be mixed." };
+		if (!hasValidStagedPromptImages(input.stagedImages))
+			return {
+				code: "invalid_input",
+				message: `stagedImages must contain 1–${MAX_STAGED_PROMPT_IMAGES} valid image IDs.`,
+			};
+	}
 	const hasUsableImage =
-		operation === "turn.prompt" && Array.isArray(input.images) && input.images.some(hasUsablePromptImage);
+		operation === "turn.prompt" &&
+		((Array.isArray(input.images) && input.images.some(hasUsablePromptImage)) ||
+			hasValidStagedPromptImages(input.stagedImages));
 	if (
 		PROMPT_OPERATIONS.has(operation) &&
 		(typeof input.text !== "string" || (input.text.trim().length === 0 && !hasUsableImage))
@@ -53,8 +113,12 @@ export function validateRequiredPromptText(operation: string, input: Input): Ada
 	return undefined;
 }
 
-/** Validates controls that adapters must reject before forwarding them to a host. */
-export function validateAdapterControl(operation: string, input: Input): AdapterValidationError | undefined {
+/** Validates controls before forwarding them; adapters reject ultrafast unless explicitly trusted. */
+export function validateAdapterControl(
+	operation: string,
+	input: Input,
+	options: { allowUltrafastTier?: boolean } = {},
+): AdapterValidationError | undefined {
 	const promptError = validateRequiredPromptText(operation, input);
 	if (promptError) return promptError;
 	if (operation === "runtime.reload") {
@@ -68,7 +132,12 @@ export function validateAdapterControl(operation: string, input: Input): Adapter
 			};
 		}
 	}
-	if (operation === "service_tier.set" && (typeof input.tier !== "string" || !SERVICE_TIERS.has(input.tier))) {
+	if (
+		operation === "service_tier.set" &&
+		(typeof input.tier !== "string" ||
+			!SERVICE_TIERS.has(input.tier) ||
+			(input.tier === "ultrafast" && options.allowUltrafastTier !== true))
+	) {
 		return { code: "invalid_input", message: "service_tier.set tier is invalid." };
 	}
 	return undefined;

package/src/sdk/protocol/operation-inventory.generated.json

@@ -953,6 +953,78 @@
 			"packages/coding-agent/test/sdk-operation-inventory.test.ts"
 		]
 	},
+	{
+		"sourceId": "registry:C54",
+		"sourceFile": "packages/coding-agent/src/sdk/protocol/operation-registry.ts",
+		"sourceKind": "registry",
+		"decision": "include",
+		"sdkId": "turn.image.begin",
+		"adapterMappings": {
+			"telegram": "prohibited",
+			"discord": "prohibited",
+			"slack": "prohibited",
+			"mcp": "prohibited",
+			"acp": "prohibited",
+			"daemonCli": "machine_only"
+		},
+		"testIds": [
+			"packages/coding-agent/test/sdk-operation-inventory.test.ts"
+		]
+	},
+	{
+		"sourceId": "registry:C55",
+		"sourceFile": "packages/coding-agent/src/sdk/protocol/operation-registry.ts",
+		"sourceKind": "registry",
+		"decision": "include",
+		"sdkId": "turn.image.append",
+		"adapterMappings": {
+			"telegram": "prohibited",
+			"discord": "prohibited",
+			"slack": "prohibited",
+			"mcp": "prohibited",
+			"acp": "prohibited",
+			"daemonCli": "machine_only"
+		},
+		"testIds": [
+			"packages/coding-agent/test/sdk-operation-inventory.test.ts"
+		]
+	},
+	{
+		"sourceId": "registry:C56",
+		"sourceFile": "packages/coding-agent/src/sdk/protocol/operation-registry.ts",
+		"sourceKind": "registry",
+		"decision": "include",
+		"sdkId": "turn.image.finish",
+		"adapterMappings": {
+			"telegram": "prohibited",
+			"discord": "prohibited",
+			"slack": "prohibited",
+			"mcp": "prohibited",
+			"acp": "prohibited",
+			"daemonCli": "machine_only"
+		},
+		"testIds": [
+			"packages/coding-agent/test/sdk-operation-inventory.test.ts"
+		]
+	},
+	{
+		"sourceId": "registry:C57",
+		"sourceFile": "packages/coding-agent/src/sdk/protocol/operation-registry.ts",
+		"sourceKind": "registry",
+		"decision": "include",
+		"sdkId": "turn.image.discard",
+		"adapterMappings": {
+			"telegram": "prohibited",
+			"discord": "prohibited",
+			"slack": "prohibited",
+			"mcp": "prohibited",
+			"acp": "prohibited",
+			"daemonCli": "machine_only"
+		},
+		"testIds": [
+			"packages/coding-agent/test/sdk-operation-inventory.test.ts"
+		]
+	},
 	{
 		"sourceId": "registry:G01",
 		"sourceFile": "packages/coding-agent/src/sdk/protocol/operation-registry.ts",
@@ -2642,6 +2714,17 @@
 			"testIds": "not_applicable"
 		}
 	},
+	{
+		"sourceId": "agent_session:refreshEffectiveActiveWorkflowSkillState",
+		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
+		"sourceKind": "agent_session",
+		"decision": "exclude",
+		"rationale": "internal durable workflow identity refresh before session safety checks, not an independent public SDK operation",
+		"exclusionMetadata": {
+			"adapterMappings": "not_applicable",
+			"testIds": "not_applicable"
+		}
+	},
 	{
 		"sourceId": "agent_session:replaceOwnedMcpManager",
 		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
@@ -2891,6 +2974,17 @@
 			"testIds": "not_applicable"
 		}
 	},
+	{
+		"sourceId": "agent_session:notifySessionIdentityChanged",
+		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
+		"sourceKind": "agent_session",
+		"decision": "exclude",
+		"rationale": "internal session-identity listener fan-out for in-process session surfaces; not a user-facing SDK control seam",
+		"exclusionMetadata": {
+			"adapterMappings": "not_applicable",
+			"testIds": "not_applicable"
+		}
+	},
 	{
 		"sourceId": "agent_session:emitNotice",
 		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
@@ -2924,6 +3018,17 @@
 			"testIds": "not_applicable"
 		}
 	},
+	{
+		"sourceId": "agent_session:subscribeSessionIdentityChanges",
+		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
+		"sourceKind": "agent_session",
+		"decision": "exclude",
+		"rationale": "internal session-identity subscription used by in-process adapters to follow session replacement; not a user-facing SDK control seam",
+		"exclusionMetadata": {
+			"adapterMappings": "not_applicable",
+			"testIds": "not_applicable"
+		}
+	},
 	{
 		"sourceId": "agent_session:dispose",
 		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
@@ -3111,6 +3216,17 @@
 			"testIds": "not_applicable"
 		}
 	},
+	{
+		"sourceId": "agent_session:waitForAgentEndHandlingForTests",
+		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
+		"sourceKind": "agent_session",
+		"decision": "exclude",
+		"rationale": "test-only SDK terminal-event handler completion barrier, not a user-facing SDK control seam",
+		"exclusionMetadata": {
+			"adapterMappings": "not_applicable",
+			"testIds": "not_applicable"
+		}
+	},
 	{
 		"sourceId": "agent_session:drainAsyncJobDeliveriesForAcp",
 		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
@@ -3333,6 +3449,39 @@
 			"testIds": "not_applicable"
 		}
 	},
+	{
+		"sourceId": "agent_session:hasCommittedMCPToolSelectionAuthority",
+		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
+		"sourceKind": "agent_session",
+		"decision": "exclude",
+		"rationale": "internal committed MCP-selection authority predicate used by catalog reconciliation; not a user-facing SDK control seam",
+		"exclusionMetadata": {
+			"adapterMappings": "not_applicable",
+			"testIds": "not_applicable"
+		}
+	},
+	{
+		"sourceId": "agent_session:hasMCPToolSelectionAuthority",
+		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
+		"sourceKind": "agent_session",
+		"decision": "exclude",
+		"rationale": "internal MCP-selection authority predicate used by catalog and mode-transition reconciliation; not a user-facing SDK control seam",
+		"exclusionMetadata": {
+			"adapterMappings": "not_applicable",
+			"testIds": "not_applicable"
+		}
+	},
+	{
+		"sourceId": "agent_session:getActiveMCPToolNames",
+		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
+		"sourceKind": "agent_session",
+		"decision": "exclude",
+		"rationale": "internal MCP bridge subset used by mode controllers to preserve live selections across tool swaps; not a user-facing SDK control seam",
+		"exclusionMetadata": {
+			"adapterMappings": "not_applicable",
+			"testIds": "not_applicable"
+		}
+	},
 	{
 		"sourceId": "agent_session:getSelectedMCPToolNames",
 		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
@@ -4502,6 +4651,17 @@
 			"testIds": "not_applicable"
 		}
 	},
+	{
+		"sourceId": "agent_session:markProfileRoleOverrideManual",
+		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
+		"sourceKind": "agent_session",
+		"decision": "exclude",
+		"rationale": "internal profile role-layer ownership tracking after explicit user assignments; not a user-facing SDK control seam",
+		"exclusionMetadata": {
+			"adapterMappings": "not_applicable",
+			"testIds": "not_applicable"
+		}
+	},
 	{
 		"sourceId": "agent_session:getActiveModelProfile",
 		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
@@ -4513,12 +4673,23 @@
 			"testIds": "not_applicable"
 		}
 	},
+	{
+		"sourceId": "agent_session:getActivatedModelProfile",
+		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
+		"sourceKind": "agent_session",
+		"decision": "exclude",
+		"rationale": "internal model-profile activation provenance used to gate role-only materialization, not a user-facing SDK control seam",
+		"exclusionMetadata": {
+			"adapterMappings": "not_applicable",
+			"testIds": "not_applicable"
+		}
+	},
 	{
 		"sourceId": "agent_session:setUnavailableModelProfile",
 		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
 		"sourceKind": "agent_session",
 		"decision": "exclude",
-		"rationale": "internal session-scoped unavailable profile tracking; mutated by the session lifecycle on model-load failure, not a public SDK control seam",
+		"rationale": "internal session-scoped startup-profile recovery marker, not a user-facing SDK control seam",
 		"exclusionMetadata": {
 			"adapterMappings": "not_applicable",
 			"testIds": "not_applicable"
@@ -4529,7 +4700,7 @@
 		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
 		"sourceKind": "agent_session",
 		"decision": "exclude",
-		"rationale": "internal session-scoped unavailable profile query for UI status rendering; not a public SDK operation",
+		"rationale": "internal session-scoped startup-profile recovery status for UI rendering, not a public SDK operation",
 		"exclusionMetadata": {
 			"adapterMappings": "not_applicable",
 			"testIds": "not_applicable"
@@ -4568,6 +4739,39 @@
 			"testIds": "not_applicable"
 		}
 	},
+	{
+		"sourceId": "agent_session:getConfigurationPaths",
+		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
+		"sourceKind": "agent_session",
+		"decision": "exclude",
+		"rationale": "internal config hot-reload path identity projection, not a user-facing SDK control seam",
+		"exclusionMetadata": {
+			"adapterMappings": "not_applicable",
+			"testIds": "not_applicable"
+		}
+	},
+	{
+		"sourceId": "agent_session:validateConfiguration",
+		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
+		"sourceKind": "agent_session",
+		"decision": "exclude",
+		"rationale": "internal read-only config hot-reload preflight, not an independent SDK operation",
+		"exclusionMetadata": {
+			"adapterMappings": "not_applicable",
+			"testIds": "not_applicable"
+		}
+	},
+	{
+		"sourceId": "agent_session:reloadConfiguration",
+		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
+		"sourceKind": "agent_session",
+		"decision": "exclude",
+		"rationale": "internal transactional config hot-reload publication, not a user-facing SDK control seam",
+		"exclusionMetadata": {
+			"adapterMappings": "not_applicable",
+			"testIds": "not_applicable"
+		}
+	},
 	{
 		"sourceId": "agent_session:syncEagerDelegation",
 		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
@@ -4590,6 +4794,28 @@
 			"testIds": "not_applicable"
 		}
 	},
+	{
+		"sourceId": "agent_session:getProfileInstalledOverrideState",
+		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
+		"sourceKind": "agent_session",
+		"decision": "exclude",
+		"rationale": "internal model-profile activation rollback snapshot, not a user-facing SDK control seam",
+		"exclusionMetadata": {
+			"adapterMappings": "not_applicable",
+			"testIds": "not_applicable"
+		}
+	},
+	{
+		"sourceId": "agent_session:restoreProfileInstalledOverrideState",
+		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
+		"sourceKind": "agent_session",
+		"decision": "exclude",
+		"rationale": "internal model-profile activation rollback restoration, not a user-facing SDK control seam",
+		"exclusionMetadata": {
+			"adapterMappings": "not_applicable",
+			"testIds": "not_applicable"
+		}
+	},
 	{
 		"sourceId": "agent_session:clearProfileInstalledOverrides",
 		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
@@ -4828,6 +5054,39 @@
 			"testIds": "not_applicable"
 		}
 	},
+	{
+		"sourceId": "agent_session:prepareModelSelectionForProfileActivation",
+		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
+		"sourceKind": "agent_session",
+		"decision": "exclude",
+		"rationale": "internal staged model-selection preparation for profile activation, not a user-facing SDK control seam",
+		"exclusionMetadata": {
+			"adapterMappings": "not_applicable",
+			"testIds": "not_applicable"
+		}
+	},
+	{
+		"sourceId": "agent_session:commitPreparedProfileModelSelection",
+		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
+		"sourceKind": "agent_session",
+		"decision": "exclude",
+		"rationale": "internal model-selection commit for profile activation, not a user-facing SDK control seam",
+		"exclusionMetadata": {
+			"adapterMappings": "not_applicable",
+			"testIds": "not_applicable"
+		}
+	},
+	{
+		"sourceId": "agent_session:finishPreparedProfileModelSelection",
+		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",
+		"sourceKind": "agent_session",
+		"decision": "exclude",
+		"rationale": "internal post-commit model-selection refresh for profile activation, not a user-facing SDK control seam",
+		"exclusionMetadata": {
+			"adapterMappings": "not_applicable",
+			"testIds": "not_applicable"
+		}
+	},
 	{
 		"sourceId": "agent_session:restoreModelSelectionForRollback",
 		"sourceFile": "packages/coding-agent/src/session/agent-session.ts",

package/src/sdk/protocol/operation-registry.ts

@@ -125,6 +125,10 @@ const controls = [
 	["retry.now", "Immediately retry pending backoff."],
 	["bash.background", "Move active managed bash to the background."],
 	["model.profile.set", "Activate a model profile for the current session."],
+	["turn.image.begin", "Begin a bounded host-owned image upload."],
+	["turn.image.append", "Append a canonical base64 image chunk."],
+	["turn.image.finish", "Verify and stage a complete image."],
+	["turn.image.discard", "Discard an unfinished or staged image."],
 ] as const;
 
 const globals = [
@@ -235,6 +239,15 @@ const reverse = [
 ] as const;
 
 function controlDisposition(id: string): Record<Adapter, AdapterDisposition> {
+	if (["C54", "C55", "C56", "C57"].includes(id))
+		return dispositions({
+			telegram: "prohibited",
+			discord: "prohibited",
+			slack: "prohibited",
+			mcp: "prohibited",
+			acp: "prohibited",
+			daemonCli: "machine_only",
+		});
 	if (["C25", "C26", "C27", "C28", "C29", "C30", "C31", "C32", "C34", "C48"].includes(id))
 		return dispositions({
 			telegram: "prohibited",
@@ -271,7 +284,13 @@ function controlErrors(id: string): string[] {
 		// C01/C05 submit a prompt and therefore run the prompt preflight, which
 		// refuses a session with no selected model before admission. The code is
 		// appended: ACP machine-only mapping reads errorCodes[0].
-		C01: ["client_ref_conflict", "reconciliation_capacity", "reconciliation_persist_failed", "model_not_selected"],
+		C01: [
+			"client_ref_conflict",
+			"reconciliation_capacity",
+			"reconciliation_persist_failed",
+			"model_not_selected",
+			"image_upload_unavailable",
+		],
 		C02: ["turn_not_active", "client_ref_conflict", "reconciliation_capacity", "reconciliation_persist_failed"],
 		C09: ["client_ref_conflict", "reconciliation_capacity", "reconciliation_persist_failed"],
 		C06: ["action_claimed"],
@@ -294,6 +313,10 @@ function controlErrors(id: string): string[] {
 		C50: ["nothing_to_retry", "busy"],
 		C51: ["retry_not_pending"],
 		C52: ["not_foldable", "already_backgrounded", "no_active_bash"],
+		C54: ["invalid_input", "busy", "resource_gone", "operation_prohibited"],
+		C55: ["invalid_input", "busy", "resource_gone", "operation_prohibited"],
+		C56: ["invalid_input", "busy", "resource_gone", "operation_prohibited"],
+		C57: ["invalid_input", "resource_gone", "operation_prohibited"],
 	};
 	return errors[id] ?? ["invalid_request", "busy"];
 }
@@ -354,8 +377,15 @@ export const OPERATIONS: readonly Operation[] = [
 					: id === "G10"
 						? ["invalid_input", "not_found", "idempotency_conflict", "lifecycle_pending", "terminal_uncertain"]
 						: ["G03", "G04", "G05"].includes(id)
-							? ["invalid_request", "unknown_model_profile", "model_profile_registry_error"]
-							: ["invalid_request"],
+							? [
+									"invalid_request",
+									"unknown_model_profile",
+									"model_profile_registry_error",
+									"legacy_lifecycle_ambiguous",
+								]
+							: ["G06", "G07", "G08"].includes(id)
+								? ["invalid_request", "legacy_lifecycle_ambiguous"]
+								: ["invalid_request"],
 			adapterDispositions:
 				id === "G02"
 					? dispositions({

package/src/sdk/reconciliation-extensions.ts

@@ -10,5 +10,6 @@ export {
 	type DurableReconciliationRecord,
 	type DurableSteerReconciliationRecord,
 	type ReconciliationStore,
+	type ReconciliationStoreInstrumentationEvent,
 	resolveReconciliationSessionFile,
 } from "./bus/reconciliation-store";

package/src/sdk/session-list.ts

@@ -20,6 +20,7 @@ export const SESSION_LIST_SAVED_SESSION_OMISSION_DETAIL_CODES = [
 	"managed_gc_journal_capacity_exceeded",
 	"atomic_unavailable",
 	"invalid_request",
+	"permission_denied",
 	"durability_failed",
 	"durability_not_provable",
 	"capacity_exceeded",