@gajae-code/coding-agent 0.16.0 → 0.16.3

package/src/sdk/session.ts

@@ -51,6 +51,7 @@ import {
 	isBackgroundJobSupportEnabled,
 	jobElapsedMs,
 } from "../async";
+import { resolveBrowserBackend } from "../browser-backend";
 import { loadCapability, reset as resetCapabilities } from "../capability";
 import { type Rule, ruleCapability, setActiveRules } from "../capability/rule";
 import type { SourceMeta } from "../capability/types";
@@ -150,7 +151,7 @@ import { markAutoroutingInactive } from "../sdk/host/internal-autorouting-state"
 import { createSdkSessionRuntimeExtension, registerSdkOnlyNotificationCommand } from "../sdk/host/session-runtime";
 import { createSdkWebSocketTransport } from "../sdk/host/websocket-transport";
 import type { SecretObfuscator } from "../secrets";
-import { AgentSession, type ForkContextSeed } from "../session/agent-session";
+import { AgentSession, type ForkContextSeed, isSessionDisposalIncompleteError } from "../session/agent-session";
 import { AuthBrokerClient, AuthStorage, RemoteAuthCredentialStore } from "../session/auth-storage";
 import { type CustomMessage, convertToLlm } from "../session/messages";
 import { createReadonlySessionManager, SessionManager } from "../session/session-manager";
@@ -1104,12 +1105,16 @@ function buildMCPPromptCommands(manager: MCPManager): LoadedCustomCommand[] {
  */
 
 function withEmbeddedDefaultGjcSkills(skills: Skill[]): Skill[] {
-	const byName = new Map(skills.map(skill => [skill.name, skill]));
+	const byName = new Map<string, Skill>();
+	for (const skill of skills) {
+		const key = skill.name.toLowerCase();
+		if (!byName.has(key)) byName.set(key, skill);
+	}
 	// The four public GJC workflow skills are a product invariant: even if a
 	// caller-supplied or filesystem skill shares a name, the bundled definition
 	// wins so workflow routing can never be silently hijacked.
 	for (const defaultSkill of getEmbeddedDefaultGjcSkills()) {
-		byName.set(defaultSkill.name, defaultSkill);
+		byName.set(defaultSkill.name.toLowerCase(), defaultSkill);
 	}
 	return [...byName.values()];
 }
@@ -2438,7 +2443,7 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 										"Cannot rescope a session with caller-owned MCP authority; recreate the session at the target cwd.",
 									);
 								}
-								return sessionManager.runExclusiveCwdTransition(async () => {
+								return sessionManager.runExclusiveCwdMoveTransition(async () => {
 									if (moveConsumed) {
 										throw new Error(
 											"This session has already been rescoped; only one agent-invoked move is allowed per session.",
@@ -2713,7 +2718,8 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 			registerForegroundFoldParticipant: adapter =>
 				session?.registerForegroundFoldParticipant(adapter) ?? (() => {}),
 			hasForegroundBashBackgroundRequestHandler: () => session?.hasForegroundBashBackgroundRequestHandler() ?? false,
-			requestForegroundBashBackground: () => Promise.resolve(session?.requestForegroundBashBackground() ?? false),
+			requestForegroundBashBackground: (reason, adapter) =>
+				Promise.resolve(session?.requestForegroundBashBackground(reason, adapter) ?? false),
 
 			getCredentialSessionId: () => session?.credentialSessionId ?? credentialSessionId,
 			getMcpManager: () => mcpManager ?? options.inheritedMcpManager,
@@ -2770,16 +2776,6 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 				return m ? buildNamedToolChoice(name, m) : undefined;
 			},
 			buildToolChoiceResult: name => buildNamedToolChoiceResult(name, session.model),
-			steer: msg =>
-				session.agent.steer({
-					role: "custom",
-					customType: msg.customType,
-					content: msg.content,
-					display: false,
-					details: msg.details,
-					attribution: "agent",
-					timestamp: Date.now(),
-				}),
 			sendCustomMessage: (msg, opts) => session.sendCustomMessage(msg, opts),
 			purgeQueuedCustomMessages: predicate => session.purgeQueuedCustomMessages(predicate),
 			peekQueueInvoker: () => session.peekQueueInvoker(),
@@ -3562,7 +3558,7 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 			!model &&
 			!options.modelPattern &&
 			!startupCredentialModelRejected &&
-			configuredDefaultPatterns.length === 0
+			(configuredDefaultPatterns.length === 0 || preferredCredentialProvider !== undefined)
 		) {
 			// Re-resolve the allowed set: extension factories above may have
 			// registered providers/models that weren't visible at startup.
@@ -3896,7 +3892,9 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 				? await memoryBackend.buildDeveloperInstructions(agentDir, settings, session)
 				: undefined;
 
-			const appendPrompt: string | undefined = memoryInstructions ?? undefined;
+			const browserBackend = resolveBrowserBackend(settings);
+			const appendPrompt =
+				[memoryInstructions, browserBackend.developerInstructions].filter(Boolean).join("\n\n") || undefined;
 			let pluginSystemAppendices = "";
 			try {
 				pluginSystemAppendices = await renderAlwaysOnSystemAppendices({ cwd: getLiveCwd() });
@@ -4277,7 +4275,7 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 			transformContext,
 			steeringMode: settings.get("steeringMode") ?? "one-at-a-time",
 			followUpMode: settings.get("followUpMode") ?? "one-at-a-time",
-			interruptMode: settings.get("interruptMode") ?? "immediate",
+			toolInterruptPolicy: settings.get("toolInterruptPolicy") ?? "abort_tools",
 			thinkingBudgets: settings.getGroup("thinkingBudgets"),
 			temperature: settings.get("temperature") >= 0 ? settings.get("temperature") : undefined,
 			topP: settings.get("topP") >= 0 ? settings.get("topP") : undefined,
@@ -4575,38 +4573,49 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 
 		// Attach the live session to the pre-registered ref so peers can route IRC
 		// messages here. Refresh sessionFile in case it was unavailable at pre-register
-		// time. The dispose wrapper below unregisters on teardown.
+		// time. The registered terminal cleanup below unregisters on teardown.
 		agentRegistry.attachSession(resolvedAgentId, session, sessionManager.getSessionFile() ?? null);
 		{
-			const originalDispose = session.dispose.bind(session);
-			session.dispose = async () => {
-				try {
-					await originalDispose();
-				} finally {
+			let cleanupPromise: Promise<void> | undefined;
+			const finishCleanup = async (): Promise<void> => {
+				if (cleanupPromise) return cleanupPromise;
+				const cleanup = (async () => {
+					const failures: unknown[] = [];
 					try {
 						agentRegistry.unregister(resolvedAgentId);
 						releaseCredentialDisabledSubscription();
 						releaseLocalProtocolOverride();
+					} catch (error) {
+						failures.push(error);
 					} finally {
-						// The endpoint is gone: its owned registrations can never
-						// reach a delivery settlement boundary, and foreign-endpoint
-						// tuples are deliberately never classified terminal by other
-						// managers — retire them before unregistering the manager so
-						// repeated session churn cannot saturate the registry
-						// (review thread P2). The endpoint is the manager's live
-						// registration key, which survives newSession/switchSession
-						// rekeying and may differ from the persisted logical session id.
-						if (!options.parentTaskPrefix) {
-							retireOwnedRegistrationsForEndpoint(
-								AsyncJobManager.endpointIdOf(asyncJobManager) ?? asyncJobEndpointId,
-							);
-							AsyncJobManager.unregisterManager(asyncJobManager);
+						try {
+							if (!options.parentTaskPrefix) {
+								retireOwnedRegistrationsForEndpoint(
+									AsyncJobManager.endpointIdOf(asyncJobManager) ?? asyncJobEndpointId,
+								);
+								AsyncJobManager.unregisterManager(asyncJobManager);
+							}
+						} catch (error) {
+							failures.push(error);
+						}
+						try {
+							await closeOwnedAuthStorage();
+						} catch (error) {
+							failures.push(error);
+						}
+						try {
+							await closeOwnedSettings();
+						} catch (error) {
+							failures.push(error);
 						}
-						await closeOwnedAuthStorage();
-						await closeOwnedSettings();
 					}
-				}
+					if (failures.length > 0) throw new AggregateError(failures, "SDK disposal cleanup failed.");
+				})();
+				cleanupPromise = cleanup;
+				void cleanup.catch(() => {});
+				return cleanup;
 			};
+			session.registerToolSessionCleanup(finishCleanup);
 		}
 
 		if (model?.api === "openai-codex-responses") {
@@ -4834,7 +4843,16 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 		let cleanupDiagnostic: unknown;
 		try {
 			if (hasSession) {
-				await session.dispose();
+				try {
+					await session.dispose();
+				} catch (disposeError) {
+					if (!isSessionDisposalIncompleteError(disposeError)) {
+						throw disposeError;
+					}
+					// The first call is intentionally bounded for startup callers. Join the
+					// retained teardown before releasing the resources it still owns.
+					await session.awaitDisposeCompletion();
+				}
 			} else {
 				if (hasRegistered) agentRegistry.unregister(resolvedAgentId);
 				// Admission happens before session construction. Any later startup

package/src/sdk/turn-result.ts

@@ -17,6 +17,7 @@ export interface TurnResultError {
 	code: string;
 	message: string;
 }
+export type TurnResultReceiptState = "absent" | "present" | "missing" | "unknown";
 export interface TurnResultPage {
 	status: TurnResultStatus;
 	kind?: "prompt" | "skill";
@@ -26,6 +27,8 @@ export interface TurnResultPage {
 	acceptedAt?: number;
 	startedAt?: number;
 	terminalAt?: number;
+	receiptState?: TurnResultReceiptState;
+	outcome?: unknown;
 	content?: TurnResultContent;
 	error?: TurnResultError;
 }
@@ -51,3 +54,22 @@ export function sanitizeTurnResultContent(text: unknown): TurnResultContent | un
 		truncated,
 	};
 }
+
+export function reportableTurnResultContent(content: TurnResultContent | undefined): boolean {
+	return content !== undefined && content.text.trim().length > 0;
+}
+
+/** First reportable invocation-owned content wins; blank evidence remains replaceable. */
+export function reduceTurnResultContent(
+	existing: TurnResultContent | undefined,
+	incoming: TurnResultContent | undefined,
+): TurnResultContent | undefined {
+	if (reportableTurnResultContent(existing)) return existing;
+	if (incoming === undefined) return existing;
+	const sanitized = sanitizeTurnResultContent(incoming.text);
+	if (sanitized === undefined) return existing;
+	return {
+		...sanitized,
+		truncated: sanitized.truncated || incoming.truncated || existing?.truncated === true,
+	};
+}