@gajae-code/coding-agent 0.13.3 → 0.14.0

package/src/sdk/bus/session-control.ts

@@ -24,7 +24,17 @@ export interface BoundNotificationSession<Context extends NotificationSessionCon
 }
 
 export type NotificationEndpointStartResult = "started" | "already" | "disabled" | "failed";
-export type TelegramDaemonPreflightResult = "ready" | "blocked_identity" | "failed";
+/**
+ * Outcome of the Telegram daemon preflight.
+ *
+ * `pending` means ownership acquisition is in flight and was deliberately NOT
+ * awaited: chat daemons are optional notification adapters, never session
+ * authority, so reconciliation on an awaited session-lifecycle path must never
+ * block on one. A pending preflight neither stops the runtime nor marks it
+ * blocked — the runtime starts, adapters stay withheld while the owner state is
+ * not ready, and the ensure's settle callback re-reconciles.
+ */
+export type TelegramDaemonPreflightResult = "ready" | "pending" | "blocked_identity" | "failed";
 
 /**
  * The endpoint implementation is deliberately injected. The controller owns
@@ -35,6 +45,20 @@ export interface NotificationSessionRuntime<Context extends NotificationSessionC
 	isRunning(binding: BoundNotificationSession<Context>): boolean;
 	start(binding: BoundNotificationSession<Context>): Promise<NotificationEndpointStartResult>;
 	stop(binding: BoundNotificationSession<Context>): Promise<boolean>;
+	/**
+	 * Provider-neutral ownership re-proof, called for ANY effective chat
+	 * provider before the Telegram-specific preflight.
+	 *
+	 * A credential, destination, or actor-authorization change invalidates the
+	 * ownership proof that authorized this runtime's adapters. The runtime must
+	 * withhold its LOCAL adapters until the new identity is proved. It does NOT
+	 * revoke an already-attached external chat daemon's SessionRouter
+	 * attachment, so such a daemon can still observe host events and reach the
+	 * host's inbound/control paths during the window; closing that requires an
+	 * authenticated chat-attachment authority boundary at the Router layer.
+	 * Implementations must not await the daemon ensure itself.
+	 */
+	reproveOwnership?(binding: BoundNotificationSession<Context>): Promise<void>;
 	/**
 	 * Proves the complete Telegram owner identity before a generic endpoint can
 	 * emit a frame. `blocked_identity` is fail-closed and starts nothing.
@@ -316,6 +340,22 @@ export class NotificationSessionController {
 			const telegramEffective = isProviderEffectivelyEnabled(cfg, "telegram");
 			const nonTelegramEffectiveForTelegram =
 				isProviderEffectivelyEnabled(cfg, "discord") || isProviderEffectivelyEnabled(cfg, "slack");
+			// Ownership identity is provider-neutral: re-prove for ANY effective
+			// chat provider before the Telegram-specific preflight, so a
+			// Discord-only or Slack-only credential/destination/actor change also
+			// withholds adapters until the new identity is proved.
+			if (telegramEffective || nonTelegramEffectiveForTelegram) {
+				try {
+					// Idempotent and keyed: a config change racing this call is caught
+					// by the next attempt's key comparison, so no extra
+					// current-config check is needed here (adding one would
+					// short-circuit the bounded churn loop before its preflight).
+					await runtime.reproveOwnership?.(binding);
+				} catch {
+					// Re-proof is best-effort withholding; a failure must not gate the
+					// session. The runtime stays in whatever state it already had.
+				}
+			}
 			if (telegramEffective && telegramMarker && !nonTelegramEffectiveForTelegram) {
 				if (runtime.isRunning(binding)) await runtime.stop(binding);
 				if (!this.#isCurrentConfig(cfg)) continue;
@@ -329,7 +369,13 @@ export class NotificationSessionController {
 					ensured = "failed";
 				}
 				if (!this.#isCurrentConfig(cfg)) continue;
-				if (ensured !== "ready" && !nonTelegramEffectiveForTelegram) {
+				// Only a SETTLED non-ready preflight gates the runtime. `pending`
+				// falls through to the normal start path: the session is never held
+				// or stopped by an in-flight daemon ensure, and adapters stay
+				// withheld by the runtime's own owner-state check until it settles.
+				// A missing hook keeps its prior gating semantics; only `pending` is exempt.
+				const settledNotReady = ensured !== "ready" && ensured !== "pending";
+				if (settledNotReady && !nonTelegramEffectiveForTelegram) {
 					if (runtime.isRunning(binding)) await runtime.stop(binding);
 					this.#blockedRuntimeSessions.add(binding.sessionId);
 					return {
@@ -337,7 +383,7 @@ export class NotificationSessionController {
 						status: this.#status(binding, cfg, runtime),
 					};
 				}
-				if (ensured !== "ready" && nonTelegramEffectiveForTelegram) {
+				if (settledNotReady && nonTelegramEffectiveForTelegram) {
 					const isolated = await runtime.isolateTelegram?.(binding);
 					if (isolated !== "started" && isolated !== "already") {
 						if (runtime.isRunning(binding)) await runtime.stop(binding);

package/src/sdk/bus/slack-conversation.ts

@@ -10,6 +10,7 @@ export interface SlackInboundDispatchReceipt {
 	actionId?: string;
 	/** The endpoint generation and SDK effect captured before Socket Mode ACK. */
 	endpointGeneration: number;
+	attachmentAuthorityId?: string;
 	/** Identifier of the protected journal payload; mappings never retain message bodies. */
 	effectId: string;
 	idempotencyKey: string;
@@ -25,7 +26,10 @@ export interface SlackConversation extends ConversationRecord {
 	rootTs?: string;
 	sessionId?: string;
 	endpointGeneration?: number;
+	attachmentAuthorityId?: string;
 	clientMsgId?: string;
+	/** Exact pending Router-removal cleanup; cleared only after the mapping close CAS commits. */
+	cleanupEffectId?: string;
 	/** Exclusive, expiring authority for provider reconciliation/publication of the root intent. */
 	rootPublicationOwner?: string;
 	rootPublicationLeaseExpiresAt?: number;