@gajae-code/coding-agent 0.11.11 → 0.12.1

package/src/gjc-runtime/workflow-manifest.ts

@@ -1,6 +1,7 @@
 /**
  * TypeScript is the authoritative source of truth for GJC workflow manifests.
- * Keep the checked-in JSON projection synchronized manually with this module.
+ * Any JSON manifest projection is derived from this module and must never be
+ * hand-edited.
  */
 
 import { CANONICAL_GJC_WORKFLOW_SKILLS, type CanonicalGjcWorkflowSkill } from "../skill-state/canonical-skills";
@@ -22,9 +23,7 @@ export interface WorkflowVerb {
 	name: string;
 	planned?: boolean;
 	/** Invocation surface that exposes this verb in the real CLI parser. */
-	surface?: "state-action" | "command-positional" | "command-flag" | "draft-action";
-	/** Legacy surface retained for callers that have not migrated to normal typed commands. */
-	compatibilityOnly?: boolean;
+	surface?: "state-action" | "command-positional" | "command-flag";
 }
 
 export interface TypedArgSpec {
@@ -33,7 +32,6 @@ export interface TypedArgSpec {
 	enumValues?: string[];
 	required?: boolean;
 	appliesToVerbs?: string[];
-	compatibilityOnly?: boolean;
 	planned?: boolean;
 }
 
@@ -74,7 +72,22 @@ const PLANNED_ADMIN_VERBS = ["graph", "prune", "migrate", "force-overwrite"] as
 const COMMON_TYPED_ARGS: TypedArgSpec[] = [
 	{ name: "input", type: "string", appliesToVerbs: ["write", "api"] },
 	{ name: "mode", type: "enum", enumValues: [...CANONICAL_GJC_WORKFLOW_SKILLS], appliesToVerbs: [...STATE_VERBS] },
-	{ name: "session-id", type: "string", appliesToVerbs: [...STATE_VERBS, "kickoff", "write-spec", "write-artifact"] },
+	{
+		name: "session-id",
+		type: "string",
+		appliesToVerbs: [
+			...STATE_VERBS,
+			"kickoff",
+			"write-spec",
+			"write-artifact",
+			"stage",
+			"check",
+			"apply",
+			"discard",
+			"read",
+			"write",
+		],
+	},
 	{ name: "thread-id", type: "string", appliesToVerbs: ["write", "clear", "handoff"] },
 	{ name: "turn-id", type: "string", appliesToVerbs: ["write", "clear", "handoff"] },
 	{ name: "to", type: "string", required: true, appliesToVerbs: ["handoff"] },
@@ -95,9 +108,6 @@ function stateVerbs(): WorkflowVerb[] {
 function positionalVerbs(names: readonly string[]): WorkflowVerb[] {
 	return names.map(name => verb(name, "command-positional"));
 }
-function draftVerbs(names: readonly string[]): WorkflowVerb[] {
-	return names.map(name => verb(name, "draft-action"));
-}
 
 function flagVerbs(names: readonly string[]): WorkflowVerb[] {
 	return names.map(name => verb(name, "command-flag"));
@@ -168,15 +178,7 @@ export const WORKFLOW_MANIFEST: Record<CanonicalGjcWorkflowSkill, SkillManifest>
 		verbs: [
 			...stateVerbs(),
 			...flagVerbs(["kickoff", "write-spec"]),
-			...draftVerbs(["draft create", "draft edit", "draft show", "draft check", "draft rebase", "draft discard"]),
-			...positionalVerbs([
-				"initialize-context",
-				"confirm-topology",
-				"record-answer",
-				"apply-round-result",
-				"inspect",
-				"sanity-check",
-			]),
+			...positionalVerbs(["stage", "check", "apply", "discard", "read", "write", "clear", "handoff"]),
 			...plannedVerbs(PLANNED_ADMIN_VERBS),
 		],
 		typedArgs: [
@@ -185,180 +187,25 @@ export const WORKFLOW_MANIFEST: Record<CanonicalGjcWorkflowSkill, SkillManifest>
 			{ name: "deep", type: "boolean", appliesToVerbs: ["kickoff"] },
 			{ name: "threshold", type: "number", appliesToVerbs: ["kickoff"] },
 			{ name: "threshold-source", type: "string", appliesToVerbs: ["kickoff"] },
-			{ name: "trace", type: "boolean", appliesToVerbs: ["kickoff"] },
-			{ name: "json", type: "boolean", appliesToVerbs: ["kickoff", "write-spec"] },
 			{ name: "stage", type: "enum", enumValues: ["final"], appliesToVerbs: ["write-spec"] },
 			{ name: "slug", type: "string", appliesToVerbs: ["write-spec"] },
 			{ name: "spec", type: "string", required: true, appliesToVerbs: ["write-spec"] },
 			{ name: "handoff", type: "enum", enumValues: ["ralplan"], appliesToVerbs: ["write-spec"] },
 			{ name: "deliberate", type: "boolean", appliesToVerbs: ["write-spec"] },
-			{
-				name: "session-id",
-				type: "string",
-				required: true,
-				appliesToVerbs: ["draft create"],
-			},
-			{
-				name: "for",
-				type: "enum",
-				enumValues: ["initialize-context", "confirm-topology", "record-answer", "apply-round-result"],
-				required: true,
-				appliesToVerbs: ["draft create"],
-			},
-			{ name: "round-key", type: "string", appliesToVerbs: ["draft create"] },
-			{ name: "round", type: "number", appliesToVerbs: ["draft create"] },
-			{ name: "question-id", type: "string", appliesToVerbs: ["draft create"] },
-			{ name: "round-id", type: "string", appliesToVerbs: ["draft create"] },
-			{ name: "component-id", type: "string", appliesToVerbs: ["draft create"] },
-			{ name: "dimension", type: "string", appliesToVerbs: ["draft create"] },
-			{
-				name: "draft-id",
-				type: "string",
-				required: true,
-				appliesToVerbs: [
-					"draft edit",
-					"draft show",
-					"draft check",
-					"draft rebase",
-					"draft discard",
-					"initialize-context",
-					"confirm-topology",
-					"record-answer",
-					"apply-round-result",
-				],
-			},
-			{
-				name: "expected-draft-revision",
-				type: "number",
-				required: true,
-				appliesToVerbs: [
-					"draft edit",
-					"draft rebase",
-					"draft discard",
-					"initialize-context",
-					"confirm-topology",
-					"record-answer",
-					"apply-round-result",
-				],
-			},
-			{
-				name: "op",
-				type: "enum",
-				enumValues: ["set", "append", "remove"],
-				required: true,
-				appliesToVerbs: ["draft edit"],
-			},
-			{ name: "path", type: "string", required: true, appliesToVerbs: ["draft edit"] },
-			{ name: "value", type: "string", appliesToVerbs: ["draft edit"] },
-			{ name: "value-file", type: "string", appliesToVerbs: ["draft edit"] },
-			{ name: "null", type: "boolean", appliesToVerbs: ["draft edit"] },
-			{ name: "to-state-revision", type: "number", required: true, appliesToVerbs: ["draft rebase"] },
 			{
 				name: "json",
 				type: "boolean",
-				required: true,
-				appliesToVerbs: [
-					"draft create",
-					"draft edit",
-					"draft show",
-					"draft check",
-					"draft rebase",
-					"draft discard",
-					"initialize-context",
-					"confirm-topology",
-					"record-answer",
-					"apply-round-result",
-					"inspect",
-					"sanity-check",
-				],
-			},
-			{
-				name: "session-id",
-				type: "string",
-				required: true,
-				appliesToVerbs: ["inspect", "sanity-check"],
-			},
-			{
-				name: "session-id",
-				type: "string",
-				required: true,
-				compatibilityOnly: true,
-				appliesToVerbs: ["initialize-context", "confirm-topology", "record-answer", "apply-round-result"],
-			},
-			{
-				name: "schema-version",
-				type: "number",
-				required: true,
-				compatibilityOnly: true,
-				appliesToVerbs: ["initialize-context", "confirm-topology", "record-answer", "apply-round-result"],
-			},
-			{
-				name: "expected-revision",
-				type: "number",
-				required: true,
-				compatibilityOnly: true,
-				appliesToVerbs: ["initialize-context", "confirm-topology", "record-answer", "apply-round-result"],
-			},
-			{
-				name: "input-json",
-				type: "object",
-				required: true,
-				compatibilityOnly: true,
-				appliesToVerbs: ["initialize-context", "confirm-topology"],
-			},
-			{
-				name: "round",
-				type: "number",
-				required: true,
-				compatibilityOnly: true,
-				appliesToVerbs: ["record-answer", "apply-round-result"],
-			},
-			{
-				name: "question-id",
-				type: "string",
-				required: true,
-				compatibilityOnly: true,
-				appliesToVerbs: ["record-answer", "apply-round-result"],
+				appliesToVerbs: ["write-spec", "stage", "check", "apply", "discard", "read", "write", "clear", "handoff"],
 			},
+			{ name: "input", type: "string", required: true, appliesToVerbs: ["stage", "write"] },
+			{ name: "reset", type: "boolean", appliesToVerbs: ["write"] },
 			{
-				name: "round-id",
-				type: "string",
-				compatibilityOnly: true,
-				appliesToVerbs: ["record-answer", "apply-round-result"],
-			},
-			{ name: "component-id", type: "string", compatibilityOnly: true, appliesToVerbs: ["record-answer"] },
-			{ name: "dimension", type: "string", compatibilityOnly: true, appliesToVerbs: ["record-answer"] },
-			{
-				name: "answer-json",
-				type: "object",
-				required: true,
-				compatibilityOnly: true,
-				appliesToVerbs: ["record-answer"],
-			},
-			{
-				name: "question-json",
-				type: "string",
-				required: true,
-				compatibilityOnly: true,
-				appliesToVerbs: ["record-answer"],
-			},
-			{
-				name: "result-json",
-				type: "object",
-				required: true,
-				compatibilityOnly: true,
-				appliesToVerbs: ["apply-round-result"],
-			},
-			{
-				name: "selector",
+				name: "for",
 				type: "enum",
-				enumValues: ["summary", "recent-scored", "pending", "round", "topology", "facts", "triggers", "floor"],
+				enumValues: ["initialize-context", "record-round", "update-facts", "merge-state"],
 				required: true,
-				appliesToVerbs: ["inspect"],
+				appliesToVerbs: ["stage"],
 			},
-			{ name: "round-key", type: "string", appliesToVerbs: ["inspect"] },
-			{ name: "cursor", type: "string", appliesToVerbs: ["inspect"] },
-			{ name: "limit", type: "number", appliesToVerbs: ["inspect"] },
 			{ name: "args", type: "string", planned: true },
 			{ name: "metadata-json", type: "string", planned: true },
 		],
@@ -443,9 +290,7 @@ export const WORKFLOW_MANIFEST: Record<CanonicalGjcWorkflowSkill, SkillManifest>
 				"classify-blocker",
 				"record-critic-verdict",
 				"record-critic-gate-override",
-				"start-pipeline-overlap",
-				"join-pipeline-overlap",
-				"rebaseline-pipeline-overlap",
+				"quality-gate",
 			]),
 			...plannedVerbs(PLANNED_ADMIN_VERBS),
 		],
@@ -480,7 +325,7 @@ export const WORKFLOW_MANIFEST: Record<CanonicalGjcWorkflowSkill, SkillManifest>
 					"classify-blocker",
 					"record-critic-verdict",
 					"record-critic-gate-override",
-					"rebaseline-pipeline-overlap",
+					"quality-gate",
 				],
 			},
 			{
@@ -500,69 +345,10 @@ export const WORKFLOW_MANIFEST: Record<CanonicalGjcWorkflowSkill, SkillManifest>
 			{ name: "blockers-json", type: "string", appliesToVerbs: ["record-critic-verdict"] },
 			{ name: "goal-id", type: "string", appliesToVerbs: ["record-critic-verdict"] },
 			{ name: "classification-event-id", type: "string", appliesToVerbs: ["record-critic-verdict"] },
-			{
-				name: "goal-metadata-json",
-				type: "string",
-				appliesToVerbs: ["create-goals"],
-			},
-			{
-				name: "prior-goal-id",
-				type: "string",
-				required: true,
-				appliesToVerbs: ["start-pipeline-overlap"],
-			},
-			{
-				name: "next-goal-id",
-				type: "string",
-				required: true,
-				appliesToVerbs: ["start-pipeline-overlap"],
-			},
-			{
-				name: "review-handles-json",
-				type: "string",
-				required: true,
-				appliesToVerbs: ["start-pipeline-overlap"],
-			},
-			{
-				name: "qa-handles-json",
-				type: "string",
-				required: true,
-				appliesToVerbs: ["start-pipeline-overlap"],
-			},
-			{
-				name: "implementation-handle-json",
-				type: "string",
-				required: true,
-				appliesToVerbs: ["start-pipeline-overlap"],
-			},
-			{
-				name: "overlap-id",
-				type: "string",
-				required: true,
-				appliesToVerbs: ["join-pipeline-overlap", "rebaseline-pipeline-overlap"],
-			},
-			{
-				name: "review-result-json",
-				type: "string",
-				required: true,
-				appliesToVerbs: ["join-pipeline-overlap"],
-			},
-			{
-				name: "qa-result-json",
-				type: "string",
-				required: true,
-				appliesToVerbs: ["join-pipeline-overlap"],
-			},
-			{
-				name: "target-state-json",
-				type: "string",
-				required: true,
-				appliesToVerbs: ["rebaseline-pipeline-overlap"],
-			},
-			{ name: "quality-gate-json", type: "string", appliesToVerbs: ["checkpoint"] },
+			{ name: "quality-gate-json", type: "string", appliesToVerbs: ["checkpoint", "quality-gate"] },
+			{ name: "goal-id", type: "string", appliesToVerbs: ["quality-gate"] },
 			{ name: "goal-id", type: "string", appliesToVerbs: ["steer"] },
 			{ name: "goal-id", type: "string", appliesToVerbs: ["classify-blocker"] },
-			{ name: "goal-id", type: "string", required: true, appliesToVerbs: ["rebaseline-pipeline-overlap"] },
 			{
 				name: "classification",
 				type: "enum",
@@ -612,9 +398,6 @@ export const WORKFLOW_MANIFEST: Record<CanonicalGjcWorkflowSkill, SkillManifest>
 					"classify-blocker",
 					"record-critic-verdict",
 					"record-critic-gate-override",
-					"start-pipeline-overlap",
-					"join-pipeline-overlap",
-					"rebaseline-pipeline-overlap",
 				],
 			},
 			{ name: "directive-json", type: "string", appliesToVerbs: ["steer"], planned: true },
@@ -679,6 +462,9 @@ export const WORKFLOW_MANIFEST: Record<CanonicalGjcWorkflowSkill, SkillManifest>
 					"read-worker-status",
 					"read-worker-heartbeat",
 					"update-worker-heartbeat",
+					"read-worker-memory-guard",
+					"update-worker-memory-guard",
+					"apply-worker-memory-guard",
 					"write-worker-inbox",
 					"write-worker-identity",
 					"append-event",
@@ -705,6 +491,11 @@ export const WORKFLOW_MANIFEST: Record<CanonicalGjcWorkflowSkill, SkillManifest>
 			},
 			{ name: "completion_evidence", type: "object", appliesToVerbs: ["api"] },
 			{ name: "completionEvidence", type: "object", appliesToVerbs: ["api"] },
+			{ name: "platform", type: "string", appliesToVerbs: ["api"] },
+			{ name: "automatic-action-allowed", type: "boolean", appliesToVerbs: ["api"] },
+			{ name: "incident-id", type: "string", appliesToVerbs: ["api"] },
+			{ name: "pid-probe", type: "object", appliesToVerbs: ["api"] },
+			{ name: "candidates", type: "object", appliesToVerbs: ["api"] },
 			{ name: "args", type: "string", planned: true },
 			{ name: "metadata-json", type: "string", planned: true },
 		],

package/src/hooks/native-skill-hook.ts

@@ -1,6 +1,6 @@
 import { appendFile, mkdir, stat } from "node:fs/promises";
-import * as os from "node:os";
 import * as path from "node:path";
+import { getAgentDir, getConfigDirName } from "@gajae-code/utils";
 import { YAML } from "bun";
 import type { SkillDiscoverySettings } from "../config/skill-settings-defaults";
 import { DEFAULT_DISABLED_EXTENSIONS, DEFAULT_SKILL_DISCOVERY_SETTINGS } from "../config/skill-settings-defaults";
@@ -153,11 +153,24 @@ async function readRawConfig(filePath: string): Promise<Record<string, unknown>
 	}
 }
 
+/**
+ * Config files that decide skill discovery, resolved through the trusted helpers.
+ *
+ * These paths pick the `config.yml` whose `skills.customDirectories` the agent
+ * then loads skills from, so the directory they are built from is a trust
+ * boundary. Bun loads `cwd/.env` into `process.env` before any module runs, so
+ * reading `GJC_CODING_AGENT_DIR` / `GJC_CONFIG_DIR` directly let a repository
+ * point this at a directory it ships and inject its own skill directories.
+ *
+ * `getAgentDir()` and `getConfigDirName()` apply the escalation guards that
+ * already exist for exactly this (`trustedAgentDirOverride`,
+ * `trustedConfigDirName`), and resolve to the same locations this used to build
+ * by hand: `dirs.agentDir` is `path.join(os.homedir(), getConfigDirName(), "agent")`
+ * when no trusted override is present.
+ */
 function resolveConfigPaths(cwd: string, override?: string[]): string[] {
 	if (override) return override;
-	const configDirName = process.env.GJC_CONFIG_DIR ?? process.env.PI_CONFIG_DIR ?? ".gjc";
-	const userAgentDir = process.env.GJC_CODING_AGENT_DIR ?? path.join(os.homedir(), configDirName, "agent");
-	return [path.join(userAgentDir, "config.yml"), path.join(cwd, configDirName, "config.yml")];
+	return [path.join(getAgentDir(), "config.yml"), path.join(cwd, getConfigDirName(), "config.yml")];
 }
 
 async function resolveEffectiveSkillConfig(

package/src/hooks/skill-state.ts

@@ -3,7 +3,6 @@ import * as path from "node:path";
 import { logger } from "@gajae-code/utils";
 import type { SkillDiscoverySettings } from "../config/skill-settings-defaults";
 import { detectDeepInterviewPlaintextAskLeak } from "../deep-interview/plaintext-gate-guard";
-import { scoreToUnits } from "../gjc-runtime/deep-interview-ambiguity";
 import { activeSnapshotPath, modeStatePath as sessionModeStatePath } from "../gjc-runtime/session-layout";
 import { resolveGjcSessionForRead } from "../gjc-runtime/session-resolution";
 import { ModeStateSchema, SkillActiveStateSchema } from "../gjc-runtime/state-schema";
@@ -411,29 +410,8 @@ async function seedSkillActivationState(
 		...(input.turnId ? { turn_id: input.turnId } : {}),
 	};
 	if (skill === "deep-interview") {
-		const threshold = DEFAULT_DEEP_INTERVIEW_AMBIGUITY_THRESHOLD;
-		const thresholdUnits = scoreToUnits(threshold);
-		modeState.schema_version = 1;
-		modeState.resolution = "standard";
-		modeState.threshold = threshold;
-		modeState.threshold_units = thresholdUnits;
+		modeState.threshold = DEFAULT_DEEP_INTERVIEW_AMBIGUITY_THRESHOLD;
 		modeState.threshold_source = "default";
-		modeState.state = {
-			setup: { status: "unresolved" },
-			type: "greenfield",
-			intent_contract_required: true,
-			rounds: [],
-			established_facts: [],
-			topology: { status: "pending", components: [], deferred_components: [] },
-			ontology_snapshots: [],
-			auto_researched_rounds: [],
-			auto_answered_rounds: [],
-			architect_failures: 0,
-			current_ambiguity: 1.0,
-			threshold,
-			threshold_units: thresholdUnits,
-			threshold_source: "default",
-		};
 	}
 
 	await readExistingStateForMutation(initializedStatePath);