@gadmin2n/schematics 0.0.144 → 0.0.146

package/dist/lib/application/files/gadmin2-game-angle-demo/server/src/modules/httpRequest/http-request-runtime.controller.ts

@@ -62,76 +62,80 @@ export class HttpRequestRuntimeController {
     const node = (version?.dsl as any)?.nodes?.find(
       (item: any) => item.id === input.nodeId,
     );
+    const dynamicSubject = Array.isArray(node?.config?.subjects)
+      ? node.config.subjects.find(
+          (subject: any) =>
+            subject?.source === 'DYNAMIC' &&
+            subject.inputKey === input.lookupKey,
+        )
+      : undefined;
+    const nodeConfig =
+      node?.runtimeKey === 'http_request' && !input.configKey
+        ? node.config
+        : node?.runtimeKey === 'human_approval' &&
+          input.configKey === 'externalRequest'
+        ? node.config.external?.request
+        : node?.runtimeKey === 'human_approval' &&
+          input.configKey === 'approverLookupRequest'
+        ? dynamicSubject?.lookup?.request
+        : undefined;
     if (
       !version ||
       version.workflowId !== instance.workflowId ||
-      node?.runtimeKey !== 'http_request' ||
-      !node?.config ||
-      typeof node.config !== 'object' ||
-      typeof node.config.connectionRef !== 'string'
+      !nodeConfig ||
+      typeof nodeConfig !== 'object' ||
+      typeof nodeConfig.connectionRef !== 'string'
     )
       throw runtimeError(
         'WORKFLOW_RUNTIME_COMPILED_INPUT_INVALID',
         'HTTP Request input does not match the compiled workflow',
       );
 
-    const nodeConfig = node.config as HttpRequestNodeConfig & {
-      retryOnFail?: boolean;
-      maxRetries?: number;
-      retryInterval?: number;
-    };
+    const requestConfig = nodeConfig as HttpRequestNodeConfig;
     const connection = await this.connections.resolveRuntime(
-      nodeConfig.connectionRef,
+      requestConfig.connectionRef,
     );
-    const request = materializeHttpRequest(nodeConfig, connection, {
-      input: input.input,
-      workflow: input.workflow,
-      system: input.system ?? {},
-    });
-    const attempts = nodeConfig.retryOnFail
-      ? Math.min(Math.max(nodeConfig.maxRetries ?? 0, 0), 10) + 1
-      : 1;
-
-    let lastError: unknown;
-    for (let attempt = 0; attempt < attempts; attempt += 1) {
-      try {
-        const response = await axios.request({
-          url: request.url,
-          method: request.method,
-          params: request.query,
-          headers: request.headers,
-          data: request.body,
-          timeout: request.timeoutMs,
-          ...(request.ignoreSslErrors && {
-            httpsAgent: new HttpsAgent({ rejectUnauthorized: false }),
-          }),
-          maxRedirects: 5,
-          validateStatus: (status) => status >= 200 && status < 300,
-        });
-        return {
-          status: response.status,
-          data: response.data,
-          headers: Object.fromEntries(Object.entries(response.headers)),
-        };
-      } catch (error) {
-        lastError = error;
-        if (attempt + 1 < attempts)
-          await delay(
-            Math.min(Math.max(nodeConfig.retryInterval ?? 1000, 0), 60000),
-          );
-      }
+    const request = materializeHttpRequest(
+      requestConfig,
+      connection,
+      {
+        input: input.input,
+        workflow: input.workflow,
+        approval: input.approval,
+      },
+      { operationKey: input.operationKey },
+    );
+    try {
+      const response = await axios.request({
+        url: request.url,
+        method: request.method,
+        params: request.query,
+        headers: request.headers,
+        data: request.body,
+        timeout: request.timeoutMs,
+        ...(request.ignoreSslErrors && {
+          httpsAgent: new HttpsAgent({ rejectUnauthorized: false }),
+        }),
+        maxRedirects: 5,
+        validateStatus: (status) => status >= 200 && status < 300,
+      });
+      return {
+        status: response.status,
+        data: response.data,
+        headers: Object.fromEntries(Object.entries(response.headers)),
+      };
+    } catch (error) {
+      const status = axios.isAxiosError(error)
+        ? error.response?.status
+        : undefined;
+      throw new BadGatewayException({
+        code: 'HTTP_REQUEST_EXECUTION_FAILED',
+        message: status
+          ? `External API returned HTTP ${status}`
+          : 'External API request failed',
+        retryable: true,
+      });
     }
-
-    const status = axios.isAxiosError(lastError)
-      ? lastError.response?.status
-      : undefined;
-    throw new BadGatewayException({
-      code: 'HTTP_REQUEST_EXECUTION_FAILED',
-      message: status
-        ? `External API returned HTTP ${status}`
-        : 'External API request failed',
-      retryable: true,
-    });
   }
 }
 
@@ -147,7 +151,3 @@ function parseId(value: string): bigint {
 function runtimeError(code: string, message: string) {
   return new BadRequestException({ code, message, retryable: false });
 }
-
-function delay(milliseconds: number): Promise<void> {
-  return new Promise((resolve) => setTimeout(resolve, milliseconds));
-}

package/dist/lib/application/files/gadmin2-game-angle-demo/server/src/modules/httpRequest/http-request-runtime.dto.ts

@@ -1,6 +1,7 @@
 import {
   Allow,
   IsDefined,
+  IsIn,
   IsNotEmpty,
   IsObject,
   IsOptional,
@@ -28,6 +29,19 @@ export class ExecuteHttpRequestRuntimeDto {
   @IsNotEmpty()
   nodeId!: string;
 
+  @IsOptional()
+  @IsIn(['externalRequest', 'approverLookupRequest'])
+  configKey?: 'externalRequest' | 'approverLookupRequest';
+
+  @IsOptional()
+  @IsString()
+  @IsNotEmpty()
+  lookupKey?: string;
+
+  @IsString()
+  @IsNotEmpty()
+  operationKey!: string;
+
   @Allow()
   @IsDefined()
   input!: unknown;
@@ -37,5 +51,5 @@ export class ExecuteHttpRequestRuntimeDto {
 
   @IsOptional()
   @IsObject()
-  system?: Record<string, unknown>;
+  approval?: Record<string, unknown>;
 }

package/dist/lib/application/files/gadmin2-game-angle-demo/server/src/modules/httpRequest/http-request-runtime.util.spec.ts

@@ -1,6 +1,43 @@
 import { materializeHttpRequest } from './http-request-runtime.util';
 
 describe('HTTP Request runtime materialization', () => {
+  it('uses the Base URL unchanged when the request path is root', () => {
+    const request = materializeHttpRequest(
+      {
+        connectionRef: 'servicenow_uat',
+        method: 'GET',
+        path: '/',
+        queryBindings: {
+          serial_number: {
+            source: 'FIXED',
+            valueType: 'STRING',
+            value: 'CND2063LXC',
+          },
+          query_type: {
+            source: 'FIXED',
+            valueType: 'STRING',
+            value: 'exact',
+          },
+        },
+      },
+      {
+        baseUrl:
+          'https://tencentuat.service-now.com/api/tenam/sn_oep_asset/serialNum',
+        authType: 'BASIC',
+        secrets: { username: 'user', password: 'password' },
+      },
+      { input: {}, workflow: {} },
+    );
+
+    expect(request.url).toBe(
+      'https://tencentuat.service-now.com/api/tenam/sn_oep_asset/serialNum',
+    );
+    expect(request.query).toEqual({
+      serial_number: 'CND2063LXC',
+      query_type: 'exact',
+    });
+  });
+
   it('resolves input, Workflow data, and fixed values into a request', () => {
     const request = materializeHttpRequest(
       {
@@ -119,7 +156,7 @@ describe('HTTP Request runtime materialization', () => {
     ).toThrow('HTTP_TEMPLATE_SOURCE_REQUIRED:wecomId');
   });
 
-  it('resolves system-provided values without mixing them into Workflow data', () => {
+  it('resolves approval data without changing previous-node input', () => {
     const request = materializeHttpRequest(
       {
         connectionRef: 'myoa',
@@ -127,8 +164,8 @@ describe('HTTP Request runtime materialization', () => {
         path: '/approvals',
         headerBindings: {
           'x-request-id': {
-            source: 'SYSTEM',
-            path: 'approval.requestId',
+            source: 'APPROVAL',
+            path: 'requestId',
           },
         },
         bodyMode: 'JSON',
@@ -137,7 +174,7 @@ describe('HTTP Request runtime materialization', () => {
           data: [
             {
               key: 'gadmin_callback_token',
-              value: ['{{system.callback.token}}'],
+              value: ['{{approval.callbackToken}}'],
             },
           ],
         },
@@ -148,11 +185,13 @@ describe('HTTP Request runtime materialization', () => {
         secrets: {},
       },
       {
-        input: {},
-        workflow: { title: '服务器权限申请' },
-        system: {
-          approval: { requestId: '42' },
-          callback: { token: 'ext_cb_approval' },
+        input: { title: '上一个节点的数据' },
+        workflow: {
+          title: '服务器权限申请',
+        },
+        approval: {
+          requestId: '42',
+          callbackToken: 'ext_cb_approval',
         },
       },
     );
@@ -168,4 +207,26 @@ describe('HTTP Request runtime materialization', () => {
       ],
     });
   });
+
+  it('adds an opaque idempotency key to mutating external requests', () => {
+    const request = materializeHttpRequest(
+      {
+        connectionRef: 'orders',
+        method: 'POST',
+        path: '/orders',
+      },
+      {
+        baseUrl: 'https://orders.example.com',
+        authType: 'NONE',
+        secrets: {},
+      },
+      { input: {}, workflow: {} },
+      { operationKey: 'workflow:12:node:internal-node-id' },
+    );
+
+    expect(request.headers['Idempotency-Key']).toMatch(/^[a-f0-9]{64}$/);
+    expect(request.headers['Idempotency-Key']).not.toContain(
+      'internal-node-id',
+    );
+  });
 });

package/dist/lib/application/files/gadmin2-game-angle-demo/server/src/modules/httpRequest/http-request-runtime.util.ts

@@ -45,12 +45,13 @@ export interface MaterializedHttpRequest {
 export interface HttpRequestMaterializationOptions {
   timestamp?: string;
   nonce?: string;
+  operationKey?: string;
 }
 
 export interface HttpRequestData {
   input: unknown;
   workflow: Record<string, unknown>;
-  system?: Record<string, unknown>;
+  approval?: Record<string, unknown>;
 }
 
 export function materializeHttpRequest(
@@ -66,9 +67,15 @@ export function materializeHttpRequest(
   const resolvedPath = resolveTemplates(config.path, data);
   if (typeof resolvedPath !== 'string')
     throw new Error('HTTP_REQUEST_PATH_INVALID');
-  const base = new URL(ensureTrailingSlash(connection.baseUrl));
-  const url = new URL(resolvedPath.replace(/^\//, ''), base);
-  if (url.origin !== base.origin)
+  const connectionUrl = new URL(connection.baseUrl);
+  const url =
+    resolvedPath === '/'
+      ? connectionUrl
+      : new URL(
+          resolvedPath.replace(/^\//, ''),
+          new URL(ensureTrailingSlash(connection.baseUrl)),
+        );
+  if (url.origin !== connectionUrl.origin)
     throw new Error('HTTP_REQUEST_PATH_CANNOT_CHANGE_ORIGIN');
 
   const query = resolveBindings(config.queryBindings ?? {}, data);
@@ -83,6 +90,7 @@ export function materializeHttpRequest(
     ),
   };
   applyAuthentication(connection, headers, query, _options);
+  applyIdempotencyKey(method, headers, _options.operationKey);
 
   const timeoutSeconds = config.timeoutSeconds ?? 30;
   if (
@@ -110,6 +118,22 @@ export function materializeHttpRequest(
   };
 }
 
+function applyIdempotencyKey(
+  method: string,
+  headers: Record<string, string>,
+  operationKey: string | undefined,
+): void {
+  if (
+    !operationKey ||
+    !['POST', 'PUT', 'PATCH', 'DELETE'].includes(method) ||
+    Object.keys(headers).some((key) => key.toLowerCase() === 'idempotency-key')
+  )
+    return;
+  headers['Idempotency-Key'] = createHash('sha256')
+    .update(operationKey)
+    .digest('hex');
+}
+
 function resolveBindings(
   bindings: Record<string, ParameterBinding>,
   data: HttpRequestData,
@@ -124,7 +148,7 @@ function resolveBindings(
           binding,
           data.input,
           data.workflow,
-          data.system,
+          data.approval,
         ),
       ];
     }),
@@ -157,7 +181,7 @@ function resolveTemplates(value: unknown, data: HttpRequestData): unknown {
 function requireReference(data: HttpRequestData, path: string): unknown {
   const normalized = path.trim();
   const [source, ...parts] = normalized.split('.');
-  if (!['input', 'workflow', 'system'].includes(source) || parts.length === 0)
+  if (!['input', 'workflow', 'approval'].includes(source) || parts.length === 0)
     throw new Error(`HTTP_TEMPLATE_SOURCE_REQUIRED:${normalized}`);
 
   let current: unknown =
@@ -165,7 +189,7 @@ function requireReference(data: HttpRequestData, path: string): unknown {
       ? data.input
       : source === 'workflow'
       ? data.workflow
-      : data.system;
+      : data.approval;
   for (const part of parts) {
     if (!current || typeof current !== 'object' || !(part in current))
       throw new Error(`HTTP_TEMPLATE_RESOLUTION_FAILED:${normalized}`);

package/dist/lib/application/files/gadmin2-game-angle-demo/server/src/modules/humanApproval/approval-signal-outbox.service.spec.ts

@@ -0,0 +1,30 @@
+import { ApprovalSignalOutboxService } from './approval-signal-outbox.service';
+
+describe('ApprovalSignalOutboxService', () => {
+  it('does not claim rows that exhausted their retry budget', async () => {
+    const findMany = jest.fn().mockResolvedValue([]);
+    const prisma = {
+      $transaction: jest.fn((callback) =>
+        callback({
+          approvalSignalOutbox: {
+            findMany,
+            updateMany: jest.fn(),
+          },
+        }),
+      ),
+    };
+    const service = new ApprovalSignalOutboxService(prisma as any, {} as any);
+
+    await service.poll();
+
+    expect(findMany).toHaveBeenCalledWith(
+      expect.objectContaining({
+        where: expect.objectContaining({
+          OR: expect.arrayContaining([
+            expect.objectContaining({ retryCount: { lt: 10 } }),
+          ]),
+        }),
+      }),
+    );
+  });
+});

package/dist/lib/application/files/gadmin2-game-angle-demo/server/src/modules/humanApproval/approval-signal-outbox.service.ts

@@ -3,7 +3,11 @@ import { Interval } from '@nestjs/schedule';
 import { randomUUID } from 'crypto';
 import { PrismaService } from 'nestjs-prisma';
 import { TemporalService } from '../workflow/temporal.service';
-import { outboxError, outboxRetryAt } from './outbox-retry.util';
+import {
+  OUTBOX_MAX_RETRY_COUNT,
+  outboxError,
+  outboxRetryAt,
+} from './outbox-retry.util';
 
 const BATCH_SIZE = 25;
 const LOCK_TIMEOUT_MS = 60_000;
@@ -33,8 +37,16 @@ export class ApprovalSignalOutboxService {
         where: {
           nextAttemptAt: { lte: now },
           OR: [
-            { status: { in: ['PENDING', 'FAILED'] }, lockedAt: null },
-            { status: 'PROCESSING', lockedAt: { lt: staleAt } },
+            {
+              status: { in: ['PENDING', 'FAILED'] },
+              retryCount: { lt: OUTBOX_MAX_RETRY_COUNT },
+              lockedAt: null,
+            },
+            {
+              status: 'PROCESSING',
+              retryCount: { lt: OUTBOX_MAX_RETRY_COUNT },
+              lockedAt: { lt: staleAt },
+            },
           ],
         },
         orderBy: { id: 'asc' },
@@ -46,8 +58,16 @@ export class ApprovalSignalOutboxService {
         where: {
           id: { in: ids },
           OR: [
-            { status: { in: ['PENDING', 'FAILED'] }, lockedAt: null },
-            { status: 'PROCESSING', lockedAt: { lt: staleAt } },
+            {
+              status: { in: ['PENDING', 'FAILED'] },
+              retryCount: { lt: OUTBOX_MAX_RETRY_COUNT },
+              lockedAt: null,
+            },
+            {
+              status: 'PROCESSING',
+              retryCount: { lt: OUTBOX_MAX_RETRY_COUNT },
+              lockedAt: { lt: staleAt },
+            },
           ],
         },
         data: { status: 'PROCESSING', lockedAt: now, lockedBy: claimId },
@@ -108,7 +128,9 @@ export class ApprovalSignalOutboxService {
         },
       });
       this.logger.warn(
-        `Approval signal ${row.id} failed: ${outboxError(error)}`,
+        `Approval signal ${row.id} failed${
+          retryCount >= OUTBOX_MAX_RETRY_COUNT ? ' permanently' : ''
+        }: ${outboxError(error)}`,
       );
     }
   }

package/dist/lib/application/files/gadmin2-game-angle-demo/server/src/modules/humanApproval/approval-subject-source.util.spec.ts

@@ -1,7 +1,7 @@
 import { materializeApprovalSubjects } from './approval-subject-source.util';
 
 describe('materializeApprovalSubjects', () => {
-  it('combines static approvers with scalar and array dynamic inputs', () => {
+  it('combines static approvers with embedded dynamic lookup results', () => {
     expect(
       materializeApprovalSubjects(
         [
@@ -18,8 +18,17 @@ describe('materializeApprovalSubjects', () => {
           },
         ],
         {
-          request_owner: 'bob',
-          review_groups: ['finance', 'risk', 'finance'],
+          request_owner: {
+            subjects: [{ provider: 'USER', refs: ['bob'] }],
+          },
+          review_groups: {
+            subjects: [
+              {
+                provider: 'USER_GROUP',
+                refs: ['finance', 'risk', 'finance'],
+              },
+            ],
+          },
         },
       ),
     ).toEqual([
@@ -42,4 +51,42 @@ describe('materializeApprovalSubjects', () => {
       ),
     ).toThrow('Dynamic approver input "request_owner" is missing or empty');
   });
+
+  it('materializes the subjects returned by an embedded lookup script', () => {
+    expect(
+      materializeApprovalSubjects(
+        [
+          {
+            source: 'DYNAMIC',
+            provider: 'USER',
+            inputKey: 'direct_manager',
+          },
+        ],
+        {
+          direct_manager: {
+            subjects: [{ provider: 'USER', refs: ['leader-a'] }],
+          },
+        },
+      ),
+    ).toEqual([{ provider: 'USER', refs: ['leader-a'] }]);
+  });
+
+  it('rejects a lookup result that does not use the configured provider', () => {
+    expect(() =>
+      materializeApprovalSubjects(
+        [
+          {
+            source: 'DYNAMIC',
+            provider: 'USER',
+            inputKey: 'direct_manager',
+          },
+        ],
+        {
+          direct_manager: {
+            subjects: [{ provider: 'USER_GROUP', refs: ['leaders'] }],
+          },
+        },
+      ),
+    ).toThrow('Dynamic approver input "direct_manager" is missing or empty');
+  });
 });

package/dist/lib/application/files/gadmin2-game-angle-demo/server/src/modules/humanApproval/approval-subject-source.util.ts

@@ -26,7 +26,11 @@ export function materializeApprovalSubjects(
   for (const source of sources) {
     const refs =
       source.source === 'DYNAMIC'
-        ? normalizeDynamicRefs(dynamicInputs[source.inputKey], source.inputKey)
+        ? normalizeDynamicRefs(
+            dynamicInputs[source.inputKey],
+            source.inputKey,
+            source.provider,
+          )
         : normalizeRefs(source.refs);
     const current = refsByProvider.get(source.provider) ?? [];
     refsByProvider.set(source.provider, [...new Set([...current, ...refs])]);
@@ -35,13 +39,32 @@ export function materializeApprovalSubjects(
   return [...refsByProvider].map(([provider, refs]) => ({ provider, refs }));
 }
 
-function normalizeDynamicRefs(value: unknown, inputKey: string): string[] {
-  const refs = normalizeRefs(Array.isArray(value) ? value : [value]);
+function normalizeDynamicRefs(
+  value: unknown,
+  inputKey: string,
+  provider: ApprovalSubjectProvider,
+): string[] {
+  const result = asObject(value);
+  const subjects = Array.isArray(result.subjects) ? result.subjects : [];
+  const refs = normalizeRefs(
+    subjects.flatMap((item) => {
+      const subject = asObject(item);
+      return subject.provider === provider && Array.isArray(subject.refs)
+        ? subject.refs
+        : [];
+    }),
+  );
   if (refs.length === 0)
     throw new Error(`Dynamic approver input "${inputKey}" is missing or empty`);
   return refs;
 }
 
+function asObject(value: unknown): Record<string, unknown> {
+  return value && typeof value === 'object' && !Array.isArray(value)
+    ? (value as Record<string, unknown>)
+    : {};
+}
+
 function normalizeRefs(values: unknown[]): string[] {
   return [
     ...new Set(