@gabrielrufino/cube 1.0.22 → 1.0.23

package/build/LinkedList/ILinkedList.d.ts

@@ -4,10 +4,10 @@ interface ILinkedList<T> {
     get size(): number;
     get isEmpty(): boolean;
     push(_element: T): T;
-    getFromPosition(_position: number): ILinkedListItem<T> | undefined;
+    getFromPosition(_position: number): ILinkedListItem<T> | null;
     positionOf(_element: T): number | undefined;
     insertInPosition(_element: T, _position: number): T | undefined;
-    remove(_element: T): T | undefined;
-    removeFromPosition(_position: number): T | undefined;
+    remove(_element: T): T | null;
+    removeFromPosition(_position: number): T | null;
 }
 export default ILinkedList;

package/build/LinkedList/index.d.ts

@@ -1,4 +1,5 @@
 import ILinkedList from './ILinkedList';
+import ILinkedListItem from './ILinkedListItem';
 export default class LinkedList<T = number> implements ILinkedList<T> {
     private readonly _FIRST_POSITION;
     private _head;
@@ -12,13 +13,10 @@ export default class LinkedList<T = number> implements ILinkedList<T> {
     get isEmpty(): boolean;
     positionOf(element: T): number | undefined;
     push(element: T): T;
-    remove(element: T): T | undefined;
+    remove(element: T): T | null;
     insertInPosition(element: T, position: number): T | undefined;
-    getFromPosition(position: number): {
-        value: T;
-        next: T | null;
-    } | undefined;
-    removeFromPosition(position: number): T | undefined;
-    private getNodeFromPosition;
+    getFromPosition(position: number): ILinkedListItem<T> | null;
+    removeFromPosition(position: number): T | null;
+    private _getNodeFromPosition;
     private [Symbol.toPrimitive];
 }

package/build/LinkedList/index.js

@@ -55,7 +55,7 @@ var LinkedList = /** @class */ (function () {
         var current = this._head;
         var position = 0;
         while (current && current.value !== element) {
-            current = current === null || current === void 0 ? void 0 : current.next;
+            current = current.next;
             position += 1;
         }
         if (current) {
@@ -81,6 +81,7 @@ var LinkedList = /** @class */ (function () {
         if (position) {
             return this.removeFromPosition(position);
         }
+        return null;
     };
     LinkedList.prototype.insertInPosition = function (element, position) {
         if (position < this._FIRST_POSITION || position > this.size) {
@@ -92,7 +93,7 @@ var LinkedList = /** @class */ (function () {
             this._head = node;
         }
         else {
-            var before = this.getNodeFromPosition(position - 1);
+            var before = this._getNodeFromPosition(position - 1);
             var after = (before && before.next) || null;
             if (before) {
                 before.next = node;
@@ -104,51 +105,45 @@ var LinkedList = /** @class */ (function () {
     };
     LinkedList.prototype.getFromPosition = function (position) {
         var _a;
-        if (position < this._FIRST_POSITION || position > this.size - 1) {
-            return undefined;
-        }
-        var node = this._head;
-        for (var i = 0; i < position; i++) {
-            node = (node === null || node === void 0 ? void 0 : node.next) || null;
+        var node = this._getNodeFromPosition(position);
+        if (!node) {
+            return null;
         }
-        if (node === null || node === void 0 ? void 0 : node.value) {
-            return {
-                value: node.value,
-                next: ((_a = node.next) === null || _a === void 0 ? void 0 : _a.value) || null,
-            };
-        }
-        return undefined;
+        return {
+            value: node.value,
+            next: ((_a = node.next) === null || _a === void 0 ? void 0 : _a.value) || null,
+        };
     };
     LinkedList.prototype.removeFromPosition = function (position) {
-        if (position < this._FIRST_POSITION || position > (this.size - 1)) {
-            return undefined;
+        if (position < this._FIRST_POSITION || position >= this.size) {
+            return null;
         }
         var current = this._head;
         if (position === this._FIRST_POSITION) {
-            this._head = (current === null || current === void 0 ? void 0 : current.next) || null;
+            this._head = current.next;
         }
         else {
             var previous = void 0;
-            for (var i = 0; i < position; i++) {
+            for (var i = 0; i < position && current; i++) {
                 previous = current;
-                current = (current === null || current === void 0 ? void 0 : current.next) || null;
+                current = current.next;
             }
             if (previous) {
-                previous.next = (current === null || current === void 0 ? void 0 : current.next) || null;
+                previous.next = current.next;
             }
         }
         this._size -= 1;
-        return current === null || current === void 0 ? void 0 : current.value;
+        return current.value;
     };
-    LinkedList.prototype.getNodeFromPosition = function (position) {
-        if (position < this._FIRST_POSITION || position > this.size - 1) {
-            return undefined;
+    LinkedList.prototype._getNodeFromPosition = function (position) {
+        if (position < this._FIRST_POSITION || position > (this.size - 1)) {
+            return null;
         }
         var node = this._head;
-        for (var i = 0; i < position; i++) {
-            node = (node === null || node === void 0 ? void 0 : node.next) || null;
+        for (var i = 0; i < position && (node === null || node === void 0 ? void 0 : node.next); i++) {
+            node = node.next;
         }
-        return node || undefined;
+        return node;
     };
     LinkedList.prototype[Symbol.toPrimitive] = function (type) {
         var primitives = {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@gabrielrufino/cube",
-  "version": "1.0.22",
+  "version": "1.0.23",
   "description": "Data Structures and Algorithms made in Typescript",
   "main": "build/index.js",
   "scripts": {