@futurelastic/colab-handbook 1.15.0-rc.4 → 1.15.0-rc.5
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/package.json +1 -1
- package/tools/colab +6 -0
- package/tools/lib/git.js +16 -0
package/package.json
CHANGED
package/tools/colab
CHANGED
|
@@ -11764,6 +11764,12 @@ function classifyCiRunRaw(repoAbs, run, at) {
|
|
|
11764
11764
|
const detail = n === 1 ? `1 run at ${at}: success` : `${n} runs at ${at}: all success`;
|
|
11765
11765
|
return { ok: true, class: null, detail };
|
|
11766
11766
|
}
|
|
11767
|
+
if (run.cancelledOnly) {
|
|
11768
|
+
// #628: one workflow's only run at this sha was cancelled — it verified nothing, and the other
|
|
11769
|
+
// workflows' success does not stand in for it. Name it so a human knows what to re-run.
|
|
11770
|
+
const c = run.cancelledOnly;
|
|
11771
|
+
return { ok: false, class: HUMAN_GATED, detail: `run for ${at}: workflow "${c.workflowName}" never finished here — its only run${c.databaseId ? ` (run ${c.databaseId})` : ''} was cancelled, so it verified nothing; re-run it (#628)` };
|
|
11772
|
+
}
|
|
11767
11773
|
return { ok: false, class: HUMAN_GATED, detail: `run for ${at}: status=completed conclusion=${run.conclusion || 'none'}` };
|
|
11768
11774
|
}
|
|
11769
11775
|
if (run.status === 'none') {
|
package/tools/lib/git.js
CHANGED
|
@@ -1304,6 +1304,22 @@ function summarizeRepoOwnedRuns(forSha, sha) {
|
|
|
1304
1304
|
);
|
|
1305
1305
|
if (notGreen) return { status: 'completed', conclusion: notGreen.conclusion, sha, createdAt: notGreen.createdAt || null, databaseId: notGreen.databaseId || null, runCount };
|
|
1306
1306
|
|
|
1307
|
+
// #628: a NAMED workflow whose head is `cancelled` has no run at this sha that ran to the end —
|
|
1308
|
+
// newestRunPerWorkflow never lets a cancelled row stand for a workflow that has a non-neutral
|
|
1309
|
+
// run (#92), so a cancelled head means cancelled is all it has. That workflow verified nothing,
|
|
1310
|
+
// and a sibling workflow's success must not carry the verdict for it. Measured: the only test
|
|
1311
|
+
// workflow at a trunk head hung and was cancelled, and the head read GREEN on a lint workflow's
|
|
1312
|
+
// success. Unnamed rows (older reads, hand-built fixtures) stay neutral exactly as before — they
|
|
1313
|
+
// cannot be told apart from a superseded straggler of a passing run, which is #92's case.
|
|
1314
|
+
const cancelledOnly = forSha.find((x) => x && x.workflowName && x.status === 'completed' && x.conclusion === 'cancelled');
|
|
1315
|
+
if (cancelledOnly) {
|
|
1316
|
+
return {
|
|
1317
|
+
status: 'completed', conclusion: 'cancelled', sha, createdAt: cancelledOnly.createdAt || null,
|
|
1318
|
+
databaseId: cancelledOnly.databaseId || null, runCount,
|
|
1319
|
+
cancelledOnly: { workflowName: cancelledOnly.workflowName, databaseId: cancelledOnly.databaseId || null },
|
|
1320
|
+
};
|
|
1321
|
+
}
|
|
1322
|
+
|
|
1307
1323
|
// A green verdict is owed only when EVERY sibling at this sha has finished (#307). A row that is
|
|
1308
1324
|
// still queued/in_progress has not passed — it has not run — so picking the first completed
|
|
1309
1325
|
// success here would stamp `runCount` (the FULL sibling count) onto a verdict that inspected one
|