@futurelastic/colab-handbook 1.13.0-rc.40 → 1.13.0-rc.42

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/package.json CHANGED
@@ -33,5 +33,5 @@
33
33
  "engines": {
34
34
  "node": ">=18"
35
35
  },
36
- "version": "1.13.0-rc.40"
36
+ "version": "1.13.0-rc.42"
37
37
  }
@@ -297,6 +297,9 @@ jobs:
297
297
  needs: dedupe
298
298
  if: ${{ !cancelled() && needs.dedupe.outputs.tested != 'true' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.repository) }}
299
299
  runs-on: ubuntu-latest # EDIT: self-hosted label if this repo needs one.
300
+ timeout-minutes: 45 # a hung build must not hold the runner for the 360-minute default (#572).
301
+ # EDIT: measured (#572): the slowest Laravel adopter's build ran p99 20 / max 26 min. Keep this
302
+ # well above YOUR p99 — below it a slow but healthy suite goes red (`gh run view <id>` per job).
300
303
  # Re-exported so the migrations job below resolves PHP exactly once, here.
301
304
  outputs:
302
305
  php-version: ${{ steps.toolchain.outputs.php-version }}
@@ -637,6 +640,8 @@ jobs:
637
640
  # form would skip this job on exactly the runs it exists for (#418).
638
641
  if: ${{ !cancelled() && needs.build.result == 'success' }}
639
642
  runs-on: ubuntu-latest # EDIT: self-hosted label if this repo needs one.
643
+ timeout-minutes: 15 # a hung round-trip must not hold the runner for the 360-minute default (#572).
644
+ # EDIT: measured (#572): p99 under 4 min / max 5 min on every adopter. Keep it well above your own p99.
640
645
  strategy:
641
646
  fail-fast: false
642
647
  matrix:
@@ -290,6 +290,9 @@ jobs:
290
290
  # hashFiles() would have been testing an empty directory even if it were
291
291
  # allowed.
292
292
  runs-on: ubuntu-latest # EDIT: self-hosted label if this repo needs one.
293
+ timeout-minutes: 60 # a hung build must not hold the runner for the 360-minute default (#572).
294
+ # EDIT: measured (#572): the slowest Node adopter's build ran p99 37 / max 43 min. Keep this
295
+ # well above YOUR p99 — below it a slow but healthy suite goes red (`gh run view <id>` per job).
293
296
  # Re-exported so the opt-in round-trip job below resolves Node exactly once, here.
294
297
  outputs:
295
298
  node-version: ${{ steps.toolchain.outputs.node-version }}
@@ -587,6 +590,8 @@ jobs:
587
590
  # # including `dedupe`, which is skipped on every ordinary push (#418).
588
591
  # if: ${{ !cancelled() && needs.build.result == 'success' }}
589
592
  # runs-on: ubuntu-latest # EDIT: self-hosted label if this repo needs one.
593
+ # timeout-minutes: 15 # a hung round-trip must not hold the runner for the 360-minute default (#572).
594
+ # # EDIT: measured (#572): p99 under 4 min on every adopter. Keep it well above your own p99.
590
595
  # strategy:
591
596
  # fail-fast: false
592
597
  # matrix:
@@ -279,6 +279,9 @@ jobs:
279
279
  needs: dedupe
280
280
  if: ${{ !cancelled() && needs.dedupe.outputs.tested != 'true' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.repository) }}
281
281
  runs-on: ubuntu-latest # EDIT: self-hosted label if this repo needs one.
282
+ timeout-minutes: 30 # a hung build must not hold the runner for the 360-minute default (#572).
283
+ # EDIT: NOT a measured fit (#572) — one Python adopter, whose build is a byte-compile (p99
284
+ # under 1 min). Set it well above YOUR p99 — below it a slow but healthy suite goes red.
282
285
  defaults:
283
286
  run:
284
287
  # EDIT: set to the directory holding the Python project if it is not at the root.
@@ -14,7 +14,8 @@
14
14
  // previous final), verifies that, and still fails the run. A manual rollback is a re-run
15
15
  // with the previous tag.
16
16
  // The outcome — "running vX.Y.Z at <time>" or the failure — goes to the run summary and, when one
17
- // exists, to the release issue (the issue carrying `<!-- colab:release version=vX.Y.Z -->`).
17
+ // exists, to the release issue (the issue whose body STARTS with `<!-- colab:release version=vX.Y.Z -->`;
18
+ // one that only mentions it is not the record — #576).
18
19
  //
19
20
  // CONFIGURATION (env; the workflow's one env block):
20
21
  // DEPLOY_ADAPTER portainer (default) — loads ./deploy-adapter-<name>.mjs beside this file
@@ -187,12 +188,25 @@ async function waitForVersion(url, version, io, timeoutS, auth = {}) {
187
188
  }
188
189
  }
189
190
 
191
+ // The release issue is the one whose body STARTS with the marker (leading whitespace tolerated) —
192
+ // never one that merely mentions it, which the search above also returns, in an order GitHub's
193
+ // ranking decides (#576). The same anchored rule as the handbook's release codec
194
+ // (`decodeTrackingMarker`, #575), restated here because this copy never calls back to the handbook.
195
+ export function releaseIssue(json, tag) {
196
+ let list;
197
+ try { list = JSON.parse(json || '[]'); } catch { return ''; }
198
+ if (!Array.isArray(list)) return '';
199
+ const re = /^\s*<!--\s*colab:release\s+version=(v[0-9]+\.[0-9]+\.[0-9]+)\s*-->/;
200
+ const hit = list.find((i) => { const m = re.exec(String((i && i.body) || '')); return m && m[1] === tag; });
201
+ return hit ? String(hit.number) : '';
202
+ }
203
+
190
204
  function record(io, tag, line) {
191
205
  io.summary(line);
192
206
  const repo = io.env.GITHUB_REPOSITORY;
193
207
  if (!repo) return;
194
- const found = io.sh('gh', ['issue', 'list', '--repo', repo, '--state', 'all', '--search', `"colab:release version=${tag}" in:body`, '--json', 'number', '--jq', '.[0].number // ""']);
195
- const n = found.status === 0 ? found.stdout.trim() : '';
208
+ const found = io.sh('gh', ['issue', 'list', '--repo', repo, '--state', 'all', '--search', `"colab:release version=${tag}" in:body`, '--json', 'number,body']);
209
+ const n = found.status === 0 ? releaseIssue(found.stdout, tag) : '';
196
210
  if (!n) { io.log(`no release issue for ${tag} — recorded in the run summary only`); return; }
197
211
  const c = io.sh('gh', ['issue', 'comment', n, '--repo', repo, '--body', line]);
198
212
  if (c.status !== 0) io.log(`could not comment on release issue #${n}: ${c.stderr.trim()}`);