@futurelastic/colab-handbook 1.13.0-rc.10 โ 1.13.0-rc.11
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/package.json +1 -1
- package/tools/lib/shipguard.js +12 -1
package/package.json
CHANGED
package/tools/lib/shipguard.js
CHANGED
|
@@ -190,10 +190,21 @@ function bodyShaClaims(message) {
|
|
|
190
190
|
* an issue that carries no delivery-type label is still covered.
|
|
191
191
|
*/
|
|
192
192
|
const TOOL_MARKS = ['๐ Claimed', 'โ
Released', '๐ข Shipped', '๐ Referenced', 'โฉ๏ธ Sent back'];
|
|
193
|
+
/**
|
|
194
|
+
* #535: a comment whose WHOLE body is one signature line (`โ <name> ยท <machine>/<session>`) is
|
|
195
|
+
* not evidence either. Some deployments post one after every comment; it records who spoke, never
|
|
196
|
+
* what was delivered. Only the bare line is excluded โ a distill that merely ENDS in a signature
|
|
197
|
+
* still counts, so the test is on the whole trimmed body, single line, no `m` flag.
|
|
198
|
+
*/
|
|
199
|
+
const SIGNATURE_ONLY = /^โ[^\S\n][^\n]*\S$/;
|
|
200
|
+
function isSignatureOnly(body) {
|
|
201
|
+
return SIGNATURE_ONLY.test(body);
|
|
202
|
+
}
|
|
193
203
|
function evidenceComments(comments) {
|
|
194
204
|
return (Array.isArray(comments) ? comments : []).filter((c) => {
|
|
195
205
|
const body = String((c && c.body) || '').trim();
|
|
196
206
|
if (!body) return false;
|
|
207
|
+
if (isSignatureOnly(body)) return false;
|
|
197
208
|
return !TOOL_MARKS.some((mark) => body.startsWith(mark));
|
|
198
209
|
});
|
|
199
210
|
}
|
|
@@ -312,6 +323,6 @@ function zeroClaimVerdict(issuesCount, branchName, brokenClaimsCount, { remoteOn
|
|
|
312
323
|
|
|
313
324
|
module.exports = {
|
|
314
325
|
branchIssueNumbers, commitIssueNumbers, corroborateIssues, branchType,
|
|
315
|
-
subjectSanity, bodyShaClaims, evidenceComments, hasEvidence, TOOL_MARKS,
|
|
326
|
+
subjectSanity, bodyShaClaims, evidenceComments, hasEvidence, isSignatureOnly, TOOL_MARKS,
|
|
316
327
|
closesCoverage, zeroClaimVerdict,
|
|
317
328
|
};
|