@futdevpro/nts-dynamo 1.5.52 → 1.5.54

package/src/_services/dynamo-nts-db.service.ts

@@ -112,7 +112,8 @@ export class DynamoNTS_DBService<T extends Dynamo_Metadata> {
   }
 
   /**
-   * returns data by _id, throws error if not found
+   * returns data by _id, 
+   * !!!: throws error if not found (errorCode on not found: NTS-DBS-GI1)
    * @param id id
    * @returns data
    */
@@ -121,7 +122,14 @@ export class DynamoNTS_DBService<T extends Dynamo_Metadata> {
       if (res) {
         return res.toObject() as T;
       } else {
-        return null;
+        /* return null; */
+        throw new Dynamo_Error({ 
+          status: 417, 
+          errorCode: 'NTS-DBS-GI1',
+          addECToUserMsg: true,
+          message: `get ${this.dataParams.dbName} by ID was unsuccessful: data not found by id: ${id} (NTS DB)`, 
+          userMessage: this.defaultErrorUserMsg
+        });
       }
     }).catch(error => {
       throw new Dynamo_Error({ 
@@ -142,7 +150,9 @@ export class DynamoNTS_DBService<T extends Dynamo_Metadata> {
   }
 
   /**
-   * get data by dependency data id, throws error if not found
+   * get data by dependency data id, 
+   * !!!: throws error if not found (errorCode on not found: NTS-DBS-GD2)
+   * 
    * @param dependencyId id
    * @returns data
    */
@@ -161,7 +171,14 @@ export class DynamoNTS_DBService<T extends Dynamo_Metadata> {
       if (res) {
         return res.toObject() as T;
       } else {
-        return null;
+        /* return null; */
+        throw new Dynamo_Error({ 
+          status: 417, 
+          errorCode: 'NTS-DBS-GD2',
+          addECToUserMsg: true,
+          message: `get ${this.dataParams.dbName} by ${this.depDataName} was unsuccessful: data not found by id: ${dependencyId} (NTS DB)`, 
+          userMessage: this.defaultErrorUserMsg
+        });
       }
     }).catch(error => {
       throw new Dynamo_Error({ 
@@ -182,7 +199,9 @@ export class DynamoNTS_DBService<T extends Dynamo_Metadata> {
   }
 
   /**
-   * get data by dependency data id, throws error if not found
+   * get data by dependency data id, 
+   * !!!: throws error if not found (errorCode on not found: NTS-DBS-GLD2)
+   * 
    * @param dependencyId id
    * @returns dataList
    */
@@ -198,8 +217,20 @@ export class DynamoNTS_DBService<T extends Dynamo_Metadata> {
     }
 
     let dataList: T[] = await this.dataModel.find({ [this.depDataName]: dependencyId })
-    .then(res => res ?? [])
-    .catch(error => {
+    .then(res => {
+      if (res) {
+        return res as T[];
+      } else {
+        /* return []; */
+        throw new Dynamo_Error({ 
+          status: 417, 
+          errorCode: 'NTS-DBS-GLD2',
+          addECToUserMsg: true,
+          message: `get ${this.dataParams.dbName} by ${this.depDataName} was unsuccessful: no data found by id: ${dependencyId} (NTS DB)`, 
+          userMessage: this.defaultErrorUserMsg
+        });
+      }
+    }).catch(error => {
       throw new Dynamo_Error({ 
         status: 417, 
         errorCode: 'NTS-DBS-GLD1',
@@ -222,7 +253,9 @@ export class DynamoNTS_DBService<T extends Dynamo_Metadata> {
   }
 
   /**
-   * get multiple data objects by a list of DependencyIDs, throws error if not found
+   * get multiple data objects by a list of DependencyIDs, 
+   * !!!: throws error if not found (errorCode on not found: NTS-DBS-GLDS2)
+   * 
    * @param ids ids
    * @returns dataList
    */
@@ -238,8 +271,20 @@ export class DynamoNTS_DBService<T extends Dynamo_Metadata> {
     }
 
     let dataList: T[] = await this.dataModel.find({ [this.depDataName]: { $in: ids }})
-    .then(res => res ?? [])
-    .catch(error => {
+    .then(res => {
+      if (res) {
+        return res as T[];
+      } else {
+        /* return []; */
+        throw new Dynamo_Error({ 
+          status: 417, 
+          errorCode: 'NTS-DBS-GLDS2',
+          addECToUserMsg: true,
+          message: `get ${this.dataParams.dbName} by ${this.depDataName} was unsuccessful: no data found by ids: ${ids} (NTS DB)`, 
+          userMessage: this.defaultErrorUserMsg
+        });
+      }
+    }).catch(error => {
       throw new Dynamo_Error({ 
         status: 417, 
         errorCode: 'NTS-DBS-GLDS1',
@@ -264,6 +309,7 @@ export class DynamoNTS_DBService<T extends Dynamo_Metadata> {
   /**
    * returns search result for searchBy object params
    * can use lists or xRange values for searchBy obj properties
+   * 
    * @param searchBy filter
    * @param narrowByDependencyIds id
    * @returns dataList
@@ -357,13 +403,27 @@ export class DynamoNTS_DBService<T extends Dynamo_Metadata> {
   }
 
   /**
-   * returns all data from database, throws error if not found
+   * returns all data from database, 
+   * !!!: throws error if not found (errorCode on not found: NTS-DBS-GA1)
+   * 
    * @returns dataList
    */
   async getAll(): Promise<T[]> {
     let dataList: T[] = await this.dataModel.find({})
-    .then(res => res ?? [])
-    .catch(error => {
+    .then(res => {
+      if (res) {
+        return res as T[];
+      } else {
+        /* return null; */
+        throw new Dynamo_Error({ 
+          status: 417, 
+          errorCode: 'NTS-DBS-GA1',
+          addECToUserMsg: true,
+          message: `get all ${this.dataParams.dbName} was unsuccessful: no data found (NTS DB)`, 
+          userMessage: this.defaultErrorUserMsg
+        });
+      }
+    }).catch(error => {
       throw new Dynamo_Error({ 
         status: 417, 
         errorCode: 'NTS-DBS-GA0',
@@ -434,7 +494,9 @@ export class DynamoNTS_DBService<T extends Dynamo_Metadata> {
   // DIRECT Basic MONGOOSE FUNCTIONS (with error handlings)
 
   /**
-   * Find the data first by any of its parameters, throws error if not found
+   * Find the data first by any of its parameters, 
+   * !!!: throws error if not found (errorCode on not found: NTS-DBS-FO1)
+   * 
    * @param filter if you can, use unique parameters for find!
    * 
    * @example 
@@ -460,16 +522,23 @@ export class DynamoNTS_DBService<T extends Dynamo_Metadata> {
   async findOne(filter: any): Promise<T> {
     let data: T = await this.dataModel.findOne(filter).then(res => {
       if (res) {
-        return res.toObject() as T;
+        return res as T;
       } else {
-        return null;
+        /* return null; */
+        throw new Dynamo_Error({ 
+          status: 417, 
+          errorCode: 'NTS-DBS-FO1',
+          addECToUserMsg: true,
+          message: `findOne ${this.dataParams.dbName} was unsuccessful, no data found (NTS DB) fliter: ${filter}`, 
+          userMessage: this.defaultErrorUserMsg
+        });
       }
     }).catch(error => {
       throw new Dynamo_Error({ 
         status: 417, 
         errorCode: 'NTS-DBS-FO0',
         addECToUserMsg: true,
-        message: `findOne ${this.dataParams.dbName} was unsuccessful (NTS DB)`, 
+        message: `findOne ${this.dataParams.dbName} was unsuccessful (NTS DB) fliter: ${filter}`, 
         userMessage: this.defaultErrorUserMsg, 
         error 
       });
@@ -483,7 +552,10 @@ export class DynamoNTS_DBService<T extends Dynamo_Metadata> {
   }
 
   /**
-   * Find the data first by any of its parameters, throws error if not found
+   * #MONGOOSE FUNCTION
+   * Find the data first by any of its parameters, 
+   * !!!: throws error if not found (errorCode on not found: NTS-DBS-F1)
+   * 
    * @param filter if you can, use unique parameters for find!
    * 
    * @example 
@@ -508,8 +580,20 @@ export class DynamoNTS_DBService<T extends Dynamo_Metadata> {
    */
   async find(filter: any): Promise<T[]> {
     let dataList: T[] = await this.dataModel.find(filter)
-    .then(res => res ?? [])
-    .catch(error => {
+    .then(res => {
+      if (res) {
+        return res as T[];
+      } else {
+        /* return null; */
+        throw new Dynamo_Error({ 
+          status: 417, 
+          errorCode: 'NTS-DBS-F1',
+          addECToUserMsg: true,
+          message: `find ${this.dataParams.dbName} was unsuccessful, no data found (NTS DB) fliter: ${filter}`, 
+          userMessage: this.defaultErrorUserMsg
+        });
+      }
+    }).catch(error => {
       throw new Dynamo_Error({ 
         status: 417, 
         errorCode: 'NTS-DBS-F0',
@@ -532,7 +616,9 @@ export class DynamoNTS_DBService<T extends Dynamo_Metadata> {
   }
 
   /**
-   * Find the data first by any of its parameters, throws error if not found
+   * #MONGOOSE FUNCTION
+   * Find the data first by any of its parameters
+   * 
    * @param filter if you can, use unique parameters for find!
    * 
    * @example 
@@ -591,7 +677,10 @@ export class DynamoNTS_DBService<T extends Dynamo_Metadata> {
   }
 
   /**
+   * #MONGOOSE FUNCTION
    * Find data by _id and update
+   * !!!: throws error if not found (errorCode on not found: )
+   * 
    * @param id id
    * @param update update
    * @returns data
@@ -626,14 +715,14 @@ export class DynamoNTS_DBService<T extends Dynamo_Metadata> {
     if (typeof newData._id === 'object') {
       newData._id = `${newData._id}`;
     }
-    /* update._id = newData._id;
-    update.__v = newData.__v; */
 
     return newData;
   }
 
   /**
-   * Find the data first by any of its parameters, throws error if not found
+   * #MONGOOSE FUNCTION
+   * Find the data first by any of its parameters
+   * 
    * @param filter This uses the basic Mongoose updateOne.
    * If you can, use unique parameters for find!
    * @example 
@@ -682,23 +771,12 @@ export class DynamoNTS_DBService<T extends Dynamo_Metadata> {
    * $unset:       // Removes the specified field from a document. (set: "" to value)
    * //
    */
-  async updateOne(updateBy: any, update: any, modifier: string): Promise<T> {
+  async updateOne(updateBy: any, update: any, modifier: string): Promise<void> {
     update.__lastModified = new Date();
     update.__lastModifiedBy = modifier;
     
-    let newData: T = await this.dataModel.updateOne(updateBy, update).then(res => {
-      if (res) {
-        return res.toObject() as T;
-      } else {
-        throw new Dynamo_Error({ 
-          status: 204, 
-          errorCode: 'NTS-DBS-FU1',
-          addECToUserMsg: true,
-          message: `update ${this.dataParams.dbName} result not found! (NTS DB)`,
-          userMessage: this.defaultErrorUserMsg
-        });
-      }
-    }).catch(error => {
+    await this.dataModel.updateOne(updateBy, update)
+    .catch(error => {
       throw new Dynamo_Error({
         status: 417, 
         errorCode: 'NTS-DBS-UO0',
@@ -708,19 +786,12 @@ export class DynamoNTS_DBService<T extends Dynamo_Metadata> {
         error 
       });
     });
-
-    if (typeof newData._id === 'object') {
-      newData._id = `${newData._id}`;
-    }
-    /* update._id = newData._id;
-    update.__v = newData.__v; */
-    console.log(`Dynamo function result under testing: ${newData}`);
-
-    return newData;
   }
 
   /**
+   * #MONGOOSE FUNCTION
    * update one parameter by a specific
+   * 
    * @param filter This uses the basic Mongoose updateMany.
    * @example 
    * // by email: 
@@ -768,12 +839,11 @@ export class DynamoNTS_DBService<T extends Dynamo_Metadata> {
    * $unset:       // Removes the specified field from a document. (set: "" to value)
    * //
    */
-  async updateMany(updateBy: any, update: any, modifier: string): Promise<T[]> {
+  async updateMany(updateBy: any, update: any, modifier: string): Promise<void> {
     update.__lastModified = new Date();
     update.__lastModifiedBy = modifier;
 
-    let dataList: T[] = await this.dataModel.updateMany(updateBy, update)
-    .then(res => res ?? [])
+    await this.dataModel.updateMany(updateBy, update)
     .catch(error => {
       throw new Dynamo_Error({ 
         status: 417, 
@@ -784,18 +854,6 @@ export class DynamoNTS_DBService<T extends Dynamo_Metadata> {
         error 
       });
     });
-
-    if (0 < dataList.length) {
-      dataList.forEach((data: T) => {
-        if (data && typeof data._id === 'object') {
-          data._id = `${data._id}`;
-        }
-      });
-    }
-    
-    console.log(`Dynamo function result under testing: ${dataList}`);
-
-    return dataList;
   }
 
   // ----------------------------------------------------------------------------------