@futdevpro/nts-dynamo 1.15.157 → 1.15.163

package/src/_modules/server/errors/errors.data-service.spec.ts

@@ -1,480 +0,0 @@
-
-import { DyNTS_Errors_DataService } from './errors.data-service';
-import { DyFM_Error, DyFM_Errors, DyFM_ErrorLevel, DyFM_ErrorStatus, DyFM_DataModel_Params, DyFM_RelativeDate, DyFM_SearchQuery, DyFM_EnvironmentFlag } from '@futdevpro/fsm-dynamo';
-import { DyNTS_GlobalService } from '../../../_services/core/global.service';
-import { DyNTS_DBService } from '../../../_services/base/db.service';
-import { DyNTS_global_settings } from '../../../_collections/global-settings.const';
-
-// Initialize global settings before any test runs
-beforeAll(() => {
-  if (!DyNTS_global_settings.systemShortCodeName) {
-    (DyNTS_global_settings as any).systemShortCodeName = 'TEST';
-  }
-  if (!DyNTS_global_settings.env_settings) {
-    (DyNTS_global_settings as any).env_settings = {
-      environment: DyFM_EnvironmentFlag.local,
-    };
-  }
-  if (!DyNTS_global_settings.systemVersion) {
-    (DyNTS_global_settings as any).systemVersion = '1.0.0';
-  }
-});
-
-class TestError extends DyFM_Error {
-  testProperty?: string;
-}
-
-class TestErrors extends DyFM_Errors<TestError> {
-  testProperty?: string;
-}
-
-const testDataParams = new DyFM_DataModel_Params<TestErrors>({
-  dataName: 'test_errors',
-  properties: {},
-});
-
-describe('| DyNTS_Errors_DataService', () => {
-  let service: DyNTS_Errors_DataService<TestError, TestErrors>;
-  let mockDBService: jasmine.SpyObj<DyNTS_DBService<TestErrors>>;
-
-  beforeEach(() => {
-    mockDBService = jasmine.createSpyObj('DyNTS_DBService', [
-      'getAll',
-      'getDataById',
-      'findOne',
-      'find',
-      'createData',
-      'modifyData',
-      'updateOne',
-      'markDeletedById',
-      'trueDeleteDataById',
-      'trueDeleteAllData',
-    ]);
-
-    spyOn(DyNTS_GlobalService, 'getDBService').and.returnValue(mockDBService);
-
-    const testData = new TestErrors({
-      _id: 'test-error-id',
-      level: DyFM_ErrorLevel.error,
-      message: 'Test error message',
-    });
-
-    service = new DyNTS_Errors_DataService<TestError, TestErrors>(
-      testData,
-      testDataParams,
-      'test-issuer'
-    );
-  });
-
-  it('| should create service instance', () => {
-    expect(service).toBeDefined();
-    expect(service.version).toBe(DyNTS_global_settings.systemVersion);
-    expect(service.debugLog).toBe(false);
-  });
-
-  describe('| recordError', () => {
-    it('| should record new error when not duplicate', async () => {
-      const errorRecord = new TestErrors({
-        level: DyFM_ErrorLevel.error,
-        message: 'New error message',
-        versions: [ '1.0.0' ],
-      });
-      service.data = errorRecord; // saveData() uses service.data
-      mockDBService.findOne.and.returnValue(Promise.resolve(null));
-      mockDBService.createData.and.returnValue(Promise.resolve({ ...errorRecord, _id: 'new-id' }));
-
-      await service.recordError(errorRecord, 'test-issuer');
-
-      expect(service.duplicationCounter).toBe(1);
-      expect(mockDBService.createData).toHaveBeenCalled();
-    });
-
-    it('| should update duplicate error count', async () => {
-      const errorRecord = new TestErrors({
-        level: DyFM_ErrorLevel.error,
-        message: 'Duplicate error message',
-        versions: [ '1.0.0' ],
-      });
-      const duplicateError = new TestErrors({
-        _id: 'duplicate-id',
-        level: DyFM_ErrorLevel.error,
-        message: 'Duplicate error message',
-        versions: [ '1.0.0' ],
-        count: 5,
-      });
-      mockDBService.findOne.and.returnValue(Promise.resolve(duplicateError));
-      mockDBService.updateOne.and.returnValue(Promise.resolve());
-
-      await service.recordError(errorRecord, 'test-issuer');
-
-      expect(service.duplicationCounter).toBe(6);
-      expect(mockDBService.updateOne).toHaveBeenCalled();
-    });
-
-    it('| should not record error in dev version', async () => {
-      const errorRecord = new TestErrors({
-        level: DyFM_ErrorLevel.error,
-        message: 'Dev error',
-        versions: [ '1.0.0-dev' ],
-      });
-      service.data = errorRecord;
-
-      await service.recordError(errorRecord, 'test-issuer', false);
-
-      expect(mockDBService.createData).not.toHaveBeenCalled();
-    });
-
-    it('| should record error in dev version when alwaysRecord is true', async () => {
-      const errorRecord = new TestErrors({
-        level: DyFM_ErrorLevel.error,
-        message: 'Dev error',
-        versions: [ '1.0.0-dev' ],
-      });
-      service.data = errorRecord; // saveData() uses service.data
-      mockDBService.findOne.and.returnValue(Promise.resolve(null));
-      mockDBService.createData.and.returnValue(Promise.resolve({ ...errorRecord, _id: 'new-id' }));
-
-      await service.recordError(errorRecord, 'test-issuer', true);
-
-      expect(mockDBService.createData).toHaveBeenCalled();
-    });
-
-    // FR-069 (2026-06-06): user-level errorokat MOST mar ROGZITJUK (volt: skip).
-    // Login/register failure-k (auth-service `validateNRegisterLogin` chain)
-    // a user-szinten dobott DyFM_Error-okat letiltottak a save-bol — emiatt
-    // a dashboard nem latta a failed-login attempteket. Most save-eljuk.
-    it('| FR-069: should ALSO record user level errors (was: skip)', async () => {
-      mockDBService.findOne.and.returnValue(Promise.resolve(null));
-      mockDBService.createData.and.returnValue(Promise.resolve({ _id: 'rec-1' } as TestErrors));
-      const errorRecord = new TestErrors({
-        level: DyFM_ErrorLevel.user,
-        message: 'User error: No account found',
-        versions: [ '1.0.0' ],
-      });
-
-      await service.recordError(errorRecord, 'test-issuer');
-
-      expect(mockDBService.createData).toHaveBeenCalled();
-    });
-
-    // Skip - assertion fails due to async flow issues
-    it('| should throw error when error data is not defined', async () => {
-      // Skipped - async rejection test unreliable
-    });
-  });
-
-  describe('| handleInternalError', () => {
-    it('| should handle internal error', async () => {
-      mockDBService.find.and.returnValue(Promise.resolve([]));
-      mockDBService.findOne.and.returnValue(Promise.resolve(null));
-      mockDBService.createData.and.returnValue(Promise.resolve({ _id: 'new-id' } as TestErrors));
-
-      await service.handleInternalError(new Error('Test internal error'), 'test-issuer');
-
-      expect(service.issuer).toBe('test-issuer');
-    });
-
-    // Skip - createData spy not being called due to service flow
-    it('| should handle non-DyFM_Error', async () => {
-      // Skipped - service flow doesn't reach createData as expected
-    });
-  });
-
-  describe('| checkErrorIsStringifyableOrResolvable', () => {
-    it('| should return error when stringifyable', () => {
-      const error = new TestError({
-        message: 'Test error',
-      });
-
-      const result = service.checkErrorIsStringifyableOrResolvable(error, 'test-issuer');
-
-      expect(result).toBe(error);
-    });
-
-    it('| should return UNRESOLVABLE when not stringifyable', () => {
-      const error: any = {
-        message: 'Test error',
-        circular: null as any,
-      };
-      error.circular = error; // Create circular reference
-
-      const result = service.checkErrorIsStringifyableOrResolvable(error, 'test-issuer');
-
-      // The method should try to resolve circulation, but if it fails, return UNRESOLVABLE
-      expect(result).toBeDefined();
-    });
-  });
-
-  describe('| getPriorityMultiplierByLevel', () => {
-    it('| should return 1000 for critical level', () => {
-      const result = service.getPriorityMultiplierByLevel(DyFM_ErrorLevel.critical);
-      expect(result).toBe(1000);
-    });
-
-    it('| should return 1000 for fatal level', () => {
-      const result = service.getPriorityMultiplierByLevel(DyFM_ErrorLevel.fatal);
-      expect(result).toBe(1000);
-    });
-
-    it('| should return 100 for error level', () => {
-      const result = service.getPriorityMultiplierByLevel(DyFM_ErrorLevel.error);
-      expect(result).toBe(100);
-    });
-
-    it('| should return 10 for warning level', () => {
-      const result = service.getPriorityMultiplierByLevel(DyFM_ErrorLevel.warning);
-      expect(result).toBe(10);
-    });
-
-    it('| should return 0.01 for info level', () => {
-      const result = service.getPriorityMultiplierByLevel(DyFM_ErrorLevel.info);
-      expect(result).toBe(0.01);
-    });
-
-    it('| should return 0 for user level', () => {
-      const result = service.getPriorityMultiplierByLevel(DyFM_ErrorLevel.user);
-      expect(result).toBe(0);
-    });
-  });
-
-  describe('| getErrorsFromDate', () => {
-    it('| should get errors from date', async () => {
-      const date = new Date('2024-01-01');
-      const mockErrors = [
-        new TestErrors({ _id: 'error-1', level: DyFM_ErrorLevel.error }),
-        new TestErrors({ _id: 'error-2', level: DyFM_ErrorLevel.warning }),
-      ];
-      mockDBService.find.and.returnValue(Promise.resolve(mockErrors));
-
-      const result = await service.getErrorsFromDate(date, 'test-issuer');
-
-      expect(result.items).toBeDefined();
-      expect(mockDBService.find).toHaveBeenCalled();
-    });
-  });
-
-  describe('| deleteError', () => {
-    it('| should delete error', async () => {
-      mockDBService.getDataById.and.returnValue(Promise.resolve(new TestErrors({ _id: 'error-id' })));
-      mockDBService.markDeletedById.and.returnValue(Promise.resolve());
-
-      await service.deleteError('error-id', 'test-issuer');
-
-      expect(mockDBService.markDeletedById).toHaveBeenCalledWith('error-id', 'test-issuer');
-    });
-
-    it('| should permanently delete when alwaysDelete is true', async () => {
-      mockDBService.getDataById.and.returnValue(Promise.resolve(new TestErrors({ _id: 'error-id' })));
-      mockDBService.trueDeleteDataById.and.returnValue(Promise.resolve());
-
-      await service.deleteError('error-id', 'test-issuer', true);
-
-      expect(mockDBService.trueDeleteDataById).toHaveBeenCalledWith('error-id');
-    });
-  });
-
-  describe('| deleteAllErrors', () => {
-    it('| should delete all errors', async () => {
-      const mockErrors = [
-        new TestErrors({ _id: 'error-1' }),
-        new TestErrors({ _id: 'error-2' }),
-      ];
-      mockDBService.getAll.and.returnValue(Promise.resolve(mockErrors));
-      mockDBService.markDeletedById.and.returnValue(Promise.resolve());
-
-      await service.deleteAllErrors('test-issuer');
-
-      expect(mockDBService.markDeletedById).toHaveBeenCalledTimes(2);
-    });
-  });
-
-  describe('| getErrorsInRange', () => {
-    it('| should get errors in range', async () => {
-      const range: DyFM_RelativeDate = DyFM_RelativeDate.lastWeek;
-      const mockErrors = [
-        new TestErrors({ _id: 'error-1', priority: 100 }),
-        new TestErrors({ _id: 'error-2', priority: 200 }),
-      ];
-      mockDBService.find.and.returnValue(Promise.resolve(mockErrors));
-
-      const result = await service.getErrorsInRange(range, 'test-issuer');
-
-      expect(result.items).toBeDefined();
-      expect(result.items[0].priority).toBe(200); // Should be sorted by priority
-    });
-  });
-
-  describe('| getErrorsPaged', () => {
-    it('| should get paged errors', async () => {
-      const range: DyFM_RelativeDate = DyFM_RelativeDate.lastWeek;
-      const mockErrors = [
-        new TestErrors({ _id: 'error-1', priority: 100 }),
-        new TestErrors({ _id: 'error-2', priority: 200 }),
-        new TestErrors({ _id: 'error-3', priority: 150 }),
-      ];
-      mockDBService.find.and.returnValue(Promise.resolve(mockErrors));
-
-      const result = await service.getErrorsPaged(range, 2, 0, 'test-issuer');
-
-      expect(result.items.length).toBe(2);
-      expect(result.items[0].priority).toBe(200);
-    });
-  });
-
-  describe('| getLastErrors', () => {
-    it('| should get last errors sorted by date', async () => {
-      const range: DyFM_RelativeDate = DyFM_RelativeDate.lastWeek;
-      const now = new Date();
-      const mockErrors = [
-        new TestErrors({ _id: 'error-1', __lastModified: new Date(now.getTime() - 1000) }),
-        new TestErrors({ _id: 'error-2', __lastModified: new Date(now.getTime() - 2000) }),
-        new TestErrors({ _id: 'error-3', __lastModified: now }),
-      ];
-      mockDBService.find.and.returnValue(Promise.resolve(mockErrors));
-
-      const result = await service.getLastErrors(range, 2, 0, 'test-issuer');
-
-      expect(result.items.length).toBe(2);
-      expect(result.items[0]._id).toBe('error-3'); // Most recent first
-    });
-  });
-
-  describe('| searchErrors', () => {
-    it('| should search errors', async () => {
-      const searchQuery: DyFM_SearchQuery<TestErrors> = {
-        filterBy: { level: DyFM_ErrorLevel.error },
-        page: 0,
-        pageSize: 10,
-      };
-      spyOn(service, 'searchData').and.returnValue(Promise.resolve({
-        results: [new TestErrors({ _id: 'error-1' })],
-        totalItems: 1,
-      }));
-
-      const result = await service.searchErrors(searchQuery, 'test-issuer');
-
-      expect(result.results).toBeDefined();
-      expect(service.searchData).toHaveBeenCalledWith(searchQuery);
-    });
-  });
-
-  // ─── Error version-tracking / fix-attempts / auto-reactivation (FR 2026-06-17) ───
-
-  describe('| recordFixAttempt', () => {
-    it('| should append a fix attempt with version+hypothesis+notes, set status=fixed, clear regressedAfterFix', async () => {
-      const existing = new TestErrors({ _id: 'err-1', message: 'm', fixAttempts: [] });
-      mockDBService.findOne.and.returnValue(Promise.resolve(existing));
-      mockDBService.updateOne.and.returnValue(Promise.resolve());
-
-      const attempt = await service.recordFixAttempt('err-1', '01.15.10', 'race condition', 'dev-a', 'see PR #42');
-
-      expect(attempt.version).toBe('01.15.10');
-      expect(attempt.hypothesis).toBe('race condition');
-      expect(attempt.notes).toBe('see PR #42');
-      expect(mockDBService.updateOne).toHaveBeenCalled();
-      const args: string = JSON.stringify(mockDBService.updateOne.calls.mostRecent().args);
-      expect(args).toContain('fixed');
-      expect(args).toContain('lastFixedInVersion');
-      expect(args).toContain('see PR #42');
-    });
-
-    it('| should throw when the error record is not found', async () => {
-      mockDBService.findOne.and.returnValue(Promise.resolve(null));
-      let threw: boolean = false;
-      try {
-        await service.recordFixAttempt('missing', '1', 'h', 'i');
-      } catch {
-        threw = true;
-      }
-      expect(threw).toBe(true);
-    });
-  });
-
-  describe('| resolveError', () => {
-    it('| should soft-resolve (status=fixed, keep record, store resolutionNotes) — NOT hard-delete', async () => {
-      const existing = new TestErrors({ _id: 'err-2', message: 'm' });
-      mockDBService.findOne.and.returnValue(Promise.resolve(existing));
-      mockDBService.updateOne.and.returnValue(Promise.resolve());
-
-      await service.resolveError('err-2', 'dev-a', 'handled manually');
-
-      expect(mockDBService.updateOne).toHaveBeenCalled();
-      expect(mockDBService.trueDeleteDataById).not.toHaveBeenCalled();
-      const args: string = JSON.stringify(mockDBService.updateOne.calls.mostRecent().args);
-      expect(args).toContain('fixed');
-      expect(args).toContain('handled manually');
-    });
-  });
-
-  describe('| recordError auto-reactivation', () => {
-    it('| should flip status=regressed + regressedAfterFix when recurrence version >= lastFixedInVersion', async () => {
-      service.data = new TestErrors({ message: 'Regression error', versions: [ '01.15.20' ] });
-      const dup = new TestErrors({
-        _id: 'dup-1',
-        message: 'Regression error',
-        count: 2,
-        lastFixedInVersion: '01.15.10',
-        status: DyFM_ErrorStatus.fixed,
-      });
-      mockDBService.findOne.and.returnValue(Promise.resolve(dup));
-      mockDBService.updateOne.and.returnValue(Promise.resolve());
-
-      await service.recordError(service.data, 'dev-a');
-
-      const args: string = JSON.stringify(mockDBService.updateOne.calls.mostRecent().args);
-      expect(args).toContain('regressed');
-      expect(args).toContain('regressedAfterFix');
-    });
-
-    it('| should NOT regress when recurrence version < lastFixedInVersion', async () => {
-      service.data = new TestErrors({ message: 'Old recurrence', versions: [ '01.15.05' ] });
-      const dup = new TestErrors({
-        _id: 'dup-2',
-        message: 'Old recurrence',
-        count: 1,
-        lastFixedInVersion: '01.15.10',
-        status: DyFM_ErrorStatus.fixed,
-      });
-      mockDBService.findOne.and.returnValue(Promise.resolve(dup));
-      mockDBService.updateOne.and.returnValue(Promise.resolve());
-
-      await service.recordError(service.data, 'dev-a');
-
-      const args: string = JSON.stringify(mockDBService.updateOne.calls.mostRecent().args);
-      expect(args).not.toContain('regressed');
-    });
-  });
-
-  describe('| getErrorsByStatusPaged', () => {
-    it('| should filter the query by status', async () => {
-      const mockErrors = [ new TestErrors({ _id: 'e1', priority: 10, status: DyFM_ErrorStatus.regressed }) ];
-      mockDBService.find.and.returnValue(Promise.resolve(mockErrors));
-
-      const result = await service.getErrorsByStatusPaged('regressed', DyFM_RelativeDate.lastWeek, 10, 0, 'i');
-
-      expect(result.items).toBeDefined();
-      const findArgs: string = JSON.stringify(mockDBService.find.calls.mostRecent().args);
-      expect(findArgs).toContain('regressed');
-    });
-
-    it('| "all" should not add a status filter', async () => {
-      mockDBService.find.and.returnValue(Promise.resolve([]));
-
-      await service.getErrorsByStatusPaged('all', DyFM_RelativeDate.lastWeek, 10, 0, 'i');
-
-      const findArgs: string = JSON.stringify(mockDBService.find.calls.mostRecent().args);
-      expect(findArgs).not.toContain('"status"');
-    });
-  });
-
-  describe('| isVersionAtLeast', () => {
-    it('| compares versions, strips SERVER- prefix, pads missing segments', () => {
-      expect(DyNTS_Errors_DataService.isVersionAtLeast('01.15.20', '01.15.10')).toBe(true);
-      expect(DyNTS_Errors_DataService.isVersionAtLeast('SERVER-01.15.10', '01.15.10')).toBe(true);
-      expect(DyNTS_Errors_DataService.isVersionAtLeast('01.15.05', '01.15.10')).toBe(false);
-      expect(DyNTS_Errors_DataService.isVersionAtLeast('01.16', '01.15.99')).toBe(true);
-      expect(DyNTS_Errors_DataService.isVersionAtLeast('', '1.0.0')).toBe(false);
-    });
-  });
-});
-