@futdevpro/nts-dynamo 1.14.43 → 1.14.45

package/src/_modules/discord-bot/_collections/dibo-operations.util.ts

@@ -88,7 +88,7 @@ export class DyNTS_DiBo_Operations_Util {
   ): Promise<Collection<string, GuildMember>> {
     const channel = this.findChannelByName(guild.channels, channelName)
         
-    const members = await guild?.members.fetch()
+    const members = await this.fetchMembersInGuild(guild)
 
     const allowedMembers = members?.filter((member) =>
       channel.permissionsFor(member)?.has('ViewChannel')
@@ -97,6 +97,29 @@ export class DyNTS_DiBo_Operations_Util {
     return allowedMembers
   }
 
+  static async fetchMembersInGuild(guild: Guild): Promise<Collection<string, GuildMember>> {
+    // First try to use the cache, because the fetch() can timeout for large guilds
+    let members: Collection<string, GuildMember> = guild?.members.cache
+
+    // If the cache is empty or does not contain all the necessary members, try to fetch them
+    if (!members || members.size === 0) {
+      try {
+        // Try to fetch with a limit to avoid timeout
+        members = await guild?.members.fetch({ limit: 1000 })
+      } catch (fetchError: any) {
+        // If the fetch times out, use the cache (even if it is empty)
+        DyFM_Log.warn(
+          'Failed to fetch members, using cache instead', 
+          fetchError?.message || fetchError
+        )
+        
+        members = guild?.members.cache || new Collection<string, GuildMember>()
+      }
+    }
+
+    return members;
+  }
+
   static async readMemberNamesInChannel(guild: Guild, channelName: string): Promise<string[]> {
     const members = await this.readMembersInChannel(guild, channelName)
 

package/src/_services/base/data.service.ts

@@ -1242,11 +1242,35 @@ export class DyNTS_DataService<T extends DyFM_Metadata> {
         });
       }
 
+      const errors: DyFM_Error[] = [];
+
       Object.values(properties).forEach(
         (propertyParams: DyFM_DataProperty_Params<any, T>) => {
-          this.validateProperty(data, data[propertyParams.key], propertyParams, isSubObjectOf);
+          try {
+            this.validateProperty(data, data[propertyParams.key], propertyParams, isSubObjectOf);
+          } catch (error) {
+            errors.push(error);
+          }
         }
       );
+
+      if (errors.length > 0) {
+        if (errors.length === 1) {
+          throw errors[0];
+        } else {
+          throw new DyFM_Error({
+            ...this._getDefaultErrorSettings(
+              'validateByPropertyParams', 
+              new Error(
+                'Validation failed! (multiple validation errors)' + 
+                errors.map((error: DyFM_Error) => `\n  ${DyFM_Error.getAnyMessage(error)}`).join('')
+              )
+            ),
+            errorCode: `${DyNTS_global_settings.systemShortCodeName}|DyNTS-DS0-VDP3`,
+            errors: errors,
+          });
+        }
+      }
     } catch (error) {
       if (error?.errorCode?.includes?.('DyNTS-DS0-VDP')) {
         throw error;
@@ -1390,6 +1414,7 @@ export class DyNTS_DataService<T extends DyFM_Metadata> {
               'validateProperty',
               new Error(
                 `validateProperty failed, "${this.getPropertyKey(propertyParams, isSubObjectOf)}" is not a valid string! ` +
+                `(type: ${typeof propertyValue}, value: "${propertyValue}") ` +
                 `(${this.dataParams.dataName})` +
                 ((data as any)?.name ? `\n  The failed data's name: ${(data as any).name}` : '')
               )
@@ -1413,6 +1438,7 @@ export class DyNTS_DataService<T extends DyFM_Metadata> {
               'validateProperty',
               new Error(
                 `validateProperty failed, "${this.getPropertyKey(propertyParams, isSubObjectOf)}" is not a valid boolean! ` +
+                `(type: ${typeof propertyValue}, value: "${propertyValue}") ` +
                 `(${this.dataParams.dataName})` +
                 ((data as any)?.name ? `\n  The failed data's name: ${(data as any).name}` : '')
               )
@@ -1433,6 +1459,7 @@ export class DyNTS_DataService<T extends DyFM_Metadata> {
               'validateProperty',
               new Error(
                 `validateProperty failed, "${this.getPropertyKey(propertyParams, isSubObjectOf)}" is not a valid object! ` +
+                `(type: ${typeof propertyValue}, value: "${propertyValue}") ` +
                 `(${this.dataParams.dataName})` +
                 (data as any)?.name ? `\n  That failed data's name: ${(data as any).name}` : ''
               )
@@ -1457,6 +1484,7 @@ export class DyNTS_DataService<T extends DyFM_Metadata> {
               'validateProperty',
               new Error(
                 `validateProperty failed, "${this.getPropertyKey(propertyParams, isSubObjectOf)}" is not a valid array! ` +
+                `(type: ${typeof propertyValue}, value: "${propertyValue}") ` +
                 `(${this.dataParams.dataName})` +
                 ((data as any)?.name ? `\n  The failed data's name: ${(data as any).name}` : '')
               )
@@ -1507,6 +1535,7 @@ export class DyNTS_DataService<T extends DyFM_Metadata> {
             new Error(
               `validateProperty failed, "${this.getPropertyKey(propertyParams, isSubObjectOf)}" is not a valid property type! ` +
               `(type: ${propertyParams.type}, nonBasicType: ${propertyParams.nonBasicType}) ` +
+              `(value type: ${typeof propertyValue}, value: "${propertyValue}") ` +
               `(${this.dataParams.dataName})` +
               ((data as any)?.name ? `\n  The failed data's name: ${(data as any).name}` : '')
             )