@futdevpro/nts-dynamo 1.11.25 → 1.11.27

package/src/_modules/open-ai/_services/oai-llm.service-base.ts

@@ -1,7 +1,7 @@
 import { OpenAI } from 'openai';
 
 import { DyFM_OpenAI_Settings, DyFM_OpenAIModel, DyFM_GPTCall_Settings } from '@futdevpro/fsm-dynamo/open-ai';
-import { DyFM_AnyError, DyFM_Error, DyFM_Error_Settings, DyFM_Log, DyFM_notNull } from '@futdevpro/fsm-dynamo';
+import { DyFM_AnyError, DyFM_Error, DyFM_Error_Settings, DyFM_Log, DyFM_notNull, DyFM_Shared } from '@futdevpro/fsm-dynamo';
 
 import { DyNTS_global_settings } from '../../../_collections/global-settings.const';
 import { DyNTS_OAI_GPT_Message } from '../_models/interfaces/oai-gpt-message.interface';
@@ -193,7 +193,7 @@ export class DyNTS_OAI_LLM_ServiceBase {
 
     const answer = await this.askQuestion(set);
 
-    return DyFM_safeParseJSON<T>(answer);
+    return DyFM_Shared.safeParseJSON<T>(answer);
   }
   /** the exact same as {@link requestSelect} */
   selectRequest = this.requestSelect;
@@ -263,7 +263,7 @@ export class DyNTS_OAI_LLM_ServiceBase {
     
     const answer = await this.askQuestion(set);
 
-    return DyFM_safeParseList<T[]>(answer);
+    return DyFM_Shared.safeParseList<T[]>(answer);
   }
   /** the exact same as {@link requestMultipleSelect} */
   multipleSelectRequest = this.requestMultipleSelect;
@@ -291,7 +291,7 @@ export class DyNTS_OAI_LLM_ServiceBase {
 
     const answer = await this.askQuestion(set);
     
-    return DyFM_safeParseJSON<T>(answer);
+    return DyFM_Shared.safeParseJSON<T>(answer);
   }
   /** the exact same as {@link askJSONQuestion} */
   jsonQuestion = this.askJSONQuestion;
@@ -324,7 +324,7 @@ export class DyNTS_OAI_LLM_ServiceBase {
 
     const answer = await this.askQuestion(set);
 
-    return DyFM_safeParseJSON<T>(answer);
+    return DyFM_Shared.safeParseJSON<T>(answer);
   }
   /** the exact same as {@link askJSONQuestionWithKeysDescription} */
   jsonQuestionWithKeysDescription = this.askJSONQuestionWithKeysDescription;
@@ -357,7 +357,7 @@ export class DyNTS_OAI_LLM_ServiceBase {
 
     const answer = await this.askQuestion(set);
 
-    return DyFM_safeParseJSON<T>(answer);
+    return DyFM_Shared.safeParseJSON<T>(answer);
   }
   /** the exact same as {@link askJSONQuestionWithExactKeys} */
   jsonQuestionWithExactKeys = this.askJSONQuestionWithExactKeys;
@@ -385,7 +385,7 @@ export class DyNTS_OAI_LLM_ServiceBase {
 
     const answer = await this.askQuestion(set);
 
-    return DyFM_safeParseList(answer);
+    return DyFM_Shared.safeParseList<string[]>(answer);
   }
   /** the exact same as {@link askListQuestion} */
   listQuestion = this.askListQuestion;
@@ -597,6 +597,30 @@ export class DyNTS_OAI_LLM_ServiceBase {
       content: settings?.systemPrompt || this.defaultSystemPrompt,
     };
   }
+
+  protected validateConversation(conversation: DyNTS_OAI_GPT_Message[]): void {
+    conversation.forEach((message: DyNTS_OAI_GPT_Message, index: number) => {
+      if (!message.role) {
+        throw new DyFM_Error({
+          message: `Message has no role at index ${index}`,
+          additionalContent: {
+            invalidMessage: message,
+            conversation: conversation,
+          }
+        });
+      }
+
+      if (!message.content) {
+        throw new DyFM_Error({
+          message: `Message has no content at index ${index}`,
+          additionalContent: {
+            invalidMessage: message,
+            conversation: conversation,
+          }
+        });
+      }
+    });
+  }
   
   protected getDefaultErrorSettings(
     fnName: string, 
@@ -618,92 +642,3 @@ export class DyNTS_OAI_LLM_ServiceBase {
 
   //#endregion
 }
-
-/**
- * parses the JSON list, if it fails, it returns the answer as a single item in an array
- * 
- * (uses {@link DyFM_safeParseJSON})
- * @deprecated use {@link DyFM_Shared.safeParseList} instead
- */
-export function DyFM_safeParseList<T extends Array<any>>(
-  textedJSON: string, 
-  disableErrorLog?: boolean
-): T {
-  const parsed = DyFM_safeParseJSON<T>(textedJSON, true);
-
-  if (Array.isArray(parsed)) {
-    return parsed;
-  } else if (typeof parsed === 'object') {
-    if (!disableErrorLog) {
-      DyFM_Log.warn(
-        'DyFM_safeParseList result is an object, returning its values', 
-        {
-          parsed: parsed,
-        }
-      );
-    }
-
-    return Object.values(parsed) as T;
-  } else {
-
-    if (!disableErrorLog) {
-      DyFM_Log.warn(
-        'DyFM_safeParseList result is not an array or object, returning it as a single item', 
-        {
-          parsed: parsed,
-        }
-      );
-    }
-
-    return [ parsed ] as string[] as T;
-  }
-}
-
-/**
- * parses the JSON, if it fails, it returns { unparsableResult: textedJSON }
- * 
- * (uses {@link DyFM_failableSafeParseJSON})
- * @deprecated use {@link DyFM_Shared.safeParseJSON} instead
- */
-export function DyFM_safeParseJSON<T = any>(
-  textedJSON: string,
-  disableErrorLog?: boolean
-): T | { unparsableResult: string } {
-  try {
-    return DyFM_failableSafeParseJSON(textedJSON);
-  } catch (error) {
-    if (!disableErrorLog) {
-      DyFM_Log.error(
-        'Unable to parse JSON answer:', 
-        {
-          unparsedJSON: textedJSON,
-          error: error,
-        }
-      );
-    }
-
-    return { unparsableResult: textedJSON };
-  }
-}
-
-/**
- * parses the JSON, if it fails, it throws an error
- * (also will extract the JSON from "```json ... ```" wrapper)
- * @deprecated use {@link DyFM_Shared.failableSafeParseJSON} instead
- */
-export function DyFM_failableSafeParseJSON<T = any>(textedJSON: string): T {
-  if (!textedJSON) {
-    throw new Error(`No content provided to JSON parse ("${textedJSON}")`);
-  }
-
-  const match = textedJSON.match(/```json(.*)```/s);
-  textedJSON = textedJSON.replaceAll('\n', '');
-
-  if (match) {
-    return JSON.parse(match[1].replaceAll('\n', ''));
-  } else {
-    return JSON.parse(
-      textedJSON.replaceAll('```json', '').replaceAll('```', '')
-    );
-  }
-}

package/src/_modules/socket/_services/socket-server.service.ts

@@ -498,12 +498,21 @@ export abstract class DyNTS_SocketServerService<
         }
       });
         
-      newSocketServer.listen(this.params.port);
-      
-      DyFM_Log.success(
-        `\nsocket server setup finished: "${this.params.name}"` + 
-        `\nsocket server listening on port: "${this.params.port}"`
-      );
+      try {
+        newSocketServer.listen(this.params.port);
+        
+        DyFM_Log.success(
+          `\nsocket server setup finished: "${this.params.name}"` + 
+          `\nsocket server listening on port: "${this.params.port}"`
+        );
+      } catch (listenError) {
+        const errorMessage = `Failed to bind socket server "${this.params.name}" to port ${this.params.port}. ` +
+          `This could be due to port already in use or insufficient permissions. ` +
+          `Please ensure the port is available and try again.`;
+        
+        DyFM_Log.error(errorMessage, listenError);
+        throw new Error(errorMessage);
+      }
 
       successCallback();
       

package/src/_modules/socket/app-extended.server.spec.ts

@@ -9,17 +9,42 @@ describe('| DyNTS_AppExtended;', (): void => {
   process.setMaxListeners(20);
   let app: DyNTS_AppExtended;
 
+  // Helper function to safely stop and cleanup app
+  const safeStopApp = async (): Promise<void> => {
+    if (app) {
+      try {
+        await app.stop();
+      } catch (error) {
+        DyFM_Log.testWarn('Error stopping app:', error);
+      }
+      app = null;
+    }
+  };
+
+  // Helper function to wait for app to be ready with timeout
+  const waitForAppReady = async (appInstance: DyNTS_AppExtended, timeoutMs: number = 10000): Promise<void> => {
+    const startTime = Date.now();
+    while (!appInstance.started && (Date.now() - startTime) < timeoutMs) {
+      await DyFM_delay(100);
+    }
+    
+    if (!appInstance.started) {
+      throw new Error(`App failed to start within ${timeoutMs}ms`);
+    }
+  };
+
   describe('| a extended-base instance;', (): void => {
     beforeEach(async (): Promise<void> => {
       try {
         await DyFM_waitUntil((): boolean => !app, second);
+        await DyFM_delay(100); // Ensure previous instance is fully cleaned up
 
         app = new DyNTS_AppExtendedBase_Mock();
-
         await DyFM_delay(100);
         
         await app.ready();
-
+        await waitForAppReady(app);
+        
         await DyFM_delay(100);
       } catch (error) {
         DyFM_Log.testError(
@@ -35,16 +60,15 @@ describe('| DyNTS_AppExtended;', (): void => {
           (new Error()).stack,
           (error as DyFM_Error)?.additionalContent?.errors?.reverse()?.unshift()?.stack
         );
+        throw error; // Re-throw to fail the test
       }
     });
 
     afterEach(async (): Promise<void> => {
       try {
         await DyFM_delay(100);
-        
-        await app.stop();
-
-        app = null;
+        await safeStopApp();
+        await DyFM_delay(100);
       } catch (error) {
         DyFM_Log.testError(
           '| DyNTS_AppExtended; | a extended-base instance; test afterEach error:\n', 
@@ -64,10 +88,12 @@ describe('| DyNTS_AppExtended;', (): void => {
 
     it('| should be created', (): void => {
       expect(app).toBeDefined();
+      expect(app).toBeInstanceOf(DyNTS_AppExtendedBase_Mock);
     });
 
-    it('| should be started', (): void => {
+    it('| should be started', async (): Promise<void> => {
       expect(app.started).toBeTrue();
+      expect(app).toBeDefined();
     });
   });
 
@@ -75,13 +101,14 @@ describe('| DyNTS_AppExtended;', (): void => {
     beforeEach(async (): Promise<void> => {
       try {
         await DyFM_waitUntil((): boolean => !app, second);
+        await DyFM_delay(100); // Ensure previous instance is fully cleaned up
 
         app = new DyNTS_AppExtendedFull_Mock();
-
         await DyFM_delay(100);
         
         await app.ready();
-
+        await waitForAppReady(app);
+        
         await DyFM_delay(100);
       } catch (error) {
         DyFM_Log.testError(
@@ -97,16 +124,15 @@ describe('| DyNTS_AppExtended;', (): void => {
           (new Error()).stack,
           (error as DyFM_Error)?.additionalContent?.errors?.reverse()?.unshift()?.stack
         );
+        throw error; // Re-throw to fail the test
       }
     });
 
     afterEach(async (): Promise<void> => {
       try {
         await DyFM_delay(100);
-        
-        await app.stop();
-
-        app = null;
+        await safeStopApp();
+        await DyFM_delay(100);
       } catch (error) {
         DyFM_Log.testError(
           '| DyNTS_AppExtended; | a extended-full instance; test afterEach error:\n', 
@@ -126,10 +152,12 @@ describe('| DyNTS_AppExtended;', (): void => {
 
     it('| should be created', async (): Promise<void> => {
       expect(app).toBeDefined();
+      expect(app).toBeInstanceOf(DyNTS_AppExtendedFull_Mock);
     });
       
     it('| should be started', async (): Promise<void> => {
       expect(app.started).toBeTrue();
+      expect(app).toBeDefined();
     });
   });
 
@@ -137,12 +165,14 @@ describe('| DyNTS_AppExtended;', (): void => {
     beforeEach(async (): Promise<void> => {
       try {
         await DyFM_waitUntil((): boolean => !app, second);
+        await DyFM_delay(100); // Ensure previous instance is fully cleaned up
 
         app = new DyNTS_AppWbMock_Mock();
         await DyFM_delay(100);
         
         await app.ready();
-
+        await waitForAppReady(app);
+        
         await DyFM_delay(100);
       } catch (error) {
         DyFM_Log.testError(
@@ -158,15 +188,15 @@ describe('| DyNTS_AppExtended;', (): void => {
           (new Error()).stack,
           (error as DyFM_Error)?.additionalContent?.errors?.reverse()?.unshift()?.stack
         );
+        throw error; // Re-throw to fail the test
       }
     });
+
     afterEach(async (): Promise<void> => {
       try {
         await DyFM_delay(100);
-        
-        await app.stop();
-
-        app = null;
+        await safeStopApp();
+        await DyFM_delay(100);
       } catch (error) {
         DyFM_Log.testError(
           '| DyNTS_AppExtended; | a wb-mock instance; test afterEach error:\n', 
@@ -186,10 +216,12 @@ describe('| DyNTS_AppExtended;', (): void => {
 
     it('| should be created', async (): Promise<void> => {
       expect(app).toBeDefined();
+      expect(app).toBeInstanceOf(DyNTS_AppWbMock_Mock);
     });
       
     it('| should be started', async (): Promise<void> => {
       expect(app.started).toBeTrue();
+      expect(app).toBeDefined();
     });
   });
 });