@futdevpro/nts-dynamo 1.11.16 → 1.11.18

package/src/_modules/open-ai/_services/oai-llm-chat.service-base.ts

@@ -32,26 +32,21 @@ export class DyNTS_OAI_LLMChat_ServiceBase extends DyNTS_OAI_LLM_ServiceBase {
    * and the {@link DyNTS_OAI_LLM_Predefined_Requests.yesNo.upperCaseYes} to check the answer
    */
   async yesNoQuestionInConversation(
-    conversation: DyNTS_OAI_GPT_Message[],
-    question: string, 
-    issuer: string,
-    debugLog?: boolean,
-    settings?: DyFM_GPTCall_Settings,
-    /** this is used to readably replace too long contents to eg '...' in logs */
-    replaceThisInLog?: string
+    set: {
+      conversation: DyNTS_OAI_GPT_Message[],
+      question: string, 
+      issuer: string,
+      settings?: DyFM_GPTCall_Settings,
+      debugLog?: boolean,
+      /** this is used to readably replace too long contents to eg '...' in logs */
+      replaceThisInLog?: string,
+    }
   ): Promise<boolean> {
-    question += this.predefinedRequests.yesNo.request;
+    set.question += this.predefinedRequests.yesNo.request;
 
-    this.logQuestion(question, replaceThisInLog, debugLog);
+    this.logQuestion(set);
 
-    const answer = await this.getAnswerInConversation(
-      conversation, 
-      question, 
-      issuer, 
-      settings,
-      debugLog,
-      replaceThisInLog
-    );
+    const answer = await this.getQuestionAnswerInConversation(set);
 
     return answer.toUpperCase().includes(this.predefinedRequests.yesNo.upperCaseYes);
   }
@@ -63,24 +58,19 @@ export class DyNTS_OAI_LLMChat_ServiceBase extends DyNTS_OAI_LLM_ServiceBase {
    * Uses the {@link DyNTS_OAI_LLM_Predefined_Requests.simpleQuestion} to ask the question
    */
   async simpleQuestionInConversation(
-    conversation: DyNTS_OAI_GPT_Message[],
-    question: string, 
-    issuer: string,
-    settings?: DyFM_GPTCall_Settings,
-    debugLog?: boolean,
-    /** this is used to readably replace too long contents to eg '...' in logs */
-    replaceThisInLog?: string
+    set: {
+      conversation: DyNTS_OAI_GPT_Message[],
+      question: string, 
+      issuer: string,
+      settings?: DyFM_GPTCall_Settings,
+      debugLog?: boolean,
+      /** this is used to readably replace too long contents to eg '...' in logs */
+      replaceThisInLog?: string,
+    }
   ): Promise<string> {
-    this.logQuestion(question, replaceThisInLog, debugLog);
+    this.logQuestion(set);
 
-    return await this.getAnswerInConversation(
-      conversation, 
-      question, 
-      issuer, 
-      settings,
-      debugLog,
-      replaceThisInLog
-    );
+    return await this.getQuestionAnswerInConversation(set);
   }
   askSimpleQuestionInConversation = this.simpleQuestionInConversation;
 
@@ -90,30 +80,25 @@ export class DyNTS_OAI_LLMChat_ServiceBase extends DyNTS_OAI_LLM_ServiceBase {
    * Uses the {@link DyNTS_OAI_LLM_Predefined_Requests.percentageOnly} to ask the question
    */
   async percentageQuestionInConversation(
-    conversation: DyNTS_OAI_GPT_Message[],
-    question: string, 
-    issuer: string,
-    settings?: DyFM_GPTCall_Settings,
-    debugLog?: boolean,
-    /** this is used to readably replace too long contents to eg '...' in logs */
-    replaceThisInLog?: string
+    set: {
+      conversation: DyNTS_OAI_GPT_Message[],
+      question: string, 
+      issuer: string,
+      settings?: DyFM_GPTCall_Settings,
+      debugLog?: boolean,
+      /** this is used to readably replace too long contents to eg '...' in logs */
+      replaceThisInLog?: string,
+    }
   ): Promise<number> {
-    question += this.predefinedRequests.percentageOnly;
+    set.question += this.predefinedRequests.percentageOnly;
 
-    this.logQuestion(question, replaceThisInLog, debugLog);
+    this.logQuestion(set);
 
-    const answer = await this.getAnswerInConversation(
-      conversation, 
-      question, 
-      issuer, 
-      settings,
-      debugLog,
-      replaceThisInLog
-    );
+    const answer = await this.getQuestionAnswerInConversation(set);
 
     if (isNaN(+answer)) {
       DyFM_Log.error('GPT_ServiceBase', 'asykPercentageQuestion', 'Invalid answer', {
-        question,
+        question: set.question,
         answer,
       });
 
@@ -131,36 +116,31 @@ export class DyNTS_OAI_LLMChat_ServiceBase extends DyNTS_OAI_LLM_ServiceBase {
    * Uses the {@link DyNTS_OAI_LLM_Predefined_Requests.selectRequest} to ask the question
    */
   async selectQuestionInConversation(
-    conversation: DyNTS_OAI_GPT_Message[],
-    question: string, 
-    selectFrom: string[], 
-    issuer: string,
-    settings?: DyFM_GPTCall_Settings,
-    debugLog?: boolean,
-    /** this is used to readably replace too long contents to eg '...' in logs */
-    replaceThisInLog?: string
+    set: {
+      conversation: DyNTS_OAI_GPT_Message[],
+      question: string, 
+      selectFrom: string[], 
+      issuer: string,
+      settings?: DyFM_GPTCall_Settings,
+      debugLog?: boolean,
+      /** this is used to readably replace too long contents to eg '...' in logs */
+      replaceThisInLog?: string,
+    }
   ): Promise<string> {
     // replace the {{DyNTS_selectOptions}} with the list of options
     const selectQuestionAddition = this.predefinedRequests.selectRequest.replace(
       '{{DyNTS_selectOptions}}', 
-      this.getTextListAsText(selectFrom)
+      this.getTextListAsText(set.selectFrom)
     );
-    question += selectQuestionAddition;
+    set.question += selectQuestionAddition;
     
-    this.logQuestion(question, replaceThisInLog, debugLog);
+    this.logQuestion(set);
 
-    let answer = await this.getAnswerInConversation(
-      conversation, 
-      question, 
-      issuer, 
-      settings,
-      debugLog,
-      replaceThisInLog
-    );
+    let answer = await this.getQuestionAnswerInConversation(set);
     
     answer = answer.toLocaleUpperCase();
     
-    for (const item of selectFrom) {
+    for (const item of set.selectFrom) {
       if (answer.includes(item.toLocaleUpperCase())) return item;
     }
 
@@ -176,31 +156,26 @@ export class DyNTS_OAI_LLMChat_ServiceBase extends DyNTS_OAI_LLM_ServiceBase {
    * Uses the {@link DyNTS_OAI_LLM_Predefined_Requests.selectRequest} to ask the question
    */
   async requestSelectInConversation<T>(
-    conversation: DyNTS_OAI_GPT_Message[],
-    question: string,
-    selectFrom: T[],
-    issuer: string,
-    settings?: DyFM_GPTCall_Settings,
-    debugLog?: boolean,
-    /** this is used to readably replace too long contents to eg '...' in logs */
-    replaceThisInLog?: string,
+    set: {
+      conversation: DyNTS_OAI_GPT_Message[],
+      question: string,
+      selectFrom: T[],
+      issuer: string,
+      settings?: DyFM_GPTCall_Settings,
+      debugLog?: boolean,
+      /** this is used to readably replace too long contents to eg '...' in logs */
+      replaceThisInLog?: string,
+    }
   ): Promise<T | { unparsableResult: string }> {
     const selectQuestionAddition = this.predefinedRequests.selectRequest.replace(
       '{{DyNTS_selectOptions}}', 
-      this.getTextListAsText(selectFrom.map(item => `"${JSON.stringify(item)}"`))
+      this.getTextListAsText(set.selectFrom.map(item => `"${JSON.stringify(item)}"`))
     );
-    question += selectQuestionAddition;
+    set.question += selectQuestionAddition;
 
-    this.logQuestion(question, null, debugLog); 
+    this.logQuestion(set); 
 
-    const answer = await this.getAnswerInConversation(
-      conversation, 
-      question, 
-      issuer, 
-      settings,
-      debugLog,
-      replaceThisInLog
-    );
+    const answer = await this.getQuestionAnswerInConversation(set);
 
     return DyFM_safeParseJSON<T>(answer);
   }
@@ -212,35 +187,30 @@ export class DyNTS_OAI_LLMChat_ServiceBase extends DyNTS_OAI_LLM_ServiceBase {
    * Uses the {@link DyNTS_OAI_LLM_Predefined_Requests.multiselect} to ask the question
    */
   async multipleSelectQuestionWithOptionsInConversation(
-    conversation: DyNTS_OAI_GPT_Message[],
-    question: string, 
-    options: string[], 
-    issuer: string,
-    settings?: DyFM_GPTCall_Settings,
-    debugLog?: boolean,
-    /** this is used to readably replace too long contents to eg '...' in logs */
-    replaceThisInLog?: string
+    set: {
+      conversation: DyNTS_OAI_GPT_Message[],
+      question: string, 
+      options: string[], 
+      issuer: string,
+      settings?: DyFM_GPTCall_Settings,
+      debugLog?: boolean,
+      /** this is used to readably replace too long contents to eg '...' in logs */
+      replaceThisInLog?: string,
+    }
   ): Promise<string[]> {
     const selectQuestionAddition = this.predefinedRequests.multiselect.replace(
       '{{DyNTS_selectOptions}}', 
-      this.getTextListAsText(options)
+      this.getTextListAsText(set.options)
     );
-    question += selectQuestionAddition;
+    set.question += selectQuestionAddition;
 
-    let answer = await this.getAnswerInConversation(
-      conversation, 
-      question, 
-      issuer, 
-      settings,
-      debugLog,
-      replaceThisInLog
-    );
+    let answer = await this.getQuestionAnswerInConversation(set);
     
     answer = answer.toLocaleUpperCase();
     
     const result: string[] = [];
 
-    for (const item of options) {
+    for (const item of set.options) {
       if (answer.includes(item.toLocaleUpperCase())) {
         result.push(item);
       }
@@ -258,31 +228,26 @@ export class DyNTS_OAI_LLMChat_ServiceBase extends DyNTS_OAI_LLM_ServiceBase {
    * Uses the {@link DyNTS_OAI_LLM_Predefined_Requests.multiselect} to ask the question
    */
   async requestMultipleSelectInConversation<T>(
-    conversation: DyNTS_OAI_GPT_Message[],
-    question: string,
-    options: T[],
-    issuer: string,
-    settings?: DyFM_GPTCall_Settings,
-    debugLog?: boolean,
-    /** this is used to readably replace too long contents to eg '...' in logs */
-    replaceThisInLog?: string,
+    set: {
+      conversation: DyNTS_OAI_GPT_Message[],
+      question: string,
+      options: T[],
+      issuer: string,
+      settings?: DyFM_GPTCall_Settings,
+      debugLog?: boolean,
+      /** this is used to readably replace too long contents to eg '...' in logs */
+      replaceThisInLog?: string,
+    }
   ): Promise<T[]> {
     const selectQuestionAddition = this.predefinedRequests.multiselect.replace(
       '{{DyNTS_selectOptions}}', 
-      this.getTextListAsText(options.map(item => `"${JSON.stringify(item)}"`))
+      this.getTextListAsText(set.options.map(item => `"${JSON.stringify(item)}"`))
     );
-    question += selectQuestionAddition;
+    set.question += selectQuestionAddition;
     
-    this.logQuestion(question, null, debugLog);
+    this.logQuestion(set);
 
-    const answer = await this.getAnswerInConversation(
-      conversation, 
-      question, 
-      issuer, 
-      settings,
-      debugLog,
-      replaceThisInLog
-    );
+    const answer = await this.getQuestionAnswerInConversation(set);
 
     return DyFM_safeParseList<T[]>(answer);
   }
@@ -298,26 +263,21 @@ export class DyNTS_OAI_LLMChat_ServiceBase extends DyNTS_OAI_LLM_ServiceBase {
    * (uses {@link DyFM_safeParseJSON})
    */
   async jsonQuestionInConversation<T = any>(
-    conversation: DyNTS_OAI_GPT_Message[],
-    question: string, 
-    issuer: string,
-    settings?: DyFM_GPTCall_Settings,
-    debugLog?: boolean,
-    /** this is used to readably replace too long contents to eg '...' in logs */
-    replaceThisInLog?: string
+    set: {
+      conversation: DyNTS_OAI_GPT_Message[],
+      question: string, 
+      issuer: string,
+      settings?: DyFM_GPTCall_Settings,
+      debugLog?: boolean,
+      /** this is used to readably replace too long contents to eg '...' in logs */
+      replaceThisInLog?: string,
+    }
   ): Promise<T | { unparsableResult: string }> {
-    question += this.predefinedRequests.jsonRequest;
+    set.question += this.predefinedRequests.jsonRequest;
 
-    this.logQuestion(question, replaceThisInLog, debugLog);
+    this.logQuestion(set);
 
-    const answer = await this.getAnswerInConversation(
-      conversation, 
-      question, 
-      issuer, 
-      settings,
-      debugLog,
-      replaceThisInLog
-    );
+    const answer = await this.getQuestionAnswerInConversation(set);
     
     return DyFM_safeParseJSON<T>(answer);
   }
@@ -333,31 +293,26 @@ export class DyNTS_OAI_LLMChat_ServiceBase extends DyNTS_OAI_LLM_ServiceBase {
    * (uses {@link DyFM_safeParseJSON})
    */
   async jsonQuestionWithKeysDescriptionInConversation<T = any>(
-    conversation: DyNTS_OAI_GPT_Message[],
-    question: string, 
-    keysDescription: string,
-    issuer: string,
-    settings?: DyFM_GPTCall_Settings,
-    debugLog?: boolean,
-    /** this is used to readably replace too long contents to eg '...' in logs */
-    replaceThisInLog?: string
+    set: {
+      conversation: DyNTS_OAI_GPT_Message[],
+      question: string, 
+      keysDescription: string,
+      issuer: string,
+      settings?: DyFM_GPTCall_Settings,
+      debugLog?: boolean,
+      /** this is used to readably replace too long contents to eg '...' in logs */
+      replaceThisInLog?: string,
+    }
   ): Promise<T | { unparsableResult: string }> {
     const jsonRequestWithKeysDescription = this.predefinedRequests.jsonRequestWithKeysDescription.replace(
       '{{DyNTS_jsonKeysDescription}}', 
-      keysDescription
+      set.keysDescription
     );
-    question += jsonRequestWithKeysDescription;
+    set.question += jsonRequestWithKeysDescription;
 
-    this.logQuestion(question, replaceThisInLog, debugLog);
+    this.logQuestion(set);
 
-    const answer = await this.getAnswerInConversation(
-      conversation, 
-      question, 
-      issuer, 
-      settings,
-      debugLog,
-      replaceThisInLog
-    );
+    const answer = await this.getQuestionAnswerInConversation(set);
 
     return DyFM_safeParseJSON<T>(answer);
   }
@@ -373,31 +328,26 @@ export class DyNTS_OAI_LLMChat_ServiceBase extends DyNTS_OAI_LLM_ServiceBase {
    * (uses {@link DyFM_safeParseJSON})
    */
   async jsonQuestionWithExactKeysInConversation<T = any>(
-    conversation: DyNTS_OAI_GPT_Message[],
-    question: string, 
-    keys: string[],
-    issuer: string,
-    settings?: DyFM_GPTCall_Settings,
-    debugLog?: boolean,
-    /** this is used to readably replace too long contents to eg '...' in logs */
-    replaceThisInLog?: string
+    set: {
+      conversation: DyNTS_OAI_GPT_Message[],
+      question: string, 
+      keys: string[],
+      issuer: string,
+      settings?: DyFM_GPTCall_Settings,
+      debugLog?: boolean,
+      /** this is used to readably replace too long contents to eg '...' in logs */
+      replaceThisInLog?: string,
+    }
   ): Promise<T | { unparsableResult: string }> {
     const jsonRequestWithExactKeys = this.predefinedRequests.jsonRequestWithExactKeys.replace(
       '{{DyNTS_jsonKeys}}', 
-      this.getTextListAsText(keys)
+      this.getTextListAsText(set.keys)
     );
-    question += jsonRequestWithExactKeys;
+    set.question += jsonRequestWithExactKeys;
 
-    this.logQuestion(question, replaceThisInLog, debugLog);
+    this.logQuestion(set);
 
-    const answer = await this.getAnswerInConversation(
-      conversation, 
-      question, 
-      issuer, 
-      settings,
-      debugLog,
-      replaceThisInLog
-    );
+    const answer = await this.getQuestionAnswerInConversation(set);
 
     return DyFM_safeParseJSON<T>(answer);
   }
@@ -413,26 +363,21 @@ export class DyNTS_OAI_LLMChat_ServiceBase extends DyNTS_OAI_LLM_ServiceBase {
    * (uses {@link DyFM_safeParseList})
    */
   async listQuestionInConversation(
-    conversation: DyNTS_OAI_GPT_Message[],
-    question: string, 
-    issuer: string,
-    settings?: DyFM_GPTCall_Settings,
-    debugLog?: boolean,
-    /** this is used to readably replace too long contents to eg '...' in logs */
-    replaceThisInLog?: string,
+    set: {
+      conversation: DyNTS_OAI_GPT_Message[],
+      question: string, 
+      issuer: string,
+      settings?: DyFM_GPTCall_Settings,
+      debugLog?: boolean,
+      /** this is used to readably replace too long contents to eg '...' in logs */
+      replaceThisInLog?: string,
+    }
   ): Promise<string[]> {
-    question += this.predefinedRequests.listRequest;
+    set.question += this.predefinedRequests.listRequest;
 
-    this.logQuestion(question, replaceThisInLog, debugLog);
+    this.logQuestion(set);
 
-    const answer = await this.getAnswerInConversation(
-      conversation, 
-      question, 
-      issuer, 
-      settings,
-      debugLog,
-      replaceThisInLog
-    );
+    const answer = await this.getQuestionAnswerInConversation(set);
 
     return DyFM_safeParseList(answer);
   }
@@ -463,6 +408,26 @@ export class DyNTS_OAI_LLMChat_ServiceBase extends DyNTS_OAI_LLM_ServiceBase {
 
     return answer;
   } */
+
+  async getQuestionAnswerInConversation(
+    set: {
+      conversation: DyNTS_OAI_GPT_Message[],
+      question: string, 
+      issuer: string,
+      settings?: DyFM_GPTCall_Settings,
+      debugLog?: boolean,
+      /** this is used to readably replace too long contents to eg '...' in logs */
+      replaceThisInLog?: string,
+    }
+  ): Promise<string> {
+    return await this.getAnswerInConversation({
+      ...set,
+      newMessage: set.question,
+    });
+  }
+  /* getQuestionAnswerInConversation = this.getAnswerInConversation; */
+  getQuestionInConversation = this.getQuestionAnswerInConversation;
+  askQuestionInConversation = this.getQuestionAnswerInConversation;
   
   /**
    * Asks the AI to answer a question using the whole conversation
@@ -472,37 +437,43 @@ export class DyNTS_OAI_LLMChat_ServiceBase extends DyNTS_OAI_LLM_ServiceBase {
    * Uses the {@link resolveConversation}
    */
   async getAnswerInConversation(
-    conversation: DyNTS_OAI_GPT_Message[],
-    newMessage: string, 
-    issuer: string,
-    settings?: DyFM_GPTCall_Settings,
-    debugLog?: boolean,
-    /** this is used to readably replace too long contents to eg '...' in logs */
-    replaceThisInLog?: string,
+    set: {
+      conversation: DyNTS_OAI_GPT_Message[],
+      newMessage: string, 
+      issuer: string,
+      settings?: DyFM_GPTCall_Settings,
+      debugLog?: boolean,
+      /** this is used to readably replace too long contents to eg '...' in logs */
+      replaceThisInLog?: string,
+    }
   ): Promise<string> {
-    conversation.push({
+    set.conversation.push({
       role: DyNTS_OAI_GPT_Message_Role.user,
-      content: newMessage,
+      content: set.newMessage,
     });
 
-    const answer: string = (await this.resolveConversation(
-      conversation, 
-      issuer, 
-      settings,
-      false,
-      debugLog,
-      replaceThisInLog,
-    )) as string;
+    const answer: string = await this.resolveConversationMessage(set);
 
-    if (debugLog || this.debugLog) {
+    if (set.debugLog || this.debugLog) {
       console.log(' - answer: ', answer);
     }
 
     return answer;
   }
-  getQuestionAnswerInConversation = this.getAnswerInConversation;
-  getQuestionInConversation = this.getAnswerInConversation;
-  askQuestionInConversation = this.getAnswerInConversation;
+
+  async resolveConversationMessage(
+    set: {
+      conversation: DyNTS_OAI_GPT_Message[],
+      issuer: string,
+      settings?: DyFM_GPTCall_Settings,
+      getFullResponse?: boolean,
+      debugLog?: boolean,
+      /** this is used to readably replace too long contents to eg '...' in logs */
+      replaceThisInLog?: string,
+    }
+  ): Promise<string> {
+    return await this.resolveConversation(set) as string;
+  }
 
   /**
    * Resolves a conversation
@@ -510,34 +481,42 @@ export class DyNTS_OAI_LLMChat_ServiceBase extends DyNTS_OAI_LLM_ServiceBase {
    * Uses the {@link getMessageCreateInput}
    */
   async resolveConversation(
-    conversation: DyNTS_OAI_GPT_Message[],
-    issuer: string,
-    settings?: DyFM_GPTCall_Settings,
-    getFullResponse?: boolean,
-    debugLog?: boolean,
-    /** this is used to readably replace too long contents to eg '...' in logs */
-    replaceThisInLog?: string,
+    set: {
+      conversation: DyNTS_OAI_GPT_Message[],
+      issuer: string,
+      settings?: DyFM_GPTCall_Settings,
+      getFullResponse?: boolean,
+      debugLog?: boolean,
+      /** this is used to readably replace too long contents to eg '...' in logs */
+      replaceThisInLog?: string,
+    }
   ): Promise<string | ChatCompletion> {
     try {
-      conversation.unshift(this.getDefaultSystemMessage(settings));
+      set.conversation.unshift(this.getDefaultSystemMessage(set.settings));
 
       // conversation shortening
-      const shortenedConversation = this.shortenConversation(conversation, issuer, debugLog);
+      const shortenedConversation = this.shortenConversation(set);
       
-      this.logConversation(shortenedConversation, debugLog, replaceThisInLog);
+      this.logConversation({
+        ...set,
+        conversation: shortenedConversation,
+      });
 
       const result: ChatCompletion = await this.openai.chat.completions.create(
-        this.getMessageCreateInput(shortenedConversation, issuer, settings)
+        this.getMessageCreateInput({
+          ...set,
+          conversation: shortenedConversation,
+        })
       ) as ChatCompletion;
 
-      if (getFullResponse) {
+      if (set.getFullResponse) {
         return result;
       }
 
       return result.choices[0].message.content;
     } catch (error) {
       throw new DyFM_Error({
-        ...this.getDefaultErrorSettings('resolveConversation', error, issuer),
+        ...this.getDefaultErrorSettings('resolveConversation', error, set.issuer),
         
         errorCode: `${DyNTS_global_settings.systemShortCodeName}|DyNTS-OAB-RC0`,
       });
@@ -546,12 +525,14 @@ export class DyNTS_OAI_LLMChat_ServiceBase extends DyNTS_OAI_LLM_ServiceBase {
   resolveSimpleUserMessageInConversation = this.resolveConversation;
 
   protected shortenConversation(
-    conversation: DyNTS_OAI_GPT_Message[],
-    issuer: string,
-    debugLog?: boolean,
+    set: {
+      conversation: DyNTS_OAI_GPT_Message[],
+      issuer: string,
+      debugLog?: boolean,
+    }
   ): DyNTS_OAI_GPT_Message[] {
     try {
-      const clonedConversation = DyFM_clone(conversation);
+      const clonedConversation = DyFM_clone(set.conversation);
       const systemMessages = clonedConversation.filter(
         message => message.role === DyNTS_OAI_GPT_Message_Role.system
       );
@@ -561,7 +542,7 @@ export class DyNTS_OAI_LLMChat_ServiceBase extends DyNTS_OAI_LLM_ServiceBase {
       ).map(message => message.content);
       let stringifiedMessages = JSON.stringify(msgs);
 
-      if (this.debugLog || debugLog) {
+      if (this.debugLog || set.debugLog) {
         console.log('stringifiedMessagesCount before removing', stringifiedMessages.length);
       }
       
@@ -579,7 +560,7 @@ export class DyNTS_OAI_LLMChat_ServiceBase extends DyNTS_OAI_LLM_ServiceBase {
         lastStringifiedMessagesLength = stringifiedMessages.length;
       }
 
-      if (this.debugLog || debugLog) {
+      if (this.debugLog || set.debugLog) {
         console.log('removedMessagesCount', removedMessagesCount);
         console.log('lastStringifiedMessagesLength', lastStringifiedMessagesLength);
       }
@@ -587,7 +568,7 @@ export class DyNTS_OAI_LLMChat_ServiceBase extends DyNTS_OAI_LLM_ServiceBase {
       if (!clonedConversation.length) {
         DyFM_Log.error('No conversation messages (left)', { 
           /* conversation: DyFM_clone(conversation), */
-          conversationLength: conversation.length,
+          conversationLength: set.conversation.length,
           clonedConversation: DyFM_clone(clonedConversation),
         });
         throw new Error('No conversation messages (left)');
@@ -596,8 +577,9 @@ export class DyNTS_OAI_LLMChat_ServiceBase extends DyNTS_OAI_LLM_ServiceBase {
       return [ ...systemMessages, ...clonedConversation ];
     } catch (error) {
       console.error('❌❌ Error shortening conversation:', error);
+
       throw new DyFM_Error({
-        ...this.getDefaultErrorSettings('shortenConversation', error, issuer),
+        ...this.getDefaultErrorSettings('shortenConversation', error, set.issuer),
         
         errorCode: `${DyNTS_global_settings.systemShortCodeName}|DyNTS-OAB-SC0`,
       });
@@ -605,15 +587,17 @@ export class DyNTS_OAI_LLMChat_ServiceBase extends DyNTS_OAI_LLM_ServiceBase {
   }
 
   protected logConversation(
-    conversation: DyNTS_OAI_GPT_Message[], 
-    debugLog?: boolean,
-    /** this is used to readably replace too long contents to eg '...' in logs */
-    replaceThisInLog?: string,
+    set: {
+      conversation: DyNTS_OAI_GPT_Message[], 
+      debugLog?: boolean,
+      /** this is used to readably replace too long contents to eg '...' in logs */
+      replaceThisInLog?: string,
+    }
   ) {
-    if (debugLog || this.debugLog) {
-      conversation.forEach(message => {
+    if (set.debugLog || this.debugLog) {
+      set.conversation.forEach(message => {
         console.log(
-          ` - ${message.role}: ${message.content.replace(replaceThisInLog, this.defaultLogReplacer)}`
+          ` - ${message.role}: ${message.content.replace(set.replaceThisInLog, this.defaultLogReplacer)}`
         );
       });
     }