@futdevpro/dynamo-eslint 1.15.22 → 1.15.28

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (197) hide show
  1. package/.c8rc.json +26 -26
  2. package/.cursor/rules/__assistant_guide.mdc +30 -30
  3. package/.cursor/rules/__main.mdc +64 -64
  4. package/.cursor/rules/_ag_backend-structure.mdc +85 -85
  5. package/.cursor/rules/_ag_backend.mdc +16 -16
  6. package/.cursor/rules/_ag_debug.mdc +7 -7
  7. package/.cursor/rules/_ag_documentation_writing_rules.mdc +372 -372
  8. package/.cursor/rules/_ag_file-refactoring.mdc +113 -113
  9. package/.cursor/rules/_ag_fixes_rules.mdc +5 -5
  10. package/.cursor/rules/_ag_frontend-structure.mdc +86 -86
  11. package/.cursor/rules/_ag_frontend.mdc +39 -39
  12. package/.cursor/rules/_ag_import-rules.mdc +44 -44
  13. package/.cursor/rules/_ag_naming.mdc +115 -115
  14. package/.cursor/rules/_ag_running_commands.mdc +4 -4
  15. package/.cursor/rules/_ag_server-controller.mdc +5 -5
  16. package/.cursor/rules/_ag_should-be.mdc +6 -6
  17. package/.cursor/rules/_ag_swearing.mdc +47 -47
  18. package/.cursor/rules/ai_development_guide.md +60 -60
  19. package/.cursor/rules/ai_directives.md +114 -114
  20. package/.cursor/rules/cursor-rules.md +160 -160
  21. package/.cursor/rules/default-command.mdc +464 -464
  22. package/.cursor/rules/error_code_pattern.md +39 -39
  23. package/.cursor/rules/saved rule mcp server use.md +15 -15
  24. package/.dynamo/pipeline.cicd.config.json +184 -184
  25. package/.dynamo/version-bump.config.json +5 -5
  26. package/.eslintrc.json +4 -4
  27. package/.github/workflows/main.yml +436 -436
  28. package/.husky/pre-commit +2 -2
  29. package/.vscode/settings.json +11 -11
  30. package/README.md +319 -319
  31. package/__documentations/2026-04-18-ccap-review-integration.md +173 -173
  32. package/__documentations/2026-08-18-bfr-ctm-005-eslint9-validator-report.md +45 -0
  33. package/build/configs/base.d.ts +9 -9
  34. package/build/configs/base.js +150 -150
  35. package/build/configs/fsm.d.ts +1 -1
  36. package/build/configs/fsm.js +7 -7
  37. package/build/configs/ngx-package.d.ts +1 -1
  38. package/build/configs/ngx-package.js +7 -7
  39. package/build/configs/ngx.d.ts +4 -4
  40. package/build/configs/ngx.js +91 -91
  41. package/build/configs/nts-package.d.ts +1 -1
  42. package/build/configs/nts-package.js +17 -17
  43. package/build/configs/nts.d.ts +1 -1
  44. package/build/configs/nts.js +31 -31
  45. package/build/index.d.ts +1 -1
  46. package/build/index.js +2 -2
  47. package/build/plugin/index.d.ts +52 -52
  48. package/build/plugin/index.js +80 -80
  49. package/build/plugin/rules/angular/angular-for-track-logic.d.ts +7 -7
  50. package/build/plugin/rules/angular/angular-for-track-logic.js +81 -81
  51. package/build/plugin/rules/angular/effect-signal-loop.d.ts +9 -9
  52. package/build/plugin/rules/angular/effect-signal-loop.js +112 -112
  53. package/build/plugin/rules/angular/no-async-ngoninit.d.ts +8 -8
  54. package/build/plugin/rules/angular/no-async-ngoninit.js +42 -42
  55. package/build/plugin/rules/angular/no-component-direct-api.d.ts +9 -9
  56. package/build/plugin/rules/angular/no-component-direct-api.js +75 -75
  57. package/build/plugin/rules/angular/no-method-call-in-template.d.ts +8 -8
  58. package/build/plugin/rules/angular/no-method-call-in-template.js +79 -79
  59. package/build/plugin/rules/angular/no-ngfor-directive.d.ts +7 -7
  60. package/build/plugin/rules/angular/no-ngfor-directive.js +59 -59
  61. package/build/plugin/rules/angular/no-ngif-directive.d.ts +7 -7
  62. package/build/plugin/rules/angular/no-ngif-directive.js +59 -59
  63. package/build/plugin/rules/explicit-types.d.ts +3 -3
  64. package/build/plugin/rules/explicit-types.js +178 -178
  65. package/build/plugin/rules/import/import-order.d.ts +3 -3
  66. package/build/plugin/rules/import/import-order.js +154 -154
  67. package/build/plugin/rules/import/no-import-type.d.ts +3 -3
  68. package/build/plugin/rules/import/no-import-type.js +45 -45
  69. package/build/plugin/rules/import/no-js-import.d.ts +3 -3
  70. package/build/plugin/rules/import/no-js-import.js +40 -40
  71. package/build/plugin/rules/naming-patterns.d.ts +7 -7
  72. package/build/plugin/rules/naming-patterns.d.ts.map +1 -1
  73. package/build/plugin/rules/naming-patterns.js +366 -350
  74. package/build/plugin/rules/naming-patterns.js.map +1 -1
  75. package/build/plugin/rules/no-getter-logic.d.ts +3 -3
  76. package/build/plugin/rules/no-getter-logic.js +194 -194
  77. package/build/plugin/rules/prefer-enum-over-string-union.d.ts +3 -3
  78. package/build/plugin/rules/prefer-enum-over-string-union.js +289 -289
  79. package/build/plugin/rules/prefer-interface-over-duplicate-types.d.ts +3 -3
  80. package/build/plugin/rules/prefer-interface-over-duplicate-types.js +264 -264
  81. package/build/plugin/rules/require-jsdoc-description.d.ts +3 -3
  82. package/build/plugin/rules/require-jsdoc-description.js +496 -496
  83. package/build/plugin/rules/require-test-description-prefix.d.ts +3 -3
  84. package/build/plugin/rules/require-test-description-prefix.js +135 -135
  85. package/build/plugin/rules/ts/data-model-extends.d.ts +8 -8
  86. package/build/plugin/rules/ts/data-model-extends.js +94 -94
  87. package/build/plugin/rules/ts/no-any-type.d.ts +8 -8
  88. package/build/plugin/rules/ts/no-any-type.js +36 -36
  89. package/build/plugin/rules/ts/no-as-cast.d.ts +8 -8
  90. package/build/plugin/rules/ts/no-as-cast.js +49 -49
  91. package/build/plugin/rules/ts/no-dynamic-imports.d.ts +8 -8
  92. package/build/plugin/rules/ts/no-dynamic-imports.js +50 -50
  93. package/build/plugin/rules/ts/no-native-browser-dialogs.d.ts +8 -8
  94. package/build/plugin/rules/ts/no-native-browser-dialogs.js +78 -78
  95. package/build/plugin/rules/ts/no-plain-function-export.d.ts +9 -9
  96. package/build/plugin/rules/ts/no-plain-function-export.js +69 -69
  97. package/build/plugin/rules/ts/one-export-per-file.d.ts +8 -8
  98. package/build/plugin/rules/ts/one-export-per-file.js +73 -73
  99. package/build/scripts/dynamo-fix.d.ts +26 -26
  100. package/build/scripts/dynamo-fix.js +146 -146
  101. package/build/scripts/dynamo-fix.js.map +1 -1
  102. package/build/scripts/eslintrc-audit.d.ts +26 -26
  103. package/build/scripts/eslintrc-audit.js +100 -100
  104. package/build/scripts/fix-return-types.d.ts +74 -74
  105. package/build/scripts/fix-return-types.js +226 -226
  106. package/build/scripts/validate-imports.d.ts +26 -26
  107. package/build/scripts/validate-imports.js +157 -137
  108. package/build/scripts/validate-imports.js.map +1 -1
  109. package/build/scripts/validate-naming.d.ts +26 -26
  110. package/build/scripts/validate-naming.js +157 -123
  111. package/build/scripts/validate-naming.js.map +1 -1
  112. package/eslint.config.js +15 -15
  113. package/package.json +105 -105
  114. package/samples/.vscode/settings.json +13 -13
  115. package/samples/base/.eslintrc.json +6 -6
  116. package/samples/base/eslint.config.js +3 -3
  117. package/samples/fsm/.eslintrc.json +4 -4
  118. package/samples/fsm/eslint.config.js +3 -3
  119. package/samples/ngx/.eslintrc.json +6 -6
  120. package/samples/ngx/eslint.config.js +3 -3
  121. package/samples/ngx-package/.eslintrc.json +4 -4
  122. package/samples/ngx-package/eslint.config.js +3 -3
  123. package/samples/nts/.eslintrc.json +6 -6
  124. package/samples/nts/eslint.config.js +3 -3
  125. package/samples/nts-package/.eslintrc.json +4 -4
  126. package/samples/nts-package/eslint.config.js +3 -3
  127. package/samples/package.json.example +26 -26
  128. package/samples/poc-sample.ts +38 -38
  129. package/samples/poc-violations.ts +54 -54
  130. package/scripts/run-coverage-tests.js +24 -24
  131. package/spec/support/helpers/ts-node-helper.js +9 -9
  132. package/spec/support/jasmine.coverage.json +23 -23
  133. package/spec/support/jasmine.json +24 -24
  134. package/src/configs/base.ts +157 -157
  135. package/src/configs/fsm.ts +10 -10
  136. package/src/configs/ngx-package.ts +10 -10
  137. package/src/configs/ngx.ts +96 -96
  138. package/src/configs/nts-package.ts +20 -20
  139. package/src/configs/nts.ts +34 -34
  140. package/src/index.ts +4 -4
  141. package/src/plugin/index.ts +86 -86
  142. package/src/plugin/rules/angular/angular-for-track-logic.spec.ts +44 -44
  143. package/src/plugin/rules/angular/angular-for-track-logic.ts +88 -88
  144. package/src/plugin/rules/angular/effect-signal-loop.spec.ts +89 -89
  145. package/src/plugin/rules/angular/effect-signal-loop.ts +125 -125
  146. package/src/plugin/rules/angular/no-async-ngoninit.spec.ts +50 -50
  147. package/src/plugin/rules/angular/no-async-ngoninit.ts +43 -43
  148. package/src/plugin/rules/angular/no-component-direct-api.spec.ts +78 -78
  149. package/src/plugin/rules/angular/no-component-direct-api.ts +82 -82
  150. package/src/plugin/rules/angular/no-method-call-in-template.spec.ts +63 -63
  151. package/src/plugin/rules/angular/no-method-call-in-template.ts +89 -89
  152. package/src/plugin/rules/angular/no-ngfor-directive.spec.ts +44 -44
  153. package/src/plugin/rules/angular/no-ngfor-directive.ts +62 -62
  154. package/src/plugin/rules/angular/no-ngif-directive.spec.ts +44 -44
  155. package/src/plugin/rules/angular/no-ngif-directive.ts +62 -62
  156. package/src/plugin/rules/explicit-types.spec.ts +190 -190
  157. package/src/plugin/rules/explicit-types.ts +186 -186
  158. package/src/plugin/rules/import/import-order.spec.ts +219 -219
  159. package/src/plugin/rules/import/import-order.ts +197 -197
  160. package/src/plugin/rules/import/no-import-type.spec.ts +69 -69
  161. package/src/plugin/rules/import/no-import-type.ts +46 -46
  162. package/src/plugin/rules/import/no-js-import.spec.ts +82 -82
  163. package/src/plugin/rules/import/no-js-import.ts +45 -45
  164. package/src/plugin/rules/naming-patterns.spec.ts +189 -127
  165. package/src/plugin/rules/naming-patterns.ts +426 -408
  166. package/src/plugin/rules/no-getter-logic.spec.ts +591 -591
  167. package/src/plugin/rules/no-getter-logic.ts +220 -220
  168. package/src/plugin/rules/prefer-enum-over-string-union.spec.ts +583 -583
  169. package/src/plugin/rules/prefer-enum-over-string-union.ts +333 -333
  170. package/src/plugin/rules/prefer-interface-over-duplicate-types.spec.ts +404 -404
  171. package/src/plugin/rules/prefer-interface-over-duplicate-types.ts +314 -314
  172. package/src/plugin/rules/require-jsdoc-description.spec.ts +779 -779
  173. package/src/plugin/rules/require-jsdoc-description.ts +572 -572
  174. package/src/plugin/rules/require-test-description-prefix.spec.ts +459 -459
  175. package/src/plugin/rules/require-test-description-prefix.ts +154 -154
  176. package/src/plugin/rules/ts/data-model-extends.spec.ts +84 -84
  177. package/src/plugin/rules/ts/data-model-extends.ts +100 -100
  178. package/src/plugin/rules/ts/no-any-type.spec.ts +28 -28
  179. package/src/plugin/rules/ts/no-any-type.ts +36 -36
  180. package/src/plugin/rules/ts/no-as-cast.spec.ts +51 -51
  181. package/src/plugin/rules/ts/no-as-cast.ts +51 -51
  182. package/src/plugin/rules/ts/no-dynamic-imports.spec.ts +54 -54
  183. package/src/plugin/rules/ts/no-dynamic-imports.ts +49 -49
  184. package/src/plugin/rules/ts/no-native-browser-dialogs.spec.ts +54 -54
  185. package/src/plugin/rules/ts/no-native-browser-dialogs.ts +84 -84
  186. package/src/plugin/rules/ts/no-plain-function-export.spec.ts +72 -72
  187. package/src/plugin/rules/ts/no-plain-function-export.ts +73 -73
  188. package/src/plugin/rules/ts/one-export-per-file.spec.ts +64 -64
  189. package/src/plugin/rules/ts/one-export-per-file.ts +77 -77
  190. package/src/scripts/dynamo-fix.ts +172 -172
  191. package/src/scripts/eslintrc-audit.ts +116 -116
  192. package/src/scripts/fix-return-types.spec.ts +65 -65
  193. package/src/scripts/fix-return-types.ts +288 -288
  194. package/src/scripts/validate-imports.ts +278 -249
  195. package/src/scripts/validate-naming.ts +204 -176
  196. package/src/scripts/validator-cli.integration.spec.ts +96 -0
  197. package/tsconfig.json +31 -31
@@ -1,404 +1,404 @@
1
- import preferInterfaceRule from './prefer-interface-over-duplicate-types';
2
-
3
- describe('| prefer-interface-over-duplicate-types', () => {
4
- it('| should be a valid ESLint rule', () => {
5
- expect(preferInterfaceRule.meta?.type).toBe('suggestion');
6
- expect(preferInterfaceRule.meta?.docs?.description).toContain('Suggest creating interfaces');
7
- // BFR-ADVENTOR-009 (2. lépcső): a forrás-megőrző fixer VISSZAKAPCSOLVA auto-fix-re (érvényes kódot ad).
8
- expect(preferInterfaceRule.meta?.fixable).toBe('code');
9
- });
10
-
11
- it('| should have create function that returns visitor object', () => {
12
- const mockContext = {
13
- report: () => {},
14
- options: [{ threshold: 3 }],
15
- sourceCode: {
16
- getText: () => '',
17
- getScope: () => ({ variables: [] }),
18
- ast: { body: [] },
19
- },
20
- } as any;
21
-
22
- const result = preferInterfaceRule.create(mockContext);
23
-
24
- expect(typeof result).toBe('object');
25
- expect(typeof result.TSTypeLiteral).toBe('function');
26
- expect(typeof result['Program:exit']).toBe('function');
27
- });
28
-
29
- it('| should not report when object type is used less than threshold', () => {
30
- let reportCalled = false;
31
- const mockContext = {
32
- report: (options: any) => {
33
- reportCalled = true;
34
- },
35
- options: [{ threshold: 3 }],
36
- sourceCode: {
37
- getText: () => '{ name: string; age: number }',
38
- getScope: () => ({ variables: [] }),
39
- ast: { body: [] },
40
- },
41
- } as any;
42
-
43
- const rule = preferInterfaceRule.create(mockContext);
44
-
45
- // Simulate 2 usages (below threshold of 3)
46
- const mockNode1 = {
47
- type: 'TSTypeLiteral',
48
- members: [
49
- { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
50
- { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
51
- ],
52
- } as any;
53
-
54
- const mockNode2 = {
55
- type: 'TSTypeLiteral',
56
- members: [
57
- { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
58
- { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
59
- ],
60
- } as any;
61
-
62
- rule.TSTypeLiteral(mockNode1);
63
- rule.TSTypeLiteral(mockNode2);
64
- rule['Program:exit']({} as any);
65
-
66
- expect(reportCalled).toBe(false);
67
- });
68
-
69
- it('| should report when object type is used at or above threshold', () => {
70
- let reportCalled = false;
71
- const mockContext = {
72
- report: (options: any) => {
73
- reportCalled = true;
74
- expect(options.messageId).toBe('preferInterface');
75
- expect(options.data.count).toBe('3');
76
- expect(options.data.interfaceName).toContain('Interface');
77
- },
78
- options: [{ threshold: 3 }],
79
- sourceCode: {
80
- getText: () => '{ name: string; age: number }',
81
- getScope: () => ({ variables: [] }),
82
- ast: { body: [] },
83
- },
84
- } as any;
85
-
86
- const rule = preferInterfaceRule.create(mockContext);
87
-
88
- // Simulate 3 usages (at threshold)
89
- const mockNode = {
90
- type: 'TSTypeLiteral',
91
- members: [
92
- { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
93
- { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
94
- ],
95
- } as any;
96
-
97
- rule.TSTypeLiteral(mockNode);
98
- rule.TSTypeLiteral(mockNode);
99
- rule.TSTypeLiteral(mockNode);
100
- rule['Program:exit']({} as any);
101
-
102
- expect(reportCalled).toBe(true);
103
- });
104
-
105
- it('| should handle custom threshold', () => {
106
- let reportCalled = false;
107
- const mockContext = {
108
- report: (options: any) => {
109
- reportCalled = true;
110
- expect(options.data.count).toBe('2');
111
- },
112
- options: [{ threshold: 2 }],
113
- sourceCode: {
114
- getText: () => '{ name: string }',
115
- getScope: () => ({ variables: [] }),
116
- ast: { body: [] },
117
- },
118
- } as any;
119
-
120
- const rule = preferInterfaceRule.create(mockContext);
121
-
122
- const mockNode = {
123
- type: 'TSTypeLiteral',
124
- members: [
125
- { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
126
- ],
127
- } as any;
128
-
129
- rule.TSTypeLiteral(mockNode);
130
- rule.TSTypeLiteral(mockNode);
131
- rule['Program:exit']({} as any);
132
-
133
- expect(reportCalled).toBe(true);
134
- });
135
-
136
- it('| should handle structural equivalence (different property order)', () => {
137
- let reportCalled = false;
138
- const mockContext = {
139
- report: (options: any) => {
140
- reportCalled = true;
141
- expect(options.data.count).toBe('2');
142
- },
143
- options: [{ threshold: 2 }],
144
- sourceCode: {
145
- getText: () => '',
146
- getScope: () => ({ variables: [] }),
147
- ast: { body: [] },
148
- },
149
- } as any;
150
-
151
- const rule = preferInterfaceRule.create(mockContext);
152
-
153
- // First object: { name: string, age: number }
154
- const mockNode1 = {
155
- type: 'TSTypeLiteral',
156
- members: [
157
- { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
158
- { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
159
- ],
160
- } as any;
161
-
162
- // Second object: { age: number, name: string } (different order)
163
- const mockNode2 = {
164
- type: 'TSTypeLiteral',
165
- members: [
166
- { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
167
- { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
168
- ],
169
- } as any;
170
-
171
- rule.TSTypeLiteral(mockNode1);
172
- rule.TSTypeLiteral(mockNode2);
173
- rule['Program:exit']({} as any);
174
-
175
- expect(reportCalled).toBe(true);
176
- });
177
-
178
- it('| should handle optional properties', () => {
179
- let reportCalled = false;
180
- const mockContext = {
181
- report: (options: any) => {
182
- reportCalled = true;
183
- expect(options.data.count).toBe('2');
184
- },
185
- options: [{ threshold: 2 }],
186
- sourceCode: {
187
- getText: () => '',
188
- getScope: () => ({ variables: [] }),
189
- ast: { body: [] },
190
- },
191
- } as any;
192
-
193
- const rule = preferInterfaceRule.create(mockContext);
194
-
195
- const mockNode = {
196
- type: 'TSTypeLiteral',
197
- members: [
198
- { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } }, optional: true },
199
- { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
200
- ],
201
- } as any;
202
-
203
- rule.TSTypeLiteral(mockNode);
204
- rule.TSTypeLiteral(mockNode);
205
- rule['Program:exit']({} as any);
206
-
207
- expect(reportCalled).toBe(true);
208
- });
209
-
210
- it('| should handle readonly properties', () => {
211
- let reportCalled = false;
212
- const mockContext = {
213
- report: (options: any) => {
214
- reportCalled = true;
215
- expect(options.data.count).toBe('2');
216
- },
217
- options: [{ threshold: 2 }],
218
- sourceCode: {
219
- getText: () => '',
220
- getScope: () => ({ variables: [] }),
221
- ast: { body: [] },
222
- },
223
- } as any;
224
-
225
- const rule = preferInterfaceRule.create(mockContext);
226
-
227
- const mockNode = {
228
- type: 'TSTypeLiteral',
229
- members: [
230
- { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } }, readonly: true },
231
- { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
232
- ],
233
- } as any;
234
-
235
- rule.TSTypeLiteral(mockNode);
236
- rule.TSTypeLiteral(mockNode);
237
- rule['Program:exit']({} as any);
238
-
239
- expect(reportCalled).toBe(true);
240
- });
241
-
242
- it('| auto-fix a FORRÁS-SZÖVEGBŐL épít (BFR-ADVENTOR-009 2. lépcső: komplex típus megőrizve, nem `reference`)', () => {
243
- // egy komplex property-t szimulálunk: a member getText-je egy function-type — a régi lossy fixer
244
- // ezt `reference`/`complex`-re redukálta (érvénytelen TS); az új fixer EXAKT megőrzi.
245
- const complexMember: any = {
246
- type: 'TSPropertySignature', key: { name: 'onError' },
247
- };
248
- const numberMember: any = {
249
- type: 'TSPropertySignature', key: { name: 'count' },
250
- };
251
- const memberTexts: Map<any, string> = new Map([
252
- [ complexMember, 'onError: (e: Error) => void' ],
253
- [ numberMember, 'count: number' ],
254
- ]);
255
-
256
- let insertedText: string = '';
257
- const mockFixer: any = {
258
- insertTextAfterRange: (_range: unknown, text: string): unknown => { insertedText = text; return {}; },
259
- replaceText: (): unknown => ({}),
260
- };
261
-
262
- const mockContext = {
263
- report: (options: any) => {
264
- expect(typeof options.fix).toBe('function'); // auto-fix VISSZA (nem suggestion)
265
- options.fix(mockFixer);
266
- },
267
- options: [{ threshold: 2 }],
268
- sourceCode: {
269
- // a body-generátor a member-node getText-jét használja; a normalizáló getTypeString nem fut a fixerben
270
- getText: (n: any): string => memberTexts.get(n) ?? '{ onError: fn; count: number }',
271
- getScope: () => ({ variables: [] }),
272
- ast: { body: [] },
273
- },
274
- } as any;
275
-
276
- const rule = preferInterfaceRule.create(mockContext);
277
-
278
- const mockNode = {
279
- type: 'TSTypeLiteral',
280
- members: [
281
- { ...complexMember, typeAnnotation: { typeAnnotation: { type: 'TSFunctionType' } } },
282
- { ...numberMember, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
283
- ],
284
- } as any;
285
- // a getText a fenti two member-referenciákat kapja — a mockNode.members MÁSOK, ezért a getText-map
286
- // kulcsait használjuk a mockNode.members-ként:
287
- mockNode.members = [ complexMember, numberMember ];
288
-
289
- rule.TSTypeLiteral(mockNode);
290
- rule.TSTypeLiteral(mockNode);
291
- rule['Program:exit']({} as any);
292
-
293
- // a generált interface a MEGŐRZÖTT function-type-ot tartalmazza, NEM `reference`/`complex`-et
294
- expect(insertedText).toContain('onError: (e: Error) => void;');
295
- expect(insertedText).toContain('count: number;');
296
- expect(insertedText).not.toContain('reference');
297
- expect(insertedText).not.toContain('complex');
298
- });
299
-
300
- it('| should handle default threshold when no options provided', () => {
301
- let reportCalled = false;
302
- const mockContext = {
303
- report: (options: any) => {
304
- reportCalled = true;
305
- expect(options.data.count).toBe('3');
306
- },
307
- options: [],
308
- sourceCode: {
309
- getText: () => '',
310
- getScope: () => ({ variables: [] }),
311
- ast: { body: [] },
312
- },
313
- } as any;
314
-
315
- const rule = preferInterfaceRule.create(mockContext);
316
-
317
- const mockNode = {
318
- type: 'TSTypeLiteral',
319
- members: [
320
- { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
321
- ],
322
- } as any;
323
-
324
- rule.TSTypeLiteral(mockNode);
325
- rule.TSTypeLiteral(mockNode);
326
- rule.TSTypeLiteral(mockNode);
327
- rule['Program:exit']({} as any);
328
-
329
- expect(reportCalled).toBe(true);
330
- });
331
-
332
- it('| should handle complex nested types', () => {
333
- let reportCalled = false;
334
- const mockContext = {
335
- report: (options: any) => {
336
- reportCalled = true;
337
- expect(options.data.count).toBe('2');
338
- },
339
- options: [{ threshold: 2 }],
340
- sourceCode: {
341
- getText: () => '',
342
- getScope: () => ({ variables: [] }),
343
- ast: { body: [] },
344
- },
345
- } as any;
346
-
347
- const rule = preferInterfaceRule.create(mockContext);
348
-
349
- const mockNode = {
350
- type: 'TSTypeLiteral',
351
- members: [
352
- {
353
- type: 'TSPropertySignature',
354
- key: { name: 'user' },
355
- typeAnnotation: {
356
- typeAnnotation: {
357
- type: 'TSTypeLiteral',
358
- members: [
359
- { type: 'TSPropertySignature', key: { name: 'id' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
360
- { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
361
- ],
362
- },
363
- },
364
- },
365
- ],
366
- } as any;
367
-
368
- rule.TSTypeLiteral(mockNode);
369
- rule.TSTypeLiteral(mockNode);
370
- rule['Program:exit']({} as any);
371
-
372
- expect(reportCalled).toBe(true);
373
- });
374
-
375
- it('| should handle error cases gracefully', () => {
376
- const mockContext = {
377
- report: () => {},
378
- options: [{ threshold: 2 }],
379
- sourceCode: {
380
- getText: () => '',
381
- getScope: () => {
382
- throw new Error('Scope error');
383
- },
384
- ast: { body: [] },
385
- },
386
- } as any;
387
-
388
- const rule = preferInterfaceRule.create(mockContext);
389
-
390
- const mockNode = {
391
- type: 'TSTypeLiteral',
392
- members: [
393
- { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
394
- ],
395
- } as any;
396
-
397
- // Should not throw error
398
- expect(() => {
399
- rule.TSTypeLiteral(mockNode);
400
- rule.TSTypeLiteral(mockNode);
401
- rule['Program:exit']({} as any);
402
- }).not.toThrow();
403
- });
404
- });
1
+ import preferInterfaceRule from './prefer-interface-over-duplicate-types';
2
+
3
+ describe('| prefer-interface-over-duplicate-types', () => {
4
+ it('| should be a valid ESLint rule', () => {
5
+ expect(preferInterfaceRule.meta?.type).toBe('suggestion');
6
+ expect(preferInterfaceRule.meta?.docs?.description).toContain('Suggest creating interfaces');
7
+ // BFR-ADVENTOR-009 (2. lépcső): a forrás-megőrző fixer VISSZAKAPCSOLVA auto-fix-re (érvényes kódot ad).
8
+ expect(preferInterfaceRule.meta?.fixable).toBe('code');
9
+ });
10
+
11
+ it('| should have create function that returns visitor object', () => {
12
+ const mockContext = {
13
+ report: () => {},
14
+ options: [{ threshold: 3 }],
15
+ sourceCode: {
16
+ getText: () => '',
17
+ getScope: () => ({ variables: [] }),
18
+ ast: { body: [] },
19
+ },
20
+ } as any;
21
+
22
+ const result = preferInterfaceRule.create(mockContext);
23
+
24
+ expect(typeof result).toBe('object');
25
+ expect(typeof result.TSTypeLiteral).toBe('function');
26
+ expect(typeof result['Program:exit']).toBe('function');
27
+ });
28
+
29
+ it('| should not report when object type is used less than threshold', () => {
30
+ let reportCalled = false;
31
+ const mockContext = {
32
+ report: (options: any) => {
33
+ reportCalled = true;
34
+ },
35
+ options: [{ threshold: 3 }],
36
+ sourceCode: {
37
+ getText: () => '{ name: string; age: number }',
38
+ getScope: () => ({ variables: [] }),
39
+ ast: { body: [] },
40
+ },
41
+ } as any;
42
+
43
+ const rule = preferInterfaceRule.create(mockContext);
44
+
45
+ // Simulate 2 usages (below threshold of 3)
46
+ const mockNode1 = {
47
+ type: 'TSTypeLiteral',
48
+ members: [
49
+ { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
50
+ { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
51
+ ],
52
+ } as any;
53
+
54
+ const mockNode2 = {
55
+ type: 'TSTypeLiteral',
56
+ members: [
57
+ { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
58
+ { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
59
+ ],
60
+ } as any;
61
+
62
+ rule.TSTypeLiteral(mockNode1);
63
+ rule.TSTypeLiteral(mockNode2);
64
+ rule['Program:exit']({} as any);
65
+
66
+ expect(reportCalled).toBe(false);
67
+ });
68
+
69
+ it('| should report when object type is used at or above threshold', () => {
70
+ let reportCalled = false;
71
+ const mockContext = {
72
+ report: (options: any) => {
73
+ reportCalled = true;
74
+ expect(options.messageId).toBe('preferInterface');
75
+ expect(options.data.count).toBe('3');
76
+ expect(options.data.interfaceName).toContain('Interface');
77
+ },
78
+ options: [{ threshold: 3 }],
79
+ sourceCode: {
80
+ getText: () => '{ name: string; age: number }',
81
+ getScope: () => ({ variables: [] }),
82
+ ast: { body: [] },
83
+ },
84
+ } as any;
85
+
86
+ const rule = preferInterfaceRule.create(mockContext);
87
+
88
+ // Simulate 3 usages (at threshold)
89
+ const mockNode = {
90
+ type: 'TSTypeLiteral',
91
+ members: [
92
+ { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
93
+ { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
94
+ ],
95
+ } as any;
96
+
97
+ rule.TSTypeLiteral(mockNode);
98
+ rule.TSTypeLiteral(mockNode);
99
+ rule.TSTypeLiteral(mockNode);
100
+ rule['Program:exit']({} as any);
101
+
102
+ expect(reportCalled).toBe(true);
103
+ });
104
+
105
+ it('| should handle custom threshold', () => {
106
+ let reportCalled = false;
107
+ const mockContext = {
108
+ report: (options: any) => {
109
+ reportCalled = true;
110
+ expect(options.data.count).toBe('2');
111
+ },
112
+ options: [{ threshold: 2 }],
113
+ sourceCode: {
114
+ getText: () => '{ name: string }',
115
+ getScope: () => ({ variables: [] }),
116
+ ast: { body: [] },
117
+ },
118
+ } as any;
119
+
120
+ const rule = preferInterfaceRule.create(mockContext);
121
+
122
+ const mockNode = {
123
+ type: 'TSTypeLiteral',
124
+ members: [
125
+ { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
126
+ ],
127
+ } as any;
128
+
129
+ rule.TSTypeLiteral(mockNode);
130
+ rule.TSTypeLiteral(mockNode);
131
+ rule['Program:exit']({} as any);
132
+
133
+ expect(reportCalled).toBe(true);
134
+ });
135
+
136
+ it('| should handle structural equivalence (different property order)', () => {
137
+ let reportCalled = false;
138
+ const mockContext = {
139
+ report: (options: any) => {
140
+ reportCalled = true;
141
+ expect(options.data.count).toBe('2');
142
+ },
143
+ options: [{ threshold: 2 }],
144
+ sourceCode: {
145
+ getText: () => '',
146
+ getScope: () => ({ variables: [] }),
147
+ ast: { body: [] },
148
+ },
149
+ } as any;
150
+
151
+ const rule = preferInterfaceRule.create(mockContext);
152
+
153
+ // First object: { name: string, age: number }
154
+ const mockNode1 = {
155
+ type: 'TSTypeLiteral',
156
+ members: [
157
+ { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
158
+ { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
159
+ ],
160
+ } as any;
161
+
162
+ // Second object: { age: number, name: string } (different order)
163
+ const mockNode2 = {
164
+ type: 'TSTypeLiteral',
165
+ members: [
166
+ { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
167
+ { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
168
+ ],
169
+ } as any;
170
+
171
+ rule.TSTypeLiteral(mockNode1);
172
+ rule.TSTypeLiteral(mockNode2);
173
+ rule['Program:exit']({} as any);
174
+
175
+ expect(reportCalled).toBe(true);
176
+ });
177
+
178
+ it('| should handle optional properties', () => {
179
+ let reportCalled = false;
180
+ const mockContext = {
181
+ report: (options: any) => {
182
+ reportCalled = true;
183
+ expect(options.data.count).toBe('2');
184
+ },
185
+ options: [{ threshold: 2 }],
186
+ sourceCode: {
187
+ getText: () => '',
188
+ getScope: () => ({ variables: [] }),
189
+ ast: { body: [] },
190
+ },
191
+ } as any;
192
+
193
+ const rule = preferInterfaceRule.create(mockContext);
194
+
195
+ const mockNode = {
196
+ type: 'TSTypeLiteral',
197
+ members: [
198
+ { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } }, optional: true },
199
+ { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
200
+ ],
201
+ } as any;
202
+
203
+ rule.TSTypeLiteral(mockNode);
204
+ rule.TSTypeLiteral(mockNode);
205
+ rule['Program:exit']({} as any);
206
+
207
+ expect(reportCalled).toBe(true);
208
+ });
209
+
210
+ it('| should handle readonly properties', () => {
211
+ let reportCalled = false;
212
+ const mockContext = {
213
+ report: (options: any) => {
214
+ reportCalled = true;
215
+ expect(options.data.count).toBe('2');
216
+ },
217
+ options: [{ threshold: 2 }],
218
+ sourceCode: {
219
+ getText: () => '',
220
+ getScope: () => ({ variables: [] }),
221
+ ast: { body: [] },
222
+ },
223
+ } as any;
224
+
225
+ const rule = preferInterfaceRule.create(mockContext);
226
+
227
+ const mockNode = {
228
+ type: 'TSTypeLiteral',
229
+ members: [
230
+ { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } }, readonly: true },
231
+ { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
232
+ ],
233
+ } as any;
234
+
235
+ rule.TSTypeLiteral(mockNode);
236
+ rule.TSTypeLiteral(mockNode);
237
+ rule['Program:exit']({} as any);
238
+
239
+ expect(reportCalled).toBe(true);
240
+ });
241
+
242
+ it('| auto-fix a FORRÁS-SZÖVEGBŐL épít (BFR-ADVENTOR-009 2. lépcső: komplex típus megőrizve, nem `reference`)', () => {
243
+ // egy komplex property-t szimulálunk: a member getText-je egy function-type — a régi lossy fixer
244
+ // ezt `reference`/`complex`-re redukálta (érvénytelen TS); az új fixer EXAKT megőrzi.
245
+ const complexMember: any = {
246
+ type: 'TSPropertySignature', key: { name: 'onError' },
247
+ };
248
+ const numberMember: any = {
249
+ type: 'TSPropertySignature', key: { name: 'count' },
250
+ };
251
+ const memberTexts: Map<any, string> = new Map([
252
+ [ complexMember, 'onError: (e: Error) => void' ],
253
+ [ numberMember, 'count: number' ],
254
+ ]);
255
+
256
+ let insertedText: string = '';
257
+ const mockFixer: any = {
258
+ insertTextAfterRange: (_range: unknown, text: string): unknown => { insertedText = text; return {}; },
259
+ replaceText: (): unknown => ({}),
260
+ };
261
+
262
+ const mockContext = {
263
+ report: (options: any) => {
264
+ expect(typeof options.fix).toBe('function'); // auto-fix VISSZA (nem suggestion)
265
+ options.fix(mockFixer);
266
+ },
267
+ options: [{ threshold: 2 }],
268
+ sourceCode: {
269
+ // a body-generátor a member-node getText-jét használja; a normalizáló getTypeString nem fut a fixerben
270
+ getText: (n: any): string => memberTexts.get(n) ?? '{ onError: fn; count: number }',
271
+ getScope: () => ({ variables: [] }),
272
+ ast: { body: [] },
273
+ },
274
+ } as any;
275
+
276
+ const rule = preferInterfaceRule.create(mockContext);
277
+
278
+ const mockNode = {
279
+ type: 'TSTypeLiteral',
280
+ members: [
281
+ { ...complexMember, typeAnnotation: { typeAnnotation: { type: 'TSFunctionType' } } },
282
+ { ...numberMember, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
283
+ ],
284
+ } as any;
285
+ // a getText a fenti two member-referenciákat kapja — a mockNode.members MÁSOK, ezért a getText-map
286
+ // kulcsait használjuk a mockNode.members-ként:
287
+ mockNode.members = [ complexMember, numberMember ];
288
+
289
+ rule.TSTypeLiteral(mockNode);
290
+ rule.TSTypeLiteral(mockNode);
291
+ rule['Program:exit']({} as any);
292
+
293
+ // a generált interface a MEGŐRZÖTT function-type-ot tartalmazza, NEM `reference`/`complex`-et
294
+ expect(insertedText).toContain('onError: (e: Error) => void;');
295
+ expect(insertedText).toContain('count: number;');
296
+ expect(insertedText).not.toContain('reference');
297
+ expect(insertedText).not.toContain('complex');
298
+ });
299
+
300
+ it('| should handle default threshold when no options provided', () => {
301
+ let reportCalled = false;
302
+ const mockContext = {
303
+ report: (options: any) => {
304
+ reportCalled = true;
305
+ expect(options.data.count).toBe('3');
306
+ },
307
+ options: [],
308
+ sourceCode: {
309
+ getText: () => '',
310
+ getScope: () => ({ variables: [] }),
311
+ ast: { body: [] },
312
+ },
313
+ } as any;
314
+
315
+ const rule = preferInterfaceRule.create(mockContext);
316
+
317
+ const mockNode = {
318
+ type: 'TSTypeLiteral',
319
+ members: [
320
+ { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
321
+ ],
322
+ } as any;
323
+
324
+ rule.TSTypeLiteral(mockNode);
325
+ rule.TSTypeLiteral(mockNode);
326
+ rule.TSTypeLiteral(mockNode);
327
+ rule['Program:exit']({} as any);
328
+
329
+ expect(reportCalled).toBe(true);
330
+ });
331
+
332
+ it('| should handle complex nested types', () => {
333
+ let reportCalled = false;
334
+ const mockContext = {
335
+ report: (options: any) => {
336
+ reportCalled = true;
337
+ expect(options.data.count).toBe('2');
338
+ },
339
+ options: [{ threshold: 2 }],
340
+ sourceCode: {
341
+ getText: () => '',
342
+ getScope: () => ({ variables: [] }),
343
+ ast: { body: [] },
344
+ },
345
+ } as any;
346
+
347
+ const rule = preferInterfaceRule.create(mockContext);
348
+
349
+ const mockNode = {
350
+ type: 'TSTypeLiteral',
351
+ members: [
352
+ {
353
+ type: 'TSPropertySignature',
354
+ key: { name: 'user' },
355
+ typeAnnotation: {
356
+ typeAnnotation: {
357
+ type: 'TSTypeLiteral',
358
+ members: [
359
+ { type: 'TSPropertySignature', key: { name: 'id' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
360
+ { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
361
+ ],
362
+ },
363
+ },
364
+ },
365
+ ],
366
+ } as any;
367
+
368
+ rule.TSTypeLiteral(mockNode);
369
+ rule.TSTypeLiteral(mockNode);
370
+ rule['Program:exit']({} as any);
371
+
372
+ expect(reportCalled).toBe(true);
373
+ });
374
+
375
+ it('| should handle error cases gracefully', () => {
376
+ const mockContext = {
377
+ report: () => {},
378
+ options: [{ threshold: 2 }],
379
+ sourceCode: {
380
+ getText: () => '',
381
+ getScope: () => {
382
+ throw new Error('Scope error');
383
+ },
384
+ ast: { body: [] },
385
+ },
386
+ } as any;
387
+
388
+ const rule = preferInterfaceRule.create(mockContext);
389
+
390
+ const mockNode = {
391
+ type: 'TSTypeLiteral',
392
+ members: [
393
+ { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
394
+ ],
395
+ } as any;
396
+
397
+ // Should not throw error
398
+ expect(() => {
399
+ rule.TSTypeLiteral(mockNode);
400
+ rule.TSTypeLiteral(mockNode);
401
+ rule['Program:exit']({} as any);
402
+ }).not.toThrow();
403
+ });
404
+ });