@funnelsgrove/cli 0.1.87 → 0.1.89

package/template_scaffold/tests/src/runtime/use-funnel-flow-controller.integration.test.ts

@@ -1,203 +0,0 @@
-import { existsSync, readFileSync } from 'node:fs';
-import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
-
-const { posthogFlagsPath } = vi.hoisted(() => ({
-  posthogFlagsPath: new URL(
-    '../../../../funnel-runtime/src/runtime/posthog-flags.ts',
-    import.meta.url,
-  ).pathname,
-}));
-
-// This suite mocks the runtime's internal posthog-flags module by source path,
-// which only exists inside the funnelsgrove monorepo. Standalone funnels
-// scaffolded from the template resolve @funnelsgrove/runtime from node_modules
-// and cover the same routing logic through use-funnel-flow-controller.test.ts.
-const insideMonorepo = existsSync(posthogFlagsPath);
-
-vi.mock(posthogFlagsPath, () => ({
-  resolveExperimentVariant: vi.fn(),
-  bootstrapPostHog: vi.fn(),
-  isPostHogReady: vi.fn(() => true),
-  identifyPostHog: vi.fn(),
-  getPostHog: vi.fn(() => null),
-}));
-
-import type {
-  FunnelManifest,
-  FunnelManifestExperiment,
-} from '@funnelsgrove/runtime';
-import {
-  resolveExperimentAssignment,
-  resolveExperimentVariant,
-  resolveNextStepId,
-} from '@funnelsgrove/runtime';
-import { computeRenderSuspended } from '../../../src/runtime/use-funnel-flow-controller';
-
-const mockedResolveVariant = vi.mocked(resolveExperimentVariant);
-
-const heroExperiment: FunnelManifestExperiment = {
-  experimentId: 'exp_hero',
-  stepId: 'hero',
-  variants: [
-    { variantKey: 'control', routeToStepId: 'hero_v1' },
-    { variantKey: 'variant_a', routeToStepId: 'hero_v2' },
-  ],
-};
-
-const manifest: FunnelManifest = {
-  templateArchitectureVersion: 1,
-  stepContractVersion: 2,
-  meta: { title: 'Hero Experiment Funnel', description: 'integration fixture' },
-  viewport: { width: 390, height: 844 },
-  assets: {},
-  steps: [
-    {
-      id: 'hero',
-      name: 'hero',
-      path: '/hero',
-      filePath: 'src/steps/hero.tsx',
-      componentKey: 'hero',
-      type: 'intro_hero',
-      title: 'Hero',
-    },
-    {
-      id: 'hero_v1',
-      name: 'hero-v1',
-      path: '/hero-v1',
-      filePath: 'src/steps/hero-v1.tsx',
-      componentKey: 'heroV1',
-      type: 'intro_hero',
-      title: 'Hero v1',
-    },
-    {
-      id: 'hero_v2',
-      name: 'hero-v2',
-      path: '/hero-v2',
-      filePath: 'src/steps/hero-v2.tsx',
-      componentKey: 'heroV2',
-      type: 'intro_hero',
-      title: 'Hero v2',
-    },
-  ],
-  edgesByStepId: {
-    hero: [{ toStepId: 'hero_v1' }],
-  },
-  experiments: [heroExperiment],
-};
-
-// The controller's renderedStepId is derived by passing the active step's
-// experiment through resolveExperimentAssignment and routing to the matched
-// variant's routeToStepId (falling back to control). That is exactly the
-// function under test here. See apps/funnel-template/src/runtime/use-funnel-flow-controller.ts
-// (renderedStepId useMemo).
-const computeRenderedStepIdForActiveExperiment = (
-  experiment: FunnelManifestExperiment,
-): string => {
-  const assignment = resolveExperimentAssignment({
-    experimentId: experiment.experimentId,
-    variants: experiment.variants,
-  });
-  return assignment?.routeToStepId ?? experiment.stepId;
-};
-
-describe.skipIf(!insideMonorepo)('PostHog variant resolution (integration)', () => {
-  beforeEach(() => {
-    mockedResolveVariant.mockReset();
-  });
-
-  afterEach(() => {
-    vi.clearAllMocks();
-  });
-
-  it('routes to the variant_a target when PostHog resolves exp_hero to variant_a', () => {
-    mockedResolveVariant.mockReturnValue('variant_a');
-
-    expect(computeRenderedStepIdForActiveExperiment(heroExperiment)).toBe('hero_v2');
-
-    expect(
-      resolveNextStepId({
-        manifest,
-        currentStepId: 'hero',
-        attributes: {},
-        resolveExperimentVariantKey: (experiment) =>
-          resolveExperimentVariant(experiment.experimentId) ?? null,
-      }),
-    ).toBe('hero_v2');
-  });
-
-  it('falls back to control (hero_v1) when PostHog is not ready / returns undefined', () => {
-    mockedResolveVariant.mockReturnValue(undefined);
-
-    expect(computeRenderedStepIdForActiveExperiment(heroExperiment)).toBe('hero_v1');
-
-    expect(
-      resolveNextStepId({
-        manifest,
-        currentStepId: 'hero',
-        attributes: {},
-        resolveExperimentVariantKey: (experiment) =>
-          resolveExperimentVariant(experiment.experimentId) ?? null,
-      }),
-    ).toBe('hero_v1');
-  });
-
-  it('falls back to control (hero_v1) when PostHog resolves to an unknown variant key', () => {
-    mockedResolveVariant.mockReturnValue('phantom');
-
-    expect(computeRenderedStepIdForActiveExperiment(heroExperiment)).toBe('hero_v1');
-
-    expect(
-      resolveNextStepId({
-        manifest,
-        currentStepId: 'hero',
-        attributes: {},
-        resolveExperimentVariantKey: (experiment) =>
-          resolveExperimentVariant(experiment.experimentId) ?? null,
-      }),
-    ).toBe('hero_v1');
-  });
-
-  it('suspends render on an experiment step while PostHog is not ready', () => {
-    expect(
-      computeRenderSuspended({
-        activeStepId: 'hero',
-        postHogReady: false,
-        experiments: manifest.experiments,
-      }),
-    ).toBe(true);
-
-    expect(
-      computeRenderSuspended({
-        activeStepId: 'hero',
-        postHogReady: true,
-        experiments: manifest.experiments,
-      }),
-    ).toBe(false);
-  });
-
-  it('does not suspend render on an experiment step in preview runtime', () => {
-    expect(
-      computeRenderSuspended({
-        activeStepId: 'hero',
-        postHogReady: false,
-        experiments: manifest.experiments,
-        isPreviewRuntime: true,
-      }),
-    ).toBe(false);
-  });
-
-  it('renders experiment variants on the source URL before normal continuation', () => {
-    const adapterSource = readFileSync(new URL('../../../src/runtime/use-funnel-flow-controller.ts', import.meta.url), 'utf8');
-    const runtimeSource = readFileSync(
-      new URL('../../../../funnel-runtime/src/runtime/use-funnel-flow-controller.ts', import.meta.url),
-      'utf8',
-    );
-
-    expect(adapterSource).toContain('useFunnelFlowController as useSharedFunnelFlowController');
-    expect(runtimeSource).toContain('activeExperimentForStep');
-    expect(runtimeSource).not.toContain('goToStep(renderedStepId)');
-    expect(runtimeSource).toContain('goToStep(resolveNextStepId(renderedStepId');
-    expect(runtimeSource).toContain('ignoreExperiment: Boolean(activeExperimentForStep && renderedStepId === safeActiveStepId)');
-    expect(runtimeSource).toContain('if (prevId === renderedStepId)');
-  });
-});

package/template_scaffold/tests/src/runtime/use-funnel-flow-controller.test.ts

@@ -1,76 +0,0 @@
-import { describe, expect, it } from 'vitest';
-import { readFileSync } from 'node:fs';
-import { computeRenderSuspended } from '../../../src/runtime/use-funnel-flow-controller';
-
-describe('computeRenderSuspended', () => {
-  const experiments = [
-    { stepId: 'step-paywall' },
-    { stepId: 'step-headline' },
-  ];
-
-  it('renderSuspended is true when active step has experiment and posthog is not ready', () => {
-    expect(
-      computeRenderSuspended({
-        activeStepId: 'step-paywall',
-        postHogReady: false,
-        experiments,
-      }),
-    ).toBe(true);
-  });
-
-  it('renderSuspended is false when active step has no experiment', () => {
-    expect(
-      computeRenderSuspended({
-        activeStepId: 'step-intro',
-        postHogReady: false,
-        experiments,
-      }),
-    ).toBe(false);
-  });
-
-  it('renderSuspended is false after posthog becomes ready', () => {
-    expect(
-      computeRenderSuspended({
-        activeStepId: 'step-paywall',
-        postHogReady: true,
-        experiments,
-      }),
-    ).toBe(false);
-  });
-
-  it('renderSuspended is false in preview runtime even when posthog is not ready', () => {
-    expect(
-      computeRenderSuspended({
-        activeStepId: 'step-paywall',
-        postHogReady: false,
-        experiments,
-        isPreviewRuntime: true,
-      }),
-    ).toBe(false);
-  });
-});
-
-describe('qualified visitor analytics', () => {
-  it('delegates flow behavior to the shared runtime controller with template analytics', () => {
-    const source = readFileSync(new URL('../../../src/runtime/use-funnel-flow-controller.ts', import.meta.url), 'utf8');
-
-    expect(source).toContain('useFunnelFlowController as useSharedFunnelFlowController');
-    expect(source).toContain('return useSharedFunnelFlowController<FunnelStepId>({');
-    expect(source).toContain('analytics: publicAnalyticsSdk');
-    expect(source).toContain('stepContractVersion: funnelManifest.stepContractVersion');
-    expect(source).toContain('defaultStepId: defaultFunnelStepId');
-    expect(source).toContain('stepSequence: funnelStepSequence');
-    expect(source).toContain('stepById');
-    expect(source).toContain('stepComponentById');
-    expect(source).toContain('funnelExperiments');
-  });
-
-  it('does not carry a local copy of shared controller internals', () => {
-    const source = readFileSync(new URL('../../../src/runtime/use-funnel-flow-controller.ts', import.meta.url), 'utf8');
-
-    expect(source).not.toContain('FIRST_STEP_ENGAGEMENT_THRESHOLD_MS');
-    expect(source).not.toContain('apiService.bootstrapSession');
-    expect(source).not.toContain('apiService.pingUserContext');
-    expect(source).not.toContain('window.setTimeout');
-  });
-});

package/template_scaffold/tests/src/steps/paywall-checkout-options.test.ts

@@ -1,104 +0,0 @@
-import { describe, expect, it } from 'vitest';
-import {
-  buildPaywallCheckoutBillingDetails,
-  buildPaywallCheckoutExpressOptions,
-  buildPaywallCheckoutPaymentElementOptions,
-} from '../../../src/steps/paywall-checkout-options';
-
-describe('paywall checkout options', () => {
-  it('prioritizes Link and stacked express checkout buttons for the checkout dialog', () => {
-    const options = buildPaywallCheckoutExpressOptions({
-      amountCents: 3599,
-      summaryLabel: 'ClaimBee Pro · 3 Months',
-    });
-
-    expect(options.paymentMethodOrder).toEqual(['link', 'apple_pay', 'google_pay']);
-    expect(options.buttonHeight).toBe(55);
-    expect(options.layout).toEqual({
-      maxColumns: 1,
-      maxRows: 0,
-      overflow: 'never',
-    });
-    expect(options.paymentMethods).toMatchObject({
-      applePay: 'always',
-      googlePay: 'always',
-      amazonPay: 'never',
-      klarna: 'never',
-      paypal: 'never',
-    });
-    expect(options.lineItems).toEqual([
-      {
-        name: 'ClaimBee Pro · 3 Months',
-        amount: 3599,
-      },
-    ]);
-  });
-
-  it('keeps the card form focused on manual card entry while prefilling the known email', () => {
-    const options = buildPaywallCheckoutPaymentElementOptions({
-      email: 'jane@example.com',
-    });
-
-    expect(options.paymentMethodOrder).toEqual(['card']);
-    expect(options.wallets).toEqual({
-      applePay: 'never',
-      googlePay: 'never',
-      link: 'never',
-    });
-    expect(options.fields).toEqual({
-      billingDetails: {
-        address: 'if_required',
-        email: 'never',
-        name: 'never',
-        phone: 'auto',
-      },
-    });
-    expect(options.defaultValues).toEqual({
-      billingDetails: {
-        email: 'jane@example.com',
-      },
-    });
-    expect(options.layout).toEqual({
-      type: 'tabs',
-    });
-  });
-
-  it('shows the email field when the funnel has not collected one yet', () => {
-    const options = buildPaywallCheckoutPaymentElementOptions({});
-
-    expect(options.fields).toEqual({
-      billingDetails: {
-        address: 'if_required',
-        email: 'auto',
-        name: 'never',
-        phone: 'auto',
-      },
-    });
-    expect(options.defaultValues).toBeUndefined();
-  });
-
-  it('supplies hidden billing details when the checkout form omits the name field', () => {
-    expect(
-      buildPaywallCheckoutBillingDetails({
-        email: 'jane.doe@example.com',
-        name: 'Jane Doe',
-      }),
-    ).toEqual({
-      email: 'jane.doe@example.com',
-      name: 'Jane Doe',
-    });
-
-    expect(
-      buildPaywallCheckoutBillingDetails({
-        email: 'jane.doe@example.com',
-      }),
-    ).toEqual({
-      email: 'jane.doe@example.com',
-      name: 'jane doe',
-    });
-
-    expect(buildPaywallCheckoutBillingDetails({})).toEqual({
-      name: 'Customer',
-    });
-  });
-});

package/template_scaffold/tests/src/steps/shared-header-contract.test.ts

@@ -1,29 +0,0 @@
-import { readFileSync } from 'node:fs';
-import path from 'node:path';
-import { describe, expect, it } from 'vitest';
-
-const sourceStepsDirectory = path.resolve(__dirname, '../../../src/steps');
-
-const readStepSource = (fileName: string): string =>
-  readFileSync(path.resolve(sourceStepsDirectory, fileName), 'utf8');
-
-describe('template shared header contract', () => {
-  it('renders template step headers through the shared FunnelStepHeader component', () => {
-    const sharedHeaderSource = readStepSource('../components/step/FunnelStepHeader.tsx');
-
-    expect(sharedHeaderSource).toContain('export type FunnelStepHeaderProps');
-    expect(sharedHeaderSource).toContain('export function FunnelStepHeader');
-
-    const headerStepFiles = [
-      'step-01.tsx',
-      'step-02.tsx',
-      'step-04.tsx',
-    ];
-
-    headerStepFiles.forEach((fileName) => {
-      const stepSource = readStepSource(fileName);
-      expect(stepSource).toContain("from '@/components/step/FunnelStepHeader'");
-      expect(stepSource).toContain('<FunnelStepHeader');
-    });
-  });
-});

package/template_scaffold/tests/src/steps/step-01.test.ts

@@ -1,38 +0,0 @@
-import { describe, expect, it } from 'vitest';
-import { stepOneContent } from '@/steps/content/step-01.content';
-import {
-  resolveStepOneArtworkSrc,
-  resolveStepOneImportedAssetSrc,
-} from '@/steps/step-01';
-
-describe('StepOne helpers', () => {
-  it('falls back to the bundled sprite when configured artwork failed to load', () => {
-    expect(
-      resolveStepOneArtworkSrc(
-        {
-          src: 'https://example.com/missing-step-one.png',
-          alt: 'Broken step one artwork',
-        },
-        '/claimbee/steps-sprite-default.png',
-        true,
-      ),
-    ).toBe('/claimbee/steps-sprite-default.png');
-  });
-
-  it('normalizes imported sprite assets from both preview and Next runtimes', () => {
-    expect(resolveStepOneImportedAssetSrc('/claimbee/steps-sprite-default.png')).toBe(
-      '/claimbee/steps-sprite-default.png',
-    );
-    expect(resolveStepOneImportedAssetSrc({ src: '/claimbee/steps-sprite-default.png' })).toBe(
-      '/claimbee/steps-sprite-default.png',
-    );
-  });
-
-  it('ships ClaimBee-style default headline copy', () => {
-    expect(stepOneContent.locales.en.headline).toEqual([
-      'People getting',
-      'free money',
-      'know one secret',
-    ]);
-  });
-});

package/template_scaffold/tests/src/steps/step-02.test.ts

@@ -1,43 +0,0 @@
-import { readFileSync } from 'node:fs';
-import path from 'node:path';
-import { describe, expect, it } from 'vitest';
-import { stepTwoContent, stepTwoOptions } from '../../../src/steps/content/step-02.content';
-import { stepTwo } from '../../../src/steps/step-02';
-
-const stepSource = readFileSync(path.resolve(__dirname, '../../../src/steps/step-02.tsx'), 'utf8');
-
-describe('StepTwo', () => {
-  it('declares its typed multi-select answer contract and immutable option IDs', () => {
-    expect(stepTwo.choice).toEqual({
-      answerKey: 'selectedDevices',
-      allowEmpty: true,
-    });
-    expect(stepTwoOptions.map((option) => option.id)).toEqual([
-      'iphone',
-      'laptop',
-      'watch',
-      'none',
-    ]);
-    expect(Object.isFrozen(stepTwoOptions)).toBe(true);
-    expect(stepTwoOptions.every((option) => Object.isFrozen(option))).toBe(true);
-  });
-
-  it('owns explicit typed completion instead of writing choices continuously', () => {
-    expect(stepTwo.actionBar).toEqual({ hidden: true });
-    expect(stepTwoContent.locales.en.continueLabel).toBe('Continue');
-    expect(stepSource).toContain('useStepChoices(stepTwo, stepTwoOptions)');
-    expect(stepSource).toContain('<PrimaryButton');
-    expect(stepSource).toContain('{content.continueLabel}');
-    expect(stepSource).toContain('completeMulti(selectedIds)');
-    expect(stepSource).not.toContain('useEffect');
-    expect(stepSource).not.toContain('setAnswer');
-  });
-
-  it('exposes each native choice button and its selected state to assistive technology', () => {
-    expect(stepSource).toContain('role="group"');
-    expect(stepSource).not.toContain('role="list"');
-    expect(stepSource).not.toContain('role="listitem"');
-    expect(stepSource).toContain('aria-pressed={isSelected}');
-    expect(stepSource).toContain('aria-hidden="true"');
-  });
-});

package/template_scaffold/tests/src/steps/step-03.test.ts

@@ -1,15 +0,0 @@
-import { describe, expect, it } from 'vitest';
-import { resolveStepThreeAutoAdvanceMs, stepThree } from '../../../src/steps/step-03';
-
-describe('StepThree', () => {
-  it('keeps the shell action bar hidden because the step owns its own auto-advance behavior', () => {
-    expect(stepThree.actionBar).toEqual({
-      hidden: true,
-    });
-  });
-
-  it('disables auto-advance when the funnel is rendered inside builder preview', () => {
-    expect(resolveStepThreeAutoAdvanceMs(true)).toBeNull();
-    expect(resolveStepThreeAutoAdvanceMs(false)).toBe(2200);
-  });
-});

package/template_scaffold/tests/src/steps/step-04.test.ts

@@ -1,32 +0,0 @@
-import { readFileSync } from 'node:fs';
-import path from 'node:path';
-import { describe, expect, it } from 'vitest';
-import { stepFourContent } from '@/steps/content/step-04.content';
-
-describe('StepFour scratchpad', () => {
-  it('stores scratchpad and reward copy as structured editable content', () => {
-    expect(stepFourContent.locales.en.header.title).toEqual([
-      'Scratch & Unlock',
-      'Your Claim Advantage',
-    ]);
-    expect(stepFourContent.locales.en.ticket.offerLabel).toBe('50% OFF');
-    expect(stepFourContent.locales.en.reward.ctaLabel).toBe('Claim Discount →');
-  });
-
-  it('reveals the scratch ticket before advancing through the manifest edge', () => {
-    const stepSource = readFileSync(path.resolve(__dirname, '../../../src/steps/step-04.tsx'), 'utf8');
-
-    expect(stepSource).toContain("data-node-id='7390:1456'");
-    expect(stepSource).toContain("data-node-id='6992:6168'");
-    expect(stepSource).toContain('scratchThreshold');
-    expect(stepSource).not.toContain("from '@funnelsgrove/analytics'");
-    expect(stepSource).not.toContain('publicAnalyticsSdk');
-    expect(stepSource).not.toContain('trackFunnelCompleted');
-    expect(stepSource).not.toContain('trackRegistrationCompleted');
-    expect(stepSource).not.toContain('.flush()');
-    // Manifest edges own routing (step-4 -> email-capture -> paywall);
-    // the CTA must not hardcode a jump past email capture.
-    expect(stepSource).toContain('goNext()');
-    expect(stepSource).not.toContain('goToStep(stepPaywallId)');
-  });
-});

package/template_scaffold/tests/src/steps/step-31-email-capture.test.ts

@@ -1,22 +0,0 @@
-import { readFileSync } from 'node:fs';
-import { describe, expect, it } from 'vitest';
-
-describe('email capture workflow ownership', () => {
-  it('only validates UI state and calls the shared context helper', () => {
-    const source = readFileSync(new URL('../../../src/steps/step-31-email-capture.tsx', import.meta.url), 'utf8');
-
-    expect(source).toContain('submitEmailCapture } = useFunnel();');
-    expect(source).toContain('await submitEmailCapture(email);');
-    expect(source.match(/submitEmailCapture\(email\)/g)).toHaveLength(1);
-
-    expect(source).not.toContain('apiService');
-    expect(source).not.toContain('publicAnalyticsSdk');
-    expect(source).not.toContain('trackLead');
-    expect(source).not.toContain('trackEmailCaptured');
-    expect(source).not.toContain('metaPixel');
-    expect(source).not.toContain('googleTag');
-    expect(source).not.toContain('stepPaywallId');
-    expect(source).not.toContain('goToStep');
-    expect(source).not.toContain('/sdk/public/users/email-capture');
-  });
-});