@funnelsgrove/cli 0.1.20 → 0.1.24

package/dist/localSync.d.ts

@@ -17,6 +17,10 @@ export type SourceFile = {
     contentType?: string;
     contentEncoding?: 'base64';
 };
+export type SafeRootWriteHooks = {
+    beforeDirectoryCreate?: (relativeDirectoryPath: string) => void | Promise<void>;
+    afterDirectoryEntrySync?: (relativeDirectoryPath: string) => void | Promise<void>;
+};
 export type ChangedSourceFiles = {
     currentManifest: SyncManifest;
     deletedPaths: string[];
@@ -80,7 +84,11 @@ export type SyncDownLocalLifecycle = {
     writeSyncState: () => Promise<unknown>;
 };
 export declare function runSyncDownLocalLifecycle(lifecycle: SyncDownLocalLifecycle): Promise<void>;
+export declare const assertSafeRootFileWriteTarget: (rootDir: string, relativePath: string) => Promise<void>;
+export declare const readSafeRootFile: (rootDir: string, relativePath: string) => Promise<Buffer>;
+export declare const writeSafeRootFile: (rootDir: string, relativePath: string, content: string | Buffer, hooks?: SafeRootWriteHooks) => Promise<void>;
 export declare function normalizeSyncPath(filePath: string): string;
+export declare function assertSafeSyncPath(filePath: string): string;
 export declare function shouldSyncFile(filePath: string): boolean;
 export declare function buildSyncManifest(rootDir: string, input: SyncManifestInput): Promise<SyncManifest>;
 export declare function buildCommittedSyncManifest(input: {

package/dist/localSync.js

@@ -60,28 +60,83 @@ const resolveSafeRoot = async (rootDir, create) => {
     }
     return realpath(rootDir);
 };
-const assertSafeExistingPath = async (rootDir, relativePath, createParents) => {
-    const safePath = assertSafeSyncPath(relativePath);
-    const segments = safePath.split('/');
+const syncDirectory = async (directoryPath) => {
+    const handle = await open(directoryPath, constants.O_RDONLY);
+    try {
+        await handle.sync();
+    }
+    finally {
+        await handle.close();
+    }
+};
+const ensureDurableDirectoryChain = async (rootDir, segments, hooks) => {
     let current = rootDir;
-    for (const segment of segments.slice(0, -1)) {
+    for (const [index, segment] of segments.entries()) {
+        const parent = current;
         current = path.join(current, segment);
         let metadata;
         try {
             metadata = await lstat(current);
         }
         catch (error) {
-            if (!createParents || !isErrno(error, 'ENOENT'))
+            if (!isErrno(error, 'ENOENT'))
                 throw error;
-            await mkdir(current);
+            const relativeDirectoryPath = segments.slice(0, index + 1).join('/');
+            await hooks.beforeDirectoryCreate?.(relativeDirectoryPath);
+            try {
+                await mkdir(current);
+            }
+            catch (mkdirError) {
+                if (!isErrno(mkdirError, 'EEXIST'))
+                    throw mkdirError;
+            }
             metadata = await lstat(current);
+            if (metadata.isSymbolicLink() || !metadata.isDirectory()) {
+                throw sourceCandidateInvariantError(`Local sync path traverses a symlink: ${relativeDirectoryPath}`);
+            }
+            await syncDirectory(parent);
+            await hooks.afterDirectoryEntrySync?.(relativeDirectoryPath);
+            continue;
         }
         if (metadata.isSymbolicLink() || !metadata.isDirectory()) {
-            throw sourceCandidateInvariantError(`Local sync path traverses a symlink: ${relativePath}`);
+            throw sourceCandidateInvariantError(`Local sync path traverses a symlink: ${segments.join('/')}`);
+        }
+    }
+};
+const assertSafeExistingPath = async (rootDir, relativePath, createParents, allowMissingParents = false, hooks = {}) => {
+    const safePath = assertSafeSyncPath(relativePath);
+    const segments = safePath.split('/');
+    let parentIsMissing = false;
+    const parentSegments = segments.slice(0, -1);
+    if (createParents) {
+        await ensureDurableDirectoryChain(rootDir, parentSegments, hooks);
+    }
+    else {
+        let current = rootDir;
+        for (const segment of parentSegments) {
+            current = path.join(current, segment);
+            if (parentIsMissing)
+                continue;
+            let metadata;
+            try {
+                metadata = await lstat(current);
+            }
+            catch (error) {
+                if (allowMissingParents && isErrno(error, 'ENOENT')) {
+                    parentIsMissing = true;
+                    continue;
+                }
+                throw error;
+            }
+            if (metadata.isSymbolicLink() || !metadata.isDirectory()) {
+                throw sourceCandidateInvariantError(`Local sync path traverses a symlink: ${relativePath}`);
+            }
         }
     }
     const absolutePath = path.join(rootDir, ...segments);
     assertContainedPath(rootDir, absolutePath);
+    if (parentIsMissing)
+        return absolutePath;
     try {
         const metadata = await lstat(absolutePath);
         if (metadata.isSymbolicLink() || !metadata.isFile()) {
@@ -94,6 +149,10 @@ const assertSafeExistingPath = async (rootDir, relativePath, createParents) => {
     }
     return absolutePath;
 };
+export const assertSafeRootFileWriteTarget = async (rootDir, relativePath) => {
+    const resolvedRoot = await resolveSafeRoot(rootDir, false);
+    await assertSafeExistingPath(resolvedRoot, relativePath, false, true);
+};
 const assertOpenFileContained = async (rootDir, absolutePath, opened) => {
     const openedStat = await opened.stat();
     if (!openedStat.isFile()) {
@@ -106,7 +165,7 @@ const assertOpenFileContained = async (rootDir, absolutePath, opened) => {
         throw sourceCandidateInvariantError('Local source changed while opening it. Retry the sync.');
     }
 };
-const readSafeRootFile = async (rootDir, relativePath) => {
+export const readSafeRootFile = async (rootDir, relativePath) => {
     const resolvedRoot = await resolveSafeRoot(rootDir, false);
     const absolutePath = await assertSafeExistingPath(resolvedRoot, relativePath, false);
     let handle;
@@ -127,9 +186,9 @@ const readSafeRootFile = async (rootDir, relativePath) => {
         await handle.close();
     }
 };
-const writeSafeRootFile = async (rootDir, relativePath, content) => {
+export const writeSafeRootFile = async (rootDir, relativePath, content, hooks = {}) => {
     const resolvedRoot = await resolveSafeRoot(rootDir, true);
-    const absolutePath = await assertSafeExistingPath(resolvedRoot, relativePath, true);
+    const absolutePath = await assertSafeExistingPath(resolvedRoot, relativePath, true, false, hooks);
     const tempPath = path.join(path.dirname(absolutePath), `.${path.basename(absolutePath)}.fgrove-${randomUUID()}.tmp`);
     let handle = null;
     try {
@@ -141,6 +200,7 @@ const writeSafeRootFile = async (rootDir, relativePath, content) => {
         handle = null;
         await assertSafeExistingPath(resolvedRoot, relativePath, true);
         await rename(tempPath, absolutePath);
+        await syncDirectory(path.dirname(absolutePath));
         assertContainedPath(resolvedRoot, await realpath(absolutePath));
     }
     finally {
@@ -154,7 +214,7 @@ export function normalizeSyncPath(filePath) {
     return normalized.replace(/^(\.\/|\/)+/, '');
 }
 const sourceCandidateInvariantError = (reason) => Object.assign(new Error(reason), { code: 'FG-CANDIDATE-001' });
-function assertSafeSyncPath(filePath) {
+export function assertSafeSyncPath(filePath) {
     if (filePath.length === 0
         || Array.from(filePath).length > MAX_SOURCE_CANDIDATE_PATH_CHARACTERS
         || filePath !== filePath.trim()

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@funnelsgrove/cli",
-  "version": "0.1.20",
+  "version": "0.1.24",
   "description": "FunnelsGrove command-line tools for editing, syncing, and publishing funnels",
   "type": "module",
   "bin": {

package/template_docs/.funnelsgrove-docs.json

@@ -1,6 +1,6 @@
 {
   "schemaVersion": 1,
-  "bundleVersion": "2.0.8",
+  "bundleVersion": "2.0.12",
   "stepContractVersion": 3,
   "contractHash": "d761e91d5ac6ff9e72c6d49c5bcd014270912473a66f99c49d726c65998085cf",
   "managedFiles": [
@@ -38,7 +38,7 @@
     },
     {
       "path": "docs/funnelsgrove/migrations/step-contract-v3.md",
-      "sha256": "963e849027819a4b924ea0af2a09e23c610b838125477bd3a79d104cdbda3d8d"
+      "sha256": "2a25df4203ff0ca8a8532a22bdb5c11ab687b00b369894e3a3376caa378028d7"
     },
     {
       "path": "docs/funnelsgrove/qa/analytics.md",
@@ -58,7 +58,7 @@
     },
     {
       "path": "docs/funnelsgrove/recipes/add-experiment.md",
-      "sha256": "832b4331d6690d0596800c5aeb969f608dd62cf63d9ae527054e832fb60f8abd"
+      "sha256": "9918b577f47a9577c3c98d9a6a7a8762ddfeedb667efe13000900d1a1daee1f9"
     },
     {
       "path": "docs/funnelsgrove/recipes/add-step.md",
@@ -138,7 +138,7 @@
     },
     {
       "path": "funnel-docs.config.json",
-      "sha256": "734116ac17d631bcf7b5e34b2cf58097aef7952a36b47f3bd7f0533223ff4ed2"
+      "sha256": "06ea750a825821a578161e287b01388d229ec1c82e3c2fbc956a7e57a0c3888d"
     }
   ]
 }

package/template_docs/docs/funnelsgrove/migrations/step-contract-v3.md

@@ -17,7 +17,7 @@ Supported read versions: `1`, `2`, `3`. Authoring and publish target version `3`
 
 ### Package release order
 
-Release `@funnelsgrove/runtime` `0.1.60` first, then `@funnelsgrove/analytics` `0.1.37`, then `@funnelsgrove/cli` `0.1.20`. Deploy the API and funnel template only after those registry versions are available. Publishing packages and deploying production remain separately approved operational actions.
+Release `@funnelsgrove/runtime` `0.1.60` first, then `@funnelsgrove/analytics` `0.1.37`, then `@funnelsgrove/cli` `0.1.24`. Deploy the API and funnel template only after those registry versions are available. Publishing packages and deploying production remain separately approved operational actions.
 <!-- funnelsgrove:generated:end contract-v3/migration/step-contract-v3 -->
 
 ## Version-last policy

package/template_docs/docs/funnelsgrove/recipes/add-experiment.md

@@ -19,13 +19,162 @@ Contract hash: `d761e91d5ac6ff9e72c6d49c5bcd014270912473a66f99c49d726c65998085cf
 
 ## Procedure
 
-1. Build and validate every control/variant step before activation.
-2. Give each variant a stable, contract-compliant identity and normal outgoing edge.
-3. Create the experiment through FunnelsGrove so the platform owns the database row, feature flag, and generated experiment snapshot.
-4. Keep variant keys, labels, traffic percentages, source step, and route targets aligned.
-5. Resolve assignment and any redirect before creating the destination step visit.
-6. Keep the default flow valid when the experiment is stopped or assignment is unavailable.
-7. Run experiment-focused tests, then `fgrove validate`.
+1. Start in a synced funnel checkout and run `fgrove status` and `git status --short`.
+2. Build the control and variant steps or offer sets in the same local change.
+3. Save one of the strict JSON specs below as `experiment.json`.
+4. Create the database draft, hosted snapshot, and matching local generated files:
+
+   ```bash
+   fgrove experiments create --spec experiment.json --dir .
+   ```
+
+   For machine-readable output, run `fgrove experiments create --spec experiment.json --dir . --json`. It emits only `experimentId`, `experimentKey`, `draftVersionId`, and `writtenPaths`, with generated paths in canonical order.
+5. Resolve assignment and any redirect before creating the destination step visit. Keep the default flow valid when assignment is stopped, missing, or invalid.
+6. Run experiment-focused tests and `fgrove validate`, then follow the delivery path below.
+
+## JSON contract
+
+Use only the documented fields. Unknown top-level and variant fields are rejected.
+
+All experiment types require non-empty `id`, `name`, and `stepId`; one `primaryMetric`; at least one unique `trackedMetrics` entry containing the primary metric; and two to five variants. Each variant requires a unique non-empty `variantKey`, `label`, and `routeToStepId`, an integer `trafficPercent` from 0 through 100, and `isControl`. Exactly one variant is the control and traffic must total 100.
+
+Length limits are enforced after surrounding whitespace is trimmed: `variantKey` is at most 120 characters. `id`, `name`, `stepId`, `label`, `routeToStepId`, and `offerSetKey` are each at most 200 characters after trimming. `offerSetKey` applies only to pricing variants.
+
+Metrics are exactly `step_completion`, `next_step_reached`, `checkout_opened`, `funnel_completed`, or `paying_customer`.
+
+### Step experiment
+
+Every variant routes to the step that implements that experience.
+
+```json
+{
+  "id": "claim-headline-v1",
+  "name": "Claim headline experiment",
+  "type": "step",
+  "stepId": "claim",
+  "primaryMetric": "next_step_reached",
+  "trackedMetrics": [
+    "next_step_reached",
+    "funnel_completed"
+  ],
+  "variants": [
+    {
+      "variantKey": "control",
+      "label": "Control",
+      "routeToStepId": "claim",
+      "trafficPercent": 50,
+      "isControl": true
+    },
+    {
+      "variantKey": "variant_b",
+      "label": "Variant B",
+      "routeToStepId": "claim-b",
+      "trafficPercent": 50,
+      "isControl": false
+    }
+  ]
+}
+```
+
+### Paywall experiment
+
+Like `step`, every variant has a route target. Use `type: "paywall"` when the routes select complete paywall step variants.
+
+```json
+{
+  "id": "paywall-layout-v1",
+  "name": "Paywall layout experiment",
+  "type": "paywall",
+  "stepId": "paywall-entry",
+  "primaryMetric": "checkout_opened",
+  "trackedMetrics": [
+    "checkout_opened",
+    "paying_customer"
+  ],
+  "variants": [
+    {
+      "variantKey": "control",
+      "label": "Control",
+      "routeToStepId": "paywall-control",
+      "trafficPercent": 50,
+      "isControl": true
+    },
+    {
+      "variantKey": "compact",
+      "label": "Compact",
+      "routeToStepId": "paywall-compact",
+      "trafficPercent": 50,
+      "isControl": false
+    }
+  ]
+}
+```
+
+### Pricing experiment
+
+Each pricing variant also requires a non-empty `offerSetKey`, and every `routeToStepId` must exactly equal the top-level `stepId`.
+
+```json
+{
+  "id": "paywall-price-v1",
+  "name": "Paywall pricing experiment",
+  "type": "pricing",
+  "stepId": "paywall",
+  "primaryMetric": "paying_customer",
+  "trackedMetrics": [
+    "checkout_opened",
+    "paying_customer"
+  ],
+  "variants": [
+    {
+      "variantKey": "control",
+      "label": "Control",
+      "routeToStepId": "paywall",
+      "trafficPercent": 50,
+      "isControl": true,
+      "offerSetKey": "default-paywall"
+    },
+    {
+      "variantKey": "annual_focus",
+      "label": "Annual focus",
+      "routeToStepId": "paywall",
+      "trafficPercent": 50,
+      "isControl": false,
+      "offerSetKey": "annual-focus"
+    }
+  ]
+}
+```
+
+## Creation guarantees
+
+The stable `id` becomes the experiment key. Keep it unchanged for an exact retry: an identical same-key draft is reused, while a different definition or non-draft experiment is rejected rather than overwritten.
+
+Creation always produces a draft. It does not create or activate a PostHog flag, start traffic, or make unfinished variant steps or offer sets runnable. Activation remains a separate pre-activation UI/API action.
+
+The API creates the experiment and variants atomically, commits the matching generated snapshot to the hosted draft, and only then returns. The draft is immediately visible in the FunnelsGrove UI and hosted previews use the same snapshot. The CLI installs the exact returned bytes at `src/config/experiments.generated.ts` and `src/config/experiments.ts`, then updates the sync manifest last. `.funnelsgrove-sync.json` stays local and ignored; never commit or push it.
+
+## Recovery and errors
+
+- Missing `.funnelsgrove-sync.json`: run `fgrove sync down` into a clean directory first.
+- Invalid local JSON or `[FG-EXPERIMENT-SPEC]`: fix the reported field and retry with the same stable `id`.
+- `[FG-EXPERIMENT-STALE-DRAFT]`: do not overwrite remote work. Download the latest draft into a clean temporary directory, merge deliberately, rerun validation, and retry the same exact spec.
+- `[FG-EXPERIMENT-DRAFT-CONFLICT]`: the stable key already belongs to a different definition, owner, or lifecycle state. Reuse the original exact definition for a retry, or choose a new stable `id` only for a genuinely new experiment.
+- Locally changed generated experiment files are never overwritten. Resolve those edits before retrying.
+- If the API succeeded but the process stopped, retry safely with the same `id`. A ready local journal is automatically recovered before the next create or sync command; an interruption before the journal simply repeats the exact API request.
+
+## Validate and deliver
+
+After implementing all referenced variant steps or offer sets, run:
+
+```bash
+fgrove validate
+git status --short
+```
+
+For a funnel without GitHub source sync, deliver all local source changes with `fgrove sync up`.
+
+For a GitHub-connected funnel, commit and push the generated source files with the rest of the source change, then run `fgrove github pull`. Never use `fgrove sync up` for the same GitHub-connected diff, and never add `.funnelsgrove-sync.json` to git.
 
 ## Pre-activation QA
 

package/template_docs/funnel-docs.config.json

@@ -1,6 +1,6 @@
 {
   "schemaVersion": 1,
-  "bundleVersion": "2.0.8",
+  "bundleVersion": "2.0.12",
   "contractSource": "funnelsgrove-repository://apps/funnel-runtime/contracts/step-contract-v2.json",
   "fullyGenerated": [
     ".funnelsgrove-docs.json",

package/template_scaffold/.funnelsgrove-docs.json

@@ -1,6 +1,6 @@
 {
   "schemaVersion": 1,
-  "bundleVersion": "2.0.8",
+  "bundleVersion": "2.0.12",
   "stepContractVersion": 3,
   "contractHash": "d761e91d5ac6ff9e72c6d49c5bcd014270912473a66f99c49d726c65998085cf",
   "managedFiles": [
@@ -38,7 +38,7 @@
     },
     {
       "path": "docs/funnelsgrove/migrations/step-contract-v3.md",
-      "sha256": "963e849027819a4b924ea0af2a09e23c610b838125477bd3a79d104cdbda3d8d"
+      "sha256": "2a25df4203ff0ca8a8532a22bdb5c11ab687b00b369894e3a3376caa378028d7"
     },
     {
       "path": "docs/funnelsgrove/qa/analytics.md",
@@ -58,7 +58,7 @@
     },
     {
       "path": "docs/funnelsgrove/recipes/add-experiment.md",
-      "sha256": "832b4331d6690d0596800c5aeb969f608dd62cf63d9ae527054e832fb60f8abd"
+      "sha256": "9918b577f47a9577c3c98d9a6a7a8762ddfeedb667efe13000900d1a1daee1f9"
     },
     {
       "path": "docs/funnelsgrove/recipes/add-step.md",
@@ -138,7 +138,7 @@
     },
     {
       "path": "funnel-docs.config.json",
-      "sha256": "734116ac17d631bcf7b5e34b2cf58097aef7952a36b47f3bd7f0533223ff4ed2"
+      "sha256": "06ea750a825821a578161e287b01388d229ec1c82e3c2fbc956a7e57a0c3888d"
     }
   ]
 }

package/template_scaffold/.funnelsgrove-scaffold.json

@@ -1,8 +1,8 @@
 {
   "schemaVersion": 1,
-  "sourceTreeHash": "ca100df73c90d718c52c88dc94b92711f81d67f94ddaedcacb42ed3fd8cbaf48",
+  "sourceTreeHash": "c0e2831fa5a499fd8cc19324fedad962893285e153db3b4b4045fc69a0dd24d8",
   "stepContractVersion": 3,
-  "docsBundleVersion": "2.0.8",
+  "docsBundleVersion": "2.0.12",
   "files": [
     {
       "path": ".env.example",
@@ -16,7 +16,7 @@
     },
     {
       "path": ".funnelsgrove-docs.json",
-      "sha256": "a1ef27f92c6ea53137c92f994e11262f5c5412067f70d2b671163845929ea8c6",
+      "sha256": "e0b5bc7753b86eaeec74c93bf489bc12121c63aefafbbeb716f524710c058b77",
       "mode": "100644"
     },
     {
@@ -101,7 +101,7 @@
     },
     {
       "path": "docs/funnelsgrove/migrations/step-contract-v3.md",
-      "sha256": "963e849027819a4b924ea0af2a09e23c610b838125477bd3a79d104cdbda3d8d",
+      "sha256": "2a25df4203ff0ca8a8532a22bdb5c11ab687b00b369894e3a3376caa378028d7",
       "mode": "100644"
     },
     {
@@ -126,7 +126,7 @@
     },
     {
       "path": "docs/funnelsgrove/recipes/add-experiment.md",
-      "sha256": "832b4331d6690d0596800c5aeb969f608dd62cf63d9ae527054e832fb60f8abd",
+      "sha256": "9918b577f47a9577c3c98d9a6a7a8762ddfeedb667efe13000900d1a1daee1f9",
       "mode": "100644"
     },
     {
@@ -236,12 +236,12 @@
     },
     {
       "path": "funnel-agent-docs.test.ts",
-      "sha256": "bdc5f58e6ab453230e62868cd30e90f38a8e54d5a46c5f8661845a52fcf399ac",
+      "sha256": "f7e3fac8d570ed4d34965c8d8a5a631ab712c4f8df5452fb0882ebd9828cd836",
       "mode": "100644"
     },
     {
       "path": "funnel-docs.config.json",
-      "sha256": "734116ac17d631bcf7b5e34b2cf58097aef7952a36b47f3bd7f0533223ff4ed2",
+      "sha256": "06ea750a825821a578161e287b01388d229ec1c82e3c2fbc956a7e57a0c3888d",
       "mode": "100644"
     },
     {
@@ -266,12 +266,12 @@
     },
     {
       "path": "package-lock.json",
-      "sha256": "65080a7b1c2b623560cc03d46f8ad704998cf1098da6a4937aa82be0d9fd1603",
+      "sha256": "e3d6430705410764cb7a012befd1582a78f8e8269848fad9be44c3c66c4b58e7",
       "mode": "100644"
     },
     {
       "path": "package.json",
-      "sha256": "baf56567c056e658a39bef00292831208a9b65d17c7efe587d9d35483a3ece10",
+      "sha256": "f7fe244b5bc7b6449d27d048761c973f2825b0b4dba3dd931b4aa31bd523df77",
       "mode": "100644"
     },
     {

package/template_scaffold/docs/funnelsgrove/migrations/step-contract-v3.md

@@ -17,7 +17,7 @@ Supported read versions: `1`, `2`, `3`. Authoring and publish target version `3`
 
 ### Package release order
 
-Release `@funnelsgrove/runtime` `0.1.60` first, then `@funnelsgrove/analytics` `0.1.37`, then `@funnelsgrove/cli` `0.1.20`. Deploy the API and funnel template only after those registry versions are available. Publishing packages and deploying production remain separately approved operational actions.
+Release `@funnelsgrove/runtime` `0.1.60` first, then `@funnelsgrove/analytics` `0.1.37`, then `@funnelsgrove/cli` `0.1.24`. Deploy the API and funnel template only after those registry versions are available. Publishing packages and deploying production remain separately approved operational actions.
 <!-- funnelsgrove:generated:end contract-v3/migration/step-contract-v3 -->
 
 ## Version-last policy