@fungi.computer/bonsai 0.0.1 → 0.2.0

package/test/storyboard-save-template.test.mjs

@@ -1,10 +1,16 @@
 import assert from "node:assert/strict";
 import { Buffer } from "node:buffer";
-import { spawn } from "node:child_process";
-import { execFile } from "node:child_process";
+import { execFile, spawn } from "node:child_process";
 import { dirname, join } from "node:path";
 import { DatabaseSync } from "node:sqlite";
-import { mkdir, mkdtemp, readFile, rm, writeFile } from "node:fs/promises";
+import {
+  mkdir,
+  mkdtemp,
+  readFile,
+  readdir,
+  rm,
+  writeFile,
+} from "node:fs/promises";
 import { tmpdir } from "node:os";
 import process from "node:process";
 import { test } from "node:test";
@@ -24,7 +30,7 @@ import {
 // Shed's, Prints', Inkcap's and Bonsai's sources are pinned at runtime only;
 // Bonsai's compiler options do not own them.
 import { buildAppApi } from "@fungi.computer/agar/backend-declaration";
-import { mintComputerProcessId } from "@fungi.computer/computer/operations";
+import { mintComputerProcessId } from "@fungi.computer/computer-contract";
 import { appBackend as bonsaiBackend } from "../backend/methods.ts";
 import { appBackend as shedBackend } from "../../shed/backend/methods.ts";
 import { createShedRuns } from "../../shed/backend/runs.ts";
@@ -37,6 +43,50 @@ import {
 
 const execFileAsync = promisify(execFile);
 
+for (const startupFails of [false, true]) {
+  test(`HTTPS Git fixture removes certificate files after ${startupFails ? "startup failure" : "server close"}`, async (t) => {
+    const work = await mkdtemp(
+      join(tmpdir(), "storyboard-save-fixture-check-"),
+    );
+    t.after(() => rm(work, { recursive: true, force: true }));
+    const scratch = join(work, "tmp");
+    await mkdir(scratch);
+    const fixture = new URL(
+      "./storyboard-save-https-git.fixture.mjs",
+      import.meta.url,
+    );
+    const env = {
+      ...process.env,
+      HOME: work,
+      TMPDIR: scratch,
+      TMP: scratch,
+      TEMP: scratch,
+    };
+    if (startupFails) env.OPENSSL_CONF = join(work, "missing-openssl.cnf");
+    // tmpdir() is process-local. Give the real producer its own environment,
+    // rather than changing the test runner's environment or mocking openssl.
+    await execFileAsync(
+      process.execPath,
+      [
+        "--input-type=module",
+        "--eval",
+        `
+        import assert from "node:assert/strict";
+        import { startHttpsGitServer } from ${JSON.stringify(fixture.href)};
+        const startup = startHttpsGitServer(${JSON.stringify(work)});
+        ${
+          startupFails
+            ? "await assert.rejects(startup, { status: 1 });"
+            : "const server = await startup; await server.close();"
+        }
+      `,
+      ],
+      { env },
+    );
+    assert.deepEqual(await readdir(scratch), []);
+  });
+}
+
 async function readTemplate(name) {
   const template = z
     .object({ definition: z.json() })
@@ -192,7 +242,13 @@ test("the Save to git flow runs through Shed's real run handler and Inkcap's rea
         procs.set(id, record);
         const child = spawn("bash", ["-c", localCommand], {
           cwd: cwd ? localize(cwd) : undefined,
-          env: { ...process.env, GIT_SSL_NO_VERIFY: "true" },
+          // The trusted host supplies the Git remote after admission; Shed
+          // and its command carry no credential.
+          env: {
+            ...process.env,
+            GIT_SSL_NO_VERIFY: "true",
+            FUNGI_GIT_REMOTE: remote,
+          },
         });
         let stderr = "";
         child.stderr.on("data", (chunk) => {
@@ -209,13 +265,6 @@ test("the Save to git flow runs through Shed's real run handler and Inkcap's rea
       processes() {
         return Promise.resolve({ processes: [...procs.values()] });
       },
-      workflowGitPass() {
-        return Promise.resolve({
-          passId: "pass_test",
-          remote,
-          expiresAt: Date.now() + 300000,
-        });
-      },
       async write({ path, content }) {
         const target = localize(path);
         await mkdir(dirname(target), { recursive: true });

package/vite.config.ts

@@ -2,12 +2,30 @@ import { fileURLToPath } from "node:url";
 import tailwindcss from "@tailwindcss/vite";
 import react from "@vitejs/plugin-react";
 import { defineConfig } from "vite";
+import { fungiFaviconHref } from "@fungi.computer/sigils/favicon";
 
 export default defineConfig({
   envDir: false,
   base: "./",
   root: fileURLToPath(new URL("./web", import.meta.url)),
-  plugins: [react(), tailwindcss()],
+  plugins: [
+    react(),
+    tailwindcss(),
+    {
+      name: "fungi-favicon",
+      transformIndexHtml: () => [
+        {
+          tag: "link",
+          attrs: {
+            rel: "icon",
+            type: "image/svg+xml",
+            href: fungiFaviconHref,
+          },
+          injectTo: "head",
+        },
+      ],
+    },
+  ],
   build: {
     target: "es2022",
     outDir: fileURLToPath(new URL("./.botanical/web", import.meta.url)),

package/vitest.config.ts

@@ -1,5 +1,47 @@
 import { defineConfig } from "vitest/config";
 
+/**
+ * These files drive real `git` subprocesses (init, http-backend pushes, clones,
+ * plumbing reads) through Agar's real-Git test kit. Each Git spawn costs a few
+ * milliseconds idle and tens under CI load, so a test that is about 1 s on an
+ * idle box crosses the 5 s default when the gate runs at several times
+ * oversubscription. They get their own project and timeout; the fast unit
+ * tests keep Vitest's default.
+ */
+const realGit = [
+  "test/background-runtime.test.ts",
+  "test/changes.test.ts",
+  "test/file-edits.test.ts",
+  "test/files-read-copy-calls.test.ts",
+  "test/graph-commit-read-copy-calls.test.ts",
+  "test/merge-background.test.ts",
+  "test/merge-conflict.test.ts",
+  "test/merge-repro.test.ts",
+  "test/read-copy-composer.test.ts",
+  "test/read-copy-lifetimes.test.ts",
+  "test/repository-deletion.test.ts",
+];
+
 export default defineConfig({
-  test: { include: ["test/**/*.test.ts"], environment: "node" },
+  test: {
+    projects: [
+      {
+        test: {
+          name: "unit",
+          include: ["test/**/*.test.ts"],
+          exclude: realGit,
+          environment: "node",
+        },
+      },
+      {
+        test: {
+          name: "real-git",
+          include: realGit,
+          environment: "node",
+          testTimeout: 30_000,
+          hookTimeout: 30_000,
+        },
+      },
+    ],
+  },
 });

package/web/app-build-panel.tsx

@@ -1,6 +1,19 @@
+import { replayKey } from "@fungi.computer/cairn";
 import { useState } from "react";
-import { useMutation, useQuery } from "@tanstack/react-query";
+import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
+import * as S from "effect/Schema";
 import { z } from "zod";
+import { workflowDefinitionSchema } from "@fungi.computer/braid";
+import { runReply } from "@fungi.computer/workflows-wire";
+import {
+  RunTimeline,
+  OutputError,
+  runStatusSchema,
+  runSteps,
+  terminal,
+  timelineItems,
+} from "@fungi.computer/trellis/run-timeline";
+import template from "@fungi.computer/trellis/templates/bonsai-build-on-merge" with { type: "json" };
 import { Button } from "@fungi.computer/caps/components/button";
 import {
   Card,
@@ -10,57 +23,83 @@ import {
 } from "@fungi.computer/caps/components/card";
 import { Input } from "@fungi.computer/caps/components/input";
 import { pendingSchema } from "@fungi.computer/agar";
-import { appBuildView, jsonValue } from "../shared/contract.js";
+import { appBuildView, appRegistration } from "../shared/contract.js";
 import { callMethod } from "./transport.js";
 
-// The panel sends the Release back to apps.install as JSON.
-const buildView = appBuildView.extend({ release: jsonValue.nullable() });
-// While the job runs, apps.buildStatus answers Agar Pending.
-const buildStatus = z.union([pendingSchema, buildView]);
-
-/** Start a build of a registered App's source, then install or switch its
- * Release once it finishes. Owner only; the host re-checks that on every call. */
-export function AppBuildPanel() {
-  const [appId, setAppId] = useState("");
-  const [sourceRevision, setSourceRevision] = useState("");
-  const [installationId, setInstallationId] = useState("");
-  const [jobId, setJobId] = useState<string | null>(null);
+const buildStatus = z.union([pendingSchema, appBuildView]).nullable();
+const definition = S.decodeUnknownSync(workflowDefinitionSchema)(
+  template.definition,
+);
+const appDisplay = { app_bonsai: { displayName: "Bonsai", icon: "bonsai" } };
 
-  const build = useMutation({
-    mutationFn: () =>
-      callMethod("apps.build", { appId, sourceRevision }, buildView),
-    onSuccess: (job) => {
-      setJobId(job.jobId);
-    },
-  });
+/** Both this owner action and accepted main pushes start the same Workflow.
+ * Only its host-attested install step selects a Release; the panel never does. */
+export function AppBuildPanel({ repo }: { repo: string }) {
+  const queryClient = useQueryClient();
+  const [appId, setAppId] = useState<string | null>(null);
+  const [sourceRevision, setSourceRevision] = useState<string | null>(null);
+  const [installationId, setInstallationId] = useState<string | null>(null);
+  const [runId, setRunId] = useState<string | null>(null);
+  const statusKey = ["apps.buildStatus", repo];
   const status = useQuery({
-    queryKey: ["apps.buildStatus", jobId],
+    queryKey: statusKey,
+    queryFn: () => callMethod("apps.buildStatus", { repo }, buildStatus),
+    refetchInterval: 5000,
+  });
+  const settled =
+    status.data == null || "kind" in status.data ? null : status.data;
+  const selectedAppId = appId ?? settled?.appId ?? "";
+  const selectedRevision = sourceRevision ?? settled?.sourceRevision ?? "";
+  const selectedInstallationId = installationId ?? repo;
+  const run = useQuery({
+    queryKey: ["apps.buildWorkflowRun", runId],
+    enabled: runId !== null,
     queryFn: () => {
-      if (jobId === null) throw new Error("No build job to check yet");
-      return callMethod("apps.buildStatus", { jobId }, buildStatus);
+      if (runId === null) throw new Error("No Workflow run selected");
+      return callMethod("apps.buildWorkflowRun", { runId }, runStatusSchema);
     },
-    enabled: jobId !== null,
     refetchInterval: (query) =>
-      query.state.data === undefined || "kind" in query.state.data
-        ? 3_000
-        : false,
+      query.state.data !== undefined &&
+      (query.state.data.outcome !== "active" ||
+        terminal(query.state.data.status))
+        ? false
+        : 2000,
   });
-  const settled =
-    status.data === undefined || "kind" in status.data ? null : status.data;
-  const install = useMutation({
-    mutationFn: () => {
-      const release = settled?.release;
-      if (release === null || release === undefined)
-        throw new Error("This build has no Release yet");
-      return callMethod(
-        "apps.install",
-        { installationId, release },
-        z.unknown(),
+  const build = useMutation({
+    mutationFn: async () => {
+      const started = await callMethod(
+        "apps.startBuildWorkflow",
+        {
+          repo,
+          sourceRevision: selectedRevision,
+          installationId: selectedInstallationId,
+          requestId: replayKey(),
+        },
+        runReply,
       );
+      if (
+        !("kind" in started) ||
+        (started.kind !== "started" && started.kind !== "replay")
+      )
+        throw new Error("Build Workflow refused: " + JSON.stringify(started));
+      return started;
+    },
+    onSuccess: (started) => {
+      setRunId(started.runId);
     },
   });
-
-  const release = settled?.release ?? null;
+  const registration = useMutation({
+    mutationFn: () => callMethod("apps.register", { repo }, appRegistration),
+    onSuccess: (registered) => {
+      setAppId(registered.appId);
+      setSourceRevision(registered.sourceRevision);
+      setInstallationId(repo);
+      setRunId(null);
+      queryClient.setQueryData(statusKey, null);
+      build.reset();
+    },
+  });
+  const busy = build.isPending || registration.isPending;
   return (
     <Card className="w-full max-w-2xl" variant="outline">
       <CardHeader>
@@ -68,27 +107,45 @@ export function AppBuildPanel() {
       </CardHeader>
       <CardContent className="flex flex-col gap-4">
         <p className="text-sm text-[var(--stipe-fg-muted)]">
-          Build a registered App&rsquo;s source at one exact commit on this
-          Oyster&rsquo;s Computer, then install the Release, or switch an
-          already-live installation onto it. Only the owner may do this.
+          Register the committed App recipe, then start the Workflow to build,
+          verify and install your chosen revision. Its steps report what
+          actually happened. Only the owner may do this.
         </p>
+        <div>
+          <Button
+            type="button"
+            disabled={busy}
+            onClick={() => {
+              registration.mutate();
+            }}
+          >
+            {registration.isPending ? "Registering…" : "Make this an App"}
+          </Button>
+        </div>
+        {registration.isError ? (
+          <p role="alert">{registration.error.message}</p>
+        ) : null}
         <form
           className="flex flex-col gap-4"
           onSubmit={(event) => {
             event.preventDefault();
-            if (appId && sourceRevision && !build.isPending) build.mutate();
+            if (
+              selectedAppId &&
+              selectedRevision &&
+              selectedInstallationId &&
+              !busy
+            )
+              build.mutate();
           }}
         >
           <label className="flex flex-col gap-2" htmlFor="app-build-app-id">
             <span>App id</span>
             <Input
               id="app-build-app-id"
-              value={appId}
-              onChange={(event) => {
-                setAppId(event.target.value);
-              }}
-              placeholder="app_my-fork"
-              disabled={build.isPending}
+              value={selectedAppId}
+              readOnly
+              placeholder="app_myfork"
+              disabled={busy}
             />
           </label>
           <label
@@ -98,73 +155,104 @@ export function AppBuildPanel() {
             <span>Source revision</span>
             <Input
               id="app-build-source-revision"
-              value={sourceRevision}
+              value={selectedRevision}
               onChange={(event) => {
                 setSourceRevision(event.target.value);
               }}
-              placeholder={`git:${"a".repeat(40)}`}
-              disabled={build.isPending}
+              placeholder={"git:" + "a".repeat(40)}
+              disabled={busy}
             />
           </label>
-          {build.isError ? (
-            <div role="alert" className="text-sm text-error">
-              <p>{build.error.message}</p>
-            </div>
-          ) : null}
-          <div>
-            <Button
-              type="submit"
-              disabled={!appId || !sourceRevision || build.isPending}
-            >
-              {build.isPending ? "Starting build…" : "Build"}
-            </Button>
-          </div>
-        </form>
-        {jobId !== null ? (
-          <p className="text-sm" role="status">
-            Job {jobId}: {settled?.status ?? "running…"}
-            {/* A succeeded build's detail is its phase timings, not a message. */}
-            {settled?.status !== "succeeded" && settled?.detail
-              ? ` — ${settled.detail}`
-              : ""}
-          </p>
-        ) : null}
-        <form
-          className="flex flex-col gap-4"
-          onSubmit={(event) => {
-            event.preventDefault();
-            if (installationId && release !== null && !install.isPending)
-              install.mutate();
-          }}
-        >
           <label className="flex flex-col gap-2" htmlFor="app-install-id">
             <span>Install at</span>
             <Input
               id="app-install-id"
-              value={installationId}
+              value={selectedInstallationId}
               onChange={(event) => {
                 setInstallationId(event.target.value);
               }}
-              placeholder="my-fork"
-              disabled={install.isPending}
+              disabled={busy}
             />
           </label>
-          {install.isError ? (
-            <div role="alert" className="text-sm text-error">
-              <p>{install.error.message}</p>
-            </div>
-          ) : null}
+          {build.isError ? <p role="alert">{build.error.message}</p> : null}
           <div>
             <Button
               type="submit"
               disabled={
-                !installationId || release === null || install.isPending
+                !selectedAppId ||
+                !selectedRevision ||
+                !selectedInstallationId ||
+                busy
               }
             >
-              {install.isPending ? "Installing…" : "Install this Release"}
+              {build.isPending ? "Starting Workflow…" : "Build & install"}
             </Button>
           </div>
         </form>
+        {runId !== null ? (
+          <section aria-label="Build Workflow" className="flex flex-col gap-3">
+            <p role="status">Workflow run {runId}</p>
+            {run.isPending ? (
+              <p role="status">Loading Workflow steps…</p>
+            ) : null}
+            {run.isError ? <p role="alert">{run.error.message}</p> : null}
+            {run.data === undefined ? null : (
+              <>
+                <p role="status">
+                  {run.data.title}: {run.data.status}
+                </p>
+                {run.data.error === null ? null : (
+                  <OutputError error={run.data.error} />
+                )}
+                <RunTimeline
+                  items={timelineItems(
+                    runSteps(
+                      run.data.events,
+                      run.data.outcome,
+                      run.data.reviews,
+                    ),
+                    definition,
+                    appDisplay,
+                  )}
+                />
+              </>
+            )}
+          </section>
+        ) : (
+          <section
+            aria-label="Latest repository build"
+            className="flex flex-col gap-2"
+          >
+            {status.data != null && "kind" in status.data ? (
+              <p role="status">
+                Build or automatic installation is still running.
+              </p>
+            ) : null}
+            {settled === null ? null : (
+              <p role="status">
+                Job {settled.jobId}: {settled.status}
+                {settled.status !== "succeeded" && settled.detail
+                  ? " — " + settled.detail
+                  : ""}
+              </p>
+            )}
+            {status.isError ? <p role="alert">{status.error.message}</p> : null}
+            {settled?.installation?.kind === "needs_consent" ? (
+              <p role="status">
+                Needs owner consent. Automatic installation left any previous
+                Release unchanged.
+              </p>
+            ) : null}
+            {settled?.installation?.kind === "installed" ? (
+              <p role="status">
+                Installed at {settled.installation.installationId}.
+              </p>
+            ) : null}
+            {settled?.installation?.kind === "failed" ? (
+              <p role="alert">Not installed: {settled.installation.detail}</p>
+            ) : null}
+          </section>
+        )}
       </CardContent>
     </Card>
   );

package/web/bonsai.css

@@ -1,3 +1,4 @@
+@source "../../trellis/src/runs";
 @import "@fungi.computer/caps/tailwind.css";
 @source "./";
 

package/web/change-page.tsx

@@ -14,7 +14,6 @@ import {
 } from "@fungi.computer/caps/components/data-list";
 import { InlineCode } from "@fungi.computer/caps/components/inline-code";
 import { Status } from "@fungi.computer/caps/components/status";
-import { StatusLed } from "@fungi.computer/caps/components/field-guide";
 import type { MergeResult, PolicyDecision } from "../shared/contract.js";
 import {
   useAgents,
@@ -569,14 +568,19 @@ export function ChangePage({ repo, number }: { repo: string; number: number }) {
                   >
                     <div className="min-w-0">
                       <div className="flex flex-wrap items-center gap-2">
-                        <StatusLed
-                          active={check.status !== "queued"}
+                        <Status
+                          size="compact"
                           tone={
                             check.status === "passed"
-                              ? "fruiting"
+                              ? "success"
                               : check.status === "failed"
-                                ? "spore"
-                                : "mycelium"
+                                ? "error"
+                                : check.status === "running"
+                                  ? "info"
+                                  : "neutral"
+                          }
+                          motion={
+                            check.status === "running" ? "bounce" : "none"
                           }
                           label={check.status}
                         />

package/web/index.html

@@ -7,7 +7,6 @@
       name="description"
       content="Bonsai: a git platform where many agents work at once."
     />
-    <link rel="icon" href="/favicon.svg" type="image/svg+xml" />
     <title>Bonsai</title>
   </head>
   <body>

package/web/repo-settings.tsx

@@ -139,7 +139,7 @@ export function RepoSettings({ repo }: { repo: string }) {
           )}
         </CardContent>
       </Card>
-      <AppBuildPanel />
+      <AppBuildPanel key={repo} repo={repo} />
     </div>
   );
 }

package/web/public/favicon.svg

@@ -1 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32"><path d="M9 23V9m0 4c0 4 14 2 14 9" fill="none" stroke="currentColor" stroke-width="3" stroke-linecap="round"/><circle cx="9" cy="9" r="3" fill="currentColor"/><circle cx="9" cy="23" r="3" fill="currentColor"/><circle cx="23" cy="22" r="3" fill="currentColor"/></svg>