@fullstacksjs/eslint-config 8.7.3 → 8.7.4-0

package/cypress.js

@@ -1,13 +1,15 @@
+const { exts } = require('./utils');
+
 /** @type { import('eslint').Linter.Config } */
 module.exports = {
   overrides: [
     {
-      files: ['**/cypress/**/*.+(js|jsx)', '**/cypress/**/*.+(ts|tsx)'],
-      plugins: ['cypress'],
+      files: [`**/cypress/**/*.${exts}`, `**/*.cy.+${exts}`],
+      plugins: ['jest', 'jest-formatting', 'cypress'],
       env: {
         'cypress/globals': true,
       },
-      extends: ['./rules/cypress'],
+      extends: ['./rules/test', './rules/cypress'],
     },
   ],
 };

package/esm.js

@@ -1,13 +1,13 @@
 /** @type { import('eslint').Linter.Config } */
 module.exports = {
   rules: {
-    'import/extensions': 'off',
+    'import/extensions': ['error', { mjs: 'ignorePackages' }],
   },
   overrides: [
     {
       files: ['*.ts', '*.tsx'],
       rules: {
-        'import/no-unresolved': [2, { ignore: ['.js$'], caseSensitiveStrict: true }],
+        'import/no-unresolved': ['error', { ignore: ['.js$'], caseSensitiveStrict: true }],
       },
     },
   ],

package/index.js

@@ -1,21 +1,14 @@
-const fs = require('fs');
-const { Packages } = require('@frontendmonster/utils');
-const readPkgUp = require('read-pkg-up');
-
-const { packageJson: pkg } = readPkgUp.sync({
-  cwd: fs.realpathSync(process.cwd()),
-});
-
-const packages = Packages(pkg);
+const packages = require('./packages');
+const { compact } = require('@fullstacksjs/toolbox');
 
 /** @type { import('eslint').Linter.Config } */
 module.exports = {
-  extends: [
+  extends: compact([
     require.resolve('./base'),
     require.resolve('./storybook'),
     require.resolve('./jest'),
     packages.ifAnyDep('react', () => require.resolve('./react')),
     packages.ifAnyDep('typescript', () => require.resolve('./typescript')),
     packages.ifAnyDep('cypress', () => require.resolve('./cypress')),
-  ].filter(Boolean),
+  ]),
 };

package/jest.js

@@ -1,4 +1,5 @@
-const exts = '+(js|jsx|ts|tsx)';
+const { exts } = require('./utils');
+
 const dirs = '+(test|tests|__test__|__tests__|spec|specs)';
 
 /** @type { import('eslint').Linter.Config } */
@@ -10,7 +11,7 @@ module.exports = {
       env: {
         'jest/globals': true,
       },
-      extends: ['./rules/jest'],
+      extends: ['./rules/test', './rules/jest'],
     },
   ],
 };

package/nextjs.js

@@ -1,12 +1,4 @@
-const fs = require('fs');
-const { Packages } = require('@frontendmonster/utils');
-const readPkgUp = require('read-pkg-up');
-
-const { packageJson: pkg } = readPkgUp.sync({
-  cwd: fs.realpathSync(process.cwd()),
-});
-
-const packages = Packages(pkg);
+const packages = require('./packages');
 
 /** @type { import('eslint').Linter.Config } */
 module.exports = {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fullstacksjs/eslint-config",
-  "version": "8.7.3",
+  "version": "8.7.4-0",
   "license": "MIT",
   "author": "fullstacks <fullstacksjs@gmail.com>",
   "description": "fullstacks eslint config",
@@ -11,23 +11,22 @@
   "publishConfig": {
     "registry": "https://registry.npmjs.org"
   },
-  "bin": {
-    "fullstacksjs-eslint": "./bin/index.js"
-  },
   "files": [
-    "bin",
-    "rules",
     "base.js",
+    "bin",
+    "cypress.js",
+    "esm.js",
+    "graphql.js",
     "index.js",
     "jest.js",
     "nextjs.js",
-    "cypress.js",
-    "storybook.js",
-    "graphql.js",
+    "packages.js",
     "react.js",
-    "typescript.js",
+    "rules",
+    "storybook.js",
     "typecheck.js",
-    "esm.js"
+    "typescript.js",
+    "utils.js"
   ],
   "scripts": {
     "lint": "eslint .",
@@ -39,45 +38,49 @@
     "check-rules:graphql": "eslint-find-rules --no-core --deprecated --unused ./tests/graphql.js",
     "check-rules:storybook": "eslint-find-rules --no-core --deprecated --unused ./tests/storybook.js",
     "spell": "cspell ./* --no-progress",
-    "test": "npm-run-all --parallel check-rules:* && npm run spell",
+    "test": "npm-run-all --parallel check-rules:*",
     "prepublishOnly": "pinst --disable",
     "postpublish": "pinst --enable",
     "pre-commit": "npm run test && lint-staged"
   },
   "main": "index.js",
   "dependencies": {
-    "@frontendmonster/utils": "0.3.11",
-    "@graphql-eslint/eslint-plugin": "3.10.7",
-    "@typescript-eslint/eslint-plugin": "5.36.1",
-    "@typescript-eslint/parser": "5.36.1",
+    "@fullstacksjs/toolbox": "3.0.2",
+    "@graphql-eslint/eslint-plugin": "3.13.1",
+    "@typescript-eslint/eslint-plugin": "5.46.1",
+    "@typescript-eslint/parser": "5.46.1",
     "eslint-config-prettier": "8.5.0",
-    "eslint-import-resolver-typescript": "3.5.0",
+    "eslint-import-resolver-typescript": "3.5.3",
     "eslint-plugin-cypress": "2.12.1",
     "eslint-plugin-fp": "2.3.0",
     "eslint-plugin-import": "2.26.0",
-    "eslint-plugin-jest": "27.0.1",
+    "eslint-plugin-jest": "27.1.7",
     "eslint-plugin-jest-formatting": "3.1.0",
     "eslint-plugin-jsx-a11y": "6.6.1",
     "eslint-plugin-node": "11.1.0",
     "eslint-plugin-prettier": "4.2.1",
-    "eslint-plugin-promise": "6.0.1",
-    "eslint-plugin-react": "7.31.4",
+    "eslint-plugin-promise": "6.1.1",
+    "eslint-plugin-react": "7.31.11",
     "eslint-plugin-react-hooks": "4.6.0",
     "eslint-plugin-simple-import-sort": "8.0.0",
-    "eslint-plugin-storybook": "0.6.4",
+    "eslint-plugin-storybook": "0.6.8",
     "read-pkg-up": "7.0.1"
   },
   "devDependencies": {
-    "cspell": "6.8.1",
-    "eslint": "8.23.0",
+    "@semantic-release/github": "8.0.7",
+    "@semantic-release/npm": "9.0.1",
+    "@semantic-release/release-notes-generator": "10.0.3",
+    "cspell": "6.19.2",
+    "eslint": "8.29.0",
     "eslint-find-rules": "4.1.0",
-    "husky": "8.0.1",
-    "lint-staged": "13.0.3",
-    "np": "7.6.2",
+    "husky": "8.0.3",
+    "lint-staged": "13.1.0",
+    "np": "7.6.3",
     "npm-run-all": "4.1.5",
     "pinst": "3.0.0",
-    "prettier": "2.7.1",
-    "typescript": "4.8.2"
+    "prettier": "2.8.3",
+    "semantic-release": "19.0.5",
+    "typescript": "4.9.5"
   },
   "peerDependencies": {
     "cypress": ">=8",

package/packages.js

@@ -0,0 +1,9 @@
+const { Packages } = require('@fullstacksjs/toolbox');
+const readPkgUp = require('read-pkg-up');
+const fs = require('node:fs');
+
+const { packageJson: pkg } = readPkgUp.sync({
+  cwd: fs.realpathSync(process.cwd()),
+});
+
+module.exports = Packages(pkg);

package/rules/base.js

@@ -8,14 +8,20 @@ module.exports = {
     'default-case': 'error',
     'dot-notation': 'error',
     'eqeqeq': ['error', 'smart'],
+    'grouped-accessor-pairs': 'off',
     'guard-for-in': 'error',
     'no-alert': 'error',
+    'no-async-promise-executor': 'off',
     'no-caller': 'error',
     'no-case-declarations': 'error',
+    'no-console': 'off',
+    'no-constructor-return': 'error',
     'no-div-regex': 'error',
+    'no-dupe-else-if': 'error',
     'no-else-return': 'off',
     'no-empty-function': 'off',
     'no-empty-pattern': 'error',
+    'no-empty-static-block': 'warn',
     'no-eq-null': 'off',
     'no-eval': 'error',
     'no-extend-native': 'error',
@@ -27,6 +33,7 @@ module.exports = {
     'no-implicit-coercion': 'off',
     'no-implicit-globals': 'error',
     'no-implied-eval': 'error',
+    'no-import-assign': 'error',
     'no-invalid-this': 'warn',
     'no-iterator': 'error',
     'no-labels': 'error',
@@ -34,23 +41,25 @@ module.exports = {
     'no-loop-func': 'error',
     'no-loss-of-precision': 'warn',
     'no-magic-numbers': 'off',
+    'no-misleading-character-class': 'off',
     'no-multi-str': 'error',
+    'no-new': 'error',
     'no-new-func': 'error',
     'no-new-wrappers': 'error',
-    'no-new': 'error',
-    'no-octal-escape': 'error',
     'no-octal': 'error',
+    'no-octal-escape': 'error',
     'no-param-reassign': 'off',
     'no-proto': 'error',
     'no-redeclare': 'error',
-    'no-restricted-properties': 'off',
     'no-restricted-exports': 'off',
+    'no-restricted-properties': 'off',
     'no-restricted-syntax': ['error', 'WithStatement'],
     'no-return-assign': 'error',
     'no-script-url': 'error',
     'no-self-assign': 'error',
     'no-self-compare': 'error',
     'no-sequences': 'error',
+    'no-setter-return': 'error',
     'no-throw-literal': 'error',
     'no-unmodified-loop-condition': 'error',
     'no-unsafe-optional-chaining': 'error',
@@ -64,23 +73,15 @@ module.exports = {
     'no-void': 'off',
     'no-warning-comments': ['warn', { terms: ['fixme'], location: 'anywhere' }],
     'no-with': 'off',
-    'prefer-promise-reject-errors': 'off',
     'prefer-named-capture-group': 'off',
+    'prefer-promise-reject-errors': 'off',
+    'prefer-regex-literals': 'off',
     'radix': 'error',
-    'require-await': 'error',
-    'vars-on-top': 'error',
-    'yoda': 'error',
     'require-atomic-updates': 'off',
+    'require-await': 'error',
     'require-unicode-regexp': 'off',
-    'no-misleading-character-class': 'off',
-    'no-async-promise-executor': 'off',
-    'no-console': 'off',
-    'no-constructor-return': 'error',
-    'no-dupe-else-if': 'error',
-    'no-import-assign': 'error',
-    'no-setter-return': 'error',
-    'prefer-regex-literals': 'off',
-    'grouped-accessor-pairs': 'off',
     'strict': 'error',
+    'vars-on-top': 'error',
+    'yoda': 'error',
   },
 };

package/rules/cypress.js

@@ -6,10 +6,5 @@ module.exports = {
     'cypress/no-force': 'warn',
     'cypress/no-async-tests': 'error',
     'cypress/no-pause': 'error',
-
-    // other modules
-    'max-lines-per-function': ['off'],
-    '@typescript-eslint/method-signature-style': ['off'],
-    '@typescript-eslint/no-namespace ': ['off'],
   },
 };

package/rules/forbidden.js

@@ -20,6 +20,7 @@ module.exports = {
     'no-inner-declarations': 'error',
     'no-invalid-regexp': 'error',
     'no-irregular-whitespace': 'error',
+    'no-new-native-nonconstructor': 'error',
     'no-nonoctal-decimal-escape': 'error',
     'no-obj-calls': 'error',
     'no-prototype-builtins': 'off',

package/rules/jest.js

@@ -1,3 +1,5 @@
+const packages = require('../packages');
+
 module.exports = {
   rules: {
     'jest/consistent-test-it': 'off',
@@ -8,19 +10,15 @@ module.exports = {
     'jest/no-commented-out-tests': 'warn',
     'jest/no-conditional-expect': 'error',
     'jest/no-conditional-in-test': 'error',
-    'jest/no-deprecated-functions': 'error',
-    'jest/no-disabled-tests': 'warn',
     'jest/no-done-callback': 'warn',
-    'jest/no-duplicate-hooks': 'off',
     'jest/no-expect-resolves': 'off',
     'jest/no-export': 'error',
-    'jest/no-focused-tests': 'error',
     'jest/no-hooks': 'off',
-    'jest/no-identical-title': 'error',
     'jest/no-interpolation-in-snapshots': 'error',
     'jest/no-jasmine-globals': 'off',
     'jest/no-large-snapshots': ['warn', { maxSize: 300 }],
     'jest/no-mocks-import': 'error',
+    'jest/no-restricted-jest-methods': 'off',
     'jest/no-restricted-matchers': 'error',
     'jest/no-standalone-expect': 'off',
     'jest/no-test-callback': 'off',
@@ -44,27 +42,24 @@ module.exports = {
     'jest/prefer-to-contain': 'warn',
     'jest/prefer-to-have-length': 'warn',
     'jest/prefer-todo': 'warn',
-    'jest/require-hook': 'error',
+    'jest/require-hook': 'off',
     'jest/require-to-throw-message': 'off',
     'jest/require-top-level-describe': 'off',
-    'jest/unbound-method': 'error',
     'jest/valid-describe-callback': 'error',
     'jest/valid-expect-in-promise': 'error',
     'jest/valid-expect': 'error',
     'jest/valid-title': 'warn',
 
-    // jest-formatting
-    'jest-formatting/padding-around-after-all-blocks': 'warn',
-    'jest-formatting/padding-around-after-each-blocks': 'warn',
-    'jest-formatting/padding-around-all': 'warn',
-    'jest-formatting/padding-around-before-all-blocks': 'warn',
-    'jest-formatting/padding-around-before-each-blocks': 'warn',
-    'jest-formatting/padding-around-describe-blocks': 'warn',
-    'jest-formatting/padding-around-expect-groups': 'warn',
-    'jest-formatting/padding-around-test-blocks': 'warn',
+    'jest/no-deprecated-functions': 'off',
+    ...packages.ifAnyDep('jest', () => ({
+      'jest/no-deprecated-functions': 'error',
+    })),
+
+    ...packages.ifAnyDep('typescript', () => ({
+      '@typescript-eslint/unbound-method': 'off',
+    })),
 
     // conflicts
-    '@typescript-eslint/unbound-method': 'off',
     'fp/no-let': 'off',
   },
 };

package/rules/naming-convention.js

@@ -0,0 +1,50 @@
+module.exports = [
+  {
+    selector: 'default',
+    format: ['camelCase'],
+  },
+  {
+    selector: 'function',
+    format: ['camelCase', 'PascalCase'],
+  },
+  // variables, CONSTANTS, ReactComponents
+  {
+    selector: 'variable',
+    format: ['camelCase', 'UPPER_CASE', 'PascalCase'],
+  },
+  {
+    selector: 'parameter',
+    format: ['camelCase', 'PascalCase'],
+    leadingUnderscore: 'allowSingleOrDouble',
+  },
+  {
+    selector: 'memberLike',
+    format: null,
+  },
+  {
+    selector: 'memberLike',
+    modifiers: ['static'],
+    format: ['camelCase', 'PascalCase'],
+    leadingUnderscore: 'allow',
+  },
+  {
+    selector: 'memberLike',
+    modifiers: ['private'],
+    format: ['camelCase'],
+    leadingUnderscore: 'allow',
+  },
+  {
+    selector: 'typeLike',
+    format: ['PascalCase'],
+  },
+  {
+    selector: 'enumMember',
+    format: ['PascalCase'],
+  },
+  // disallow I prefix for interfaces
+  {
+    selector: 'interface',
+    format: ['PascalCase'],
+    custom: { regex: '^I[A-Z]', match: false },
+  },
+];

package/rules/promise.js

@@ -14,5 +14,6 @@ module.exports = {
     'promise/prefer-await-to-callbacks': 'off',
     'promise/prefer-await-to-then': 'off',
     'promise/valid-params': 'warn',
+    'promise/no-multiple-resolved': 'warn',
   },
 };

package/rules/react.js

@@ -11,7 +11,7 @@ module.exports = {
     'react/forbid-foreign-prop-types': 'error',
     'react/forbid-prop-types': 'off',
     'react/function-component-definition': ['warn', { namedComponents: 'arrow-function', unnamedComponents: 'arrow-function' }],
-    'react/hook-use-state': 'warn',
+    'react/hook-use-state': 'off',
     'react/iframe-missing-sandbox': 'error',
     'react/jsx-boolean-value': 'warn',
     'react/jsx-child-element-spacing': 'warn',

package/rules/style.js

@@ -17,14 +17,15 @@ module.exports = {
       // __filename, camelCase, PascalCase, CONST_VALUE, stream$, $el
       '^\\$?(__)?(([A-Z]|[a-z]|[0-9]+)|([A-Z_]))*\\$?$',
     ],
-    'linebreak-style': ['error', 'unix'],
     'line-comment-position': 'off',
+    'linebreak-style': ['error', 'unix'],
     'lines-around-comment': 'off',
     'lines-between-class-members': ['warn', 'always', { exceptAfterSingleLine: false }],
+    'logical-assignment-operators': 'off',
     'max-classes-per-file': 'off',
     'max-depth': ['error', 4],
-    'max-lines': ['error', { max: 2500, skipBlankLines: false, skipComments: false }],
     'max-lines-per-function': ['error', 150],
+    'max-lines': ['error', { max: 2500, skipBlankLines: false, skipComments: false }],
     'max-nested-callbacks': ['error', 7],
     'max-params': ['error', 7],
     'max-statements-per-line': ['error', { max: 1 }],

package/rules/test.js

@@ -0,0 +1,31 @@
+const packages = require('../packages');
+
+module.exports = {
+  rules: {
+    'jest/no-duplicate-hooks': 'error',
+    'jest/no-disabled-tests': 'error',
+    'jest/no-focused-tests': 'error',
+    'jest/no-identical-title': 'error',
+
+    // formatting
+    'jest-formatting/padding-around-after-all-blocks': 'warn',
+    'jest-formatting/padding-around-after-each-blocks': 'warn',
+    'jest-formatting/padding-around-all': 'warn',
+    'jest-formatting/padding-around-before-all-blocks': 'warn',
+    'jest-formatting/padding-around-before-each-blocks': 'warn',
+    'jest-formatting/padding-around-describe-blocks': 'warn',
+    'jest-formatting/padding-around-expect-groups': 'warn',
+    'jest-formatting/padding-around-test-blocks': 'warn',
+
+    // other modules
+    'max-lines-per-function': 'off',
+    ...packages.ifAnyDep('react', () => ({
+      'react/jsx-no-constructed-context-values': 'off',
+    })),
+    ...packages.ifAnyDep('typescript', () => ({
+      '@typescript-eslint/method-signature-style': 'off',
+      '@typescript-eslint/no-namespace ': 'off',
+      '@typescript-eslint/unbound-method': 'off',
+    })),
+  },
+};

package/rules/{typescript-requiring-type-checking.js → typecheck.js}

@@ -4,14 +4,18 @@ module.exports = {
     '@typescript-eslint/consistent-type-exports': 'warn',
     '@typescript-eslint/dot-notation': [
       'warn',
-      { allowPrivateClassPropertyAccess: false, allowProtectedClassPropertyAccess: false, allowIndexSignaturePropertyAccess: true },
+      {
+        allowPrivateClassPropertyAccess: false,
+        allowProtectedClassPropertyAccess: false,
+        allowIndexSignaturePropertyAccess: true,
+      },
     ],
     '@typescript-eslint/no-confusing-void-expression': ['warn', { ignoreArrowShorthand: true, ignoreVoidOperator: true }],
     '@typescript-eslint/no-floating-promises': ['error', { ignoreVoid: true }],
     '@typescript-eslint/no-for-in-array': 'error',
     '@typescript-eslint/no-implied-eval': 'error',
     '@typescript-eslint/no-meaningless-void-operator': ['warn', { checkNever: false }],
-    '@typescript-eslint/no-misused-promises': 'error',
+    '@typescript-eslint/no-misused-promises': ['warn', { checksVoidReturn: { attributes: false } }],
     '@typescript-eslint/no-redundant-type-constituents': 'warn',
     '@typescript-eslint/no-throw-literal': 'error',
     '@typescript-eslint/no-unnecessary-boolean-literal-compare': 'error',
@@ -30,7 +34,12 @@ module.exports = {
     '@typescript-eslint/prefer-reduce-type-parameter': 'warn',
     '@typescript-eslint/prefer-nullish-coalescing': [
       'warn',
-      { ignoreConditionalTests: false, ignoreTernaryTests: false, ignoreMixedLogicalExpressions: false, forceSuggestionFixer: false },
+      {
+        ignoreConditionalTests: false,
+        ignoreTernaryTests: false,
+        ignoreMixedLogicalExpressions: false,
+        allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing: false,
+      },
     ],
     '@typescript-eslint/prefer-regexp-exec': 'warn',
     '@typescript-eslint/prefer-return-this-type': 'warn',
@@ -42,45 +51,13 @@ module.exports = {
     '@typescript-eslint/unbound-method': ['error', { ignoreStatic: true }],
     '@typescript-eslint/naming-convention': [
       'warn',
-      {
-        selector: 'default',
-        format: ['camelCase'],
-      },
-      // variables, CONSTANTS, ReactComponents
-      {
-        selector: 'variable',
-        format: ['camelCase', 'UPPER_CASE', 'PascalCase'],
-      },
-      {
-        selector: 'parameter',
-        format: ['camelCase'],
-        leadingUnderscore: 'allow',
-      },
-      {
-        selector: 'memberLike',
-        modifiers: ['private'],
-        format: ['camelCase'],
-        leadingUnderscore: 'allow',
-      },
-      {
-        selector: 'typeLike',
-        format: ['PascalCase'],
-      },
-      // disallow I prefix for interfaces
-      {
-        selector: 'interface',
-        format: ['PascalCase'],
-        custom: {
-          regex: '^I[A-Z]',
-          match: false,
-        },
-      },
-      // force use is/should/has ... for boolean variables
+      ...require('./naming-convention'), // eslint-disable-line node/global-require
+      // force use is/should/has for boolean variables
       {
         selector: 'variable',
         types: ['boolean'],
-        format: ['camelCase'],
-        prefix: ['is', 'should', 'has', 'can', 'did', 'will', 'enable'],
+        format: ['PascalCase'],
+        prefix: ['is', 'should', 'has', 'can', 'did', 'will', 'enable', 'loading'],
       },
     ],
 

package/rules/typescript.js

@@ -30,57 +30,7 @@ module.exports = {
     '@typescript-eslint/member-naming': 'off',
     '@typescript-eslint/member-ordering': 'off',
     '@typescript-eslint/method-signature-style': ['warn', 'property'],
-    '@typescript-eslint/naming-convention': [
-      'warn',
-      {
-        selector: 'default',
-        format: ['camelCase'],
-      },
-      {
-        selector: 'function',
-        format: ['camelCase', 'PascalCase'],
-      },
-      // variables, CONSTANTS, ReactComponents
-      {
-        selector: 'variable',
-        format: ['camelCase', 'UPPER_CASE', 'PascalCase'],
-      },
-      {
-        selector: 'parameter',
-        format: ['camelCase', 'PascalCase'],
-        leadingUnderscore: 'allowSingleOrDouble',
-      },
-      {
-        selector: 'memberLike',
-        format: null,
-      },
-      {
-        selector: 'memberLike',
-        modifiers: ['static'],
-        format: ['camelCase', 'PascalCase'],
-        leadingUnderscore: 'allow',
-      },
-      {
-        selector: 'memberLike',
-        modifiers: ['private'],
-        format: ['camelCase'],
-        leadingUnderscore: 'allow',
-      },
-      {
-        selector: 'typeLike',
-        format: ['PascalCase'],
-      },
-      {
-        selector: 'enumMember',
-        format: ['PascalCase'],
-      },
-      // disallow I prefix for interfaces
-      {
-        selector: 'interface',
-        format: ['PascalCase'],
-        custom: { regex: '^I[A-Z]', match: false },
-      },
-    ],
+    '@typescript-eslint/naming-convention': ['warn', ...require('./naming-convention')], // eslint-disable-line node/global-require
     '@typescript-eslint/no-array-constructor': 'error',
     '@typescript-eslint/no-base-to-string': 'off', // false negative
     '@typescript-eslint/no-confusing-non-null-assertion': 'error',
@@ -100,13 +50,13 @@ module.exports = {
     '@typescript-eslint/no-magic-numbers': ['off', { ignoreEnums: true }], // Not good enough yet
     '@typescript-eslint/no-misused-new': 'error',
     '@typescript-eslint/no-namespace': 'error',
+    '@typescript-eslint/consistent-type-imports': ['warn', { prefer: 'type-imports', disallowTypeAnnotations: false }],
     '@typescript-eslint/no-non-null-asserted-nullish-coalescing': 'error',
     '@typescript-eslint/no-non-null-asserted-optional-chain': 'error',
     '@typescript-eslint/no-non-null-assertion': 'off',
     '@typescript-eslint/no-redeclare': ['off', { ignoreDeclarationMerge: true }], // useful in FP.
     '@typescript-eslint/no-require-imports': 'error',
     '@typescript-eslint/no-restricted-imports': 'off',
-    '@typescript-eslint/consistent-type-imports': ['warn', { prefer: 'type-imports', disallowTypeAnnotations: false }],
     '@typescript-eslint/no-shadow': 'error',
     '@typescript-eslint/no-this-alias': 'error',
     '@typescript-eslint/no-type-alias': 'off',
@@ -114,6 +64,7 @@ module.exports = {
     '@typescript-eslint/no-unsafe-argument': 'off',
     '@typescript-eslint/no-unsafe-assignment': 'off',
     '@typescript-eslint/no-unsafe-call': 'off',
+    '@typescript-eslint/no-unsafe-declaration-merging': 'warn',
     '@typescript-eslint/no-unsafe-member-access': 'off',
     '@typescript-eslint/no-unsafe-return': 'off',
     '@typescript-eslint/no-untyped-public-signature': 'off',
@@ -129,7 +80,14 @@ module.exports = {
     '@typescript-eslint/no-var-requires': 'error',
     '@typescript-eslint/object-curly-spacing': 'warn',
     '@typescript-eslint/parameter-properties': 'off',
-    '@typescript-eslint/padding-line-between-statements': ['warn', { blankLine: 'always', prev: ['return'], next: ['export'] }],
+    '@typescript-eslint/padding-line-between-statements': [
+      'warn',
+      { blankLine: 'always', prev: '*', next: ['class', 'for', 'while', 'switch', 'do', 'directive', 'function', 'iife', 'block-like'] },
+      { blankLine: 'always', prev: ['block-like', 'block'], next: ['return'] },
+      { blankLine: 'always', prev: ['block-like'], next: ['const', 'let', 'var'] },
+      { blankLine: 'always', prev: ['const', 'let', 'var'], next: ['type', 'interface'] },
+      { blankLine: 'always', prev: ['multiline-const', 'multiline-let', 'multiline-var'], next: ['if'] },
+    ],
     '@typescript-eslint/prefer-as-const': 'warn',
     '@typescript-eslint/prefer-enum-initializers': 'off',
     '@typescript-eslint/prefer-for-of': 'warn',
@@ -150,7 +108,7 @@ module.exports = {
       'off',
       { allowNumber: true, allowBoolean: false, allowAny: false, allowNullish: false, allowRegExp: false },
     ],
-    '@typescript-eslint/sort-type-union-intersection-members': [
+    '@typescript-eslint/sort-type-constituents': [
       'warn',
       {
         checkIntersections: true,

package/storybook.js

@@ -3,7 +3,7 @@ module.exports = {
   overrides: [
     {
       plugins: ['storybook'],
-      files: ['*.stories.+(ts|tsx|js|jsx|mjs|cjs)', '*.story.+(ts|tsx|js|jsx|mjs|cjs)'],
+      files: ['*.stories.+(ts|tsx|js|jsx|mjs|cjs|mdx)', '*.story.+(ts|tsx|js|jsx|mjs|cjs|mdx)'],
       extends: ['./rules/storybook.js'],
     },
   ],

package/typecheck.js

@@ -3,7 +3,7 @@ module.exports = {
   overrides: [
     {
       files: ['*.ts', '*.tsx'],
-      extends: ['./rules/typescript-requiring-type-checking.js'],
+      extends: ['./rules/typecheck.js'],
     },
   ],
 };

package/utils.js

@@ -0,0 +1 @@
+module.exports.exts = '+(js|jsx|mjs|cjs|ts|tsx|mts|cts)';

package/bin/index.js

@@ -1,9 +0,0 @@
-#!/usr/bin/env node
-
-const createOptions = require('./lib/createOptions');
-const createTasks = require('./lib/tasks');
-
-createOptions()
-  .then(createTasks)
-  .then(tasks => tasks.run())
-  .catch(() => {});

package/bin/lib/askWhenConfigExists.js

@@ -1,51 +0,0 @@
-const { readFile } = require('fs/promises');
-const inquirer = require('inquirer');
-
-const isObject = x => typeof x === 'object' && !Array.isArray(x) && x !== null;
-
-// TODO: add this function to the toolbox
-const merge = (obj, obj2) =>
-  Object.entries(obj)
-    .concat(Object.entries(obj2))
-    .reduce((acc, [key, value]) => {
-      const accValue = acc[key];
-      return Array.isArray(accValue) && Array.isArray(value)
-        ? { ...acc, [key]: accValue.concat(value) }
-        : isObject(accValue) && isObject(value)
-        ? { ...acc, [key]: merge(accValue, value) }
-        : { ...acc, [key]: value };
-    }, {});
-
-const Choice = {
-  noConfig: 'noConfig',
-  overwrite: 'overwrite',
-  extend: 'extend',
-};
-
-const askWhenConfigExists = async eslintrc => {
-  const file = await readFile('.eslintrc.json').catch(() => null);
-  if (file === null) return eslintrc;
-
-  const currentConfig = JSON.parse(file);
-  const isConfiguredBefore = eslintrc?.extends.every(c => currentConfig?.extends?.includes(c));
-  if (isConfiguredBefore) return currentConfig;
-
-  const { choice } = await inquirer.prompt({
-    type: 'list',
-    name: 'choice',
-    message: 'config found',
-    choices: [
-      {
-        value: 'overwrite',
-        name: 'overwrite the current config completely',
-      },
-      {
-        value: 'extend',
-        name: 'extend the fullstacks config alongside current config',
-      },
-    ],
-  });
-  return choice === Choice.extend ? merge(currentConfig, eslintrc) : eslintrc;
-};
-
-module.exports = askWhenConfigExists;

package/bin/lib/createOptions.js

@@ -1,25 +0,0 @@
-const getUserInput = require('./getUserInput');
-const args = require('./parseArgs');
-
-const eslintrcConfig = {
-  extends: ['@fullstacksjs'],
-};
-
-const requiredPackages = ['@fullstacksjs/eslint-config', 'eslint', 'prettier'];
-
-async function createOptions() {
-  const isTechnologyInArgv = args.t != null;
-  const optionsFromArgs = { technology: args.t };
-  const userInput = isTechnologyInArgv ? optionsFromArgs : await getUserInput();
-
-  if (userInput.technology === 'ts') {
-    requiredPackages.push('typescript');
-  }
-
-  return {
-    eslintrc: eslintrcConfig,
-    packages: requiredPackages,
-  };
-}
-
-module.exports = createOptions;

package/bin/lib/generateFile.js

@@ -1,15 +0,0 @@
-const { writeFile } = require('fs/promises');
-
-function createFileTask(eslintrc, ctx, task) {
-  return writeFile('.eslintrc.json', JSON.stringify(eslintrc, null, 2))
-    .then(() => {
-      task.title = `.eslintrc - Successfully Generated.`;
-    })
-    .catch(() => {
-      ctx.isEslintrc = false;
-      task.title = `Generating .eslintrc file`;
-      throw Error("Couldn't create file");
-    });
-}
-
-module.exports = createFileTask;

package/bin/lib/getUserInput.js

@@ -1,24 +0,0 @@
-const inquirer = require('inquirer');
-
-function getUserInput() {
-  return inquirer.prompt([
-    {
-      type: 'list',
-      name: 'technology',
-      message: 'which technology are you using?',
-      choices: [
-        {
-          value: 'ts',
-          name: 'ESLint alongside TypeScript',
-        },
-        {
-          value: 'js',
-          name: 'ESLint for JavaScript development',
-        },
-      ],
-      default: 'js',
-    },
-  ]);
-}
-
-module.exports = getUserInput;

package/bin/lib/parseArgs.js

@@ -1,12 +0,0 @@
-const yargs = require('yargs');
-
-const args = yargs(process.argv.slice(2))
-  .alias('t', 'technology')
-  .describe('t', 'Which technology are you using')
-  .choices('t', ['ts', 'js'])
-  .usage('Usage: $0 [-t ts|js]')
-  .example('$0 - ts')
-  .help('h')
-  .alias('h', 'help').argv;
-
-module.exports = args;

package/bin/lib/tasks.js

@@ -1,30 +0,0 @@
-const Listr = require('listr');
-const util = require('util');
-const askWhenConfigExists = require('./askWhenConfigExists');
-const exec = util.promisify(require('child_process').exec);
-const createFileTask = require('./generateFile');
-
-async function createTasks({ packages, eslintrc }) {
-  const installTasks = packages.map(pkg => ({
-    title: `Installing ${pkg}`,
-    task: (ctx, task) => exec(`npm i -D ${pkg}`).then(() => (task.title = `${pkg} Installed`)),
-  }));
-
-  const config = await askWhenConfigExists(eslintrc);
-
-  return new Listr(
-    [
-      {
-        title: 'Installing dependencies using npm',
-        task: () => new Listr(installTasks, { exitOnError: true }),
-      },
-      {
-        title: 'Generating .eslintrc.json file',
-        task: (ctx, task) => createFileTask(config, ctx, task),
-      },
-    ],
-    { exitOnError: false },
-  );
-}
-
-module.exports = createTasks;