@fullstacksjs/eslint-config 8.4.2 → 8.5.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fullstacksjs/eslint-config",
-  "version": "8.4.2",
+  "version": "8.5.1",
   "license": "MIT",
   "author": "fullstacks <fullstacksjs@gmail.com>",
   "description": "fullstacks eslint config",
@@ -32,12 +32,12 @@
   "scripts": {
     "lint": "eslint .",
     "check-rules:base": "eslint-find-rules --unused ./base.js",
-    "check-rules:jest": "eslint-find-rules --no-core --unused ./tests/jest.js",
+    "check-rules:jest": "eslint-find-rules --no-core --deprecated --unused ./tests/jest.js",
     "check-rules:react": "eslint-find-rules --no-core --unused ./tests/react.js",
-    "check-rules:typescript": "eslint-find-rules --no-core --unused ./tests/typescript.js",
-    "check-rules:cypress": "eslint-find-rules --no-core --unused ./tests/cypress.js",
-    "check-rules:graphql": "eslint-find-rules --no-core --unused ./tests/graphql.js",
-    "check-rules:storybook": "eslint-find-rules --no-core --unused ./tests/storybook.js",
+    "check-rules:typescript": "eslint-find-rules --no-core --deprecated --unused ./tests/typescript.js",
+    "check-rules:cypress": "eslint-find-rules --no-core --deprecated --unused ./tests/cypress.js",
+    "check-rules:graphql": "eslint-find-rules --no-core --deprecated --unused ./tests/graphql.js",
+    "check-rules:storybook": "eslint-find-rules --no-core --deprecated --unused ./tests/storybook.js",
     "spell": "cspell ./* --no-progress",
     "test": "npm-run-all --parallel check-rules:* && npm run spell",
     "prepublishOnly": "pinst --disable",
@@ -47,37 +47,37 @@
   "main": "index.js",
   "dependencies": {
     "@frontendmonster/utils": "0.3.11",
-    "@graphql-eslint/eslint-plugin": "3.10.3",
-    "@typescript-eslint/eslint-plugin": "5.20.0",
-    "@typescript-eslint/parser": "5.20.0",
+    "@graphql-eslint/eslint-plugin": "3.10.6",
+    "@typescript-eslint/eslint-plugin": "5.30.7",
+    "@typescript-eslint/parser": "5.30.7",
     "eslint-config-prettier": "8.5.0",
-    "eslint-import-resolver-typescript": "2.7.1",
+    "eslint-import-resolver-typescript": "3.3.0",
     "eslint-plugin-cypress": "2.12.1",
     "eslint-plugin-fp": "2.3.0",
     "eslint-plugin-import": "2.26.0",
-    "eslint-plugin-jest": "26.1.5",
+    "eslint-plugin-jest": "26.6.0",
     "eslint-plugin-jest-formatting": "3.1.0",
-    "eslint-plugin-jsx-a11y": "6.5.1",
+    "eslint-plugin-jsx-a11y": "6.6.1",
     "eslint-plugin-node": "11.1.0",
-    "eslint-plugin-prettier": "4.0.0",
+    "eslint-plugin-prettier": "4.2.1",
     "eslint-plugin-promise": "6.0.0",
-    "eslint-plugin-react": "7.29.4",
-    "eslint-plugin-react-hooks": "4.4.0",
+    "eslint-plugin-react": "7.30.1",
+    "eslint-plugin-react-hooks": "4.6.0",
     "eslint-plugin-simple-import-sort": "7.0.0",
-    "eslint-plugin-storybook": "0.5.11",
+    "eslint-plugin-storybook": "0.6.1",
     "read-pkg-up": "7.0.1"
   },
   "devDependencies": {
-    "cspell": "5.19.7",
-    "eslint": "8.14.0",
+    "cspell": "6.4.1",
+    "eslint": "8.20.0",
     "eslint-find-rules": "4.1.0",
-    "husky": "7.0.4",
-    "lint-staged": "12.4.0",
-    "np": "7.6.1",
+    "husky": "8.0.1",
+    "lint-staged": "13.0.3",
+    "np": "7.6.2",
     "npm-run-all": "4.1.5",
     "pinst": "3.0.0",
-    "prettier": "2.6.2",
-    "typescript": "4.6.3"
+    "prettier": "2.7.1",
+    "typescript": "4.7.4"
   },
   "peerDependencies": {
     "cypress": ">=8",

package/rules/import.js

@@ -37,7 +37,7 @@ module.exports = {
     'import/no-unassigned-import': 'off',
     'import/no-unresolved': ['error', { caseSensitiveStrict: true }],
     'import/no-unused-modules': 'off',
-    'import/no-useless-path-segments': 'off',
+    'import/no-useless-path-segments': 'warn',
     'import/no-webpack-loader-syntax': 'error',
     'import/order': ['off', { groups: ['builtin', ['external', 'internal'], 'parent', ['sibling', 'index']] }], // collision
     'import/prefer-default-export': 'off',

package/rules/jsx-a11y.js

@@ -25,7 +25,6 @@ module.exports = {
     'jsx-a11y/no-noninteractive-element-interactions': 'warn',
     'jsx-a11y/no-noninteractive-element-to-interactive-role': 'warn',
     'jsx-a11y/no-noninteractive-tabindex': 'off',
-    'jsx-a11y/no-onchange': 'off',
     'jsx-a11y/no-redundant-roles': 'error',
     'jsx-a11y/no-static-element-interactions': 'off',
     'jsx-a11y/role-has-required-aria-props': 'error',

package/rules/react.js

@@ -13,7 +13,7 @@ module.exports = {
     'react/function-component-definition': ['warn', { namedComponents: 'arrow-function', unnamedComponents: 'arrow-function' }],
     'react/hook-use-state': 'warn',
     'react/iframe-missing-sandbox': 'error',
-    'react/jsx-boolean-value': 'off',
+    'react/jsx-boolean-value': 'warn',
     'react/jsx-child-element-spacing': 'warn',
     'react/jsx-curly-brace-presence': ['warn', { props: 'never', children: 'ignore' }],
     'react/jsx-filename-extension': ['error', { extensions: ['.jsx', '.tsx'] }],
@@ -26,6 +26,7 @@ module.exports = {
     'react/jsx-no-comment-textnodes': 'error',
     'react/jsx-no-constructed-context-values': 'error',
     'react/jsx-no-duplicate-props': 'error',
+    'react/jsx-no-leaked-render': 'error',
     'react/jsx-no-literals': 'off',
     'react/jsx-no-script-url': 'error',
     'react/jsx-no-target-blank': 'error',

package/rules/storybook.js

@@ -5,6 +5,7 @@ module.exports = {
     'storybook/default-exports': 'error',
     'storybook/hierarchy-separator': 'warn',
     'storybook/no-redundant-story-name': 'warn',
+    'storybook/no-uninstalled-addons': 'error',
     'storybook/prefer-pascal-case': 'warn',
     'storybook/story-exports': 'error',
     'storybook/use-storybook-expect': 'error',

package/rules/typescript-requiring-type-checking.js

@@ -14,6 +14,13 @@ module.exports = {
     '@typescript-eslint/no-redundant-type-constituents': 'warn',
     '@typescript-eslint/no-throw-literal': 'error',
     '@typescript-eslint/no-unnecessary-boolean-literal-compare': 'error',
+    '@typescript-eslint/no-unnecessary-condition': [
+      'warn',
+      {
+        allowConstantLoopConditions: false,
+        allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing: false,
+      },
+    ],
     '@typescript-eslint/no-unnecessary-qualifier': 'error',
     '@typescript-eslint/no-unnecessary-type-arguments': 'error',
     '@typescript-eslint/no-unnecessary-type-assertion': 'error',

package/rules/typescript.js

@@ -16,6 +16,7 @@ module.exports = {
     '@typescript-eslint/ban-types': 'error',
     '@typescript-eslint/camelcase': 'off',
     '@typescript-eslint/class-literal-property-style': ['error', 'getters'],
+    '@typescript-eslint/consistent-generic-constructors': ['warn', 'constructor'],
     '@typescript-eslint/consistent-indexed-object-style': 'off',
     '@typescript-eslint/consistent-type-assertions': 'error',
     '@typescript-eslint/consistent-type-definitions': ['error', 'interface'],
@@ -51,8 +52,7 @@ module.exports = {
       },
       {
         selector: 'memberLike',
-        format: ['camelCase', 'PascalCase', 'UPPER_CASE'],
-        leadingUnderscore: 'allow',
+        format: null,
       },
       {
         selector: 'memberLike',
@@ -85,7 +85,7 @@ module.exports = {
     '@typescript-eslint/no-base-to-string': 'off', // false negative
     '@typescript-eslint/no-confusing-non-null-assertion': 'error',
     '@typescript-eslint/no-dupe-class-members': 'error',
-    '@typescript-eslint/no-duplicate-imports': ['error'],
+    '@typescript-eslint/no-duplicate-enum-values': 'error',
     '@typescript-eslint/no-dynamic-delete': 'error',
     '@typescript-eslint/no-empty-function': 'error',
     '@typescript-eslint/no-empty-interface': 'off', // Annoying with auto-fix on save.
@@ -93,7 +93,6 @@ module.exports = {
     '@typescript-eslint/no-extra-non-null-assertion': 'error',
     '@typescript-eslint/no-extraneous-class': 'error',
     '@typescript-eslint/no-for-in-array': 'error',
-    '@typescript-eslint/no-implicit-any-catch': 'off',
     '@typescript-eslint/no-inferrable-types': 'off',
     '@typescript-eslint/no-invalid-this': ['error', { capIsConstructor: false }],
     '@typescript-eslint/no-invalid-void-type': 'error',
@@ -105,7 +104,6 @@ module.exports = {
     '@typescript-eslint/no-non-null-asserted-nullish-coalescing': 'error',
     '@typescript-eslint/no-non-null-asserted-optional-chain': 'error',
     '@typescript-eslint/no-non-null-assertion': 'off',
-    '@typescript-eslint/no-parameter-properties': 'off',
     '@typescript-eslint/no-redeclare': ['off', { ignoreDeclarationMerge: true }], // useful in FP.
     '@typescript-eslint/no-require-imports': 'error',
     '@typescript-eslint/no-restricted-imports': 'off',
@@ -113,7 +111,6 @@ module.exports = {
     '@typescript-eslint/no-shadow': 'error',
     '@typescript-eslint/no-this-alias': 'error',
     '@typescript-eslint/no-type-alias': 'off',
-    '@typescript-eslint/no-unnecessary-condition': 'off',
     '@typescript-eslint/no-unnecessary-type-constraint': 'warn',
     '@typescript-eslint/no-unsafe-argument': 'off',
     '@typescript-eslint/no-unsafe-assignment': 'off',
@@ -132,6 +129,7 @@ module.exports = {
     '@typescript-eslint/no-useless-empty-export': 'warn',
     '@typescript-eslint/no-var-requires': 'error',
     '@typescript-eslint/object-curly-spacing': 'warn',
+    '@typescript-eslint/parameter-properties': 'off',
     '@typescript-eslint/padding-line-between-statements': ['warn', { blankLine: 'always', prev: ['return'], next: ['export'] }],
     '@typescript-eslint/prefer-as-const': 'warn',
     '@typescript-eslint/prefer-enum-initializers': 'off',
@@ -187,7 +185,6 @@ module.exports = {
     'default-param-last': 'off',
     'init-declarations': 'off',
     'lines-between-class-members': 'off',
-    'no-duplicate-imports': 'off',
     'no-invalid-this': 'off',
     'no-loop-func': 'off',
     'no-redeclare': 'off',