@fullstacksjs/eslint-config 7.0.0 → 7.1.0

package/README.md

@@ -115,7 +115,7 @@ If you need more advanced `typescript-eslint` rules, then you can extend from `"
 * eslint-plugin-simple-import-sort
 * eslint-plugin-fp
 * eslint-plugin-node
-* ~~eslint-plugin-promise~~ ⚠️ Disabled in v7-beta, because it's not currently supports eslint@8 ([Issue](https://github.com/xjamundx/eslint-plugin-promise/issues/218))
+* eslint-plugin-promise
 
 That's all. Feel free to use 💛
 

package/base.js

@@ -1,12 +1,5 @@
 module.exports = {
-  plugins: [
-    'prettier',
-    'import',
-    'simple-import-sort',
-    // 'promise' PENDING: https://github.com/xjamundx/eslint-plugin-promise/issues/218
-    'node',
-    'fp',
-  ],
+  plugins: ['prettier', 'import', 'simple-import-sort', 'promise', 'node', 'fp'],
   parserOptions: {
     ecmaVersion: 2020,
     sourceType: 'module',
@@ -34,7 +27,7 @@ module.exports = {
     './rules/style',
     './rules/variables',
     './rules/fp',
-    // './rules/promise', PENDING: https://github.com/xjamundx/eslint-plugin-promise/issues/218
+    './rules/promise',
     './rules/node',
     'prettier',
   ],

package/jest.js

@@ -1,7 +1,15 @@
+const exts = '(js|jsx|ts|tsx)';
+const dirs = '(test|tests|__test__|__tests__|spec|specs)';
+
 module.exports = {
-  plugins: ['jest', 'jest-formatting'],
-  env: {
-    'jest/globals': true,
-  },
-  extends: ['./rules/jest'],
+  overrides: [
+    {
+      files: [`**/${dirs}/**/*.${exts}`, `**/**/*.(spec|test).${exts}`],
+      plugins: ['jest', 'jest-formatting'],
+      env: {
+        'jest/globals': true,
+      },
+      extends: ['./rules/jest'],
+    },
+  ],
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fullstacksjs/eslint-config",
-  "version": "7.0.0",
+  "version": "7.1.0",
   "license": "MIT",
   "author": "fullstacks <fullstacksjs@gmail.com>",
   "description": "fullstacks eslint config",
@@ -45,34 +45,35 @@
     "eslint-plugin-cypress": "2.12.1",
     "eslint-plugin-fp": "2.3.0",
     "eslint-plugin-import": "2.25.3",
-    "eslint-plugin-jest-formatting": "3.1.0",
     "eslint-plugin-jest": "25.3.0",
+    "eslint-plugin-jest-formatting": "3.1.0",
     "eslint-plugin-jsx-a11y": "6.5.1",
     "eslint-plugin-node": "11.1.0",
     "eslint-plugin-prettier": "4.0.0",
-    "eslint-plugin-react-hooks": "4.3.0",
+    "eslint-plugin-promise": "6.0.0",
     "eslint-plugin-react": "7.27.1",
+    "eslint-plugin-react-hooks": "4.3.0",
     "eslint-plugin-simple-import-sort": "7.0.0",
     "lodash.has": "4.5.2",
     "read-pkg-up": "7.0.1"
   },
   "devDependencies": {
-    "eslint": "8.4.1",
+    "eslint": "8.5.0",
     "eslint-find-rules": "4.0.0",
     "husky": "7.0.4",
-    "lint-staged": "12.1.2",
+    "lint-staged": "12.1.3",
     "np": "7.6.0",
     "npm-run-all": "4.1.5",
     "pinst": "2.1.6",
     "prettier": "2.5.1",
-    "typescript": "4.5.2"
+    "typescript": "4.5.4"
   },
   "peerDependencies": {
+    "cypress": ">=8",
     "eslint": ">=7",
     "prettier": "2",
     "react": ">=16",
-    "typescript": "4",
-    "cypress": ">=8"
+    "typescript": "4"
   },
   "peerDependenciesMeta": {
     "typescript": {

package/rules/es2015.js

@@ -25,5 +25,6 @@ module.exports = {
     'prefer-template': 'error',
     'require-yield': 'error',
     'symbol-description': 'error',
+    'prefer-object-has-own': 'warn',
   },
 };

package/rules/jest.js

@@ -47,12 +47,11 @@ module.exports = {
     'jest/require-top-level-describe': 'off',
     'jest/unbound-method': 'error',
     'jest/valid-describe-callback': 'error',
-    'jest/valid-describe': 'error',
     'jest/valid-expect-in-promise': 'error',
     'jest/valid-expect': 'error',
     'jest/valid-title': 'warn',
 
-    // jest-formatiing
+    // jest-formatting
     'jest-formatting/padding-around-after-all-blocks': 'warn',
     'jest-formatting/padding-around-after-each-blocks': 'warn',
     'jest-formatting/padding-around-all': 'warn',

package/rules/typescript-requiring-type-checking.js

@@ -1,6 +1,7 @@
 module.exports = {
   rules: {
     '@typescript-eslint/await-thenable': 'error',
+    '@typescript-eslint/consistent-type-exports': 'warn',
     '@typescript-eslint/dot-notation': [
       'warn',
       { allowPrivateClassPropertyAccess: false, allowProtectedClassPropertyAccess: false, allowIndexSignaturePropertyAccess: true },

package/rules/typescript.js

@@ -58,7 +58,6 @@ module.exports = {
     '@typescript-eslint/no-require-imports': 'error',
     '@typescript-eslint/no-restricted-imports': 'off',
     '@typescript-eslint/consistent-type-imports': ['warn', { prefer: 'type-imports', disallowTypeAnnotations: false }],
-    '@typescript-eslint/consistent-type-exports': 'warn',
     '@typescript-eslint/no-shadow': 'error',
     '@typescript-eslint/no-this-alias': 'error',
     '@typescript-eslint/no-type-alias': 'off',
@@ -80,7 +79,7 @@ module.exports = {
     '@typescript-eslint/no-useless-constructor': 'error',
     '@typescript-eslint/no-var-requires': 'error',
     '@typescript-eslint/object-curly-spacing': 'warn',
-    '@typescript-eslint/padding-line-between-statements': ['warn', { blankLine: 'always', prev: ['return', 'export'], next: 'export' }],
+    '@typescript-eslint/padding-line-between-statements': ['warn', { blankLine: 'always', prev: ['return'], next: ['export'] }],
     '@typescript-eslint/prefer-as-const': 'warn',
     '@typescript-eslint/prefer-enum-initializers': 'off',
     '@typescript-eslint/prefer-for-of': 'warn',