@fullstacksjs/eslint-config 13.5.0 → 13.7.0

package/README.md

@@ -50,7 +50,7 @@ You can fine-tune module detection by overriding it, the `defineConfig` function
 
 ```typescript
 interface Options {
-  react?: boolean; // controls react, react-hooks, jsx/a11y plugins
+  react?: boolean | { additionalEffectHooks?: string }; // controls react, react-hooks, jsx/a11y plugins
   typescript?: ParserOptions // https://typescript-eslint.io/packages/parser#configuration
   node?: boolean; // controls node plugin
   sort?: boolean; // controls perfectionist plugin

package/cjs/index.d.ts

@@ -19,7 +19,7 @@ export interface Options extends Linter.Config {
    * Controls React plugin.
    * @default true - If you have `react` or `react-dom` in your dependencies.
    */
-  react?: boolean;
+  react?: boolean | { additionalEffectHooks?: string };
   /**
    * @default true
    */

package/cjs/modules/react.js

@@ -7,9 +7,11 @@ Object.defineProperty(exports, "__esModule", {
 var _eslintPlugin = _interopRequireDefault(require("@eslint-react/eslint-plugin"));
 var _eslintPluginJsxA11y = _interopRequireDefault(require("eslint-plugin-jsx-a11y"));
 var _eslintPluginReactHooks = _interopRequireDefault(require("eslint-plugin-react-hooks"));
+var _conditions = require("../utils/conditions.js");
 function _interopRequireDefault(e) { return e && e.__esModule ? e : { default: e }; }
 /** @return { import('eslint').Linter.Config } */
-function react() {
+function react(options = {}) {
+  const projectService = options.typescript && options.typescript.tsconfigRootDir && options.typescript.projectService;
   return {
     plugins: {
       ..._eslintPlugin.default.configs.all.plugins,
@@ -17,9 +19,12 @@ function react() {
       'jsx-a11y': _eslintPluginJsxA11y.default
     },
     settings: {
-      react: {
+      'react': {
         pragma: 'React',
         version: 'detect'
+      },
+      'react-hooks': {
+        additionalEffectHooks: options.react.additionalEffectHooks
       }
     },
     rules: {
@@ -83,7 +88,9 @@ function react() {
       '@eslint-react/no-unstable-default-props': 'error',
       '@eslint-react/no-unused-class-component-members': 'warn',
       '@eslint-react/no-unused-state': 'warn',
-      '@eslint-react/no-unused-props': 'off',
+      ...(0, _conditions.predicate)(projectService, {
+        '@eslint-react/no-unused-props': 'warn'
+      }),
       '@eslint-react/no-useless-forward-ref': 'off',
       '@eslint-react/no-useless-fragment': 'warn',
       '@eslint-react/no-use-context': 'warn',

package/cjs/modules/typescript.js

@@ -63,8 +63,6 @@ function typescript(options = {}) {
         prefix: ['is', 'should', 'has', 'can', 'did', 'will', 'enable', 'loading']
       }] : [])],
       '@typescript-eslint/no-array-constructor': 'error',
-      '@typescript-eslint/no-base-to-string': 'off',
-      // false negative
       '@typescript-eslint/no-confusing-non-null-assertion': 'error',
       '@typescript-eslint/no-dupe-class-members': 'error',
       '@typescript-eslint/no-duplicate-enum-values': 'error',
@@ -171,6 +169,7 @@ function typescript(options = {}) {
           allowProtectedClassPropertyAccess: false,
           allowIndexSignaturePropertyAccess: true
         }],
+        '@typescript-eslint/no-base-to-string': 'error',
         '@typescript-eslint/no-confusing-void-expression': ['off', {
           ignoreArrowShorthand: true,
           ignoreVoidOperator: true

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fullstacksjs/eslint-config",
-  "version": "13.5.0",
+  "version": "13.7.0",
   "license": "MIT",
   "author": "fullstacks <fullstacksjs@gmail.com>",
   "description": "fullstacks eslint config",
@@ -35,7 +35,7 @@
     }
   },
   "dependencies": {
-    "@eslint-react/eslint-plugin": "2.0.0",
+    "@eslint-react/eslint-plugin": "2.0.6",
     "@eslint/compat": "1.4.0",
     "@next/eslint-plugin-next": "15.5.4",
     "@stylistic/eslint-plugin": "5.4.0",
@@ -51,7 +51,7 @@
     "eslint-plugin-playwright": "2.2.2",
     "eslint-plugin-prettier": "5.5.4",
     "eslint-plugin-promise": "7.2.1",
-    "eslint-plugin-react-hooks": "5.2.0",
+    "eslint-plugin-react-hooks": "6.1.1",
     "eslint-plugin-regexp": "2.10.0",
     "eslint-plugin-storybook": "0.12.0",
     "globals": "16.4.0",

package/src/index.d.ts

@@ -19,7 +19,7 @@ export interface Options extends Linter.Config {
    * Controls React plugin.
    * @default true - If you have `react` or `react-dom` in your dependencies.
    */
-  react?: boolean;
+  react?: boolean | { additionalEffectHooks?: string };
   /**
    * @default true
    */

package/src/modules/react.mjs

@@ -2,8 +2,12 @@ import reactPlugin from '@eslint-react/eslint-plugin';
 import a11yPlugin from 'eslint-plugin-jsx-a11y';
 import hooksPlugin from 'eslint-plugin-react-hooks';
 
+import { predicate } from '../utils/conditions.mjs';
+
 /** @return { import('eslint').Linter.Config } */
-function react() {
+function react(options = {}) {
+  const projectService = options.typescript && options.typescript.tsconfigRootDir && options.typescript.projectService;
+
   return {
     plugins: {
       ...reactPlugin.configs.all.plugins,
@@ -11,10 +15,13 @@ function react() {
       'jsx-a11y': a11yPlugin,
     },
     settings: {
-      react: {
+      'react': {
         pragma: 'React',
         version: 'detect',
       },
+      'react-hooks': {
+        additionalEffectHooks: options.react.additionalEffectHooks,
+      },
     },
     rules: {
       '@eslint-react/dom/no-void-elements-with-children': 'warn',
@@ -79,7 +86,9 @@ function react() {
       '@eslint-react/no-unstable-default-props': 'error',
       '@eslint-react/no-unused-class-component-members': 'warn',
       '@eslint-react/no-unused-state': 'warn',
-      '@eslint-react/no-unused-props': 'off',
+      ...predicate(projectService, {
+        '@eslint-react/no-unused-props': 'warn',
+      }),
       '@eslint-react/no-useless-forward-ref': 'off',
       '@eslint-react/no-useless-fragment': 'warn',
       '@eslint-react/no-use-context': 'warn',

package/src/modules/typescript.mjs

@@ -68,7 +68,6 @@ function typescript(options = {}) {
           : []),
       ],
       '@typescript-eslint/no-array-constructor': 'error',
-      '@typescript-eslint/no-base-to-string': 'off', // false negative
       '@typescript-eslint/no-confusing-non-null-assertion': 'error',
       '@typescript-eslint/no-dupe-class-members': 'error',
       '@typescript-eslint/no-duplicate-enum-values': 'error',
@@ -156,6 +155,7 @@ function typescript(options = {}) {
             allowIndexSignaturePropertyAccess: true,
           },
         ],
+        '@typescript-eslint/no-base-to-string': 'error',
         '@typescript-eslint/no-confusing-void-expression': ['off', { ignoreArrowShorthand: true, ignoreVoidOperator: true }], // Annoying and conflict with @typescript-eslint/no-meaningless-void-operator
         '@typescript-eslint/no-duplicate-type-constituents': 'warn',
         '@typescript-eslint/no-for-in-array': 'error',