@fullstacksjs/eslint-config 13.13.2 → 13.14.0

package/README.md

@@ -30,6 +30,7 @@ import { defineConfig } from '@fullstacksjs/eslint-config';
 export default defineConfig({
   typescript: {
     tsconfigRootDir: import.meta.dirname, // Recommended when using TypeScript
+  }
 });
 ```
 
@@ -182,7 +183,7 @@ import/no-deprecated
 
 ```js
 export default defineConfig({
-  disableExpensiveRules: !process.env.CI || !process.env.HUSKY // Or anywhere you want
+  disableExpensiveRules: !process.env.CI || !process.env.HUSKY, // Or anywhere you want
   prettier: false // So you should run the formatter explicitly.
 });
 ```

package/cjs/modules/jest.js

@@ -6,12 +6,14 @@ Object.defineProperty(exports, "__esModule", {
 
 var _eslintPluginJest = _interopRequireDefault(require("eslint-plugin-jest"));
 var _globals = _interopRequireDefault(require("globals"));
+var _conditions = require("../utils/conditions.js");
 var _globs = require("../utils/globs.js");
 function _interopRequireDefault(e) { return e && e.__esModule ? e : { default: e }; }
 /**
  * @param { import('../index.js').Options } options
  * @return { import('eslint').Linter.Config } */
-function jest() {
+function jest(options = {}) {
+  const projectService = options.typescript && options.typescript.tsconfigRootDir && options.typescript.projectService;
   return {
     files: _globs.globs.test,
     plugins: {
@@ -37,6 +39,10 @@ function jest() {
       'jest/no-done-callback': 'warn',
       'jest/no-expect-resolves': 'off',
       'jest/no-export': 'error',
+      ...(0, _conditions.predicate)(projectService, {
+        'jest/no-error-equal': 'error',
+        'jest/no-unnecessary-assertion': 'warn'
+      }),
       'jest/no-hooks': 'off',
       'jest/no-interpolation-in-snapshots': 'error',
       'jest/no-jasmine-globals': 'off',
@@ -60,6 +66,7 @@ function jest() {
       'jest/prefer-inline-snapshots': 'off',
       'jest/prefer-lowercase-title': 'off',
       'jest/prefer-mock-promise-shorthand': 'warn',
+      'jest/prefer-mock-return-shorthand': 'warn',
       'jest/prefer-snapshot-hint': 'warn',
       'jest/prefer-spy-on': 'off',
       'jest/prefer-strict-equal': 'off',

package/cjs/modules/react.js

@@ -112,7 +112,7 @@ function react(options = {}) {
       '@eslint-react/no-unnecessary-key': 'warn',
       '@eslint-react/prefer-use-state-lazy-initialization': 'warn',
       '@eslint-react/prefer-destructuring-assignment': 'warn',
-      '@eslint-react/hooks-extra/no-direct-set-state-in-use-effect': 'warn',
+      '@eslint-react/hooks-extra/no-direct-set-state-in-use-effect': 'off',
       '@eslint-react/naming-convention/component-name': 'warn',
       '@eslint-react/naming-convention/context-name': 'warn',
       '@eslint-react/naming-convention/filename-extension': ['error', {
@@ -120,7 +120,11 @@ function react(options = {}) {
         extensions: ['.jsx', '.tsx']
       }],
       '@eslint-react/naming-convention/filename': 'off',
-      '@eslint-react/naming-convention/use-state': 'off',
+      '@eslint-react/naming-convention/ref-name': 'warn',
+      '@eslint-react/naming-convention/use-state': ['warn', {
+        enforceAssignment: true,
+        enforceSetterName: false
+      }],
       '@eslint-react/web-api/no-leaked-timeout': 'error',
       '@eslint-react/web-api/no-leaked-event-listener': 'error',
       '@eslint-react/web-api/no-leaked-interval': 'error',

package/cjs/modules/stylistic.js

@@ -25,9 +25,8 @@ function stylistic() {
         component: true,
         html: true
       }],
-      '@stylistic/no-mixed-operators': ['error', {
-        allowSamePrecedence: true
-      }],
+      '@stylistic/no-mixed-operators': 'off',
+      //conflict with prettier
       '@stylistic/padding-line-between-statements': ['warn', {
         blankLine: 'always',
         prev: ['case', 'default'],

package/cjs/modules/typescript.js

@@ -128,8 +128,7 @@ function typescript(options = {}) {
         classes: true
       }],
       '@typescript-eslint/no-useless-constructor': 'error',
-      '@typescript-eslint/no-useless-default-assignment': 'off',
-      // Re-enable after fix https://github.com/typescript-eslint/typescript-eslint/issues/11849
+      '@typescript-eslint/no-useless-default-assignment': 'warn',
       '@typescript-eslint/no-useless-empty-export': 'warn',
       '@typescript-eslint/parameter-properties': 'off',
       '@typescript-eslint/prefer-as-const': 'warn',

package/cjs/modules/vitest.js

@@ -65,6 +65,7 @@ function vitest() {
       'vitest/no-standalone-expect': 'warn',
       'vitest/no-test-prefixes': 'warn',
       'vitest/no-test-return-statement': 'warn',
+      'vitest/no-unneeded-async-expect-function': 'warn',
       'vitest/prefer-called-once': 'warn',
       'vitest/prefer-called-times': 'off',
       'vitest/prefer-called-with': 'warn',
@@ -79,6 +80,7 @@ function vitest() {
       'vitest/prefer-importing-vitest-globals': 'off',
       'vitest/prefer-lowercase-title': 'warn',
       'vitest/prefer-mock-promise-shorthand': 'warn',
+      'vitest/prefer-mock-return-shorthand': 'warn',
       'vitest/prefer-snapshot-hint': 'warn',
       'vitest/prefer-spy-on': 'warn',
       'vitest/prefer-strict-boolean-matchers': 'off',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fullstacksjs/eslint-config",
-  "version": "13.13.2",
+  "version": "13.14.0",
   "license": "MIT",
   "author": "fullstacks <fullstacksjs@gmail.com>",
   "description": "fullstacks eslint config",
@@ -9,7 +9,8 @@
     "url": "git+https://github.com/fullstacksjs/eslint-config.git"
   },
   "publishConfig": {
-    "registry": "https://registry.npmjs.org"
+    "access": "public",
+    "provenance": true
   },
   "files": [
     "src",
@@ -36,28 +37,28 @@
     }
   },
   "dependencies": {
-    "@eslint-react/eslint-plugin": "2.3.13",
+    "@eslint-react/eslint-plugin": "2.5.1",
     "@eslint/compat": "2.0.0",
-    "@next/eslint-plugin-next": "16.0.10",
+    "@next/eslint-plugin-next": "16.1.1",
     "@stylistic/eslint-plugin": "5.6.1",
-    "@vitest/eslint-plugin": "1.5.2",
+    "@vitest/eslint-plugin": "1.6.5",
     "deepmerge": "4.3.1",
     "eslint-plugin-better-tailwindcss": "3.8.0",
     "eslint-plugin-cypress": "5.2.0",
     "eslint-plugin-import-x": "4.16.1",
-    "eslint-plugin-jest": "29.5.0",
+    "eslint-plugin-jest": "29.12.1",
     "eslint-plugin-jsx-a11y": "6.10.2",
     "eslint-plugin-n": "17.23.1",
-    "eslint-plugin-perfectionist": "5.0.0",
+    "eslint-plugin-perfectionist": "5.2.0",
     "eslint-plugin-playwright": "2.4.0",
     "eslint-plugin-prettier": "5.5.4",
     "eslint-plugin-promise": "7.2.1",
     "eslint-plugin-react-hooks": "7.0.1",
     "eslint-plugin-regexp": "2.10.0",
-    "eslint-plugin-storybook": "10.1.10",
-    "globals": "16.5.0",
+    "eslint-plugin-storybook": "10.1.11",
+    "globals": "17.0.0",
     "local-pkg": "1.1.2",
-    "typescript-eslint": "8.50.0"
+    "typescript-eslint": "8.51.0"
   },
   "devDependencies": {
     "@eslint/eslintrc": "3.3.3",
@@ -74,7 +75,7 @@
     "pinst": "3.0.0",
     "prettier": "3.7.4",
     "semantic-release": "25.0.2",
-    "storybook": "10.1.10",
+    "storybook": "10.1.11",
     "typescript": "5.9.3",
     "unbuild": "3.6.1"
   },

package/src/modules/jest.mjs

@@ -1,12 +1,15 @@
 import plugin from 'eslint-plugin-jest';
 import globals from 'globals';
 
+import { predicate } from '../utils/conditions.mjs';
 import { globs } from '../utils/globs.mjs';
 
 /**
  * @param { import('..').Options } options
  * @return { import('eslint').Linter.Config } */
-function jest() {
+function jest(options = {}) {
+  const projectService = options.typescript && options.typescript.tsconfigRootDir && options.typescript.projectService;
+
   return {
     files: globs.test,
     plugins: { jest: plugin },
@@ -28,6 +31,10 @@ function jest() {
       'jest/no-done-callback': 'warn',
       'jest/no-expect-resolves': 'off',
       'jest/no-export': 'error',
+      ...predicate(projectService, {
+        'jest/no-error-equal': 'error',
+        'jest/no-unnecessary-assertion': 'warn',
+      }),
       'jest/no-hooks': 'off',
       'jest/no-interpolation-in-snapshots': 'error',
       'jest/no-jasmine-globals': 'off',
@@ -49,6 +56,7 @@ function jest() {
       'jest/prefer-inline-snapshots': 'off',
       'jest/prefer-lowercase-title': 'off',
       'jest/prefer-mock-promise-shorthand': 'warn',
+      'jest/prefer-mock-return-shorthand': 'warn',
       'jest/prefer-snapshot-hint': 'warn',
       'jest/prefer-spy-on': 'off',
       'jest/prefer-strict-equal': 'off',

package/src/modules/react.mjs

@@ -110,13 +110,20 @@ function react(options = {}) {
       '@eslint-react/prefer-use-state-lazy-initialization': 'warn',
       '@eslint-react/prefer-destructuring-assignment': 'warn',
 
-      '@eslint-react/hooks-extra/no-direct-set-state-in-use-effect': 'warn',
+      '@eslint-react/hooks-extra/no-direct-set-state-in-use-effect': 'off',
 
       '@eslint-react/naming-convention/component-name': 'warn',
       '@eslint-react/naming-convention/context-name': 'warn',
       '@eslint-react/naming-convention/filename-extension': ['error', { allow: 'always', extensions: ['.jsx', '.tsx'] }],
       '@eslint-react/naming-convention/filename': 'off',
-      '@eslint-react/naming-convention/use-state': 'off',
+      '@eslint-react/naming-convention/ref-name': 'warn',
+      '@eslint-react/naming-convention/use-state': [
+        'warn',
+        {
+          enforceAssignment: true,
+          enforceSetterName: false,
+        },
+      ],
 
       '@eslint-react/web-api/no-leaked-timeout': 'error',
       '@eslint-react/web-api/no-leaked-event-listener': 'error',

package/src/modules/stylistic.mjs

@@ -16,7 +16,7 @@ function stylistic() {
           html: true,
         },
       ],
-      '@stylistic/no-mixed-operators': ['error', { allowSamePrecedence: true }],
+      '@stylistic/no-mixed-operators': 'off', //conflict with prettier
       '@stylistic/padding-line-between-statements': [
         'warn',
         { blankLine: 'always', prev: ['case', 'default'], next: '*' },

package/src/modules/typescript.mjs

@@ -117,7 +117,7 @@ function typescript(options = {}) {
       ],
       '@typescript-eslint/no-use-before-define': ['error', { functions: false, classes: true }],
       '@typescript-eslint/no-useless-constructor': 'error',
-      '@typescript-eslint/no-useless-default-assignment': 'off', // Re-enable after fix https://github.com/typescript-eslint/typescript-eslint/issues/11849
+      '@typescript-eslint/no-useless-default-assignment': 'warn',
       '@typescript-eslint/no-useless-empty-export': 'warn',
       '@typescript-eslint/parameter-properties': 'off',
       '@typescript-eslint/prefer-as-const': 'warn',

package/src/modules/vitest.mjs

@@ -58,6 +58,7 @@ function vitest() {
       'vitest/no-standalone-expect': 'warn',
       'vitest/no-test-prefixes': 'warn',
       'vitest/no-test-return-statement': 'warn',
+      'vitest/no-unneeded-async-expect-function': 'warn',
 
       'vitest/prefer-called-once': 'warn',
       'vitest/prefer-called-times': 'off',
@@ -73,6 +74,7 @@ function vitest() {
       'vitest/prefer-importing-vitest-globals': 'off',
       'vitest/prefer-lowercase-title': 'warn',
       'vitest/prefer-mock-promise-shorthand': 'warn',
+      'vitest/prefer-mock-return-shorthand': 'warn',
       'vitest/prefer-snapshot-hint': 'warn',
       'vitest/prefer-spy-on': 'warn',
       'vitest/prefer-strict-boolean-matchers': 'off',