@fullstackhouse/cerber 1.6.5-pr.95.8074716 → 1.7.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +1 -3
- package/dist/core/autoreview.js +3 -5
- package/dist/core/config.js +0 -6
- package/dist/core/gh.js +7 -25
- package/dist/runner/prompt.js +6 -2
- package/dist/server/daemon.js +4 -20
- package/dist/server/index.js +1 -6
- package/package.json +1 -1
- package/web/dist/assets/{abnfDiagram-WEYOIA3C-BR44kMtj.js → abnfDiagram-WEYOIA3C-Fh0yGAPG.js} +1 -1
- package/web/dist/assets/{arc-3ystEIhw.js → arc-Cb1J4kng.js} +1 -1
- package/web/dist/assets/{architectureDiagram-ZHVYKT53-DXqQcprP.js → architectureDiagram-ZHVYKT53-BwxCVhjO.js} +1 -1
- package/web/dist/assets/{blockDiagram-RJAE7QA3-BP1Q4TtO.js → blockDiagram-RJAE7QA3-Czr1-oa6.js} +1 -1
- package/web/dist/assets/{c4Diagram-XDPPPE54-CtJ6gTyt.js → c4Diagram-XDPPPE54-ZWephAkD.js} +1 -1
- package/web/dist/assets/channel-B2B4MLqH.js +1 -0
- package/web/dist/assets/{chunk-2E7WHVMD-DR3KXQXv.js → chunk-2E7WHVMD-9Ra4B9GU.js} +1 -1
- package/web/dist/assets/{chunk-2Q5K7J3B-y2NRT60i.js → chunk-2Q5K7J3B-B7nbgFC1.js} +1 -1
- package/web/dist/assets/{chunk-4EMNKR2T-BIdX0Ds_.js → chunk-4EMNKR2T-CUVvjeAx.js} +1 -1
- package/web/dist/assets/{chunk-55XCU76K-Gan0lnQz.js → chunk-55XCU76K-DZ3RW9-h.js} +1 -1
- package/web/dist/assets/{chunk-5VM5RSS4-Djpz9IvY.js → chunk-5VM5RSS4-BY-uxMkf.js} +1 -1
- package/web/dist/assets/{chunk-JWPE2WC7-Bixj1CbF.js → chunk-JWPE2WC7-BJYQI99_.js} +1 -1
- package/web/dist/assets/{chunk-VQ5W62QI-Cmj0GKOF.js → chunk-VQ5W62QI-Dm8jJYkz.js} +1 -1
- package/web/dist/assets/{chunk-XXDRQBXY-DvlqGcP7.js → chunk-XXDRQBXY-CZhz6VLZ.js} +1 -1
- package/web/dist/assets/{chunk-ZCHMQSOR-eg5pae0j.js → chunk-ZCHMQSOR-D6zBviZp.js} +2 -2
- package/web/dist/assets/{classDiagram-v2-4MYWR3UA-DgOd-PQK.js → classDiagram-v2-4MYWR3UA-Lvv4Rf4Q.js} +1 -1
- package/web/dist/assets/{cose-bilkent-JH36ORCC-J_gvWNP0.js → cose-bilkent-JH36ORCC-V9TmXird.js} +1 -1
- package/web/dist/assets/{cynefin-EF2NZ3EQ-B_SKzor5.js → cynefin-EF2NZ3EQ-CcAG0DdN.js} +1 -1
- package/web/dist/assets/{cynefinDiagram-WF24UDRP-BfF5Qbgg.js → cynefinDiagram-WF24UDRP-CtbdsXNX.js} +1 -1
- package/web/dist/assets/{dagre-NK4GIZVX-CWBvgfMf.js → dagre-NK4GIZVX-KKp07WGv.js} +1 -1
- package/web/dist/assets/{diagram-CBK3MWTC-DmJhvsT0.js → diagram-CBK3MWTC-OmZxbfpK.js} +1 -1
- package/web/dist/assets/{diagram-I5XIIV2D-BJP096jB.js → diagram-I5XIIV2D-B4A3VXFh.js} +1 -1
- package/web/dist/assets/{diagram-ODIL2UCW-DXH-iGSW.js → diagram-ODIL2UCW-C6AL0pfJ.js} +1 -1
- package/web/dist/assets/{diagram-PFBEJUXE-DahNwDhl.js → diagram-PFBEJUXE-9n22hgzP.js} +1 -1
- package/web/dist/assets/{diagram-RJA3I4VV-CqUUXvNd.js → diagram-RJA3I4VV-BZahmd4j.js} +1 -1
- package/web/dist/assets/{diagram-TYUNFSNR-BgNHeOUY.js → diagram-TYUNFSNR-Vyr_m4Hx.js} +1 -1
- package/web/dist/assets/{ebnfDiagram-V4P3TTPT-HJCdw74K.js → ebnfDiagram-V4P3TTPT-BZokt2V8.js} +1 -1
- package/web/dist/assets/{elk-QONTBCTQ-B-AM96rF.js → elk-QONTBCTQ-35jgsktE.js} +1 -1
- package/web/dist/assets/{erDiagram-KYQIGQAA-CUFDCvC8.js → erDiagram-KYQIGQAA-DnORD9ar.js} +1 -1
- package/web/dist/assets/{flowDiagram-IUGLLWBU-COI4PSAH.js → flowDiagram-IUGLLWBU-DIloo7Vk.js} +1 -1
- package/web/dist/assets/{ganttDiagram-R7GPNTJY-COwqNgzN.js → ganttDiagram-R7GPNTJY-uCf1-IbQ.js} +1 -1
- package/web/dist/assets/{gitGraphDiagram-PDYL7XHY-B52YBCM_.js → gitGraphDiagram-PDYL7XHY-Dps9Z6YN.js} +1 -1
- package/web/dist/assets/{index-D_0po9OL.css → index-C-BR2leN.css} +1 -1
- package/web/dist/assets/{index-pX1lTtx6.js → index-DbkXcP68.js} +21 -17
- package/web/dist/assets/{infoDiagram-MVDRKAX5-qPAx6ekp.js → infoDiagram-MVDRKAX5-CSzv2WOS.js} +1 -1
- package/web/dist/assets/{ishikawaDiagram-HPEHV2GE-DL1RNW_l.js → ishikawaDiagram-HPEHV2GE-CfOyv1nx.js} +1 -1
- package/web/dist/assets/{journeyDiagram-BOSHW7O7-B5wiCWgX.js → journeyDiagram-BOSHW7O7-B9GewZrz.js} +1 -1
- package/web/dist/assets/{kanban-definition-FNSA4HC5-DMmdTutW.js → kanban-definition-FNSA4HC5-Dk60DC_q.js} +1 -1
- package/web/dist/assets/{linear-UDQwLr4L.js → linear-CFibZx3K.js} +1 -1
- package/web/dist/assets/{mermaid.core-uOazfyc1.js → mermaid.core-DSlXNYTz.js} +4 -4
- package/web/dist/assets/{mindmap-definition-6OY57UG3-Cn-sK0gY.js → mindmap-definition-6OY57UG3-nPEcKx2O.js} +1 -1
- package/web/dist/assets/{pegDiagram-ECIUJNBX-BedOHpzJ.js → pegDiagram-ECIUJNBX-BF7-dOgl.js} +1 -1
- package/web/dist/assets/{pieDiagram-GNMPY74T-BeVcAjsQ.js → pieDiagram-GNMPY74T-D3xpwkOg.js} +1 -1
- package/web/dist/assets/{quadrantDiagram-D57K4MC3-UmC-iPXF.js → quadrantDiagram-D57K4MC3-wvZrxdaZ.js} +1 -1
- package/web/dist/assets/{railroadDiagram-Y72NRBL7-CJelcBGC.js → railroadDiagram-Y72NRBL7-Bhmlwnxc.js} +1 -1
- package/web/dist/assets/{requirementDiagram-EQYSW5RA-BzjyYj14.js → requirementDiagram-EQYSW5RA-BISS6nU8.js} +1 -1
- package/web/dist/assets/{sankeyDiagram-SY24JHO5-onqTMiB4.js → sankeyDiagram-SY24JHO5-B13SKEJi.js} +1 -1
- package/web/dist/assets/{sequenceDiagram-BLEHNHQU-B0VStBpK.js → sequenceDiagram-BLEHNHQU-CFoMSq2Y.js} +1 -1
- package/web/dist/assets/{sizeCapture-INFHLROL-ErSVibHr.js → sizeCapture-INFHLROL-B_9ZQIpO.js} +1 -1
- package/web/dist/assets/{stateDiagram-v2-A6IESKWZ-DCs1Nd-f.js → stateDiagram-v2-A6IESKWZ-0f03epu-.js} +1 -1
- package/web/dist/assets/{swimlanes-B3ENRKFQ-CncsMWEi.js → swimlanes-B3ENRKFQ-VbPJcmFg.js} +1 -1
- package/web/dist/assets/swimlanesDiagram-AYQRV4AK-gEpmrKi3.js +8 -0
- package/web/dist/assets/{timeline-definition-JXYKGLGB-CL8XykNQ.js → timeline-definition-JXYKGLGB-BL-ztRYD.js} +1 -1
- package/web/dist/assets/{usecaseDiagram-WPOLBNNX-TZNARo13.js → usecaseDiagram-WPOLBNNX-dNJWmkMH.js} +1 -1
- package/web/dist/assets/{vennDiagram-Q3Y3IDCW-IGqYWfQ_.js → vennDiagram-Q3Y3IDCW-7Usz7k8p.js} +1 -1
- package/web/dist/assets/{wardleyDiagram-IVAIDKWA-CbRzgVFX.js → wardleyDiagram-IVAIDKWA-C0eZqxRB.js} +1 -1
- package/web/dist/assets/{xychartDiagram-4URNHDU4--7AWBTst.js → xychartDiagram-4URNHDU4-z6jTf4_g.js} +1 -1
- package/web/dist/index.html +2 -2
- package/web/dist/assets/channel-D7LGJ7OI.js +0 -1
- package/web/dist/assets/swimlanesDiagram-AYQRV4AK-CfNkGCeP.js +0 -8
package/README.md
CHANGED
|
@@ -88,9 +88,7 @@ PRs, review on click) or `--no-poll` (no GitHub polling at all) — or flip thos
|
|
|
88
88
|
switches in the cockpit's Settings, which persist in `~/.cerber/config.json`
|
|
89
89
|
and apply on the next poll. Settings also takes per-repo exceptions
|
|
90
90
|
(`daemon.autoReviewRepos`): keep a busy repo to the click while the rest are
|
|
91
|
-
drafted, or draft one repo with auto-review otherwise off.
|
|
92
|
-
PRs that only a team of yours was asked to review to the click
|
|
93
|
-
(`daemon.autoReviewTeamRequests`), while the ones naming you are still drafted.
|
|
91
|
+
drafted, or draft one repo with auto-review otherwise off.
|
|
94
92
|
|
|
95
93
|
## Contents
|
|
96
94
|
|
package/dist/core/autoreview.js
CHANGED
|
@@ -1,7 +1,5 @@
|
|
|
1
|
-
export function autoReviewFor(knobs,
|
|
2
|
-
|
|
3
|
-
return false;
|
|
4
|
-
const want = `${pr.owner}/${pr.repo}`.toLowerCase();
|
|
1
|
+
export function autoReviewFor(knobs, owner, repo) {
|
|
2
|
+
const want = `${owner}/${repo}`.toLowerCase();
|
|
5
3
|
for (const [key, on] of Object.entries(knobs.autoReviewRepos)) {
|
|
6
4
|
if (key.toLowerCase() === want)
|
|
7
5
|
return on;
|
|
@@ -20,7 +18,7 @@ export function anyAutoReview(knobs) {
|
|
|
20
18
|
* the config's own `autoReview: false` — never the flag.
|
|
21
19
|
*/
|
|
22
20
|
export function capAutoReview(knobs, flag) {
|
|
23
|
-
return flag ? knobs : { autoReview: false, autoReviewRepos: {}
|
|
21
|
+
return flag ? knobs : { autoReview: false, autoReviewRepos: {} };
|
|
24
22
|
}
|
|
25
23
|
/**
|
|
26
24
|
* One exception set (`true`/`false`) or removed (`null`), the rest left as they
|
package/dist/core/config.js
CHANGED
|
@@ -43,12 +43,6 @@ export const DaemonConfigSchema = z.object({
|
|
|
43
43
|
}
|
|
44
44
|
})
|
|
45
45
|
.default({}),
|
|
46
|
-
/**
|
|
47
|
-
* Draft PRs whose review was requested only from a team you are on. Off
|
|
48
|
-
* leaves them waiting for a click, in every repo — a request naming you is
|
|
49
|
-
* drafted either way. Resolved by `autoReviewFor` too.
|
|
50
|
-
*/
|
|
51
|
-
autoReviewTeamRequests: z.boolean().default(true),
|
|
52
46
|
/**
|
|
53
47
|
* Tap this machine's notification centre when a PR is worth coming back for
|
|
54
48
|
* — the draft landing, or the arrival itself when nothing is going to be
|
package/dist/core/gh.js
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
import { execFile } from "node:child_process";
|
|
2
2
|
import { promisify } from "node:util";
|
|
3
|
-
import { PrInfoSchema
|
|
3
|
+
import { PrInfoSchema } from "./artifact.js";
|
|
4
4
|
const execFileAsync = promisify(execFile);
|
|
5
5
|
const MAX_BUFFER = 64 * 1024 * 1024;
|
|
6
6
|
/**
|
|
@@ -206,7 +206,6 @@ export function mapSearchResults(raw) {
|
|
|
206
206
|
updatedAt: r.updatedAt,
|
|
207
207
|
isDraft: r.isDraft,
|
|
208
208
|
author: r.author?.login ?? "",
|
|
209
|
-
requestedViaTeam: false,
|
|
210
209
|
},
|
|
211
210
|
];
|
|
212
211
|
});
|
|
@@ -534,10 +533,8 @@ export async function fetchPriorRemarks(ref, people) {
|
|
|
534
533
|
* `author` is your own open PRs, which that search returns only when a team
|
|
535
534
|
* you are on was requested — GitHub will not let anyone request a review from
|
|
536
535
|
* a PR's author — so self-reviewing one would otherwise mean pasting its URL
|
|
537
|
-
* every time.
|
|
538
|
-
*
|
|
539
|
-
* same search with one qualifier changed, so they cannot drift apart on what
|
|
540
|
-
* "open" means or which repos are read-only.
|
|
536
|
+
* every time. Both are the same search with one flag changed, so they cannot
|
|
537
|
+
* drift apart on what "open" means or which repos are read-only.
|
|
541
538
|
*/
|
|
542
539
|
export function searchPrsArgs(search, repoFilter, limit = 50, updatedSince = null) {
|
|
543
540
|
const args = [
|
|
@@ -548,9 +545,7 @@ export function searchPrsArgs(search, repoFilter, limit = 50, updatedSince = nul
|
|
|
548
545
|
"archived:false",
|
|
549
546
|
// Only the author search is ever given one (`ownPrUpdatedSince`).
|
|
550
547
|
...(updatedSince ? [`updated:>=${updatedSince}`] : []),
|
|
551
|
-
|
|
552
|
-
// as a qualifier — which is what each flag turns into anyway.
|
|
553
|
-
search === "user-review-requested" ? `${search}:@me` : `--${search}=@me`,
|
|
548
|
+
`--${search}=@me`,
|
|
554
549
|
"--state=open",
|
|
555
550
|
"--limit",
|
|
556
551
|
String(limit),
|
|
@@ -562,23 +557,10 @@ export function searchPrsArgs(search, repoFilter, limit = 50, updatedSince = nul
|
|
|
562
557
|
return args;
|
|
563
558
|
}
|
|
564
559
|
export const searchAwaitingArgs = (repoFilter, limit = 50) => searchPrsArgs("review-requested", repoFilter, limit);
|
|
565
|
-
/**
|
|
566
|
-
* Open PRs where the current gh user's review is requested, drafts included,
|
|
567
|
-
* each marked with whether the request named you or only a team you are on.
|
|
568
|
-
*
|
|
569
|
-
* `review-requested:@me` matches both and cannot say which, so the by-name
|
|
570
|
-
* search runs beside it and whatever it lacks is a team's request. Its page
|
|
571
|
-
* holds a subset of the first one's, so it is only incomplete when more than a
|
|
572
|
-
* page of PRs name you — and then the overflow reads as team-only, which at
|
|
573
|
-
* worst leaves a draft to the click rather than writing one nobody wanted.
|
|
574
|
-
*/
|
|
560
|
+
/** Open PRs where the current gh user's review is requested, drafts included. */
|
|
575
561
|
export async function searchAwaitingMe(repoFilter, limit = 50) {
|
|
576
|
-
const
|
|
577
|
-
|
|
578
|
-
gh(searchPrsArgs("user-review-requested", repoFilter, limit)),
|
|
579
|
-
]);
|
|
580
|
-
const named = new Set(mapSearchResults(JSON.parse(byName)).map((pr) => artifactId(pr)));
|
|
581
|
-
return mapSearchResults(JSON.parse(all)).map((pr) => ({ ...pr, requestedViaTeam: !named.has(artifactId(pr)) }));
|
|
562
|
+
const out = await gh(searchAwaitingArgs(repoFilter, limit));
|
|
563
|
+
return mapSearchResults(JSON.parse(out));
|
|
582
564
|
}
|
|
583
565
|
/**
|
|
584
566
|
* Open PRs the current gh user opened, drafts included. They come to the inbox
|
package/dist/runner/prompt.js
CHANGED
|
@@ -75,13 +75,17 @@ Writing style (applies to every markdown field):
|
|
|
75
75
|
|
|
76
76
|
Summary shape:
|
|
77
77
|
- General to specific, and a reader must be able to stop after any section with a correct, just less detailed, picture.
|
|
78
|
+
- One thing comes before all of it. If someone must do something by hand before merging or deploying, or the merge or deploy will break or lose data, the summary OPENS with it. Examples: run a data check, backfill or clean up rows; set a secret or environment variable; deploy another service first; tell users about a breaking change. Write it as a GitHub alert, the very first lines, before any paragraph or heading, at any summary size:
|
|
79
|
+
> [!WARNING]
|
|
80
|
+
> **The action, as an imperative.** One or two sentences: what breaks if it is skipped, and where it stands now ("staging was clean; prod has not been checked yet").
|
|
81
|
+
Use one alert. If there are several such steps, list them as bullets inside it. Risks, follow-ups and anything that merely deserves care are not this; they go under ⚠️. Most PRs have nothing here, so never invent a step to fill it. Once the alert says it, no section repeats it.
|
|
78
82
|
- Past two paragraphs, break the summary into sections under \`###\` headings. These sections, in this order, each opening with its emoji — drop every one you have nothing real to say under; four sections of substance beat six with filler:
|
|
79
83
|
- \`### 🎯 \` the problem — the symptom someone hit and what it cost them, in plain words. No identifiers yet; a product manager should follow this section. For a PR that fixes nothing, this is the goal instead.
|
|
80
84
|
- \`### 🔧 \` the fix — the cause in a sentence, then what the PR does about it. Name things by what they do; identifiers wait for the sections below.
|
|
81
85
|
- \`### 🧭 \` the impact — first say what merging itself does: it changes what runs, or, for a spec or design document, nothing runs differently and approving it commits to a plan. Then, in two or three sentences with no identifiers: what will be different afterwards, for whom, and what stays the same. When several behaviours change, follow with a short before/after table of what people see, never of code. A reviewer in a hurry stops here.
|
|
82
86
|
- \`### 🧩 \` how the pieces fit — when the PR adds a flow or changes how parts work together, whether built or planned, even inside one module. Only a small internal change skips it. Zoom in through the C4 levels, each under a bold label: **System** (the people and outside systems around ours, and what passes between them), **Modules** (the deployable parts and modules, and who calls or notifies whom), **Inside a module** (the main components of the module where most of the change lives). Show only the levels that changed, and skip one that would just repeat the level above, even for a new flow: a new route to an existing service is the Modules level alone, and a new flow inside one module is usually Inside a module alone. **System** appears only when people or outside systems change. A spec PR draws the parts the plan names. Each level gets one or two plain sentences and one top-down \`\`\`mermaid flowchart (\`flowchart TD\`) of at most about 12 nodes, with plain-language labels in double quotes and each arrow labelled with what passes along it. When an existing flow changes, show "today" and "after" as two subgraphs. Use flowchart syntax, never Mermaid's C4 syntax.
|
|
83
87
|
- \`### 🔍 \` details — what a reviewer needs, not everything decided: names, the choice behind the approach, what the PR's own tests pin down, anything counter-intuitive worth knowing.
|
|
84
|
-
- \`### ⚠️ \` worth knowing — risk, follow-up, breaking change.
|
|
88
|
+
- \`### ⚠️ \` worth knowing — risk, follow-up, breaking change. A step someone must take before merging or deploying is not here; it is in the alert at the top. Skip this section when there is nothing left to say.
|
|
85
89
|
- The emoji and the order are fixed. The words after the emoji are yours: write the heading this PR needs ("### 🎯 Searching an order number returned every order"), and fall back to the plain label ("### 🎯 The problem") only when nothing sharper fits.
|
|
86
90
|
- A small PR gets one or two short paragraphs and NO headings. Headings on a three-line summary are noise.
|
|
87
91
|
- The summary describes the PR, never your review of it. Verification you performed ("I ran the tests", "checks came back green", "couldn't check X") belongs in the verdict's reasoning and nowhere else.
|
|
@@ -274,7 +278,7 @@ Rules:
|
|
|
274
278
|
- "line" is a line in the NEW version of the file and must appear in the diff. Use null for a file-level comment.
|
|
275
279
|
- "severity" is the finding's merge impact — "blocker" (would not approve with this in; the only tier that blocks), "minor" (should fix, author's call), "nit" (taste), null (not a finding: a question, a note). Grade as if the finding is true; hedge in the reply, never in the grade. A verdict revision must still follow from the worst finding left standing.
|
|
276
280
|
- Your reply is prose to a person, not a changelog. The cockpit already shows what you changed — do not list your own edits back to them.
|
|
277
|
-
- A revision keeps the shape the review is written in: a rewritten summary keeps its \`###\` sections (🎯 the problem, 🔧 the fix, 🧭 the impact, 🧩 how the pieces fit, with diagrams for only the levels that changed, 🔍 details a reviewer needs, ⚠️ worth knowing — the ones that earn their place), a rewritten "reasoning" stays one lead sentence plus bullets, and a comment body leads with the finding on its own line and never writes its own grade in — every surface prefixes that from "severity". The division of labor holds too: the summary describes the PR and the verdict's reasoning holds the review's own verification — neither retells the other.
|
|
281
|
+
- A revision keeps the shape the review is written in: a rewritten summary keeps its \`###\` sections (🎯 the problem, 🔧 the fix, 🧭 the impact, 🧩 how the pieces fit, with diagrams for only the levels that changed, 🔍 details a reviewer needs, ⚠️ worth knowing — the ones that earn their place). A step someone must take by hand before merging or deploying always opens the summary as a \`> [!WARNING]\` alert, never as a section further down. A rewritten "reasoning" stays one lead sentence plus bullets, and a comment body leads with the finding on its own line and never writes its own grade in — every surface prefixes that from "severity". The division of labor holds too: the summary describes the PR and the verdict's reasoning holds the review's own verification — neither retells the other.
|
|
278
282
|
|
|
279
283
|
Writing style:
|
|
280
284
|
- Plain words, short sentences, no jargon. Someone who has NOT read the diff should follow you.
|
package/dist/server/daemon.js
CHANGED
|
@@ -29,17 +29,6 @@ export function dedupeDiscovered(refs) {
|
|
|
29
29
|
return true;
|
|
30
30
|
});
|
|
31
31
|
}
|
|
32
|
-
function awaitingPr(ref, reply) {
|
|
33
|
-
return { id: artifactId(ref), reply, requestedViaTeam: ref.requestedViaTeam };
|
|
34
|
-
}
|
|
35
|
-
/**
|
|
36
|
-
* Whether the last poll found this PR asking only a team of yours. A row the
|
|
37
|
-
* awaiting search did not return — your own PR, one pulled in by hand — was
|
|
38
|
-
* asked of nobody, so of no team either.
|
|
39
|
-
*/
|
|
40
|
-
export function requestedViaTeam(awaiting, id) {
|
|
41
|
-
return awaiting.some((a) => a.id === id && a.requestedViaTeam);
|
|
42
|
-
}
|
|
43
32
|
/**
|
|
44
33
|
* A pure discovery stub: enough artifact for the queue to show an awaiting row.
|
|
45
34
|
* The AI run that follows (automatic or clicked) replaces it wholesale.
|
|
@@ -266,7 +255,6 @@ export function startDaemon(opts) {
|
|
|
266
255
|
notify: false,
|
|
267
256
|
autoReview: opts.autoReview,
|
|
268
257
|
autoReviewRepos: {},
|
|
269
|
-
autoReviewTeamRequests: opts.autoReview,
|
|
270
258
|
trustedRuns: false,
|
|
271
259
|
polls: 0,
|
|
272
260
|
errors: 0,
|
|
@@ -742,14 +730,14 @@ export function startDaemon(opts) {
|
|
|
742
730
|
}
|
|
743
731
|
catch {
|
|
744
732
|
// Without knowing who you are, no comment can be attributed to you.
|
|
745
|
-
return refs.map((ref) =>
|
|
733
|
+
return refs.map((ref) => ({ id: artifactId(ref), reply: "unknown" }));
|
|
746
734
|
}
|
|
747
735
|
return pool(refs, opts.parallel, async (ref) => {
|
|
748
736
|
try {
|
|
749
|
-
return
|
|
737
|
+
return { id: artifactId(ref), reply: classifyReply(await fetchConversation(ref), login) };
|
|
750
738
|
}
|
|
751
739
|
catch {
|
|
752
|
-
return
|
|
740
|
+
return { id: artifactId(ref), reply: "unknown" };
|
|
753
741
|
}
|
|
754
742
|
});
|
|
755
743
|
}
|
|
@@ -844,10 +832,7 @@ export function startDaemon(opts) {
|
|
|
844
832
|
// Your own PRs are never drafted unasked, whatever auto-review says for
|
|
845
833
|
// their repo: they are in the inbox for a self-review on demand. The same
|
|
846
834
|
// predicate decides when a tap is due, which keeps them quiet there too.
|
|
847
|
-
|
|
848
|
-
// than the PR, because the cockpit reads it there too.
|
|
849
|
-
const drafts = (pr) => !isOwnPr(pr, me) &&
|
|
850
|
-
autoReviewFor(autoReview, { ...pr, requestedViaTeam: requestedViaTeam(status.awaiting, artifactId(pr)) });
|
|
835
|
+
const drafts = (pr) => !isOwnPr(pr, me) && autoReviewFor(autoReview, pr.owner, pr.repo);
|
|
851
836
|
status.pollEnabled = knobs.poll;
|
|
852
837
|
// What the cockpit's bell defers to: a loop that isn't polling announces
|
|
853
838
|
// nothing, whatever the notify toggle says.
|
|
@@ -859,7 +844,6 @@ export function startDaemon(opts) {
|
|
|
859
844
|
status.notify = announcing();
|
|
860
845
|
status.autoReview = autoReview.autoReview;
|
|
861
846
|
status.autoReviewRepos = autoReview.autoReviewRepos;
|
|
862
|
-
status.autoReviewTeamRequests = autoReview.autoReviewTeamRequests;
|
|
863
847
|
// Recomputed too, so a trust rule added mid-run shows up in the strip.
|
|
864
848
|
status.trustedRuns = anyAutoReview(autoReview) && opts.trust !== false && config.trust.length > 0;
|
|
865
849
|
return { knobs, drafts, drafting: anyAutoReview(autoReview), notifyOn, announcing };
|
package/dist/server/index.js
CHANGED
|
@@ -6,7 +6,7 @@ import { promises as fs } from "node:fs";
|
|
|
6
6
|
import path from "node:path";
|
|
7
7
|
import { fileURLToPath } from "node:url";
|
|
8
8
|
import { randomUUID } from "node:crypto";
|
|
9
|
-
import { isPureStub
|
|
9
|
+
import { isPureStub } from "./daemon.js";
|
|
10
10
|
import { ArtifactStatusSchema, SCHEMA_VERSION, SeveritySchema, VerdictSchema, artifactId, artifactKey, } from "../core/artifact.js";
|
|
11
11
|
import { toMarkdown } from "../core/export.js";
|
|
12
12
|
import { isOwnPr } from "../core/own.js";
|
|
@@ -266,7 +266,6 @@ export async function buildApp(opts) {
|
|
|
266
266
|
// and must not hang on GitHub: a gh that cannot say in time marks nothing
|
|
267
267
|
// as yours, and Send's own guard still refuses what GitHub would.
|
|
268
268
|
const me = await loginWithin(LOGIN_WAIT_MS);
|
|
269
|
-
const awaiting = opts.daemon?.status().awaiting ?? [];
|
|
270
269
|
return c.json(artifacts.map((a) => ({
|
|
271
270
|
id: a.id,
|
|
272
271
|
key: artifactKey(a.id),
|
|
@@ -310,10 +309,6 @@ export async function buildApp(opts) {
|
|
|
310
309
|
// A PR you opened: listed apart from the ones awaiting you, and sent
|
|
311
310
|
// as a comment only (`ownPrRefusal`).
|
|
312
311
|
own: isOwnPr(a.pr, me),
|
|
313
|
-
// Only a team of yours was asked, as of the last poll — what the bell
|
|
314
|
-
// and the row's explanation need to tell "waits for a click" from
|
|
315
|
-
// "being drafted" under `autoReviewTeamRequests`.
|
|
316
|
-
requestedViaTeam: requestedViaTeam(awaiting, a.id),
|
|
317
312
|
costUsd: a.run?.costUsd ?? null,
|
|
318
313
|
withSource: a.run?.withSource ?? null,
|
|
319
314
|
trusted: a.run?.trusted ?? null,
|
package/package.json
CHANGED
package/web/dist/assets/{abnfDiagram-WEYOIA3C-BR44kMtj.js → abnfDiagram-WEYOIA3C-Fh0yGAPG.js}
RENAMED
|
@@ -1 +1 @@
|
|
|
1
|
-
import{g as p,r as u,d as a}from"./chunk-2E7WHVMD-
|
|
1
|
+
import{g as p,r as u,d as a}from"./chunk-2E7WHVMD-9Ra4B9GU.js";import{p as f}from"./chunk-JWPE2WC7-BJYQI99_.js";import{_ as n,l as o}from"./mermaid.core-DSlXNYTz.js";import{M as c,b as d}from"./cynefin-EF2NZ3EQ-CcAG0DdN.js";import"./index-DbkXcP68.js";var v=d().RailroadAbnf.parser.LangiumParser,i=n(e=>{const r=e.alternatives.map(g);return r.length===1?r[0]:{type:"choice",alternatives:r}},"transformAlternation"),g=n(e=>{const r=e.elements.map(y);return r.length===1?r[0]:{type:"sequence",elements:r}},"transformConcatenation"),b=n(e=>{if(e.includes("*")){const[t,s]=e.split("*"),l=t?parseInt(t,10):0,m=s?parseInt(s,10):1/0;return{min:l,max:m}}const r=parseInt(e,10);return{min:r,max:r}},"parseRepeat"),y=n(e=>{const r=A(e.primary);if(!e.repeat)return r;const{min:t,max:s}=b(e.repeat);return t===0&&s===1?{type:"optional",element:r}:{type:"repetition",element:r,min:t,max:s}},"transformElement"),A=n(e=>{switch(e.$type){case"AbnfStringLiteral":return{type:"terminal",value:e.value};case"AbnfNumVal":return{type:"terminal",value:e.value};case"AbnfRuleName":return{type:"nonterminal",name:e.name};case"AbnfGroup":return i(e.element);case"AbnfOptionalGroup":return{type:"optional",element:i(e.element)};default:throw new Error(`Unsupported ABNF primary node: ${e.$type}`)}},"transformPrimary"),P=n(e=>({name:e.name,definition:i(e.definition)}),"transformRule"),h=n(e=>{f(e,a),e.title&&a.setTitle(e.title),e.rules.map(r=>a.addRule(P(r)))},"populateDb"),R={parse:n(e=>{a.clear(),o.debug("[ABNF Parser] Starting Langium parse");const r=v.parse(e);if(r.lexerErrors.length>0||r.parserErrors.length>0)throw new c(r);const t=r.value;o.debug("[ABNF Parser] Parsed rules:",t.rules.length),h(t),o.debug("[ABNF Parser] Parse complete")},"parse"),parser:{yy:a}},B={parser:R,db:a,renderer:u,styles:p};export{B as diagram};
|
|
@@ -1 +1 @@
|
|
|
1
|
-
import{a5 as ln,a6 as an,a7 as H,a8 as j,a9 as B,aa as un,ab as g,ac as tn,ad as L,ae as _,af as rn,ag as o,ah as on,ai as sn,aj as fn}from"./mermaid.core-
|
|
1
|
+
import{a5 as ln,a6 as an,a7 as H,a8 as j,a9 as B,aa as un,ab as g,ac as tn,ad as L,ae as _,af as rn,ag as o,ah as on,ai as sn,aj as fn}from"./mermaid.core-DSlXNYTz.js";function cn(l){return l.innerRadius}function gn(l){return l.outerRadius}function yn(l){return l.startAngle}function dn(l){return l.endAngle}function mn(l){return l&&l.padAngle}function pn(l,h,E,q,v,A,C,a){var I=E-l,i=q-h,n=C-v,d=a-A,u=d*I-n*i;if(!(u*u<g))return u=(n*(h-A)-d*(l-v))/u,[l+u*I,h+u*i]}function W(l,h,E,q,v,A,C){var a=l-E,I=h-q,i=(C?A:-A)/L(a*a+I*I),n=i*I,d=-i*a,u=l+n,s=h+d,f=E+n,c=q+d,F=(u+f)/2,t=(s+c)/2,m=f-u,y=c-s,R=m*m+y*y,T=v-A,P=u*c-f*s,O=(y<0?-1:1)*L(on(0,T*T*R-P*P)),S=(P*y-m*O)/R,z=(-P*m-y*O)/R,w=(P*y+m*O)/R,p=(-P*m+y*O)/R,x=S-F,e=z-t,r=w-F,G=p-t;return x*x+e*e>r*r+G*G&&(S=w,z=p),{cx:S,cy:z,x01:-n,y01:-d,x11:S*(v/T-1),y11:z*(v/T-1)}}function hn(){var l=cn,h=gn,E=B(0),q=null,v=yn,A=dn,C=mn,a=null,I=ln(i);function i(){var n,d,u=+l.apply(this,arguments),s=+h.apply(this,arguments),f=v.apply(this,arguments)-un,c=A.apply(this,arguments)-un,F=rn(c-f),t=c>f;if(a||(a=n=I()),s<u&&(d=s,s=u,u=d),!(s>g))a.moveTo(0,0);else if(F>tn-g)a.moveTo(s*H(f),s*j(f)),a.arc(0,0,s,f,c,!t),u>g&&(a.moveTo(u*H(c),u*j(c)),a.arc(0,0,u,c,f,t));else{var m=f,y=c,R=f,T=c,P=F,O=F,S=C.apply(this,arguments)/2,z=S>g&&(q?+q.apply(this,arguments):L(u*u+s*s)),w=_(rn(s-u)/2,+E.apply(this,arguments)),p=w,x=w,e,r;if(z>g){var G=sn(z/u*j(S)),M=sn(z/s*j(S));(P-=G*2)>g?(G*=t?1:-1,R+=G,T-=G):(P=0,R=T=(f+c)/2),(O-=M*2)>g?(M*=t?1:-1,m+=M,y-=M):(O=0,m=y=(f+c)/2)}var J=s*H(m),K=s*j(m),N=u*H(T),Q=u*j(T);if(w>g){var U=s*H(y),V=s*j(y),X=u*H(R),Y=u*j(R),D;if(F<an)if(D=pn(J,K,X,Y,U,V,N,Q)){var Z=J-D[0],$=K-D[1],b=U-D[0],k=V-D[1],nn=1/j(fn((Z*b+$*k)/(L(Z*Z+$*$)*L(b*b+k*k)))/2),en=L(D[0]*D[0]+D[1]*D[1]);p=_(w,(u-en)/(nn-1)),x=_(w,(s-en)/(nn+1))}else p=x=0}O>g?x>g?(e=W(X,Y,J,K,s,x,t),r=W(U,V,N,Q,s,x,t),a.moveTo(e.cx+e.x01,e.cy+e.y01),x<w?a.arc(e.cx,e.cy,x,o(e.y01,e.x01),o(r.y01,r.x01),!t):(a.arc(e.cx,e.cy,x,o(e.y01,e.x01),o(e.y11,e.x11),!t),a.arc(0,0,s,o(e.cy+e.y11,e.cx+e.x11),o(r.cy+r.y11,r.cx+r.x11),!t),a.arc(r.cx,r.cy,x,o(r.y11,r.x11),o(r.y01,r.x01),!t))):(a.moveTo(J,K),a.arc(0,0,s,m,y,!t)):a.moveTo(J,K),!(u>g)||!(P>g)?a.lineTo(N,Q):p>g?(e=W(N,Q,U,V,u,-p,t),r=W(J,K,X,Y,u,-p,t),a.lineTo(e.cx+e.x01,e.cy+e.y01),p<w?a.arc(e.cx,e.cy,p,o(e.y01,e.x01),o(r.y01,r.x01),!t):(a.arc(e.cx,e.cy,p,o(e.y01,e.x01),o(e.y11,e.x11),!t),a.arc(0,0,u,o(e.cy+e.y11,e.cx+e.x11),o(r.cy+r.y11,r.cx+r.x11),t),a.arc(r.cx,r.cy,p,o(r.y11,r.x11),o(r.y01,r.x01),!t))):a.arc(0,0,u,T,R,t)}if(a.closePath(),n)return a=null,n+""||null}return i.centroid=function(){var n=(+l.apply(this,arguments)+ +h.apply(this,arguments))/2,d=(+v.apply(this,arguments)+ +A.apply(this,arguments))/2-an/2;return[H(d)*n,j(d)*n]},i.innerRadius=function(n){return arguments.length?(l=typeof n=="function"?n:B(+n),i):l},i.outerRadius=function(n){return arguments.length?(h=typeof n=="function"?n:B(+n),i):h},i.cornerRadius=function(n){return arguments.length?(E=typeof n=="function"?n:B(+n),i):E},i.padRadius=function(n){return arguments.length?(q=n==null?null:typeof n=="function"?n:B(+n),i):q},i.startAngle=function(n){return arguments.length?(v=typeof n=="function"?n:B(+n),i):v},i.endAngle=function(n){return arguments.length?(A=typeof n=="function"?n:B(+n),i):A},i.padAngle=function(n){return arguments.length?(C=typeof n=="function"?n:B(+n),i):C},i.context=function(n){return arguments.length?(a=n??null,i):a},i}export{hn as d};
|