@fullstackhouse/cerber 1.6.5-pr.94.9eb37fa → 1.6.5-pr.95.4276b94
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +3 -1
- package/dist/core/autoreview.js +5 -3
- package/dist/core/config.js +6 -0
- package/dist/core/gh.js +31 -4
- package/dist/runner/prompt.js +2 -6
- package/dist/server/daemon.js +37 -9
- package/dist/server/index.js +6 -1
- package/package.json +1 -1
- package/web/dist/assets/{abnfDiagram-WEYOIA3C-D5T4yrfy.js → abnfDiagram-WEYOIA3C-ZVjk8TRR.js} +1 -1
- package/web/dist/assets/{arc-DxeZxuoz.js → arc-DOWPP57-.js} +1 -1
- package/web/dist/assets/{architectureDiagram-ZHVYKT53-Cf-PS51B.js → architectureDiagram-ZHVYKT53-BLa6AOgS.js} +1 -1
- package/web/dist/assets/{blockDiagram-RJAE7QA3-HHCDp7AV.js → blockDiagram-RJAE7QA3-1eiXMp4x.js} +1 -1
- package/web/dist/assets/{c4Diagram-XDPPPE54-NFn7SLDA.js → c4Diagram-XDPPPE54-Cvi16eFl.js} +1 -1
- package/web/dist/assets/channel-BJT1iYGK.js +1 -0
- package/web/dist/assets/{chunk-2E7WHVMD-CfttgAMX.js → chunk-2E7WHVMD-D-_dw85f.js} +1 -1
- package/web/dist/assets/{chunk-2Q5K7J3B-BWQte7pO.js → chunk-2Q5K7J3B-fGO6Rj6K.js} +1 -1
- package/web/dist/assets/{chunk-4EMNKR2T-Bh9igyTN.js → chunk-4EMNKR2T-Cdjpm4mM.js} +1 -1
- package/web/dist/assets/{chunk-55XCU76K-BBU9TIqP.js → chunk-55XCU76K-8vKcpusr.js} +1 -1
- package/web/dist/assets/{chunk-5VM5RSS4-yOy4xnSd.js → chunk-5VM5RSS4-CwqOf2Km.js} +1 -1
- package/web/dist/assets/{chunk-JWPE2WC7-EaliTm-i.js → chunk-JWPE2WC7-DzKBdMkf.js} +1 -1
- package/web/dist/assets/{chunk-VQ5W62QI-B7P9vp6w.js → chunk-VQ5W62QI-DYd1jpy5.js} +1 -1
- package/web/dist/assets/{chunk-XXDRQBXY-CEhLPaaF.js → chunk-XXDRQBXY-30xD2ao8.js} +1 -1
- package/web/dist/assets/{chunk-ZCHMQSOR-DNwrj5b5.js → chunk-ZCHMQSOR-C1fPNQyM.js} +2 -2
- package/web/dist/assets/{classDiagram-v2-4MYWR3UA-C6_yEpiD.js → classDiagram-v2-4MYWR3UA-cEFXJtWi.js} +1 -1
- package/web/dist/assets/{cose-bilkent-JH36ORCC-DF8MzLB2.js → cose-bilkent-JH36ORCC-BwnNG4V_.js} +1 -1
- package/web/dist/assets/{cynefin-EF2NZ3EQ-_uBS-emI.js → cynefin-EF2NZ3EQ-KI3U995R.js} +1 -1
- package/web/dist/assets/{cynefinDiagram-WF24UDRP-I2bp_XCH.js → cynefinDiagram-WF24UDRP-CxK-GEja.js} +1 -1
- package/web/dist/assets/{dagre-NK4GIZVX-DfUspu1N.js → dagre-NK4GIZVX-DZg6HiOj.js} +1 -1
- package/web/dist/assets/{diagram-CBK3MWTC-D8GHnLKd.js → diagram-CBK3MWTC-OkPOrNUp.js} +1 -1
- package/web/dist/assets/{diagram-I5XIIV2D-MabF84Kx.js → diagram-I5XIIV2D-Cx5Ko7MY.js} +1 -1
- package/web/dist/assets/{diagram-ODIL2UCW-BBY_OJdu.js → diagram-ODIL2UCW-BctjIVeG.js} +1 -1
- package/web/dist/assets/{diagram-PFBEJUXE-D2qplw00.js → diagram-PFBEJUXE-CHz5D9mp.js} +1 -1
- package/web/dist/assets/{diagram-RJA3I4VV-CkFRz4Tj.js → diagram-RJA3I4VV-8SX2X19I.js} +1 -1
- package/web/dist/assets/{diagram-TYUNFSNR-HXkSGAa2.js → diagram-TYUNFSNR-DurOnOhU.js} +1 -1
- package/web/dist/assets/{ebnfDiagram-V4P3TTPT-S9b4LkDB.js → ebnfDiagram-V4P3TTPT-Cu--JXQi.js} +1 -1
- package/web/dist/assets/{elk-QONTBCTQ-BMQicl1e.js → elk-QONTBCTQ-6QbN31Uk.js} +1 -1
- package/web/dist/assets/{erDiagram-KYQIGQAA-BiFU6q82.js → erDiagram-KYQIGQAA-DjmOgpYh.js} +1 -1
- package/web/dist/assets/{flowDiagram-IUGLLWBU-CdvYEjyn.js → flowDiagram-IUGLLWBU-CDtY0JeV.js} +1 -1
- package/web/dist/assets/{ganttDiagram-R7GPNTJY-Cp9b1JEq.js → ganttDiagram-R7GPNTJY-C0okldn-.js} +1 -1
- package/web/dist/assets/{gitGraphDiagram-PDYL7XHY-44WGMg7y.js → gitGraphDiagram-PDYL7XHY-CpoFa94u.js} +1 -1
- package/web/dist/assets/{index-vSZNWvZS.js → index-DSUaxe4H.js} +42 -45
- package/web/dist/assets/{index-C-BR2leN.css → index-D_0po9OL.css} +1 -1
- package/web/dist/assets/{infoDiagram-MVDRKAX5-CTTQw5fU.js → infoDiagram-MVDRKAX5-Ygztm1Pp.js} +1 -1
- package/web/dist/assets/{ishikawaDiagram-HPEHV2GE-DtRDFDCi.js → ishikawaDiagram-HPEHV2GE-CEUgXYG-.js} +1 -1
- package/web/dist/assets/{journeyDiagram-BOSHW7O7-I1Mj_QGJ.js → journeyDiagram-BOSHW7O7-BeKRFtY5.js} +1 -1
- package/web/dist/assets/{kanban-definition-FNSA4HC5-r9h9OFux.js → kanban-definition-FNSA4HC5-DTiTF_cF.js} +1 -1
- package/web/dist/assets/{linear-Bbzk8ZVk.js → linear-DQ-15MJG.js} +1 -1
- package/web/dist/assets/{mermaid.core-C0OE1PLO.js → mermaid.core-a2mmm40M.js} +4 -4
- package/web/dist/assets/{mindmap-definition-6OY57UG3-B9W_nVnX.js → mindmap-definition-6OY57UG3-DBh5JyfG.js} +1 -1
- package/web/dist/assets/{pegDiagram-ECIUJNBX-C7Znr-Us.js → pegDiagram-ECIUJNBX-DXSD-3Z7.js} +1 -1
- package/web/dist/assets/{pieDiagram-GNMPY74T-BSY-jXvd.js → pieDiagram-GNMPY74T-B_CsO-Kg.js} +1 -1
- package/web/dist/assets/{quadrantDiagram-D57K4MC3-BHNIoyEH.js → quadrantDiagram-D57K4MC3-BwPADVT9.js} +1 -1
- package/web/dist/assets/{railroadDiagram-Y72NRBL7-DDdXI6e4.js → railroadDiagram-Y72NRBL7-DZ-AJFkA.js} +1 -1
- package/web/dist/assets/{requirementDiagram-EQYSW5RA-BJ-Rf0e7.js → requirementDiagram-EQYSW5RA-CINS96lV.js} +1 -1
- package/web/dist/assets/{sankeyDiagram-SY24JHO5-BoOwQ9NN.js → sankeyDiagram-SY24JHO5-BoiQiR0y.js} +1 -1
- package/web/dist/assets/{sequenceDiagram-BLEHNHQU-C0LL--xD.js → sequenceDiagram-BLEHNHQU-48pmhSGP.js} +1 -1
- package/web/dist/assets/{sizeCapture-INFHLROL-CiC0ypIb.js → sizeCapture-INFHLROL-DiiXSO89.js} +1 -1
- package/web/dist/assets/{stateDiagram-v2-A6IESKWZ-1v9Hde5d.js → stateDiagram-v2-A6IESKWZ-nQXJ4XNA.js} +1 -1
- package/web/dist/assets/{swimlanes-B3ENRKFQ-C0RmEF0_.js → swimlanes-B3ENRKFQ-Bt_0aKLf.js} +1 -1
- package/web/dist/assets/swimlanesDiagram-AYQRV4AK-CFDsqMUA.js +8 -0
- package/web/dist/assets/{timeline-definition-JXYKGLGB-k6G542yt.js → timeline-definition-JXYKGLGB-4D3Uxq1w.js} +1 -1
- package/web/dist/assets/{usecaseDiagram-WPOLBNNX-DXE62T0K.js → usecaseDiagram-WPOLBNNX-BsAFmexj.js} +1 -1
- package/web/dist/assets/{vennDiagram-Q3Y3IDCW-Cdp0QbnB.js → vennDiagram-Q3Y3IDCW-D7zQVvBt.js} +1 -1
- package/web/dist/assets/{wardleyDiagram-IVAIDKWA-DlnQNa9Q.js → wardleyDiagram-IVAIDKWA-B4uR9tXq.js} +1 -1
- package/web/dist/assets/{xychartDiagram-4URNHDU4-CFz9T3W3.js → xychartDiagram-4URNHDU4-CCjgk3js.js} +1 -1
- package/web/dist/index.html +2 -2
- package/web/dist/assets/channel-DYARpwfW.js +0 -1
- package/web/dist/assets/swimlanesDiagram-AYQRV4AK-bstHYQVN.js +0 -8
package/README.md
CHANGED
|
@@ -88,7 +88,9 @@ PRs, review on click) or `--no-poll` (no GitHub polling at all) — or flip thos
|
|
|
88
88
|
switches in the cockpit's Settings, which persist in `~/.cerber/config.json`
|
|
89
89
|
and apply on the next poll. Settings also takes per-repo exceptions
|
|
90
90
|
(`daemon.autoReviewRepos`): keep a busy repo to the click while the rest are
|
|
91
|
-
drafted, or draft one repo with auto-review otherwise off.
|
|
91
|
+
drafted, or draft one repo with auto-review otherwise off. And it can leave
|
|
92
|
+
PRs that only a team of yours was asked to review to the click
|
|
93
|
+
(`daemon.autoReviewTeamRequests`), while the ones naming you are still drafted.
|
|
92
94
|
|
|
93
95
|
## Contents
|
|
94
96
|
|
package/dist/core/autoreview.js
CHANGED
|
@@ -1,5 +1,7 @@
|
|
|
1
|
-
export function autoReviewFor(knobs,
|
|
2
|
-
|
|
1
|
+
export function autoReviewFor(knobs, pr) {
|
|
2
|
+
if (pr.requestedViaTeam !== false && !knobs.autoReviewTeamRequests)
|
|
3
|
+
return false;
|
|
4
|
+
const want = `${pr.owner}/${pr.repo}`.toLowerCase();
|
|
3
5
|
for (const [key, on] of Object.entries(knobs.autoReviewRepos)) {
|
|
4
6
|
if (key.toLowerCase() === want)
|
|
5
7
|
return on;
|
|
@@ -18,7 +20,7 @@ export function anyAutoReview(knobs) {
|
|
|
18
20
|
* the config's own `autoReview: false` — never the flag.
|
|
19
21
|
*/
|
|
20
22
|
export function capAutoReview(knobs, flag) {
|
|
21
|
-
return flag ? knobs : { autoReview: false, autoReviewRepos: {} };
|
|
23
|
+
return flag ? knobs : { autoReview: false, autoReviewRepos: {}, autoReviewTeamRequests: false };
|
|
22
24
|
}
|
|
23
25
|
/**
|
|
24
26
|
* One exception set (`true`/`false`) or removed (`null`), the rest left as they
|
package/dist/core/config.js
CHANGED
|
@@ -43,6 +43,12 @@ export const DaemonConfigSchema = z.object({
|
|
|
43
43
|
}
|
|
44
44
|
})
|
|
45
45
|
.default({}),
|
|
46
|
+
/**
|
|
47
|
+
* Draft PRs whose review was requested only from a team you are on. Off
|
|
48
|
+
* leaves them waiting for a click, in every repo — a request naming you is
|
|
49
|
+
* drafted either way. Resolved by `autoReviewFor` too.
|
|
50
|
+
*/
|
|
51
|
+
autoReviewTeamRequests: z.boolean().default(true),
|
|
46
52
|
/**
|
|
47
53
|
* Tap this machine's notification centre when a PR is worth coming back for
|
|
48
54
|
* — the draft landing, or the arrival itself when nothing is going to be
|
package/dist/core/gh.js
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
import { execFile } from "node:child_process";
|
|
2
2
|
import { promisify } from "node:util";
|
|
3
|
-
import { PrInfoSchema } from "./artifact.js";
|
|
3
|
+
import { PrInfoSchema, artifactId } from "./artifact.js";
|
|
4
4
|
const execFileAsync = promisify(execFile);
|
|
5
5
|
const MAX_BUFFER = 64 * 1024 * 1024;
|
|
6
6
|
/**
|
|
@@ -206,6 +206,7 @@ export function mapSearchResults(raw) {
|
|
|
206
206
|
updatedAt: r.updatedAt,
|
|
207
207
|
isDraft: r.isDraft,
|
|
208
208
|
author: r.author?.login ?? "",
|
|
209
|
+
requestedViaTeam: false,
|
|
209
210
|
},
|
|
210
211
|
];
|
|
211
212
|
});
|
|
@@ -533,8 +534,10 @@ export async function fetchPriorRemarks(ref, people) {
|
|
|
533
534
|
* `author` is your own open PRs, which that search returns only when a team
|
|
534
535
|
* you are on was requested — GitHub will not let anyone request a review from
|
|
535
536
|
* a PR's author — so self-reviewing one would otherwise mean pasting its URL
|
|
536
|
-
* every time.
|
|
537
|
-
*
|
|
537
|
+
* every time. `user-review-requested` is the inbox narrowed to requests naming
|
|
538
|
+
* you, leaving out the ones made only of a team you are on. All three are the
|
|
539
|
+
* same search with one qualifier changed, so they cannot drift apart on what
|
|
540
|
+
* "open" means or which repos are read-only.
|
|
538
541
|
*/
|
|
539
542
|
export function searchPrsArgs(search, repoFilter, limit = 50, updatedSince = null) {
|
|
540
543
|
const args = [
|
|
@@ -545,7 +548,9 @@ export function searchPrsArgs(search, repoFilter, limit = 50, updatedSince = nul
|
|
|
545
548
|
"archived:false",
|
|
546
549
|
// Only the author search is ever given one (`ownPrUpdatedSince`).
|
|
547
550
|
...(updatedSince ? [`updated:>=${updatedSince}`] : []),
|
|
548
|
-
|
|
551
|
+
// gh has a flag for the other two and none for this one, so it goes in
|
|
552
|
+
// as a qualifier — which is what each flag turns into anyway.
|
|
553
|
+
search === "user-review-requested" ? `${search}:@me` : `--${search}=@me`,
|
|
549
554
|
"--state=open",
|
|
550
555
|
"--limit",
|
|
551
556
|
String(limit),
|
|
@@ -562,6 +567,28 @@ export async function searchAwaitingMe(repoFilter, limit = 50) {
|
|
|
562
567
|
const out = await gh(searchAwaitingArgs(repoFilter, limit));
|
|
563
568
|
return mapSearchResults(JSON.parse(out));
|
|
564
569
|
}
|
|
570
|
+
/** Open PRs where the current gh user's review is requested by name — a request of a team they are on does not count. */
|
|
571
|
+
export async function searchNamingMe(repoFilter, limit = 50) {
|
|
572
|
+
const out = await gh(searchPrsArgs("user-review-requested", repoFilter, limit));
|
|
573
|
+
return mapSearchResults(JSON.parse(out));
|
|
574
|
+
}
|
|
575
|
+
/**
|
|
576
|
+
* Mark each awaiting PR with whether the request named you or only a team
|
|
577
|
+
* you are on.
|
|
578
|
+
*
|
|
579
|
+
* `review-requested:@me` matches both and cannot say which, so whatever the
|
|
580
|
+
* by-name search lacks is a team's request. Its page holds a subset of the
|
|
581
|
+
* awaiting one's, so it is only incomplete when more than a page of PRs name
|
|
582
|
+
* you — and then the overflow reads as team-only, which at worst leaves a
|
|
583
|
+
* draft to the click rather than writing one nobody wanted. `named` is null
|
|
584
|
+
* when that search was not run or failed: then nothing is marked either way.
|
|
585
|
+
*/
|
|
586
|
+
export function markTeamRequests(awaiting, named) {
|
|
587
|
+
if (named === null)
|
|
588
|
+
return awaiting.map((pr) => ({ ...pr, requestedViaTeam: null }));
|
|
589
|
+
const ids = new Set(named.map((pr) => artifactId(pr)));
|
|
590
|
+
return awaiting.map((pr) => ({ ...pr, requestedViaTeam: !ids.has(artifactId(pr)) }));
|
|
591
|
+
}
|
|
565
592
|
/**
|
|
566
593
|
* Open PRs the current gh user opened, drafts included. They come to the inbox
|
|
567
594
|
* to be reviewed on demand and never automatically — see `isOwnPr` (`own.ts`).
|
package/dist/runner/prompt.js
CHANGED
|
@@ -75,17 +75,13 @@ Writing style (applies to every markdown field):
|
|
|
75
75
|
|
|
76
76
|
Summary shape:
|
|
77
77
|
- General to specific, and a reader must be able to stop after any section with a correct, just less detailed, picture.
|
|
78
|
-
- One thing comes before all of it. If someone must do something by hand before merging or deploying, or the merge or deploy will break or lose data, the summary OPENS with it. Examples: run a data check, backfill or clean up rows; set a secret or environment variable; deploy another service first; tell users about a breaking change. Write it as a GitHub alert, the very first lines, before any paragraph or heading, at any summary size:
|
|
79
|
-
> [!WARNING]
|
|
80
|
-
> **The action, as an imperative.** One or two sentences: what breaks if it is skipped, and where it stands now ("staging was clean; prod has not been checked yet").
|
|
81
|
-
Use one alert. If there are several such steps, list them as bullets inside it. Risks, follow-ups and anything that merely deserves care are not this; they go under ⚠️. Most PRs have nothing here, so never invent a step to fill it. Once the alert says it, no section repeats it.
|
|
82
78
|
- Past two paragraphs, break the summary into sections under \`###\` headings. These sections, in this order, each opening with its emoji — drop every one you have nothing real to say under; four sections of substance beat six with filler:
|
|
83
79
|
- \`### 🎯 \` the problem — the symptom someone hit and what it cost them, in plain words. No identifiers yet; a product manager should follow this section. For a PR that fixes nothing, this is the goal instead.
|
|
84
80
|
- \`### 🔧 \` the fix — the cause in a sentence, then what the PR does about it. Name things by what they do; identifiers wait for the sections below.
|
|
85
81
|
- \`### 🧭 \` the impact — first say what merging itself does: it changes what runs, or, for a spec or design document, nothing runs differently and approving it commits to a plan. Then, in two or three sentences with no identifiers: what will be different afterwards, for whom, and what stays the same. When several behaviours change, follow with a short before/after table of what people see, never of code. A reviewer in a hurry stops here.
|
|
86
82
|
- \`### 🧩 \` how the pieces fit — when the PR adds a flow or changes how parts work together, whether built or planned, even inside one module. Only a small internal change skips it. Zoom in through the C4 levels, each under a bold label: **System** (the people and outside systems around ours, and what passes between them), **Modules** (the deployable parts and modules, and who calls or notifies whom), **Inside a module** (the main components of the module where most of the change lives). Show only the levels that changed, and skip one that would just repeat the level above, even for a new flow: a new route to an existing service is the Modules level alone, and a new flow inside one module is usually Inside a module alone. **System** appears only when people or outside systems change. A spec PR draws the parts the plan names. Each level gets one or two plain sentences and one top-down \`\`\`mermaid flowchart (\`flowchart TD\`) of at most about 12 nodes, with plain-language labels in double quotes and each arrow labelled with what passes along it. When an existing flow changes, show "today" and "after" as two subgraphs. Use flowchart syntax, never Mermaid's C4 syntax.
|
|
87
83
|
- \`### 🔍 \` details — what a reviewer needs, not everything decided: names, the choice behind the approach, what the PR's own tests pin down, anything counter-intuitive worth knowing.
|
|
88
|
-
- \`### ⚠️ \` worth knowing — risk, follow-up, breaking change.
|
|
84
|
+
- \`### ⚠️ \` worth knowing — risk, follow-up, breaking change. Skip it when there is none.
|
|
89
85
|
- The emoji and the order are fixed. The words after the emoji are yours: write the heading this PR needs ("### 🎯 Searching an order number returned every order"), and fall back to the plain label ("### 🎯 The problem") only when nothing sharper fits.
|
|
90
86
|
- A small PR gets one or two short paragraphs and NO headings. Headings on a three-line summary are noise.
|
|
91
87
|
- The summary describes the PR, never your review of it. Verification you performed ("I ran the tests", "checks came back green", "couldn't check X") belongs in the verdict's reasoning and nowhere else.
|
|
@@ -278,7 +274,7 @@ Rules:
|
|
|
278
274
|
- "line" is a line in the NEW version of the file and must appear in the diff. Use null for a file-level comment.
|
|
279
275
|
- "severity" is the finding's merge impact — "blocker" (would not approve with this in; the only tier that blocks), "minor" (should fix, author's call), "nit" (taste), null (not a finding: a question, a note). Grade as if the finding is true; hedge in the reply, never in the grade. A verdict revision must still follow from the worst finding left standing.
|
|
280
276
|
- Your reply is prose to a person, not a changelog. The cockpit already shows what you changed — do not list your own edits back to them.
|
|
281
|
-
- A revision keeps the shape the review is written in: a rewritten summary keeps its \`###\` sections (🎯 the problem, 🔧 the fix, 🧭 the impact, 🧩 how the pieces fit, with diagrams for only the levels that changed, 🔍 details a reviewer needs, ⚠️ worth knowing — the ones that earn their place)
|
|
277
|
+
- A revision keeps the shape the review is written in: a rewritten summary keeps its \`###\` sections (🎯 the problem, 🔧 the fix, 🧭 the impact, 🧩 how the pieces fit, with diagrams for only the levels that changed, 🔍 details a reviewer needs, ⚠️ worth knowing — the ones that earn their place), a rewritten "reasoning" stays one lead sentence plus bullets, and a comment body leads with the finding on its own line and never writes its own grade in — every surface prefixes that from "severity". The division of labor holds too: the summary describes the PR and the verdict's reasoning holds the review's own verification — neither retells the other.
|
|
282
278
|
|
|
283
279
|
Writing style:
|
|
284
280
|
- Plain words, short sentences, no jargon. Someone who has NOT read the diff should follow you.
|
package/dist/server/daemon.js
CHANGED
|
@@ -2,7 +2,7 @@ import { SCHEMA_VERSION, artifactId, artifactKey } from "../core/artifact.js";
|
|
|
2
2
|
import { evaluateAutoSend } from "../core/autosend.js";
|
|
3
3
|
import { anyAutoReview, autoReviewFor, capAutoReview } from "../core/autoreview.js";
|
|
4
4
|
import { loadConfig } from "../core/config.js";
|
|
5
|
-
import { classifyReply, currentLogin, fetchConversation, fetchLastReviewRequest, fetchOwnReview, fetchPrInfo, fetchReviewRequests, lastMentionOfYou, lastWordOfYours, ownPrUpdatedSince, searchAuthoredByMe, searchAwaitingMe, stillRequested, submitReview, } from "../core/gh.js";
|
|
5
|
+
import { classifyReply, currentLogin, fetchConversation, fetchLastReviewRequest, fetchOwnReview, fetchPrInfo, fetchReviewRequests, lastMentionOfYou, lastWordOfYours, markTeamRequests, ownPrUpdatedSince, searchAuthoredByMe, searchAwaitingMe, searchNamingMe, stillRequested, submitReview, } from "../core/gh.js";
|
|
6
6
|
import { withWriter } from "../core/history.js";
|
|
7
7
|
import { isOwnPr } from "../core/own.js";
|
|
8
8
|
import { pendingNews, notice, notify } from "../core/notify.js";
|
|
@@ -29,6 +29,18 @@ export function dedupeDiscovered(refs) {
|
|
|
29
29
|
return true;
|
|
30
30
|
});
|
|
31
31
|
}
|
|
32
|
+
function awaitingPr(ref, reply) {
|
|
33
|
+
return { id: artifactId(ref), reply, requestedViaTeam: ref.requestedViaTeam };
|
|
34
|
+
}
|
|
35
|
+
/**
|
|
36
|
+
* Whether the last poll found this PR asking only a team of yours, or null if
|
|
37
|
+
* it could not tell. A row the awaiting search did not return — your own PR,
|
|
38
|
+
* one pulled in by hand — was asked of nobody, so of no team either.
|
|
39
|
+
*/
|
|
40
|
+
export function requestedViaTeam(awaiting, id) {
|
|
41
|
+
const entry = awaiting.find((a) => a.id === id);
|
|
42
|
+
return entry ? entry.requestedViaTeam : false;
|
|
43
|
+
}
|
|
32
44
|
/**
|
|
33
45
|
* A pure discovery stub: enough artifact for the queue to show an awaiting row.
|
|
34
46
|
* The AI run that follows (automatic or clicked) replaces it wholesale.
|
|
@@ -255,6 +267,7 @@ export function startDaemon(opts) {
|
|
|
255
267
|
notify: false,
|
|
256
268
|
autoReview: opts.autoReview,
|
|
257
269
|
autoReviewRepos: {},
|
|
270
|
+
autoReviewTeamRequests: opts.autoReview,
|
|
258
271
|
trustedRuns: false,
|
|
259
272
|
polls: 0,
|
|
260
273
|
errors: 0,
|
|
@@ -294,14 +307,25 @@ export function startDaemon(opts) {
|
|
|
294
307
|
* PR decides nothing — a team you are on can be requested on your own PR,
|
|
295
308
|
* and `isOwnPr` reads the author either way.
|
|
296
309
|
*/
|
|
297
|
-
async function discover(me, ownPrMaxAgeDays) {
|
|
310
|
+
async function discover(me, ownPrMaxAgeDays, teamRequestsDrafted) {
|
|
298
311
|
const filters = opts.repos.length > 0 ? opts.repos : [undefined];
|
|
299
312
|
// Your own PRs only: a review request is never aged out. One that went
|
|
300
313
|
// stale leaves the search, and the reaper below drops its stub like any
|
|
301
314
|
// other the search stopped returning — a draft of yours stays put.
|
|
302
315
|
const since = ownPrUpdatedSince(ownPrMaxAgeDays);
|
|
303
|
-
const [awaiting, authored] = await Promise.all([
|
|
316
|
+
const [awaiting, named, authored] = await Promise.all([
|
|
304
317
|
Promise.all(filters.map((repo) => searchAwaitingMe(repo))),
|
|
318
|
+
// It only tells your requests from your teams', which changes nothing
|
|
319
|
+
// while both are drafted — so it is only asked while they are not.
|
|
320
|
+
// Failing, it costs that distinction for one poll rather than the poll:
|
|
321
|
+
// discovery and the announcements go ahead, and a row nobody could
|
|
322
|
+
// classify waits for the click like a team's.
|
|
323
|
+
teamRequestsDrafted
|
|
324
|
+
? Promise.resolve(null)
|
|
325
|
+
: Promise.all(filters.map((repo) => searchNamingMe(repo))).catch((err) => {
|
|
326
|
+
log(`could not tell team review requests from yours: ${err instanceof Error ? err.message : String(err)}`);
|
|
327
|
+
return null;
|
|
328
|
+
}),
|
|
305
329
|
me === null
|
|
306
330
|
? Promise.resolve(null)
|
|
307
331
|
: Promise.all(filters.map((repo) => searchAuthoredByMe(repo, since))).catch((err) => {
|
|
@@ -310,7 +334,7 @@ export function startDaemon(opts) {
|
|
|
310
334
|
}),
|
|
311
335
|
]);
|
|
312
336
|
return {
|
|
313
|
-
refs: dedupeDiscovered([...awaiting.flat(), ...(authored ?? []).flat()]),
|
|
337
|
+
refs: dedupeDiscovered([...markTeamRequests(awaiting.flat(), named?.flat() ?? null), ...(authored ?? []).flat()]),
|
|
314
338
|
ownSearched: authored !== null,
|
|
315
339
|
};
|
|
316
340
|
}
|
|
@@ -730,14 +754,14 @@ export function startDaemon(opts) {
|
|
|
730
754
|
}
|
|
731
755
|
catch {
|
|
732
756
|
// Without knowing who you are, no comment can be attributed to you.
|
|
733
|
-
return refs.map((ref) => (
|
|
757
|
+
return refs.map((ref) => awaitingPr(ref, "unknown"));
|
|
734
758
|
}
|
|
735
759
|
return pool(refs, opts.parallel, async (ref) => {
|
|
736
760
|
try {
|
|
737
|
-
return
|
|
761
|
+
return awaitingPr(ref, classifyReply(await fetchConversation(ref), login));
|
|
738
762
|
}
|
|
739
763
|
catch {
|
|
740
|
-
return
|
|
764
|
+
return awaitingPr(ref, "unknown");
|
|
741
765
|
}
|
|
742
766
|
});
|
|
743
767
|
}
|
|
@@ -832,7 +856,10 @@ export function startDaemon(opts) {
|
|
|
832
856
|
// Your own PRs are never drafted unasked, whatever auto-review says for
|
|
833
857
|
// their repo: they are in the inbox for a self-review on demand. The same
|
|
834
858
|
// predicate decides when a tap is due, which keeps them quiet there too.
|
|
835
|
-
|
|
859
|
+
// Whether only a team was asked is read off the published list rather
|
|
860
|
+
// than the PR, because the cockpit reads it there too.
|
|
861
|
+
const drafts = (pr) => !isOwnPr(pr, me) &&
|
|
862
|
+
autoReviewFor(autoReview, { ...pr, requestedViaTeam: requestedViaTeam(status.awaiting, artifactId(pr)) });
|
|
836
863
|
status.pollEnabled = knobs.poll;
|
|
837
864
|
// What the cockpit's bell defers to: a loop that isn't polling announces
|
|
838
865
|
// nothing, whatever the notify toggle says.
|
|
@@ -844,6 +871,7 @@ export function startDaemon(opts) {
|
|
|
844
871
|
status.notify = announcing();
|
|
845
872
|
status.autoReview = autoReview.autoReview;
|
|
846
873
|
status.autoReviewRepos = autoReview.autoReviewRepos;
|
|
874
|
+
status.autoReviewTeamRequests = autoReview.autoReviewTeamRequests;
|
|
847
875
|
// Recomputed too, so a trust rule added mid-run shows up in the strip.
|
|
848
876
|
status.trustedRuns = anyAutoReview(autoReview) && opts.trust !== false && config.trust.length > 0;
|
|
849
877
|
return { knobs, drafts, drafting: anyAutoReview(autoReview), notifyOn, announcing };
|
|
@@ -876,7 +904,7 @@ export function startDaemon(opts) {
|
|
|
876
904
|
status.lastSummary = "polling off (settings) — the queue only shows what you review by hand";
|
|
877
905
|
return;
|
|
878
906
|
}
|
|
879
|
-
const { refs, ownSearched } = await discover(me, knobs.ownPrMaxAgeDays);
|
|
907
|
+
const { refs, ownSearched } = await discover(me, knobs.ownPrMaxAgeDays, knobs.autoReviewTeamRequests);
|
|
880
908
|
// Your own PRs are synced into the queue with the rest, but nobody is
|
|
881
909
|
// asking you for them: they are not "awaiting" in anything the strip
|
|
882
910
|
// counts, and the cockpit's open-requests tab — "GitHub still lists you
|
package/dist/server/index.js
CHANGED
|
@@ -6,7 +6,7 @@ import { promises as fs } from "node:fs";
|
|
|
6
6
|
import path from "node:path";
|
|
7
7
|
import { fileURLToPath } from "node:url";
|
|
8
8
|
import { randomUUID } from "node:crypto";
|
|
9
|
-
import { isPureStub } from "./daemon.js";
|
|
9
|
+
import { isPureStub, requestedViaTeam } from "./daemon.js";
|
|
10
10
|
import { ArtifactStatusSchema, SCHEMA_VERSION, SeveritySchema, VerdictSchema, artifactId, artifactKey, } from "../core/artifact.js";
|
|
11
11
|
import { toMarkdown } from "../core/export.js";
|
|
12
12
|
import { isOwnPr } from "../core/own.js";
|
|
@@ -266,6 +266,7 @@ export async function buildApp(opts) {
|
|
|
266
266
|
// and must not hang on GitHub: a gh that cannot say in time marks nothing
|
|
267
267
|
// as yours, and Send's own guard still refuses what GitHub would.
|
|
268
268
|
const me = await loginWithin(LOGIN_WAIT_MS);
|
|
269
|
+
const awaiting = opts.daemon?.status().awaiting ?? [];
|
|
269
270
|
return c.json(artifacts.map((a) => ({
|
|
270
271
|
id: a.id,
|
|
271
272
|
key: artifactKey(a.id),
|
|
@@ -309,6 +310,10 @@ export async function buildApp(opts) {
|
|
|
309
310
|
// A PR you opened: listed apart from the ones awaiting you, and sent
|
|
310
311
|
// as a comment only (`ownPrRefusal`).
|
|
311
312
|
own: isOwnPr(a.pr, me),
|
|
313
|
+
// Only a team of yours was asked, as of the last poll — what the bell
|
|
314
|
+
// and the row's explanation need to tell "waits for a click" from
|
|
315
|
+
// "being drafted" under `autoReviewTeamRequests`.
|
|
316
|
+
requestedViaTeam: requestedViaTeam(awaiting, a.id),
|
|
312
317
|
costUsd: a.run?.costUsd ?? null,
|
|
313
318
|
withSource: a.run?.withSource ?? null,
|
|
314
319
|
trusted: a.run?.trusted ?? null,
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@fullstackhouse/cerber",
|
|
3
|
-
"version": "1.6.5-pr.
|
|
3
|
+
"version": "1.6.5-pr.95.4276b94",
|
|
4
4
|
"description": "AI code-review cockpit: Claude reviews your PRs into local artifacts; nothing reaches GitHub until you say so.",
|
|
5
5
|
"license": "MIT",
|
|
6
6
|
"keywords": [
|
package/web/dist/assets/{abnfDiagram-WEYOIA3C-D5T4yrfy.js → abnfDiagram-WEYOIA3C-ZVjk8TRR.js}
RENAMED
|
@@ -1 +1 @@
|
|
|
1
|
-
import{g as p,r as u,d as a}from"./chunk-2E7WHVMD-
|
|
1
|
+
import{g as p,r as u,d as a}from"./chunk-2E7WHVMD-D-_dw85f.js";import{p as f}from"./chunk-JWPE2WC7-DzKBdMkf.js";import{_ as n,l as o}from"./mermaid.core-a2mmm40M.js";import{M as c,b as d}from"./cynefin-EF2NZ3EQ-KI3U995R.js";import"./index-DSUaxe4H.js";var v=d().RailroadAbnf.parser.LangiumParser,i=n(e=>{const r=e.alternatives.map(g);return r.length===1?r[0]:{type:"choice",alternatives:r}},"transformAlternation"),g=n(e=>{const r=e.elements.map(y);return r.length===1?r[0]:{type:"sequence",elements:r}},"transformConcatenation"),b=n(e=>{if(e.includes("*")){const[t,s]=e.split("*"),l=t?parseInt(t,10):0,m=s?parseInt(s,10):1/0;return{min:l,max:m}}const r=parseInt(e,10);return{min:r,max:r}},"parseRepeat"),y=n(e=>{const r=A(e.primary);if(!e.repeat)return r;const{min:t,max:s}=b(e.repeat);return t===0&&s===1?{type:"optional",element:r}:{type:"repetition",element:r,min:t,max:s}},"transformElement"),A=n(e=>{switch(e.$type){case"AbnfStringLiteral":return{type:"terminal",value:e.value};case"AbnfNumVal":return{type:"terminal",value:e.value};case"AbnfRuleName":return{type:"nonterminal",name:e.name};case"AbnfGroup":return i(e.element);case"AbnfOptionalGroup":return{type:"optional",element:i(e.element)};default:throw new Error(`Unsupported ABNF primary node: ${e.$type}`)}},"transformPrimary"),P=n(e=>({name:e.name,definition:i(e.definition)}),"transformRule"),h=n(e=>{f(e,a),e.title&&a.setTitle(e.title),e.rules.map(r=>a.addRule(P(r)))},"populateDb"),R={parse:n(e=>{a.clear(),o.debug("[ABNF Parser] Starting Langium parse");const r=v.parse(e);if(r.lexerErrors.length>0||r.parserErrors.length>0)throw new c(r);const t=r.value;o.debug("[ABNF Parser] Parsed rules:",t.rules.length),h(t),o.debug("[ABNF Parser] Parse complete")},"parse"),parser:{yy:a}},B={parser:R,db:a,renderer:u,styles:p};export{B as diagram};
|
|
@@ -1 +1 @@
|
|
|
1
|
-
import{a5 as ln,a6 as an,a7 as H,a8 as j,a9 as B,aa as un,ab as g,ac as tn,ad as L,ae as _,af as rn,ag as o,ah as on,ai as sn,aj as fn}from"./mermaid.core-
|
|
1
|
+
import{a5 as ln,a6 as an,a7 as H,a8 as j,a9 as B,aa as un,ab as g,ac as tn,ad as L,ae as _,af as rn,ag as o,ah as on,ai as sn,aj as fn}from"./mermaid.core-a2mmm40M.js";function cn(l){return l.innerRadius}function gn(l){return l.outerRadius}function yn(l){return l.startAngle}function dn(l){return l.endAngle}function mn(l){return l&&l.padAngle}function pn(l,h,E,q,v,A,C,a){var I=E-l,i=q-h,n=C-v,d=a-A,u=d*I-n*i;if(!(u*u<g))return u=(n*(h-A)-d*(l-v))/u,[l+u*I,h+u*i]}function W(l,h,E,q,v,A,C){var a=l-E,I=h-q,i=(C?A:-A)/L(a*a+I*I),n=i*I,d=-i*a,u=l+n,s=h+d,f=E+n,c=q+d,F=(u+f)/2,t=(s+c)/2,m=f-u,y=c-s,R=m*m+y*y,T=v-A,P=u*c-f*s,O=(y<0?-1:1)*L(on(0,T*T*R-P*P)),S=(P*y-m*O)/R,z=(-P*m-y*O)/R,w=(P*y+m*O)/R,p=(-P*m+y*O)/R,x=S-F,e=z-t,r=w-F,G=p-t;return x*x+e*e>r*r+G*G&&(S=w,z=p),{cx:S,cy:z,x01:-n,y01:-d,x11:S*(v/T-1),y11:z*(v/T-1)}}function hn(){var l=cn,h=gn,E=B(0),q=null,v=yn,A=dn,C=mn,a=null,I=ln(i);function i(){var n,d,u=+l.apply(this,arguments),s=+h.apply(this,arguments),f=v.apply(this,arguments)-un,c=A.apply(this,arguments)-un,F=rn(c-f),t=c>f;if(a||(a=n=I()),s<u&&(d=s,s=u,u=d),!(s>g))a.moveTo(0,0);else if(F>tn-g)a.moveTo(s*H(f),s*j(f)),a.arc(0,0,s,f,c,!t),u>g&&(a.moveTo(u*H(c),u*j(c)),a.arc(0,0,u,c,f,t));else{var m=f,y=c,R=f,T=c,P=F,O=F,S=C.apply(this,arguments)/2,z=S>g&&(q?+q.apply(this,arguments):L(u*u+s*s)),w=_(rn(s-u)/2,+E.apply(this,arguments)),p=w,x=w,e,r;if(z>g){var G=sn(z/u*j(S)),M=sn(z/s*j(S));(P-=G*2)>g?(G*=t?1:-1,R+=G,T-=G):(P=0,R=T=(f+c)/2),(O-=M*2)>g?(M*=t?1:-1,m+=M,y-=M):(O=0,m=y=(f+c)/2)}var J=s*H(m),K=s*j(m),N=u*H(T),Q=u*j(T);if(w>g){var U=s*H(y),V=s*j(y),X=u*H(R),Y=u*j(R),D;if(F<an)if(D=pn(J,K,X,Y,U,V,N,Q)){var Z=J-D[0],$=K-D[1],b=U-D[0],k=V-D[1],nn=1/j(fn((Z*b+$*k)/(L(Z*Z+$*$)*L(b*b+k*k)))/2),en=L(D[0]*D[0]+D[1]*D[1]);p=_(w,(u-en)/(nn-1)),x=_(w,(s-en)/(nn+1))}else p=x=0}O>g?x>g?(e=W(X,Y,J,K,s,x,t),r=W(U,V,N,Q,s,x,t),a.moveTo(e.cx+e.x01,e.cy+e.y01),x<w?a.arc(e.cx,e.cy,x,o(e.y01,e.x01),o(r.y01,r.x01),!t):(a.arc(e.cx,e.cy,x,o(e.y01,e.x01),o(e.y11,e.x11),!t),a.arc(0,0,s,o(e.cy+e.y11,e.cx+e.x11),o(r.cy+r.y11,r.cx+r.x11),!t),a.arc(r.cx,r.cy,x,o(r.y11,r.x11),o(r.y01,r.x01),!t))):(a.moveTo(J,K),a.arc(0,0,s,m,y,!t)):a.moveTo(J,K),!(u>g)||!(P>g)?a.lineTo(N,Q):p>g?(e=W(N,Q,U,V,u,-p,t),r=W(J,K,X,Y,u,-p,t),a.lineTo(e.cx+e.x01,e.cy+e.y01),p<w?a.arc(e.cx,e.cy,p,o(e.y01,e.x01),o(r.y01,r.x01),!t):(a.arc(e.cx,e.cy,p,o(e.y01,e.x01),o(e.y11,e.x11),!t),a.arc(0,0,u,o(e.cy+e.y11,e.cx+e.x11),o(r.cy+r.y11,r.cx+r.x11),t),a.arc(r.cx,r.cy,p,o(r.y11,r.x11),o(r.y01,r.x01),!t))):a.arc(0,0,u,T,R,t)}if(a.closePath(),n)return a=null,n+""||null}return i.centroid=function(){var n=(+l.apply(this,arguments)+ +h.apply(this,arguments))/2,d=(+v.apply(this,arguments)+ +A.apply(this,arguments))/2-an/2;return[H(d)*n,j(d)*n]},i.innerRadius=function(n){return arguments.length?(l=typeof n=="function"?n:B(+n),i):l},i.outerRadius=function(n){return arguments.length?(h=typeof n=="function"?n:B(+n),i):h},i.cornerRadius=function(n){return arguments.length?(E=typeof n=="function"?n:B(+n),i):E},i.padRadius=function(n){return arguments.length?(q=n==null?null:typeof n=="function"?n:B(+n),i):q},i.startAngle=function(n){return arguments.length?(v=typeof n=="function"?n:B(+n),i):v},i.endAngle=function(n){return arguments.length?(A=typeof n=="function"?n:B(+n),i):A},i.padAngle=function(n){return arguments.length?(C=typeof n=="function"?n:B(+n),i):C},i.context=function(n){return arguments.length?(a=n??null,i):a},i}export{hn as d};
|