@fugood/bricks-ctor 2.25.0-beta.36 → 2.25.0-beta.37

package/compile/__tests__/index.test.js

@@ -3,8 +3,9 @@ import { compile } from '../index'
 const SUBSPACE_ID = 'SUBSPACE_00000000-0000-0000-0000-000000000001'
 const CANVAS_ID = 'CANVAS_00000000-0000-0000-0000-000000000001'
 const ANIMATION_ID = 'ANIMATION_00000000-0000-0000-0000-000000000001'
+const DATA_ID = 'PROPERTY_BANK_DATA_NODE_00000000-0000-0000-0000-000000000001'
 
-const makeApp = (animations) => {
+const makeApp = (animations = [], data = []) => {
   const rootCanvas = {
     __typename: 'Canvas',
     id: CANVAS_ID,
@@ -23,7 +24,7 @@ const makeApp = (animations) => {
     animations,
     bricks: [],
     generators: [],
-    data: [],
+    data,
     dataRouting: [],
     dataCalculation: [],
   }
@@ -35,6 +36,13 @@ const makeApp = (animations) => {
   }
 }
 
+const makeData = (remoteUpdate) => ({
+  __typename: 'Data',
+  id: DATA_ID,
+  type: 'string',
+  remoteUpdate,
+})
+
 describe('compile animations', () => {
   test('normalizes mixed legacy spring config', async () => {
     const warnSpy = jest.spyOn(console, 'warn').mockImplementation(() => {})
@@ -113,3 +121,32 @@ describe('compile animations', () => {
     ).rejects.toThrow(/Invalid animation config type/)
   })
 })
+
+describe('compile data remote update', () => {
+  test.each([
+    [undefined, { bank_type: 'none' }],
+    [{ type: 'auto' }, { bank_type: 'create', enable_remote_update: true }],
+    [
+      { type: 'device-specific' },
+      {
+        bank_type: 'create-device-specific',
+        enable_remote_update: true,
+        use_remote_id_prefix: true,
+      },
+    ],
+    [
+      { type: 'global-data', id: 'GLOBAL_PROP_1' },
+      {
+        bank_type: 'global',
+        enable_remote_update: true,
+        global_remote_update_prop: 'GLOBAL_PROP_1',
+      },
+    ],
+  ])('emits bank_type for %p', async (remoteUpdate, expectedRemoteUpdate) => {
+    const config = await compile(makeApp([], [makeData(remoteUpdate)]))
+
+    expect(config.subspace_map[SUBSPACE_ID].property_bank_map[DATA_ID]).toMatchObject(
+      expectedRemoteUpdate,
+    )
+  })
+})

package/compile/index.ts

@@ -513,9 +513,10 @@ const compileKind = (kind: Data['kind']) => {
 }
 
 const compileRemoteUpdate = (remoteUpdate: Data['remoteUpdate']) => {
-  if (!remoteUpdate) return {}
-  if (remoteUpdate.type === 'auto') return { enable_remote_update: true }
+  if (!remoteUpdate) return { bank_type: 'none' }
+  if (remoteUpdate.type === 'auto') return { bank_type: 'create', enable_remote_update: true }
   return {
+    bank_type: remoteUpdate.type === 'device-specific' ? 'create-device-specific' : 'global',
     enable_remote_update: true,
     ...(remoteUpdate.type === 'device-specific' ? { use_remote_id_prefix: true } : {}),
     ...(remoteUpdate.type === 'global-data' ? { global_remote_update_prop: remoteUpdate.id } : {}),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fugood/bricks-ctor",
-  "version": "2.25.0-beta.36",
+  "version": "2.25.0-beta.37",
   "main": "index.ts",
   "scripts": {
     "typecheck": "tsc --noEmit",
@@ -25,5 +25,5 @@
   "peerDependencies": {
     "oxfmt": "^0.36.0"
   },
-  "gitHead": "c53e96e4dfcea862106a3492ea01a6d080d26881"
+  "gitHead": "53740bd4fb9ec122c5510d9935fd43878f440eca"
 }