@fsai-flow/core 0.0.3 → 0.0.5

package/dist/README.md

@@ -0,0 +1,31 @@
+# @fsai-flow/core
+
+This library is a dependency for [FSAI-Flow](https://github.com/your-org/flowx) that contains base classes and types used throughout the application.
+
+## Installation
+
+This project is published to the npm registry. To use it in your project:
+
+```bash
+npm install @fsai-flow/core
+```
+
+## Building
+
+Run `nx build core` to build the library.
+
+## Running unit tests
+
+Run `nx test core` to execute the unit tests via [Jest](https://jestjs.io).
+
+## Contributing
+
+To contribute to this project:
+
+1. Clone this repository
+2. Make your changes
+3. Open a Pull Request
+
+## Publishing
+
+Maintainers can publish a new version to the npm package registry.

package/dist/package.json

@@ -0,0 +1,54 @@
+{
+  "name": "@fsai-flow/core",
+  "version": "0.0.4",
+  "dependencies": {
+    "@fsai-flow/workflow": "0.0.3",
+    "client-oauth2": "^4.3.3",
+    "cron": "~3.3.0",
+    "crypto-js": "~4.2.0",
+    "file-type": "^16.0.0",
+    "form-data": "4.0.4",
+    "https-proxy-agent": "^7.0.6",
+    "ioredis": "^5.3.2",
+    "lodash": "^4.17.21",
+    "mime-types": "^2.1.27",
+    "oauth-1.0a": "^2.2.6",
+    "p-cancelable": "^2.0.0",
+    "qs": "^6.10.1",
+    "request": "^2.88.2",
+    "request-promise-native": "^1.0.9",
+    "simple-oauth2": "^5.1.0",
+    "tslib": "^2.3.0",
+    "uuid": "^11.0.3",
+    "fast-glob": "3.2.12"
+  },
+  "devDependencies": {
+    "@types/crypto-js": "^4.0.1",
+    "@types/express": "^5.0.0",
+    "@types/lodash": "^4.17.13",
+    "@types/lodash.get": "^4.4.9",
+    "@types/mime-types": "^2.1.0",
+    "@types/node": "^22.10.2",
+    "@types/qs": "^6.9.17",
+    "@types/request": "^2.48.12",
+    "@types/request-promise-native": "^1.0.15",
+    "@types/simple-oauth2": "^5.0.7",
+    "@types/uuid": "^10.0.0",
+    "axios": "^1.7.9",
+    "ioredis": "^5.3.2",
+    "jsonc-eslint-parser": "^2.4.0",
+    "typescript": "~5.7.2"
+  },
+  "type": "commonjs",
+  "main": "dist/src/index",
+  "types": "dist/src/index.d.ts",
+  "overrides": {
+    "request": {
+      "form-data": "2.5.4",
+      "tough-cookie": "4.1.3"
+    },
+    "request-promise-native": {
+      "tough-cookie": "4.1.3"
+    }
+  }
+}

package/package.json

@@ -1,8 +1,8 @@
 {
   "name": "@fsai-flow/core",
-  "version": "0.0.3",
+  "version": "0.0.5",
   "dependencies": {
-    "@fsai-flow/workflow": "0.0.2",
+    "@fsai-flow/workflow": "0.0.3",
     "client-oauth2": "^4.3.3",
     "cron": "~3.3.0",
     "crypto-js": "~4.2.0",

package/src/lib/ActiveWebhooks.ts

@@ -7,7 +7,7 @@ import {
 } from '@fsai-flow/workflow';
 
 // eslint-disable-next-line import/no-cycle
-import { NodeExecuteFunctions } from '../../src';
+import { NodeExecuteFunctions } from '..';
 
 export class ActiveWebhooks {
 	private workflowWebhooks: {

package/src/lib/ActiveWorkflows.ts

@@ -23,7 +23,7 @@ import { RedisLeaderElectionManager } from './RedisLeaderElectionManager';
 import type Redis from 'ioredis';
 
 // eslint-disable-next-line import/no-cycle
-import { ITriggerTime, IWorkflowData } from '../../src';
+import { ITriggerTime, IWorkflowData } from '..';
 import { RedisOptions } from 'ioredis';
 
 interface IPollingWorkflow {

package/src/lib/LoadNodeParameterOptions.ts

@@ -25,7 +25,7 @@ import {
 } from '@fsai-flow/workflow';
 
 // eslint-disable-next-line import/no-cycle
-import { NodeExecuteFunctions } from '../../src';
+import { NodeExecuteFunctions } from '..';
 
 const TEMP_NODE_NAME = 'Temp-Node';
 const TEMP_WORKFLOW_NAME = 'Temp-Workflow';

package/src/lib/NodeExecuteFunctions.ts

@@ -96,7 +96,7 @@ import {
 	IResponseError,
 	IWorkflowSettings,
 	PLACEHOLDER_EMPTY_EXECUTION_ID,
-} from '../../src';
+} from '..';
 import { arrayBuffer } from 'stream/consumers';
 import { promises as fs } from 'fs';
 

package/src/lib/RedisLeaderElectionManager.ts

@@ -38,11 +38,76 @@ export class RedisLeaderElectionManager {
 			Logger.info(`Redis connected for leader election: ${this.lockKey}`);
 		});
 
+		this.redis.on('ready', () => {
+			Logger.info(`Redis ready for leader election: ${this.lockKey}`);
+		});
+
 		this.redis.on('error', (error: any) => {
 			Logger.error(`Redis connection error for leader election: ${error.message}`);
 		});
 	}
 
+	/**
+	 * Wait for Redis connection to be ready
+	 */
+	private async waitForRedisConnection(): Promise<void> {
+		return new Promise((resolve, reject) => {
+			if (this.redis.status === 'ready') {
+				Logger.debug(`Redis already ready for ${this.lockKey}`);
+				resolve();
+				return;
+			}
+
+			let isSettled = false;
+			let timeoutId: NodeJS.Timeout | null = null;
+
+			// Cleanup function to prevent memory leaks
+			const cleanup = () => {
+				if (isSettled) return; // Already cleaned up
+				isSettled = true;
+
+				// Clear timeout safely
+				if (timeoutId !== null) {
+					clearTimeout(timeoutId);
+					timeoutId = null;
+				}
+
+				// Remove event listeners safely
+				try {
+					this.redis.off('ready', onReady);
+					this.redis.off('error', onError);
+				} catch (error) {
+					// Ignore cleanup errors - Redis connection might be destroyed
+					Logger.debug(`Cleanup warning for ${this.lockKey}: ${error}`);
+				}
+			};
+
+			const onReady = () => {
+				cleanup();
+				Logger.debug(`Redis connection established for ${this.lockKey}`);
+				resolve();
+			};
+
+			const onError = (error: Error) => {
+				cleanup();
+				Logger.error(`Redis connection failed for ${this.lockKey}: ${error.message}`);
+				reject(error);
+			};
+
+			const onTimeout = () => {
+				cleanup();
+				reject(new Error(`Redis connection timeout after 10 seconds for ${this.lockKey}`));
+			};
+
+			// Set up timeout
+			timeoutId = setTimeout(onTimeout, 10000); // 10 second timeout
+
+			// Set up event listeners
+			this.redis.once('ready', onReady);
+			this.redis.once('error', onError);
+		});
+	}
+
 	/**
 	 * Start the leader election process
 	 */
@@ -50,6 +115,11 @@ export class RedisLeaderElectionManager {
 		Logger.info(`🚀 Starting Redis leader election for ${this.nodeId} on key ${this.lockKey}`);
 		Logger.info(`🔧 Leader election config: TTL=${this.lockTTL}ms, RenewalInterval=${this.renewalInterval}ms`);
 		
+		// Wait for Redis connection to be ready
+		Logger.info(`⏳ ${this.nodeId} waiting for Redis connection...`);
+		await this.waitForRedisConnection();
+		Logger.info(`✅ Redis connection ready for ${this.nodeId}`);
+		
 		// Try to acquire leadership immediately
 		Logger.info(`🎯 ${this.nodeId} making initial leadership attempt...`);
 		await this.tryAcquireLeadership();
@@ -98,6 +168,12 @@ export class RedisLeaderElectionManager {
 	 */
 	private async tryAcquireLeadership(): Promise<boolean> {
 		try {
+			// Check if Redis connection is ready before attempting operations
+			if (this.redis.status !== 'ready') {
+				Logger.warn(`Redis not ready for ${this.nodeId}, current status: ${this.redis.status}`);
+				return false;
+			}
+
 			Logger.debug(`Node ${this.nodeId} attempting to acquire leadership for ${this.lockKey}`);
 			
 			// Use SET with NX (not exists) and PX (expire in milliseconds)
@@ -160,6 +236,12 @@ export class RedisLeaderElectionManager {
 	 */
 	private async renewLock(): Promise<boolean> {
 		try {
+			// Check if Redis connection is ready before attempting operations
+			if (this.redis.status !== 'ready') {
+				Logger.warn(`Redis not ready for ${this.nodeId} renewal, current status: ${this.redis.status}`);
+				return false;
+			}
+
 			Logger.debug(`🔄 Node ${this.nodeId} attempting to renew leadership for ${this.lockKey}`);
 			
 			// Use Lua script to atomically check ownership and renew

package/src/lib/UserSettings.ts

@@ -13,7 +13,7 @@ import {
 	USER_FOLDER_ENV_OVERWRITE,
 	USER_SETTINGS_FILE_NAME,
 	USER_SETTINGS_SUBFOLDER,
-} from '../../src';
+} from '..';
 
 // eslint-disable-next-line @typescript-eslint/no-var-requires
 const { promisify } = require('util');

package/src/lib/WorkflowExecute.ts

@@ -23,7 +23,7 @@ import {
 	WorkflowOperationError,
 } from '@fsai-flow/workflow';
 import { get } from 'lodash';
-import { NodeExecuteFunctions } from '../../src';
+import { NodeExecuteFunctions } from '..';
 
 export class WorkflowExecute {
 	runExecutionData: IRunExecutionData;
@@ -283,10 +283,6 @@ export class WorkflowExecute {
 	): void {
 		let stillDataMissing = false;
 
-		if (connectionData.node === '__proto__' || connectionData.node === 'constructor' || connectionData.node === 'prototype') {
-			throw new Error('Prototype pollution detected');
-		}
-
 		// Check if node has multiple inputs as then we have to wait for all input data
 		// to be present before we can add it to the node-execution-stack
 		if (workflow.connectionsByDestinationNode[connectionData.node]['main'].length > 1) {

package/tsconfig.json

@@ -1,5 +1,4 @@
 {
-  "extends": "./tsconfig.base.json",
   "compilerOptions": {
 		"baseUrl": ".",
     "paths": {

package/tsconfig.base.json

@@ -1,28 +0,0 @@
-{
-    "compileOnSave": false,
-    "compilerOptions": {
-      "rootDir": ".",
-      "sourceMap": true,
-      "declaration": false,
-      "moduleResolution": "node",
-      "emitDecoratorMetadata": true,
-      "experimentalDecorators": true,
-      "importHelpers": true,
-      "target": "es2015",
-      "module": "esnext",
-      "lib": ["es2020", "dom"],
-      "skipLibCheck": true,
-      "skipDefaultLibCheck": true,
-      "baseUrl": ".",
-      "paths": {
-        "@fsai-flow/core": ["libs/core/src/index.ts"],
-        "@fsai-flow/nodes-base": ["libs/nodes-base/src/index.ts"],
-        "@fsai-flow/nodes-langchain": ["libs/nodes-langchain/src/index.ts"],
-        "@fsai-flow/workflow": ["libs/workflow/src/index.ts"],
-        "@fsai-flow/design-system": ["apps/design-system/src/main.ts"],
-        "@fsai-flow/editor-ui": ["apps/editor-ui/src/index.ts"],
-        "@fsai-flow/cli": ["apps/cli/src/index.ts"],
-      }
-    },
-    "exclude": ["node_modules", "tmp"]
-  }