@frontify/guideline-blocks-settings 0.29.2 → 0.29.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@frontify/guideline-blocks-settings",
-  "version": "0.29.2",
+  "version": "0.29.4",
   "description": "Provides types and helpers for the guideline block development",
   "sideEffects": false,
   "main": "dist/index.umd.js",
@@ -56,14 +56,14 @@
     "@dnd-kit/core": "^6.0.8",
     "@dnd-kit/modifiers": "^6.0.1",
     "@dnd-kit/sortable": "^7.0.2",
-    "@frontify/fondue": "12.0.0-beta.314",
+    "@frontify/fondue": "12.0.0-beta.316",
     "@react-aria/focus": "^3.14.0",
     "@react-stately/overlays": "^3.6.1",
     "@udecode/plate": "^21.5.0",
     "slate": "^0.94.1",
     "slate-react": "^0.98.3",
-    "@frontify/app-bridge": "3.0.0-beta.89",
-    "@frontify/sidebar-settings": "0.6.6"
+    "@frontify/app-bridge": "^3.0.0-beta.90",
+    "@frontify/sidebar-settings": "^0.6.8"
   },
   "peerDependencies": {
     "react": "^18",

package/src/components/RichTextEditor/RichTextEditor.spec.ct.tsx

@@ -10,6 +10,7 @@ import { convertToRteValue } from '../../helpers';
 const RteHtmlSelector = '[data-test-id="rte-content-html"]';
 const RichTextSelector = '[data-test-id="rich-text-editor"]';
 const ButtonSelector = '[data-test-id="button"]';
+const CheckboxSelector = '[data-test-id="checkbox-icon-box"]';
 const ToolbarButtonSelector = '[data-testid="ToolbarButton"]';
 const InternalDocumentLinkSelector = '[data-test-id="internal-link-selector-document-link"]';
 const FloatingLinkModalSelector = '[data-test-id="floating-link-insert"]';
@@ -71,7 +72,33 @@ describe('RichTextEditor', () => {
         cy.get(InternalDocumentLinkSelector).click();
         cy.get(ButtonSelector).last().click();
         cy.get(FloatingLinkModalSelector).find(ButtonSelector).last().click();
-        cy.get(RichTextSelector).find('a[href="/r/document"]').should('exist');
+        const linkTag = cy.get(RichTextSelector).find('a[href="/r/document"]');
+        linkTag.should('exist');
+        linkTag.should('have.attr', 'target', '_self');
+    });
+
+    it('should be able to select internal link with target blank', () => {
+        (appBridge.getDocumentGroups as SinonStub) = cy.stub().returns([]);
+        (appBridge.getAllDocuments as SinonStub) = cy.stub().returns(Promise.resolve(apiDocuments));
+
+        mount(
+            <RichTextEditor
+                isEditing={true}
+                plugins={new PluginComposer().setPlugin([new LinkPlugin({ appBridge })])}
+                value={convertToRteValue('p', 'This is a link')}
+            />,
+        );
+        cy.get(RichTextSelector).click();
+        cy.get(RichTextSelector).type('{selectall}');
+        cy.get(ToolbarButtonSelector).click();
+        cy.get(ButtonSelector).first().click();
+        cy.get(InternalDocumentLinkSelector).click();
+        cy.get(ButtonSelector).last().click();
+        cy.get(CheckboxSelector).click();
+        cy.get(FloatingLinkModalSelector).find(ButtonSelector).last().click();
+        const linkTag = cy.get(RichTextSelector).find('a[href="/r/document"]');
+        linkTag.should('exist');
+        linkTag.should('have.attr', 'target', '_blank');
     });
 
     it('should prepend the URL with https:// if not exists', () => {

package/src/components/RichTextEditor/plugins/ButtonPlugin/ButtonMarkupElement/ButtonMarkupElementNode.tsx

@@ -13,7 +13,7 @@ const useButton = (props: ButtonRootProps): HTMLPropsAs<'a'> & { buttonStyle: Ri
         elementToAttributes: (element) => ({
             url: element.href,
             buttonStyle: element.buttonStyle || 'primary',
-            target: element.target || '_blank',
+            target: element.target || '_self',
         }),
     });
 

package/src/components/RichTextEditor/plugins/ButtonPlugin/createButtonPlugin.ts

@@ -88,7 +88,7 @@ export const createButtonPlugin = (appBridge: AppBridgeBlock) =>
                 getNode: (el) => ({
                     type,
                     url: el.getAttribute('href'),
-                    target: el.getAttribute('target') || '_blank',
+                    target: el.getAttribute('target') || '_self',
                 }),
             },
         }),

package/src/components/RichTextEditor/plugins/LinkPlugin/LinkMarkupElement/LinkMarkupElementNode.tsx

@@ -11,7 +11,7 @@ const useLink = (props: LinkRootProps): HTMLPropsAs<'a'> => {
         ...props,
         elementToAttributes: (element) => ({
             href: element.url || element.chosenLink?.searchResult?.link || '',
-            target: element.target || '_blank',
+            target: element.target || '_self',
         }),
     });