@frockbot/plugin-voice 0.3.21 → 0.3.23

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@frockbot/plugin-voice",
-  "version": "0.3.21",
+  "version": "0.3.23",
   "private": false,
   "type": "module",
   "exports": {
@@ -26,12 +26,12 @@
     "typecheck": "vue-tsc --noEmit -p tsconfig.json"
   },
   "dependencies": {
-    "@frockbot/client-core": "0.3.21",
-    "@frockbot/client-ui": "0.3.21",
-    "@frockbot/kernel-contracts": "0.3.21",
-    "@frockbot/plugin-flock": "0.3.21",
-    "@frockbot/plugin-shell": "0.3.21",
-    "@frockbot/protocol": "0.3.21",
+    "@frockbot/client-core": "0.3.23",
+    "@frockbot/client-ui": "0.3.23",
+    "@frockbot/kernel-contracts": "0.3.23",
+    "@frockbot/plugin-flock": "0.3.23",
+    "@frockbot/plugin-shell": "0.3.23",
+    "@frockbot/protocol": "0.3.23",
     "cordis": "4.0.0-rc.8",
     "vue": "3.5.41"
   },

package/src/client/index.test.ts

@@ -5,6 +5,7 @@ import {
   type ClientSurfaceRegistry,
 } from "@frockbot/client-core";
 import { computed, ref } from "vue";
+import { frockBotWebDataKey } from "@frockbot/plugin-shell/shared";
 import { voiceClientPlugin } from "./index.js";
 import { voiceClientStateKey, type VoiceClientStateV1 } from "./state.js";
 
@@ -26,9 +27,22 @@ function surfaceRegistry(): ClientSurfaceRegistry {
 
 function mount(
   hostedRequest: NonNullable<ClientPluginContext["transport"]["hostedRequest"]>,
-): { calls: string[]; state: { value: VoiceClientStateV1 } } {
+): {
+  calls: string[];
+  state: { value: VoiceClientStateV1 };
+  reloadHolds: () => number;
+} {
   const calls: string[] = [];
   const surfaces = surfaceRegistry();
+  const web = ref({
+    reloadHolds: 0,
+    holdReload: () => {
+      web.value.reloadHolds += 1;
+      return () => {
+        web.value.reloadHolds -= 1;
+      };
+    },
+  });
   let state: unknown;
   const context: ClientPluginContext = {
     transport: {
@@ -40,6 +54,7 @@ function mount(
     },
     inject: (key) => {
       if (key === clientSurfaceRegistryKey) return surfaces as never;
+      if (key === frockBotWebDataKey) return web as never;
       throw new Error("unexpected client provider");
     },
     provide: (key, value) => {
@@ -52,10 +67,23 @@ function mount(
   return {
     calls,
     state: state as { value: VoiceClientStateV1 },
+    reloadHolds: () => web.value.reloadHolds,
   };
 }
 
 describe("Voice client contribution", () => {
+  test("holds the shell's reload while a session is live", () => {
+    const mounted = mount(() => Promise.reject(new Error("unauthenticated")));
+
+    expect(mounted.reloadHolds()).toBe(0);
+    mounted.state.value.status = "listening";
+    expect(mounted.reloadHolds()).toBe(1);
+    mounted.state.value.status = "speaking";
+    expect(mounted.reloadHolds()).toBe(1);
+    mounted.state.value.status = "offline";
+    expect(mounted.reloadHolds()).toBe(0);
+  });
+
   test("does not read User voice state before authenticated chrome mounts", () => {
     const mounted = mount(() => Promise.reject(new Error("unauthenticated")));
 

package/src/client/index.ts

@@ -11,8 +11,9 @@ import {
   type VoiceMicrophoneV1,
 } from "@frockbot/plugin-shell/client/voice-microphone";
 import { showClientNotificationV1 } from "@frockbot/plugin-shell/client/notify";
+import { frockBotWebDataKey } from "@frockbot/plugin-shell/shared";
 import { VOICE_ASSISTANT_INPUT_SAMPLE_RATE_V1 } from "@frockbot/protocol";
-import { ref } from "vue";
+import { ref, watch } from "vue";
 import {
   decodeVoiceAssistantViewV1,
   VOICE_MAX_TOOL_CALLS_V1,
@@ -299,6 +300,28 @@ export const voiceClientPlugin: ClientPlugin = (ctx) => {
     if (state.value.status === "offline") void refresh();
   }, VOICE_PENDING_POLL_INTERVAL_MS_V1);
 
+  /*
+   * A live session is work a reload would throw away, and the Voice surface
+   * is a panel rather than an overlay, so the shell cannot see it any other
+   * way. Holding is how a Package says "not right now" without the shell
+   * knowing anything about Voice.
+   */
+  const web = ctx.inject(frockBotWebDataKey);
+  let releaseHold: (() => void) | undefined;
+  const stopHold = watch(
+    () => state.value.status !== "offline",
+    (live) => {
+      if (live && !releaseHold) releaseHold = web.value.holdReload();
+      else if (!live && releaseHold) {
+        releaseHold();
+        releaseHold = undefined;
+      }
+    },
+    // Synchronous: the hold has to be up before anything can act on the
+    // status change, or a reload could land in the gap.
+    { immediate: true, flush: "sync" },
+  );
+
   return [
     ctx.provide(voiceClientStateKey, state),
     surfaces.register({
@@ -313,6 +336,9 @@ export const voiceClientPlugin: ClientPlugin = (ctx) => {
       component: VoiceToggle,
     }),
     () => {
+      stopHold();
+      releaseHold?.();
+      releaseHold = undefined;
       clearInterval(pendingPoll);
       attempt += 1;
       session?.close();