@frockbot/plugin-shell 0.3.21 → 0.3.22

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@frockbot/plugin-shell",
-  "version": "0.3.21",
+  "version": "0.3.22",
   "private": false,
   "type": "module",
   "exports": {
@@ -52,42 +52,42 @@
   },
   "dependencies": {
     "@cordisjs/plugin-webui": "0.8.2",
-    "@frockbot/agent-runtime": "0.3.21",
-    "@frockbot/application-foundation": "0.3.21",
-    "@frockbot/catalog-core": "0.3.21",
-    "@frockbot/client-core": "0.3.21",
-    "@frockbot/client-ui": "0.3.21",
-    "@frockbot/computer-core": "0.3.21",
-    "@frockbot/computer-host-protocol": "0.3.21",
-    "@frockbot/configuration-core": "0.3.21",
-    "@frockbot/connection-core": "0.3.21",
-    "@frockbot/kernel-agent-loop": "0.3.21",
-    "@frockbot/kernel-composition": "0.3.21",
-    "@frockbot/kernel-contracts": "0.3.21",
-    "@frockbot/kernel-do": "0.3.21",
-    "@frockbot/machine-protocol": "0.3.21",
-    "@frockbot/plugin-applets": "0.3.21",
-    "@frockbot/plugin-authoring": "0.3.21",
-    "@frockbot/plugin-bot-template": "0.3.21",
-    "@frockbot/plugin-computer": "0.3.21",
-    "@frockbot/plugin-flock": "0.3.21",
-    "@frockbot/plugin-image": "0.3.21",
-    "@frockbot/plugin-machine-messages": "0.3.21",
-    "@frockbot/plugin-mcp": "0.3.21",
-    "@frockbot/plugin-memory": "0.3.21",
-    "@frockbot/plugin-package-catalog": "0.3.21",
-    "@frockbot/plugin-routines": "0.3.21",
-    "@frockbot/plugin-skills": "0.3.21",
-    "@frockbot/plugin-subagents": "0.3.21",
-    "@frockbot/plugin-user-machine": "0.3.21",
-    "@frockbot/protocol": "0.3.21",
+    "@frockbot/agent-runtime": "0.3.22",
+    "@frockbot/application-foundation": "0.3.22",
+    "@frockbot/catalog-core": "0.3.22",
+    "@frockbot/client-core": "0.3.22",
+    "@frockbot/client-ui": "0.3.22",
+    "@frockbot/computer-core": "0.3.22",
+    "@frockbot/computer-host-protocol": "0.3.22",
+    "@frockbot/configuration-core": "0.3.22",
+    "@frockbot/connection-core": "0.3.22",
+    "@frockbot/kernel-agent-loop": "0.3.22",
+    "@frockbot/kernel-composition": "0.3.22",
+    "@frockbot/kernel-contracts": "0.3.22",
+    "@frockbot/kernel-do": "0.3.22",
+    "@frockbot/machine-protocol": "0.3.22",
+    "@frockbot/plugin-applets": "0.3.22",
+    "@frockbot/plugin-authoring": "0.3.22",
+    "@frockbot/plugin-bot-template": "0.3.22",
+    "@frockbot/plugin-computer": "0.3.22",
+    "@frockbot/plugin-flock": "0.3.22",
+    "@frockbot/plugin-image": "0.3.22",
+    "@frockbot/plugin-machine-messages": "0.3.22",
+    "@frockbot/plugin-mcp": "0.3.22",
+    "@frockbot/plugin-memory": "0.3.22",
+    "@frockbot/plugin-package-catalog": "0.3.22",
+    "@frockbot/plugin-routines": "0.3.22",
+    "@frockbot/plugin-skills": "0.3.22",
+    "@frockbot/plugin-subagents": "0.3.22",
+    "@frockbot/plugin-user-machine": "0.3.22",
+    "@frockbot/protocol": "0.3.22",
     "cordis": "4.0.0-rc.8",
     "vue": "3.5.41"
   },
   "devDependencies": {
     "@cloudflare/workers-types": "latest",
-    "@frockbot/plugin-prompt": "0.3.21",
-    "@frockbot/plugin-tools": "0.3.21",
+    "@frockbot/plugin-prompt": "0.3.22",
+    "@frockbot/plugin-tools": "0.3.22",
     "@types/bun": "1.3.6",
     "@types/node": "26.2.0",
     "@vitejs/plugin-vue": "6.0.8",

package/src/backend-applets.test.ts

@@ -8,6 +8,7 @@ import {
   resolveAppletCompositionV1,
   APPLET_DIRECTORY_REVISION_SEEN_KEY,
   type AppletInstanceBindingV1,
+  type AppletSourceSyncOutcomeV1,
   type AppletUserDirectoryV1,
 } from "./backend-applets.js";
 import {
@@ -344,6 +345,7 @@ describe("ctx.applets", () => {
     directory?: Partial<AppletUserDirectoryV1>;
     instance?: Partial<AppletInstanceBindingV1>;
     storage?: ReturnType<typeof memoryStorage>;
+    synced?: AppletSourceSyncOutcomeV1;
   }) {
     const storage = options.storage ?? memoryStorage();
     const recorded: unknown[] = [];
@@ -455,6 +457,9 @@ describe("ctx.applets", () => {
           stat: () =>
             Promise.resolve({ status: "not-found", reason: "" }) as never,
         },
+        ...(options.synced
+          ? { syncSourceRootNow: () => Promise.resolve(options.synced!) }
+          : {}),
         composition: {
           current: () => bootstrap(),
           lastKnownGood: () => bootstrap(),
@@ -488,6 +493,39 @@ describe("ctx.applets", () => {
     );
   });
 
+  // Production, 2026-09-04: a 470 KB `dist/ui.html` the Bot had just built was
+  // reported as `not-found: run \`applet build\` … first`, and the Bot ran the
+  // build again, three times. The build was fine; the sync could not carry the
+  // file. The publish says which of the two it was now.
+  test("publish says a built file did not reach the Workspace rather than blaming the build", async () => {
+    const { host: capability } = host({
+      files: {},
+      synced: {
+        status: "degraded",
+        detail:
+          '1 sync operation failed at "dist/ui.html": unavailable: the Computer could not answer.',
+      },
+    });
+    const outcome = await capability.publish({ appletId: APPLET }, scope);
+    expect(outcome.status).toBe("failed");
+    const reason = outcome.status === "failed" ? outcome.reason : "";
+    expect(reason).toBe(
+      '"dist/server.js" is on the Computer but did not reach the Workspace: 1 sync operation failed at "dist/ui.html": unavailable: the Computer could not answer.',
+    );
+    expect(reason).not.toMatch(/applet build/);
+  });
+
+  test("publish still blames the build when the pull of the source root was clean", async () => {
+    const { host: capability } = host({
+      files: {},
+      synced: { status: "ok", detail: "" },
+    });
+    const outcome = await capability.publish({ appletId: APPLET }, scope);
+    expect(outcome.status === "failed" && outcome.reason).toMatch(
+      /applet build/,
+    );
+  });
+
   test("publish refuses a manifest whose hashes do not match the bytes", async () => {
     const { host: capability } = host({
       files: {

package/src/backend-applets.ts

@@ -58,6 +58,20 @@ export const APPLET_PUBLISH_EFFECT_PREFIX = "applets:publish-effect:";
  */
 export const APPLET_DIRECTORY_REVISION_SEEN_KEY = "applets:directory-revision";
 
+/**
+ * How the pre-publish pull of the Applet's source root went.
+ *
+ * `ok` and `skipped` mean the store now holds what the Computer holds. Anything
+ * else means the two may differ, and a `dist/` file the publish cannot find is
+ * then far more likely to be one the sync could not carry than one `applet
+ * build` never wrote.
+ */
+export interface AppletSourceSyncOutcomeV1 {
+  status: "ok" | "degraded" | "unavailable" | "refused" | "skipped";
+  /** What the sync said went wrong, empty when it had nothing to say. */
+  detail: string;
+}
+
 /** The three files `applet build` writes, read from the durable root. */
 export const APPLET_DIST_FILES_V1 = [
   "dist/server.js",
@@ -293,8 +307,12 @@ export interface AppletCapabilityHostOptionsV1 {
    * store is read as it stands — correct but possibly stale — and the Bot is
    * told so in the failure when the files are missing, rather than the publish
    * silently using old bytes.
+   *
+   * What it answers is how that pull went. A build that is on the Computer but
+   * did not reach the store is a different failure from a build that was never
+   * run, and the publish can only say which when it is told.
    */
-  syncSourceRootNow?(appletId: string): Promise<void>;
+  syncSourceRootNow?(appletId: string): Promise<AppletSourceSyncOutcomeV1>;
   composition: Pick<CompositionStore, "current" | "lastKnownGood" | "propose">;
   now?(): Date;
 }
@@ -594,11 +612,20 @@ export function createAppletCapabilityHostV1(
     appletId: string,
     file: string,
     maximum: number,
+    synced?: AppletSourceSyncOutcomeV1,
   ): Promise<{ text: string } | { failure: string }> {
     const outcome = await options.workspace.read(
       appletDistPathV1(options.userId, appletId, file),
     );
     if (outcome.status !== "ok") {
+      // A pull that did not finish is the likelier explanation than an
+      // unbuilt Applet, and telling the Bot to build again would send it
+      // round a loop that cannot end.
+      if (synced && synced.status !== "ok" && synced.status !== "skipped") {
+        return {
+          failure: `"${file}" is on the Computer but did not reach the Workspace: ${synced.detail || "the sync could not carry it"}`,
+        };
+      }
       return {
         failure: `"${file}" is ${outcome.status}: run \`applet build\` in applets/${appletId} on the Computer first`,
       };
@@ -731,12 +758,13 @@ export function createAppletCapabilityHostV1(
 
       // Force a pull of the source root so the publish sees what the Bot just
       // built, not the last synced copy. See the seam note on the option.
-      await options.syncSourceRootNow?.(input.appletId);
+      const synced = await options.syncSourceRootNow?.(input.appletId);
 
       const server = await readFile(
         input.appletId,
         "dist/server.js",
         APPLET_MAX_SERVER_BYTES_V1,
+        synced,
       );
       if ("failure" in server) {
         return settle(failed(input.appletId, "unbuilt", server.failure));
@@ -745,6 +773,7 @@ export function createAppletCapabilityHostV1(
         input.appletId,
         "dist/ui.html",
         APPLET_MAX_UI_BYTES_V1,
+        synced,
       );
       if ("failure" in ui) {
         return settle(failed(input.appletId, "unbuilt", ui.failure));
@@ -753,6 +782,7 @@ export function createAppletCapabilityHostV1(
         input.appletId,
         "dist/manifest.json",
         APPLET_MAX_MANIFEST_BYTES_V1,
+        synced,
       );
       if ("failure" in manifestFile) {
         return settle(failed(input.appletId, "unbuilt", manifestFile.failure));

package/src/backend.ts

@@ -2492,7 +2492,9 @@ export class ShellBotBackendContribution {
               sessions: typeof active.mounted.runtime.root.sessions;
             };
             const computerIdentity = { userId: identity.userId };
-            if (!root.computers?.assignment(computerIdentity)) return;
+            if (!root.computers?.assignment(computerIdentity)) {
+              return { status: "skipped", detail: "" } as const;
+            }
             const session = root.sessions.get(active.sessionId);
             const started = session?.events.findLast(
               (event) => event.type === "step/start",
@@ -2503,7 +2505,7 @@ export class ShellBotBackendContribution {
               { botId: identity.botId },
               { signal: active.signal },
             );
-            await syncWorkspaceRootNowV1({
+            const summary = await syncWorkspaceRootNowV1({
               computer,
               sessions: root.sessions,
               sessionId: active.sessionId,
@@ -2514,6 +2516,7 @@ export class ShellBotBackendContribution {
               ),
               signal: active.signal,
             });
+            return { status: summary.status, detail: summary.detail };
           }
         : undefined,
       composition: {