@frockbot/plugin-package-publisher 0.3.8 → 0.3.10

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@frockbot/plugin-package-publisher",
-  "version": "0.3.8",
+  "version": "0.3.10",
   "private": false,
   "type": "module",
   "exports": {
@@ -23,18 +23,18 @@
     "typecheck": "vue-tsc --noEmit -p tsconfig.json"
   },
   "dependencies": {
-    "@frockbot/kernel-contracts": "0.3.8",
-    "@frockbot/plugin-prompt": "0.3.8",
-    "@frockbot/plugin-tools": "0.3.8",
-    "@frockbot/client-core": "0.3.8",
-    "@frockbot/client-ui": "0.3.8",
-    "@frockbot/plugin-shell": "0.3.8",
+    "@frockbot/kernel-contracts": "0.3.10",
+    "@frockbot/plugin-prompt": "0.3.10",
+    "@frockbot/plugin-tools": "0.3.10",
+    "@frockbot/client-core": "0.3.10",
+    "@frockbot/client-ui": "0.3.10",
+    "@frockbot/plugin-shell": "0.3.10",
     "cordis": "4.0.0-rc.8",
     "vue": "3.5.41"
   },
   "devDependencies": {
-    "@frockbot/computer-core": "0.3.8",
-    "@frockbot/plugin-testkit": "0.3.8",
+    "@frockbot/computer-core": "0.3.10",
+    "@frockbot/plugin-testkit": "0.3.10",
     "@types/bun": "1.4.0",
     "@vitejs/plugin-vue": "6.0.8",
     "typescript": "5.9.3",

package/src/agent.test.ts

@@ -156,6 +156,78 @@ describe("Package Publisher Agent contribution", () => {
     await harness.dispose();
   });
 
+  // A deployment with no Computer registers no Computer tool, so a prompt that
+  // still promises one sends the model hunting for a sandbox it cannot reach.
+  test("promises no Computer when the deployment has none", async () => {
+    const harness = await createPluginHarness([
+      ComputerRegistry,
+      SystemPromptRegistry,
+      ToolRegistry,
+    ]);
+    const fiber = await harness.mount(
+      createPackagePublisherAgentPlugin(
+        {
+          read: () => Promise.resolve(history),
+          publish: () => {
+            throw new Error("not called");
+          },
+          rollback: () => {
+            throw new Error("not called");
+          },
+        },
+        {
+          userId: "user-1",
+          defaultProviderId: "fixture",
+          configured: false,
+        },
+      ),
+    );
+    const prompt = await harness.root.systemPrompt.assemble({
+      sessionId: "session-1",
+      provider: "fixture",
+      model: "fixture",
+      turnType: "chat",
+    });
+    expect(prompt.text).not.toContain("Computer");
+    expect(prompt.text).not.toContain("/home/box");
+    // The Package Publisher still says what it does; only the Computer
+    // sentence goes.
+    expect(prompt.text).toContain("publish_setup");
+    await fiber.dispose();
+    await harness.dispose();
+  });
+
+  test("keeps the Computer sentence when a Computer is configured", async () => {
+    const harness = await createPluginHarness([
+      ComputerRegistry,
+      SystemPromptRegistry,
+      ToolRegistry,
+    ]);
+    const fiber = await harness.mount(
+      createPackagePublisherAgentPlugin(
+        {
+          read: () => Promise.resolve(history),
+          publish: () => {
+            throw new Error("not called");
+          },
+          rollback: () => {
+            throw new Error("not called");
+          },
+        },
+        { userId: "user-1", defaultProviderId: "fixture" },
+      ),
+    );
+    const prompt = await harness.root.systemPrompt.assemble({
+      sessionId: "session-1",
+      provider: "fixture",
+      model: "fixture",
+      turnType: "chat",
+    });
+    expect(prompt.text).toContain("/home/box/setup using the Computer");
+    await fiber.dispose();
+    await harness.dispose();
+  });
+
   test("satisfies built-in Package conventions", () => {
     expect(verifyPluginPackage({ packageJson, manifest })).toMatchObject({
       name: "@frockbot/plugin-package-publisher",

package/src/agent.ts

@@ -27,6 +27,17 @@ export interface PackagePublisherAgentHost {
 export interface PackagePublisherAgentConfig {
   userId: string;
   defaultProviderId: string;
+  /**
+   * Whether this deployment has a Computer at all.
+   *
+   * The Package Publisher's workspace lives on the Computer, so on a host with
+   * no Computer there is nothing true to say about editing a setup there. A
+   * prompt that promises a Computer the host does not have sends the model
+   * hunting for one and inventing a sandbox. `undefined` keeps the sentence,
+   * so a host that does not know either way behaves as before — the same
+   * convention `plugin-computer`'s `configured` uses.
+   */
+  configured?: boolean;
 }
 
 async function executeText(
@@ -96,6 +107,7 @@ export function createPackagePublisherAgentPlugin(
   if (!defaultProviderId) {
     throw new Error("Package Publisher provider id must be non-empty");
   }
+  const computerConfigured = config.configured !== false;
   const plugin: Plugin.Function = (ctx) => {
     const list: ToolDefinition = {
       name: "list_setup_revisions",
@@ -257,7 +269,11 @@ export function createPackagePublisherAgentPlugin(
         render: () =>
           [
             "## Editable setup",
-            `Edit and test the User's shared setup in ${SETUP_DIRECTORY} using the Computer.`,
+            ...(computerConfigured
+              ? [
+                  `Edit and test the User's shared setup in ${SETUP_DIRECTORY} using the Computer.`,
+                ]
+              : []),
             `Publishing archives the current Git HEAD and reads ${SETUP_APPLICATION_FILE} from that fixed folder; file editing itself is not owned by the Package Publisher.`,
             "Commit the intended source, run the setup's required checks, and call publish_setup only after they pass.",
           ].join("\n"),