@frockbot/plugin-memory 0.3.8 → 0.3.9

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@frockbot/plugin-memory",
-  "version": "0.3.8",
+  "version": "0.3.9",
   "private": false,
   "type": "module",
   "exports": {
@@ -22,10 +22,10 @@
     "typecheck": "tsc --noEmit -p tsconfig.json"
   },
   "dependencies": {
-    "@frockbot/kernel-agent-loop": "0.3.8",
-    "@frockbot/kernel-contracts": "0.3.8",
-    "@frockbot/secret-shapes": "0.3.8",
-    "@frockbot/workspace-store": "0.3.8",
+    "@frockbot/kernel-agent-loop": "0.3.9",
+    "@frockbot/kernel-contracts": "0.3.9",
+    "@frockbot/secret-shapes": "0.3.9",
+    "@frockbot/workspace-store": "0.3.9",
     "cordis": "4.0.0-rc.8"
   },
   "devDependencies": {

package/src/facts.ts

@@ -65,8 +65,11 @@ export interface MemoryFactV1 {
 export interface SourcedMemoryFactV1 extends MemoryFactV1 {
   /** The Bot whose shard holds it. */
   botId: string;
-  /** The display name of that Bot, or its id when no name is known. */
-  via: string;
+  /**
+   * The display name of that Bot, absent when no name is known. Never its id:
+   * a rendered id is a handle the model reads as a name and says out loud.
+   */
+  via?: string;
   /** `profile.md` or a monthly log. */
   kind: "profile" | "log";
   /** The generation the line was read from; ordering's tiebreak. */

package/src/render.ts

@@ -225,7 +225,9 @@ function injected(
     // prefix inside the text. The marker on the recorded text is what the
     // tier was; the file it sits in is not.
     tier: parseMemoryMarkerV1(fact.text).marker === "note" ? "note" : tier,
-    via: withVia ? fact.via : "",
+    // `via` is a name or nothing: a Bot with no name known to this store is
+    // uncredited rather than credited by its id.
+    via: withVia ? (fact.via ?? "") : "",
     learnedAt: fact.date,
     text: fact.text,
   }));

package/src/store.test.ts

@@ -5,6 +5,7 @@ import type {
   WorkspaceFilesV1,
   WorkspaceWriterV1,
 } from "@frockbot/kernel-contracts";
+import { renderInjectedFactLineV1 } from "./facts.ts";
 import {
   botMemoryRootV1,
   projectMemoryRootV1,
@@ -128,6 +129,33 @@ describe("the Memory writer", () => {
     ]);
   });
 
+  // A Bot id is a handle, not a name. Rendered as `[via remy-9d15e086]` the
+  // model reads it as a name and tells the User a sibling's id.
+  test("credits nobody rather than a Bot id when no name is known", async () => {
+    const files = createTestMemoryFilesV1({ userId: "user-1" });
+    const nameless = new MemoryStore({
+      files,
+      owner: { userId: "user-1", botId: "bot-9" },
+      clock: () => AT,
+    });
+    const root = userMemoryRootV1(OWNER);
+    await nameless.write({
+      root,
+      tier: "profile",
+      fact: "Tim stops drinking coffee at 2pm.",
+      writer: writerFor("bot-9"),
+    });
+
+    const tier = await nameless.read(root);
+
+    expect(tier.profile).toHaveLength(1);
+    expect(tier.profile[0]?.via).toBeUndefined();
+    expect(tier.profile[0]?.botId).toBe("bot-9");
+    expect(renderInjectedFactLineV1(tier.profile[0]!, 200)).not.toContain(
+      "bot-9",
+    );
+  });
+
   test("dedupes a fact that is already recorded, without writing", async () => {
     const { store } = storeFor("bot-1");
     const root = botMemoryRootV1(OWNER);

package/src/store.ts

@@ -202,8 +202,16 @@ export class MemoryStore {
     return this.#files;
   }
 
-  private via(botId: string): string {
-    return this.#names[botId] ?? botId;
+  /**
+   * The name to credit a shared fact to, or nothing.
+   *
+   * A Bot id is an internal handle, not a name: rendered into the prompt as
+   * `[via remy-9d15e086]` the model reads it as something to say out loud and
+   * tells the User a sibling's id. With no name to give, the fact is simply
+   * uncredited — the fact itself is what the User asked for.
+   */
+  private via(botId: string): string | undefined {
+    return this.#names[botId];
   }
 
   /**