@frockbot/plugin-audit 0.3.6 → 0.3.8

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@frockbot/plugin-audit",
-  "version": "0.3.6",
+  "version": "0.3.8",
   "private": false,
   "type": "module",
   "exports": {
@@ -25,11 +25,11 @@
     "typecheck": "vue-tsc --noEmit -p tsconfig.json"
   },
   "dependencies": {
-    "@frockbot/client-core": "0.3.6",
-    "@frockbot/client-ui": "0.3.6",
-    "@frockbot/kernel-contracts": "0.3.6",
-    "@frockbot/plugin-shell": "0.3.6",
-    "@frockbot/secret-shapes": "0.3.6",
+    "@frockbot/client-core": "0.3.8",
+    "@frockbot/client-ui": "0.3.8",
+    "@frockbot/kernel-contracts": "0.3.8",
+    "@frockbot/plugin-shell": "0.3.8",
+    "@frockbot/secret-shapes": "0.3.8",
     "cordis": "4.0.0-rc.8",
     "vue": "3.5.41"
   },

package/src/classify.test.ts

@@ -27,9 +27,11 @@ describe("the classifier table", () => {
       "computer",
     ],
     ["computer_process_poll", { processId: "p1" }, "process", "computer"],
-    ["memory_write", { text: "a fact" }, "file", "computer"],
-    ["skill_write", { path: "a.md" }, "file", "computer"],
-    ["package_author", { packageId: "x" }, "file", "computer"],
+    // Memory and Skills are the Workspace, not the Computer: they are
+    // written while it is hibernated and by Bots that have none.
+    ["memory_write", { text: "a fact" }, "file", "workspace"],
+    ["skill_write", { path: "a.md" }, "file", "workspace"],
+    ["package_author", { packageId: "x" }, "file", "workspace"],
     ["mcp__example__echo", { message: "hi" }, "mcp", "remote:example"],
     ["mcp__beeper__send_message", {}, "mcp", "remote:beeper"],
     // Read-only and product tools perform no audited effect at all. An audit
@@ -139,7 +141,8 @@ describe("the classifier table", () => {
         toolName: "package_author",
         input: { packageId: "acme" },
       }),
-    ).toEqual({ kind: "file", target: "computer" });
+      // `package_author` writes the Workspace, not the Computer.
+    ).toEqual({ kind: "file", target: "workspace" });
     // A wrapper that names nothing resolvable stays the wrapper, and the
     // wrapper is not an audited effect.
     expect(auditKindForToolV1("call_dynamic_tool", {})).toBeUndefined();

package/src/classify.ts

@@ -19,6 +19,7 @@ import {
   AUDIT_TARGET_COMPUTER_V1,
   AUDIT_TARGET_MACHINE_PREFIX_V1,
   AUDIT_TARGET_REMOTE_PREFIX_V1,
+  AUDIT_TARGET_WORKSPACE_V1,
   type AuditKindV1,
 } from "./shared.js";
 
@@ -41,10 +42,6 @@ export interface AuditClassificationV1 {
  * costs one table row and no new authority.
  */
 const FILE_TOOLS = new Set([
-  "memory_write",
-  "memory_forget",
-  "skill_write",
-  "package_author",
   // The registered machine's file verbs (register rows 48, 49). They are file
   // effects on "a separate filesystem" — the User's own laptop — which is why
   // their target is `machine:<id>` and never `computer`.
@@ -53,6 +50,21 @@ const FILE_TOOLS = new Set([
   "machine_copy_from_computer",
 ]);
 
+/**
+ * File effects that land in the User's Workspace, not on the Computer.
+ *
+ * Memory and Skills are object storage: they are written while the Computer is
+ * hibernated, and by Bots whose User has no Computer configured at all. Their
+ * rows said "This Computer", which named the wrong place and, in the case we
+ * saw, a place that did not exist.
+ */
+const WORKSPACE_FILE_TOOLS = new Set([
+  "memory_write",
+  "memory_forget",
+  "skill_write",
+  "package_author",
+]);
+
 /**
  * The registered machine's shell verb.
  *
@@ -192,6 +204,9 @@ export function auditKindForToolV1(
   if (name.startsWith(MACHINE_MESSAGES_PREFIX)) {
     return { kind: "mcp", target: onComputer };
   }
+  if (WORKSPACE_FILE_TOOLS.has(name)) {
+    return { kind: "file", target: AUDIT_TARGET_WORKSPACE_V1 };
+  }
   if (FILE_TOOLS.has(name)) return { kind: "file", target: onComputer };
   const mcp = MCP_TOOL.exec(name);
   if (mcp) {

package/src/client/AuditSection.vue

@@ -56,6 +56,8 @@ function selectKind(kind: AuditKindV1 | undefined): void {
 /** Where the effect ran, in words rather than in the wire shape. */
 function target(entry: AuditEntryV1): string {
   if (entry.target === "computer") return "This Computer";
+  // Memory and Skills are files in the Workspace, not on the Computer.
+  if (entry.target === "workspace") return "Workspace";
   if (entry.target.startsWith("machine:")) {
     return `Machine ${entry.target.slice("machine:".length)}`;
   }

package/src/shared.ts

@@ -88,6 +88,16 @@ export const AUDIT_OUTCOMES_V1: readonly AuditOutcomeV1[] = [
 
 /** The Bot's own Computer — the default target for every Computer effect. */
 export const AUDIT_TARGET_COMPUTER_V1 = "computer";
+/**
+ * The User's Workspace in object storage.
+ *
+ * Memory and Skills live here, not on the Computer, and they are written
+ * while it is hibernated — a Bot with no Computer configured at all still
+ * writes Memory. Rows for those writes said "This Computer", which named a
+ * machine that had nothing to do with the effect and, in the case we saw, did
+ * not exist.
+ */
+export const AUDIT_TARGET_WORKSPACE_V1 = "workspace";
 /** A registered machine of the User's, `machine:<id>` (parity register §2.16). */
 export const AUDIT_TARGET_MACHINE_PREFIX_V1 = "machine:";
 /** A remote MCP server, `remote:<host>`. */
@@ -269,6 +279,7 @@ export function decodeAuditOccurrenceIdV1(value: unknown): {
 /** Whether a string is one of the three target shapes this schema allows. */
 export function isAuditTargetV1(value: string): boolean {
   if (value === AUDIT_TARGET_COMPUTER_V1) return true;
+  if (value === AUDIT_TARGET_WORKSPACE_V1) return true;
   if (value.length > MAX_TARGET_LENGTH) return false;
   if (value.startsWith(AUDIT_TARGET_MACHINE_PREFIX_V1)) {
     return /^machine:[A-Za-z0-9][A-Za-z0-9._-]{0,127}$/.test(value);