@fro.bot/systematic 3.24.2 → 3.25.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/HARNESSES.md +18 -11
- package/dist/cli.js +305 -186
- package/dist/{index-vkmdceqk.js → index-bmsgc2em.js} +9 -10
- package/dist/index.js +1 -1
- package/dist/lib/config.d.ts +23 -7
- package/dist/lib/pi-subagents-export.d.ts +40 -7
- package/dist/lib/pi-subagents-personas.d.ts +9 -0
- package/dist/pi-subagents/agents/systematic-adversarial-document-reviewer.md +87 -0
- package/dist/pi-subagents/agents/systematic-adversarial-reviewer.md +102 -0
- package/dist/pi-subagents/agents/systematic-api-contract-reviewer.md +43 -0
- package/dist/pi-subagents/agents/systematic-architecture-strategist.md +50 -0
- package/dist/pi-subagents/agents/systematic-best-practices-researcher.md +112 -0
- package/dist/pi-subagents/agents/systematic-bug-reproduction-validator.md +88 -0
- package/dist/pi-subagents/agents/systematic-cli-readiness-reviewer.md +65 -0
- package/dist/pi-subagents/agents/systematic-code-simplicity-reviewer.md +84 -0
- package/dist/pi-subagents/agents/systematic-coherence-reviewer.md +37 -0
- package/dist/pi-subagents/agents/systematic-correctness-reviewer.md +43 -0
- package/dist/pi-subagents/agents/systematic-data-migrations-reviewer.md +47 -0
- package/dist/pi-subagents/agents/systematic-deployment-verification-agent.md +157 -0
- package/dist/pi-subagents/agents/systematic-design-lens-reviewer.md +44 -0
- package/dist/pi-subagents/agents/systematic-feasibility-reviewer.md +40 -0
- package/dist/pi-subagents/agents/systematic-framework-docs-researcher.md +91 -0
- package/dist/pi-subagents/agents/systematic-git-history-analyzer.md +44 -0
- package/dist/pi-subagents/agents/systematic-issue-intelligence-analyst.md +207 -0
- package/dist/pi-subagents/agents/systematic-maintainability-reviewer.md +43 -0
- package/dist/pi-subagents/agents/systematic-pattern-recognition-specialist.md +55 -0
- package/dist/pi-subagents/agents/systematic-performance-reviewer.md +45 -0
- package/dist/pi-subagents/agents/systematic-previous-comments-reviewer.md +59 -0
- package/dist/pi-subagents/agents/systematic-product-lens-reviewer.md +68 -0
- package/dist/pi-subagents/agents/systematic-reliability-reviewer.md +43 -0
- package/dist/pi-subagents/agents/systematic-repo-research-analyst.md +322 -0
- package/dist/pi-subagents/agents/systematic-scope-guardian-reviewer.md +52 -0
- package/dist/pi-subagents/agents/systematic-security-lens-reviewer.md +36 -0
- package/dist/pi-subagents/agents/systematic-security-reviewer.md +45 -0
- package/dist/pi-subagents/agents/systematic-spec-flow-analyzer.md +82 -0
- package/dist/pi-subagents/agents/systematic-testing-reviewer.md +43 -0
- package/dist/pi.js +186 -12
- package/package.json +13 -5
- package/skills/using-systematic/references/pi-profile.md +12 -8
package/HARNESSES.md
CHANGED
|
@@ -10,7 +10,7 @@ The four capability rows use the vocabulary in the [OpenCode profile](skills/usi
|
|
|
10
10
|
|
|
11
11
|
| Capability | OpenCode (Tier 1) | Pi (Tier 1) | Claude Code (Tier 1) | Codex CLI (Tier 2) | Gemini CLI (Tier 2) | GitHub Copilot (Tier 2) |
|
|
12
12
|
|---|---|---|---|---|---|---|
|
|
13
|
-
| Subagent delegation | `task`, including `subagent_type`, resume, and background execution [OC-1] | Bounded built-in delegate: `systematic_delegate({agent, task})`; sequential, capped at 20 turns, depth-1, `noExtensions` [PI-1]. Optional mature delegation via pi-subagents (opt-in export; outside Systematic's bounded-delegate guarantees) [PI-7] | Name-based subagent dispatch (invoke a subagent by name in the prompt text); `context: fork` for skill-scoped forks; plugin agents ship in `agents/` [CC-1][CC-9] | **UNVERIFIED** [U] | **UNVERIFIED** [U] | Built-in/custom agents [GH-1][GH-2] |
|
|
13
|
+
| Subagent delegation | `task`, including `subagent_type`, resume, and background execution [OC-1] | Bounded built-in delegate: `systematic_delegate({agent, task})`; sequential, capped at 20 turns, depth-1, `noExtensions` [PI-1]. Optional mature delegation via pi-subagents (installed package personas, opt-in export for overlays; outside Systematic's bounded-delegate guarantees) [PI-7] | Name-based subagent dispatch (invoke a subagent by name in the prompt text); `context: fork` for skill-scoped forks; plugin agents ship in `agents/` [CC-1][CC-9] | **UNVERIFIED** [U] | **UNVERIFIED** [U] | Built-in/custom agents [GH-1][GH-2] |
|
|
14
14
|
| Blocking user interaction | `question` [OC-2] | No native blocking tool; numbered-chat fallback [PI-2] | `AskUserQuestion` [CC-2] | `request_user_input`; blocking and root-thread-only [CX-1][CX-2] | `ask_user`; pauses until answers [GE-1][GE-2] | No dedicated tool name verified; plan-mode clarification and `--no-ask-user` are documented [GH-3][GH-4] |
|
|
15
15
|
| Task tracking | `todowrite` [OC-3] | No native mechanism; visible list fallback [PI-2] | `TodoWrite` is deprecated/disabled by default; `TaskCreate`/`TaskGet`/`TaskList`/`TaskUpdate` replace it [CC-3][CC-4] | **UNVERIFIED** [U] | **UNVERIFIED** [U] | No `TodoWrite` equivalent verified; cloud-agent tasks/sessions API is documented [GH-5] |
|
|
16
16
|
| Skill loading | Skills become commands and `systematic_skill` is registered [OC-4][OC-5] | `systematic_skill` adapter and Pi-native activation [PI-3][PI-4] | Native Skill tool with `SKILL.md` discovery (`~/.claude/skills/`, `.claude/skills/`, plugin `skills/`); Systematic ships no `systematic_skill` tool on Claude Code [CC-5][CC-6][CC-9] | **UNVERIFIED** [U] | **UNVERIFIED** [U] | `SKILL.md` skills [GH-6] |
|
|
@@ -26,17 +26,24 @@ Compatibility is direct: OpenCode consumes the concrete invocation language in t
|
|
|
26
26
|
|
|
27
27
|
## Pi — Tier 1 shipped adapter
|
|
28
28
|
|
|
29
|
-
Pi's profile records degraded or unavailable native capabilities and explicit fallbacks [PI-P]. The adapter registers `systematic_skill` in `src/pi.ts:
|
|
29
|
+
Pi's profile records degraded or unavailable native capabilities and explicit fallbacks [PI-P]. The adapter registers `systematic_skill` in `src/pi.ts:187-206` and `systematic_delegate` in `src/pi.ts:207-232` [PI-3]. Delegation is explicitly sequential (`executionMode: 'sequential'`), capped at `MAX_DELEGATE_TURNS = 20`, and guarded against re-entry in `src/lib/pi-delegate-tool.ts:14-18,245-249` [PI-1]. The child is spawned with `noExtensions: true`, bounding `systematic_delegate`'s own recursion; this does not bound end-to-end depth across a combined pi-subagents + Systematic path.
|
|
30
30
|
|
|
31
|
-
Optional mature delegation is available via [pi-subagents](https://github.com/tintinweb/pi-subagents)
|
|
31
|
+
Optional mature delegation is available via [pi-subagents](https://github.com/tintinweb/pi-subagents). It is outside Systematic's bounded-delegate guarantees and governed by pi-subagents' own configuration. Tested against pi-subagents 0.22.0 on Pi 1.3.0; versions outside the tested range are unsupported but nonfatal. pi-subagents reaches Systematic's personas by two paths:
|
|
32
32
|
|
|
33
|
-
|
|
33
|
+
- **Installed package.** The package declares `pi.subagents.agents` at `package.json:24-28`, pointing at `dist/pi-subagents/agents/`. `scripts/build-pi-package-agents.ts` writes that directory at build time from the same render the export uses, so the 29 curated personas it ships are byte-equal to the committed fixtures (`tests/unit/package-exports.test.ts:289-344`) [PI-7]. pi-subagents 0.22 is the first release that reads package-declared agents. It reads them from the packages in Pi's `settings.json` `packages[]`, global and project, and never from `node_modules`, because the only scan is Pi's own configured-package list (`node_modules/@tintinweb/pi-subagents/dist/package-resources.js:327-341`). It sees a project-scope package only after the project is trusted: the trust flag starts `false` (`node_modules/@tintinweb/pi-subagents/dist/package-resources.js:90`), is passed to `SettingsManager.create` when the package list is read (`node_modules/@tintinweb/pi-subagents/dist/package-resources.js:332`), and keys the scan (`node_modules/@tintinweb/pi-subagents/dist/package-resources.js:432`). An installed Systematic therefore exposes `systematic-<name>` types with plain defaults and no export step. `pi -e` does not, because it is not in `packages[]`, and neither does a git install, which has no built `dist/`. `tests/integration/pi.test.ts:1550-1652` pins dispatch from the package at project and global scope, the `packageAgents: false` switch in `subagents.json`, and local precedence [PI-7].
|
|
34
|
+
- **Export.** `systematic pi-subagents <preview|export|refresh|cleanup> --scope project|global` writes flat files that carry `systematic.json` overlays. Package agents load first, so a local file of the same name outranks the packaged one (`node_modules/@tintinweb/pi-subagents/dist/custom-agents.js:36-39,59-64`). No files are written without an explicit command [PI-7].
|
|
34
35
|
|
|
35
|
-
|
|
36
|
+
Packaged personas are config-blind. The only function that sets pi-subagents' agent registry, `registerAgents` (`node_modules/@tintinweb/pi-subagents/dist/agent-types.js:65`), is called only from its own `dist/index.js:361`, so another extension cannot register or filter agent types. Overlays, `disabled_agents` and `agents.<name>.disable` therefore cannot reach a packaged file. `src/pi.ts:143-155` warns once at startup when either is configured. pi-subagents' own `/agents → Disable` turns off one packaged persona, and `packageAgents: false` in `subagents.json` turns off all of them (`node_modules/@tintinweb/pi-subagents/dist/settings.js:133-135`). A top-level `Agent` call runs in the background unless it passes `run_in_background: false` (`node_modules/@tintinweb/pi-subagents/dist/index.js:1187`).
|
|
36
37
|
|
|
37
|
-
|
|
38
|
+
Export writes are governed by a manifest (`.systematic-personas.json`) and an exclusive per-root mutation lock (`.systematic-personas.lock`) held for the duration of `export`/`refresh`/`cleanup`; a pre-existing lock is never auto-deleted — a reported lock requires manual verification that no operation is actually running before removal. The export honors the same disable settings as the rest of Systematic: a persona disabled by `disabled_agents` (bare name or `category/name`) or by an `agents.<name>.disable` overlay is not exported [PI-6].
|
|
38
39
|
|
|
39
|
-
|
|
40
|
+
Systematic's own config (`systematic.json`/`.jsonc`) is the durable source of truth for exported personas; the generated persona files and manifest are a disposable projection. `export` computes and prints its per-file preflight actions (create/update/skip/refuse/remove), a summary and the target directory before any mutation, the same way `preview` does, and lists any files edited since export after them under "Still active in pi-subagents". `refresh` intentionally overwrites current manifest-owned generated files that have drifted from source, and removes manifest-owned files that are unchanged and no longer wanted (a disabled persona, or one dropped from the curated set) — run `preview` first to see what would change. Project-scoped export (default) loads `user → project → custom` config for the current working directory; global-scoped export loads `user → custom` only and never absorbs cwd project overlays. Project-sourced `model` on the `categories`/`agents` overlay is rejected outright by config validation; project-sourced `thinking`, `tools`, and `skills` on the `pi_subagents` overlay are silently stripped before merge; `max_turns` is trust-any. pi-subagents 0.22.0 has no equivalent frontmatter fields for `temperature`, `top_p`, or `variant` (its loader, `node_modules/@tintinweb/pi-subagents/dist/custom-agents.js`, reads none of them) — Systematic never emits them, so an authored `temperature` or `mode` does not carry over to Pi.
|
|
41
|
+
|
|
42
|
+
Every export/refresh/cleanup operation walks every path component from a scope-anchored root down to the target agents directory and fails closed if any intermediate component is a symlink or a non-directory: the project anchor is the current working directory, the default global anchor is the user's home directory, and when `PI_CODING_AGENT_DIR` is set the anchor is that variable's parent directory. Manifest entries must name files matching `systematic-*.md`. `cleanup` deletes a manifest-owned file only when its on-disk content hash still matches the manifest's recorded hash — if a generated file has drifted from what the manifest recorded, `cleanup` refuses before any mutation and leaves both the file and the manifest untouched, and the user reverts the file to its exported content or deletes it by hand before running it again. `export` and `refresh` apply the same hash check to files that are no longer wanted, but a drifted file is left in place and reported as still active, and its previous manifest entry is kept unchanged, so a hand-edit never aborts the run. Manifest content hashes are ownership/drift evidence only — they are not a cryptographic integrity or authenticity guarantee.
|
|
43
|
+
|
|
44
|
+
The package manifest exposes the extension and skills at `package.json:17-23` (and the packaged personas at `package.json:24-28`), with tests verifying both manifest entries and their packaged paths `tests/unit/package-exports.test.ts:64-84,268-288` [PI-4]. Pi's RPC/JSONL test fixture isolates its environment (`tests/integration/pi.test.ts:349-388`), and the installed runtime exposes environment-specific agent/session directories `node_modules/@earendil-works/pi-coding-agent/dist/config.js:396-398` [PI-5].
|
|
45
|
+
|
|
46
|
+
Pi honors Systematic's disable settings. `src/pi.ts` loads the merged config once at extension start and passes `disabled_skills` to the skill resolver, so a disabled skill is absent from the `systematic_skill` description and parameter hint and fails to load as unknown. It filters the `systematic_delegate` catalog with `isAgentDisabled`, so a persona disabled by `disabled_agents` (bare name or `category/name`) or by an `agents.<name>.disable` overlay disappears from the tool's description, hint and lookup. The pi-subagents export applies the same predicate, and `tests/unit/disable-parity.test.ts` pins it to what OpenCode's config handler omits [PI-6]. Settings are read at extension start, so a Pi restart applies a change. Pi's own skill discovery is a separate path: `pi.skills` ships the whole `./skills` directory and Pi's `/skill:name` commands, so those still list and load disabled skills [PI-4], [PI-5]. Pi's skill loading also has no OpenCode-style permission gate — OpenCode's `skill-tool.ts` calls `context.ask({ permission: 'skill', ... })` before returning skill content, but Pi 0.80.6's extension API has no equivalent hook and Systematic's Pi tool implementation does not call one [PI-6]. Those are deliberate honesty boundaries, not implied parity.
|
|
40
47
|
|
|
41
48
|
## Claude Code — Tier 1 shipped adapter
|
|
42
49
|
|
|
@@ -120,11 +127,11 @@ Migrated-skill discipline is enforced by the [content-integrity gate](scripts/co
|
|
|
120
127
|
- **PI-P** — [Pi profile](skills/using-systematic/references/pi-profile.md#L3-L8).
|
|
121
128
|
- **PI-1** — `src/lib/pi-delegate-tool.ts:14-18,245-249,279-291`.
|
|
122
129
|
- **PI-2** — [Pi profile](skills/using-systematic/references/pi-profile.md#L5-L8).
|
|
123
|
-
- **PI-3** — `src/pi.ts:
|
|
124
|
-
- **PI-4** — `package.json:17-23`; `tests/unit/package-exports.test.ts:
|
|
130
|
+
- **PI-3** — `src/pi.ts:187-232`.
|
|
131
|
+
- **PI-4** — `package.json:17-23`; `tests/unit/package-exports.test.ts:64-84,268-288`.
|
|
125
132
|
- **PI-5** — `tests/integration/pi.test.ts:349-388`; installed Pi source `node_modules/@earendil-works/pi-coding-agent/dist/config.js:396-398`.
|
|
126
|
-
- **PI-6** — `src/pi.ts:
|
|
127
|
-
- **PI-7** — `src/lib/pi-subagents-export.ts` (export lifecycle, manifest, rollback); `src/lib/pi-subagents-personas.ts` (curated persona list, compatibility screening); `src/cli.ts:
|
|
133
|
+
- **PI-6** — `src/pi.ts:157-162` (merged `disabled_skills` passed to the skill resolver); `src/pi.ts:208-221` (`systematic_delegate` catalog filtered with `isAgentDisabled`); `src/lib/config.ts:2103-2115` (`isAgentDisabled`); `src/lib/pi-subagents-export.ts:857-893` (`generateEntries` applies it to the export); `tests/unit/disable-parity.test.ts` (parity with OpenCode's config handler); OpenCode's contrasting permission gate at `src/lib/skill-tool.ts:191-196`.
|
|
134
|
+
- **PI-7** — `package.json:24-28` (the `pi.subagents.agents` declaration); `scripts/build-pi-package-agents.ts` (writes `dist/pi-subagents/agents/` at build time); `tests/unit/package-exports.test.ts:76-83,289-344` (manifest key, `pi-package` keyword, packed files byte-equal to the fixtures); `tests/integration/pi.test.ts:1550-1652` (real Pi host: dispatch from the package at project and global scope, the `packageAgents: false` fallback to `general-purpose`, and a local file outranking the packaged one); `node_modules/@tintinweb/pi-subagents/dist/package-resources.js:90,327-341,432` (which packages are read, trust), `node_modules/@tintinweb/pi-subagents/dist/custom-agents.js:36-39,59-64` (precedence), `node_modules/@tintinweb/pi-subagents/dist/settings.js:133-135` (`packageAgents` gate), `node_modules/@tintinweb/pi-subagents/dist/index.js:361,1187` (registry setter and background default), `node_modules/@tintinweb/pi-subagents/dist/agent-types.js:65` (`registerAgents`); `src/lib/pi-subagents-export.ts` (export lifecycle, manifest, rollback, stale-file removal and retention); `src/lib/pi-subagents-personas.ts` (curated persona list, compatibility screening); `src/cli.ts:1080-1106` (CLI surface: `pi-subagents preview|export|refresh|cleanup`). Tested interop contract: pi-subagents 0.22.0 on Pi 1.3.0.
|
|
128
135
|
- **CC-P** — [Claude Code profile](skills/using-systematic/references/claude-code-profile.md#L5-L10).
|
|
129
136
|
- **CC-1** — [Claude Code skills](https://code.claude.com/docs/en/skills) (`context: fork`); name-based subagent dispatch verified via `claude-code/agents/` and the plugin's invocation convention [CC-9].
|
|
130
137
|
- **CC-2** — [Claude Code tools reference](https://code.claude.com/docs/en/tools-reference).
|