@fro.bot/systematic 3.22.1 → 3.22.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/agents/review/README.md +3 -3
- package/agents/review/architecture-strategist.md +1 -1
- package/agents/review/code-simplicity-reviewer.md +1 -1
- package/agents/review/pattern-recognition-specialist.md +1 -1
- package/dist/index.js +9 -8
- package/package.json +1 -1
- package/skills/ce-brainstorm/references/brainstorm-sections.md +2 -2
- package/skills/ce-brainstorm/references/handoff.md +12 -12
- package/skills/ce-brainstorm/references/markdown-rendering.md +1 -1
- package/skills/ce-brainstorm/references/requirements-capture.md +2 -2
- package/skills/ce-brainstorm/references/synthesis-summary.md +7 -7
- package/skills/ce-brainstorm/references/universal-brainstorming.md +1 -1
- package/skills/ce-ideate/references/post-ideation-workflow.md +5 -5
- package/skills/ce-plan/references/deepening-workflow.md +2 -2
- package/skills/ce-plan/references/plan-handoff.md +7 -7
- package/skills/ce-plan/references/universal-planning.md +3 -3
- package/skills/ce-review/references/persona-catalog.md +3 -3
- package/skills/ce-work/references/shipping-workflow.md +10 -10
- package/skills/document-review/references/synthesis-and-presentation.md +5 -5
package/agents/review/README.md
CHANGED
|
@@ -5,6 +5,6 @@ Workflow-specific rosters live in the relevant skill catalogs.
|
|
|
5
5
|
|
|
6
6
|
These agents are not dispatched by `ce:review`:
|
|
7
7
|
|
|
8
|
-
- `systematic:review:architecture-strategist` — dispatched by `deepen-plan` and the `ce
|
|
9
|
-
- `systematic:review:pattern-recognition-specialist` — dispatched by `deepen-plan`, the `ce
|
|
10
|
-
- `systematic:review:code-simplicity-reviewer` — dispatched by `ce
|
|
8
|
+
- `systematic:review:architecture-strategist` — dispatched by `deepen-plan` and the `ce:plan` deepening workflow.
|
|
9
|
+
- `systematic:review:pattern-recognition-specialist` — dispatched by `deepen-plan`, the `ce:plan` deepening workflow, and `ce:compound`.
|
|
10
|
+
- `systematic:review:code-simplicity-reviewer` — dispatched by `ce:compound`.
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: architecture-strategist
|
|
3
|
-
description: "Analyzes code changes from an architectural perspective for pattern compliance and design integrity. Use when reviewing PRs, adding services, or evaluating structural refactors. Dispatched by deepen-plan and ce
|
|
3
|
+
description: "Analyzes code changes from an architectural perspective for pattern compliance and design integrity. Use when reviewing PRs, adding services, or evaluating structural refactors. Dispatched by deepen-plan and ce:plan's deepening workflow, not by ce:review."
|
|
4
4
|
tools: Read, Grep, Glob, Bash
|
|
5
5
|
mode: subagent
|
|
6
6
|
temperature: 0.1
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: code-simplicity-reviewer
|
|
3
|
-
description: "Final review pass to ensure code is as simple and minimal as possible. Use after implementation is complete to identify YAGNI violations and simplification opportunities. Dispatched by ce
|
|
3
|
+
description: "Final review pass to ensure code is as simple and minimal as possible. Use after implementation is complete to identify YAGNI violations and simplification opportunities. Dispatched by ce:compound for code-heavy issues, not by ce:review."
|
|
4
4
|
tools: Read, Grep, Glob, Bash
|
|
5
5
|
mode: subagent
|
|
6
6
|
temperature: 0.1
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: pattern-recognition-specialist
|
|
3
|
-
description: "Analyzes code for design patterns, anti-patterns, naming conventions, and duplication. Use when checking codebase consistency or verifying new code follows established patterns. Dispatched by deepen-plan, ce
|
|
3
|
+
description: "Analyzes code for design patterns, anti-patterns, naming conventions, and duplication. Use when checking codebase consistency or verifying new code follows established patterns. Dispatched by deepen-plan, ce:plan's deepening workflow, and ce:compound, not by ce:review."
|
|
4
4
|
tools: Read, Grep, Glob, Bash
|
|
5
5
|
mode: subagent
|
|
6
6
|
temperature: 0.6
|
package/dist/index.js
CHANGED
|
@@ -10493,20 +10493,21 @@ function parseHostOutput(output, options) {
|
|
|
10493
10493
|
metadata: output.metadata
|
|
10494
10494
|
};
|
|
10495
10495
|
}
|
|
10496
|
+
var GUARDED_SKILL_ALIASES = new Map([
|
|
10497
|
+
["ce:work", "ce-work"],
|
|
10498
|
+
["systematic:ce:work", "ce-work"],
|
|
10499
|
+
["git-commit", "git-commit"],
|
|
10500
|
+
["systematic:git-commit", "git-commit"],
|
|
10501
|
+
["git-commit-push-pr", "git-commit-push-pr"],
|
|
10502
|
+
["systematic:git-commit-push-pr", "git-commit-push-pr"]
|
|
10503
|
+
]);
|
|
10496
10504
|
function normalizeSkill(tool, args2) {
|
|
10497
10505
|
if (tool !== "systematic_skill" && tool !== "skill")
|
|
10498
10506
|
return;
|
|
10499
10507
|
if (!isRecord7(args2) || !boundedString(args2.name, MAX_SKILL_LENGTH)) {
|
|
10500
10508
|
return;
|
|
10501
10509
|
}
|
|
10502
|
-
|
|
10503
|
-
"ce:work": "ce-work",
|
|
10504
|
-
"git-commit": "git-commit",
|
|
10505
|
-
"systematic:git-commit": "git-commit",
|
|
10506
|
-
"git-commit-push-pr": "git-commit-push-pr",
|
|
10507
|
-
"systematic:git-commit-push-pr": "git-commit-push-pr"
|
|
10508
|
-
};
|
|
10509
|
-
return names[args2.name] ?? "ce-work";
|
|
10510
|
+
return GUARDED_SKILL_ALIASES.get(args2.name);
|
|
10510
10511
|
}
|
|
10511
10512
|
function trustedSkillPolicy(skill, additional = []) {
|
|
10512
10513
|
const requiredOperations = [
|
package/package.json
CHANGED
|
@@ -21,14 +21,14 @@ session produced the brainstorm.
|
|
|
21
21
|
Used in the filename (`docs/brainstorms/YYYY-MM-DD-<topic>-requirements.md`).
|
|
22
22
|
- **`topic`** — kebab-case slug identifying the brainstorm subject (e.g.,
|
|
23
23
|
`surface-scope-earlier`, `demo-reel-local-save`). Used in the filename
|
|
24
|
-
alongside `date` and as the resume-detection key when `ce
|
|
24
|
+
alongside `date` and as the resume-detection key when `ce:brainstorm`'s
|
|
25
25
|
Phase 0.1 scans `docs/brainstorms/` for an existing artifact to continue.
|
|
26
26
|
|
|
27
27
|
### Status flip does not apply to brainstorm
|
|
28
28
|
|
|
29
29
|
Unlike plans, brainstorm artifacts have no `status` field — there is no
|
|
30
30
|
`active → completed` lifecycle. A brainstorm is a one-time output that
|
|
31
|
-
downstream consumers (`ce
|
|
31
|
+
downstream consumers (`ce:plan`, `document-review`) reference via the plan's
|
|
32
32
|
`origin:` field.
|
|
33
33
|
|
|
34
34
|
### Field-name stability
|
|
@@ -45,29 +45,29 @@ What would you like to do next? (Pick a number or describe what you want.)
|
|
|
45
45
|
|
|
46
46
|
Present only the options that apply. Renumber so visible options stay contiguous starting at 1.
|
|
47
47
|
|
|
48
|
-
1. **Plan implementation with `ce
|
|
49
|
-
2. **Agent review of requirements doc with `
|
|
50
|
-
3. **Build it now with `ce
|
|
48
|
+
1. **Plan implementation with `ce:plan` (Recommended)** - Move to `ce:plan` for structured implementation planning. Shown only when `Resolve Before Planning` is empty.
|
|
49
|
+
2. **Agent review of requirements doc with `systematic:document-review`** - Dispatch reviewer agents to check the doc for coherence, feasibility, scope, and other persona-specific issues; auto-apply safe fixes; route remaining findings interactively. Shown only when a requirements document exists.
|
|
50
|
+
3. **Build it now with `ce:work` (skip planning)** - Skip planning and move to `ce:work`; suited to lightweight, well-defined changes. Shown only when `Resolve Before Planning` is empty **and** scope is lightweight, success criteria are clear, scope boundaries are clear, and no meaningful technical or research questions remain (the "direct-to-work gate").
|
|
51
51
|
4. **More clarifying questions to sharpen the doc** - Keep refining scope, edge cases, constraints, and preferences through further dialogue. Always shown.
|
|
52
52
|
5. **Done for now** - Pause; the requirements doc is saved and can be resumed later. Always shown.
|
|
53
53
|
|
|
54
|
-
**Post-review nudge (subsequent rounds only):** If the user has already run `
|
|
54
|
+
**Post-review nudge (subsequent rounds only):** If the user has already run `systematic:document-review` this session and residual P0/P1 findings remain unaddressed, add a one-line prose nudge adjacent to the menu (e.g., "Document review flagged 2 P1 findings you may want to address — pick \"Agent review of requirements doc\" to run another pass."). Reference the option by label, not number: the menu renumbers when `Resolve Before Planning` hides `Plan implementation` and `Build it now`, so a hardcoded option number can point users at the wrong action. Do not add a separate menu option; reuse the existing agent-review option.
|
|
55
55
|
|
|
56
56
|
#### 4.2 Handle the Selected Option
|
|
57
57
|
|
|
58
58
|
Selections may be the literal option label (when the user types the label or a close paraphrase) or the option number. Match numbers against the currently-rendered (post-trim) list. Free-form input that doesn't match an option or describe an alternative action should be treated as clarification — ask a follow-up rather than guessing.
|
|
59
59
|
|
|
60
|
-
**If user selects "Plan implementation with `ce
|
|
60
|
+
**If user selects "Plan implementation with `ce:plan` (Recommended)":**
|
|
61
61
|
|
|
62
|
-
Immediately load the `ce
|
|
62
|
+
Immediately load the `ce:plan` skill in the current session. Pass the requirements document path when one exists; otherwise pass a concise summary of the finalized brainstorm decisions. Do not print the closing summary first.
|
|
63
63
|
|
|
64
|
-
**If user selects "Agent review of requirements doc with `
|
|
64
|
+
**If user selects "Agent review of requirements doc with `systematic:document-review`":**
|
|
65
65
|
|
|
66
|
-
Load the `
|
|
66
|
+
Load the `systematic:document-review` skill, passing the requirements document path as the argument. When document review returns "Review complete", return to the Phase 4 options and re-render the menu (the doc may have changed, so re-evaluate `Resolve Before Planning`, direct-to-work gate, and residual findings). If residual P0/P1 findings remain unaddressed, include the post-review nudge above the menu. Do not show the closing summary yet.
|
|
67
67
|
|
|
68
|
-
**If user selects "Build it now with `ce
|
|
68
|
+
**If user selects "Build it now with `ce:work` (skip planning)":**
|
|
69
69
|
|
|
70
|
-
Immediately load the `ce
|
|
70
|
+
Immediately load the `ce:work` skill in the current session using the finalized brainstorm output as context. If a compact requirements document exists, pass its path. Do not print the closing summary first.
|
|
71
71
|
|
|
72
72
|
**If user selects "More clarifying questions to sharpen the doc":** Return to Phase 1.3 (Collaborative Dialogue) and continue asking the user clarifying questions one at a time to further refine scope, edge cases, constraints, and preferences. Continue until the user is satisfied, then return to Phase 4. Do not show the closing summary yet.
|
|
73
73
|
|
|
@@ -88,7 +88,7 @@ Key decisions:
|
|
|
88
88
|
- [Decision 1]
|
|
89
89
|
- [Decision 2]
|
|
90
90
|
|
|
91
|
-
Recommended next step: `ce
|
|
91
|
+
Recommended next step: `ce:plan`
|
|
92
92
|
```
|
|
93
93
|
|
|
94
94
|
If the user pauses with `Resolve Before Planning` still populated, display:
|
|
@@ -102,5 +102,5 @@ Planning is blocked by:
|
|
|
102
102
|
- [Blocking question 1]
|
|
103
103
|
- [Blocking question 2]
|
|
104
104
|
|
|
105
|
-
Resume with `ce
|
|
105
|
+
Resume with `ce:brainstorm` when ready to resolve these before planning.
|
|
106
106
|
```
|
|
@@ -180,7 +180,7 @@ Per-skill frontmatter fields are defined in each skill's section contract
|
|
|
180
180
|
`Status`, `CreatedAt`).
|
|
181
181
|
- **Status lifecycle is per-contract.** When the section contract
|
|
182
182
|
defines a `status` field with a lifecycle (plans use
|
|
183
|
-
`active → completed`, flipped by ce
|
|
183
|
+
`active → completed`, flipped by ce:work at shipping time via direct
|
|
184
184
|
YAML edit), it is editable in place. When the section contract does
|
|
185
185
|
not define a status lifecycle (brainstorms have no `active → completed`
|
|
186
186
|
flip — they are upstream of plans and referenced via the plan's
|
|
@@ -94,7 +94,7 @@ topic: <kebab-case-topic>
|
|
|
94
94
|
|
|
95
95
|
<!-- Include ONLY in non-interactive (headless) mode when the agent had Inferred bets that
|
|
96
96
|
were not user-confirmed in chat. Lists the un-validated agent inferences explicitly so
|
|
97
|
-
downstream review (
|
|
97
|
+
downstream review (document-review, ce:plan, human PR review) can scrutinize them as bets,
|
|
98
98
|
not as authoritative requirements. Omit entirely in interactive mode — Inferred bets get
|
|
99
99
|
user-corrected in chat and either become decisions or are revised away. -->
|
|
100
100
|
## Assumptions
|
|
@@ -232,7 +232,7 @@ Include a visual aid when the requirements would be significantly easier to unde
|
|
|
232
232
|
|
|
233
233
|
Before finalizing:
|
|
234
234
|
|
|
235
|
-
- What would `ce
|
|
235
|
+
- What would `ce:plan` still have to invent if this brainstorm ended now?
|
|
236
236
|
- Does every Standard/Deep requirement have either an observable behavior or a stated reason it is structural?
|
|
237
237
|
- Do Success Criteria cover both human outcome and downstream-agent handoff quality?
|
|
238
238
|
- If Actors are named, is each actor mentioned in the problem represented in at least one requirement, flow, or scope boundary?
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
# Synthesis Summary
|
|
2
2
|
|
|
3
|
-
**Synthesis ≠ requirements doc.** The synthesis is NOT a preview, draft, or substitute for the requirements doc — it's the scope checkpoint that doc-write consumes as input. The requirements doc itself is written in Phase 3 from the confirmed synthesis. Both the synthesis and the requirements doc stay scope-only — implementation detail (file paths, code shapes, exact error wording) is downstream (ce
|
|
3
|
+
**Synthesis ≠ requirements doc.** The synthesis is NOT a preview, draft, or substitute for the requirements doc — it's the scope checkpoint that doc-write consumes as input. The requirements doc itself is written in Phase 3 from the confirmed synthesis. Both the synthesis and the requirements doc stay scope-only — implementation detail (file paths, code shapes, exact error wording) is downstream (ce:plan's job), not the requirements doc.
|
|
4
4
|
|
|
5
5
|
**Two-stage shape: internal draft, then chat-time scoping synthesis.** The synthesis is composed in two stages. Stage 1 is an internal three-bucket draft (Stated / Inferred / Out of scope) the agent uses to think comprehensively about scope. Stage 2 is the scoping synthesis presented to the user — shaped like what two product collaborators would confirm before writing a PRD, not like a comprehensive audit and not like a one-line preview. The user only sees stage 2. The internal draft still informs the doc body via the doc-shape routing below; it just doesn't reach the user verbatim. This split exists because the comprehensive audit shape produced too much detail for the user to actually weigh in on, even when the granularity rules were followed.
|
|
6
6
|
|
|
@@ -10,7 +10,7 @@ This content is loaded when Phase 2.5 fires — after Phase 2 (approaches chosen
|
|
|
10
10
|
|
|
11
11
|
Fires for **all tiers** including Lightweight. Skip Phase 2.5 entirely on the Phase 0.1b non-software (universal-brainstorming) route.
|
|
12
12
|
|
|
13
|
-
**Headless / pipeline mode:** When invoked from a `disable-model-invocation` context (LFG, SLFG, or any automated pipeline), skip the chat-time stage entirely — there is no synchronous user to confirm with. Instead, route the internal three-bucket draft directly into the doc body sections per the "Doc shape after confirmation" table below, and route any Inferred bets to `## Assumptions` in the requirements doc so downstream review (document-review, ce
|
|
13
|
+
**Headless / pipeline mode:** When invoked from a `disable-model-invocation` context (LFG, SLFG, or any automated pipeline), skip the chat-time stage entirely — there is no synchronous user to confirm with. Instead, route the internal three-bucket draft directly into the doc body sections per the "Doc shape after confirmation" table below, and route any Inferred bets to `## Assumptions` in the requirements doc so downstream review (document-review, ce:plan, human PR review) can scrutinize them explicitly. Do not present the scoping synthesis to chat; proceed directly to Phase 3 doc-write.
|
|
14
14
|
|
|
15
15
|
---
|
|
16
16
|
|
|
@@ -70,8 +70,8 @@ Each conditional section has its own keep test. Sections are render-conditional
|
|
|
70
70
|
- **Real scope fork** — another reasonable agent might choose a different scope on this dimension (who the primary actor is, whether case X is in/out, in scope vs deferred)
|
|
71
71
|
- **Non-obvious scope inclusion** — a behavior the agent assumed is in scope that the user might want excluded
|
|
72
72
|
- **Non-obvious scope exclusion** — an item the agent moved to deferred that the user might want in scope
|
|
73
|
-
- **Cheap-now-expensive-later correction** — a scope bet that's cheap to fix now but expensive after the requirements doc lands and ce
|
|
74
|
-
- **Non-obvious consequence of multi-turn answers** — a downstream effect of combining user-stated answers that the user is unlikely to have tracked through dialogue. Surfaced forward-looking ("X means Y for the doc"), not retrospectively ("you said X"). This category is the multi-turn-dialogue reason call-outs exist at all in ce
|
|
73
|
+
- **Cheap-now-expensive-later correction** — a scope bet that's cheap to fix now but expensive after the requirements doc lands and ce:plan consumes it
|
|
74
|
+
- **Non-obvious consequence of multi-turn answers** — a downstream effect of combining user-stated answers that the user is unlikely to have tracked through dialogue. Surfaced forward-looking ("X means Y for the doc"), not retrospectively ("you said X"). This category is the multi-turn-dialogue reason call-outs exist at all in ce:brainstorm; do not filter these as "already implied by Stated"
|
|
75
75
|
|
|
76
76
|
Cut anything that doesn't match a keep-test category, including:
|
|
77
77
|
|
|
@@ -120,7 +120,7 @@ The "What we're building" prose obeys the same discipline: 1–3 sentences descr
|
|
|
120
120
|
|
|
121
121
|
Each anti-pattern below produces a bullet that fails its section's keep test, or a scoping synthesis that drifts back toward the comprehensive-audit failure mode.
|
|
122
122
|
|
|
123
|
-
- **Naming implementation detail in any bullet**: file paths, module names, exact JSON keys, HTTP status codes, error message wording, SQL syntax. The synthesis is scope-only; implementation is ce
|
|
123
|
+
- **Naming implementation detail in any bullet**: file paths, module names, exact JSON keys, HTTP status codes, error message wording, SQL syntax. The synthesis is scope-only; implementation is ce:plan's job. These granularity rules apply to every bullet in every section.
|
|
124
124
|
- **Re-stating a Q&A turn verbatim** ("you said you wanted X"): transcript, not scoping synthesis. Reframe forward-looking ("X means Y for the doc") or cut.
|
|
125
125
|
- **Re-stating the Phase 2 approach the user already picked**: the approach was chosen before Phase 2.5 — its mention belongs in one sentence of "What we're building," not as a call-out.
|
|
126
126
|
- **Padding a section to meet a bullet count**: render-conditional means empty is allowed. Omit the section entirely rather than fill it with weak items.
|
|
@@ -194,7 +194,7 @@ What got cut from the 12-item internal draft and why:
|
|
|
194
194
|
|
|
195
195
|
- Stated items already covered by the "What we're building" prose dissolved silently
|
|
196
196
|
- "Use existing rule entity" — mechanical, no real trade-off
|
|
197
|
-
- "Use Postgres for persistence" — implementation detail (ce
|
|
197
|
+
- "Use Postgres for persistence" — implementation detail (ce:plan's job), failed granularity rules
|
|
198
198
|
- One Out-of-scope item ("no rate limiting") — mechanical exclude, no reader would ask about it
|
|
199
199
|
- Three Inferred items rolled into the Trade-offs section as the explicit choices behind them
|
|
200
200
|
|
|
@@ -244,7 +244,7 @@ Fall back to a numbered list in chat only when no blocking tool exists or the ca
|
|
|
244
244
|
|
|
245
245
|
If the user response indicates they're in the wrong skill or want a different workflow (e.g., "this is too small, just ce:work it" or "this needs more thought, let me brainstorm differently"):
|
|
246
246
|
|
|
247
|
-
- Stop ce
|
|
247
|
+
- Stop ce:brainstorm
|
|
248
248
|
- Suggest the alternative skill the user appears to want (e.g., `ce:work`)
|
|
249
249
|
- Offer to load it in-session
|
|
250
250
|
- Do not push back or argue — the user's redirect signal is the deliberate choice
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
# Universal Brainstorming Facilitator
|
|
2
2
|
|
|
3
|
-
This file is loaded when ce
|
|
3
|
+
This file is loaded when ce:brainstorm detects a non-software task (Phase 0). It replaces the software-specific brainstorming phases (Phases 0.2 through 4) with facilitation principles for any domain. The Core Principles and **Interaction Rules** in the parent `ce-brainstorm/SKILL.md` still apply unchanged — including one-question-per-turn and the default to the platform's blocking question tool. This file extends those rules with universal-domain facilitation guidance; it does not relax them.
|
|
4
4
|
|
|
5
5
|
---
|
|
6
6
|
|
|
@@ -60,7 +60,7 @@ When the user picks an option in Phase 6 that requires a durable record (Brainst
|
|
|
60
60
|
| Action | Repo mode default | Elsewhere mode default |
|
|
61
61
|
|---|---|---|
|
|
62
62
|
| Save | `docs/ideation/YYYY-MM-DD-<topic>-ideation.md` | Local file (custom path if no repo context) |
|
|
63
|
-
| Brainstorm handoff | `ce
|
|
63
|
+
| Brainstorm handoff | `ce:brainstorm` | `ce:brainstorm` (universal-brainstorming) |
|
|
64
64
|
| End | Conversation only is fine | Conversation only is fine |
|
|
65
65
|
|
|
66
66
|
Both modes persist via local file save. Elsewhere mode without an obvious repo path should ask the user for a save location (current working directory, `/tmp`, or a custom path) using the same file structure as repo mode.
|
|
@@ -120,7 +120,7 @@ Ask what should happen next using the platform's blocking question tool: `questi
|
|
|
120
120
|
Offer these three options (labels are self-contained with the distinguishing word front-loaded so options stay distinct when truncated):
|
|
121
121
|
|
|
122
122
|
1. **Refine the ideation in conversation (or stop here — no save)** — add ideas, re-evaluate, or deepen analysis. No file side effects; ending the conversation at any point after this pick is a valid no-save exit.
|
|
123
|
-
2. **Brainstorm a selected idea** — load `ce
|
|
123
|
+
2. **Brainstorm a selected idea** — load `ce:brainstorm` with the chosen idea as the seed. The orchestrator first writes a durable record using the mode default in Phase 5.
|
|
124
124
|
3. **Save and end** — persist the ideation to a local file using the mode default (Phase 5.1), then end.
|
|
125
125
|
|
|
126
126
|
No-save exit is supported without a dedicated menu option. Pick option 1 and stop the conversation, or use the question tool's free-text escape to say so directly — persistence is opt-in and the terminal review loop is already a complete ideation cycle.
|
|
@@ -143,9 +143,9 @@ Ending after refinement — or without any refinement at all — is a valid no-s
|
|
|
143
143
|
|
|
144
144
|
- Write or update the durable record per the mode default in Phase 5 (5.1 file save)
|
|
145
145
|
- Mark the chosen idea as `Explored` in the saved record
|
|
146
|
-
- Load the `ce
|
|
146
|
+
- Load the `ce:brainstorm` skill with the chosen idea as the seed
|
|
147
147
|
|
|
148
|
-
**Repo mode only:** do **not** skip brainstorming and go straight to `ce
|
|
148
|
+
**Repo mode only:** do **not** skip brainstorming and go straight to `ce:plan` from ideation output — `ce:plan` wants brainstorm-grounded requirements. In elsewhere modes, ideation is a legitimate terminal state; brainstorming is optional deeper development of one idea, not a required next rung on an implementation ladder that does not exist in these modes.
|
|
149
149
|
|
|
150
150
|
### 6.3 Save and End
|
|
151
151
|
|
|
@@ -173,4 +173,4 @@ Before finishing, check:
|
|
|
173
173
|
- survivors are materially better than a naive "give me ideas" list
|
|
174
174
|
- persistence followed user choice — terminal-only sessions did not write a file
|
|
175
175
|
- when persistence did trigger, the mode default was respected unless the user explicitly overrode it
|
|
176
|
-
- acting on an idea routes to `ce
|
|
176
|
+
- acting on an idea routes to `ce:brainstorm`, not directly to implementation
|
|
@@ -226,7 +226,7 @@ Strengthen only the selected sections. Keep the plan coherent and preserve its o
|
|
|
226
226
|
Allowed changes:
|
|
227
227
|
- Clarify or strengthen decision rationale
|
|
228
228
|
- Tighten requirements trace or origin fidelity
|
|
229
|
-
- Reorder or split implementation units when sequencing is weak — but **never renumber existing U-IDs**. Reordering preserves U-IDs in their new order (e.g., U1, U3, U5 reordered is correct; renumbering to U1, U2, U3 is not). Splitting keeps the original U-ID on the original concept and assigns the next unused number to the new unit. Renumbering breaks ce
|
|
229
|
+
- Reorder or split implementation units when sequencing is weak — but **never renumber existing U-IDs**. Reordering preserves U-IDs in their new order (e.g., U1, U3, U5 reordered is correct; renumbering to U1, U2, U3 is not). Splitting keeps the original U-ID on the original concept and assigns the next unused number to the new unit. Renumbering breaks ce:work blocker and verification references that were written against the original IDs
|
|
230
230
|
- Add missing pattern references, file/test paths, or verification outcomes
|
|
231
231
|
- Expand system-wide impact, risks, or rollout treatment where justified
|
|
232
232
|
- Reclassify open questions between `Resolved During Planning` and `Deferred to Implementation` when evidence supports the change
|
|
@@ -245,4 +245,4 @@ Do **not**:
|
|
|
245
245
|
If research reveals a product-level ambiguity that should change behavior or scope:
|
|
246
246
|
- Do not silently decide it here
|
|
247
247
|
- Record it under `Open Questions`
|
|
248
|
-
- Recommend `ce
|
|
248
|
+
- Recommend `ce:brainstorm` if the gap is truly product-defining
|
|
@@ -4,17 +4,17 @@ This file contains post-plan-writing instructions: document review, post-generat
|
|
|
4
4
|
|
|
5
5
|
## 5.3.8 Document Review
|
|
6
6
|
|
|
7
|
-
After the confidence check (and any deepening), run the `
|
|
7
|
+
After the confidence check (and any deepening), run the `document-review` skill on the plan file. Pass the plan path as the argument. When this step is reached, it is mandatory — do not skip it because the confidence check already ran. The two tools catch different classes of issues.
|
|
8
8
|
|
|
9
|
-
The confidence check and
|
|
9
|
+
The confidence check and document-review are complementary:
|
|
10
10
|
- The confidence check strengthens rationale, sequencing, risk treatment, and grounding
|
|
11
11
|
- Document-review checks coherence, feasibility, scope alignment, and surfaces role-specific issues
|
|
12
12
|
|
|
13
|
-
If
|
|
13
|
+
If document-review returns findings that were auto-applied, note them briefly when presenting handoff options. If residual P0/P1 findings were surfaced, mention them so the user can decide whether to address them before proceeding.
|
|
14
14
|
|
|
15
|
-
When
|
|
15
|
+
When document-review returns "Review complete", proceed to Final Checks.
|
|
16
16
|
|
|
17
|
-
**Pipeline mode:** If invoked from an automated workflow such as LFG or any `disable-model-invocation` context, run `
|
|
17
|
+
**Pipeline mode:** If invoked from an automated workflow such as LFG or any `disable-model-invocation` context, run `document-review` with `mode:headless` and the plan path. Headless mode applies auto-fixes silently and returns structured findings without interactive prompts. Address any P0/P1 findings before returning control to the caller.
|
|
18
18
|
|
|
19
19
|
## 5.3.9 Final Checks and Cleanup
|
|
20
20
|
|
|
@@ -29,7 +29,7 @@ If artifact-backed mode was used:
|
|
|
29
29
|
|
|
30
30
|
## 5.4 Post-Generation Options
|
|
31
31
|
|
|
32
|
-
**Pipeline mode:** If invoked from an automated workflow such as LFG or any `disable-model-invocation` context, skip the interactive menu below and return control to the caller immediately. The plan file has already been written, the confidence check has already run, and
|
|
32
|
+
**Pipeline mode:** If invoked from an automated workflow such as LFG or any `disable-model-invocation` context, skip the interactive menu below and return control to the caller immediately. The plan file has already been written, the confidence check has already run, and document-review has already run — the caller (e.g., lfg) determines the next step.
|
|
33
33
|
|
|
34
34
|
After document-review completes, present the options using the platform's blocking question tool: `question` in OpenCode (call `ToolSearch` with `select:question` first if its schema isn't loaded), `request_user_input` in Codex, `ask_user` in Gemini, `ask_user` in Pi (requires the `pi-ask-user` extension). Fall back to numbered options in chat only when no blocking tool exists in the harness or the call errors (e.g., Codex edit modes) — not because a schema load is required. Never silently skip the question.
|
|
35
35
|
|
|
@@ -48,7 +48,7 @@ Based on selection:
|
|
|
48
48
|
- **Start `ce:work`** -> Call `ce:work` with the plan path
|
|
49
49
|
- **Create Issue** -> Follow the Issue Creation section below
|
|
50
50
|
- **Done for now** -> Display a brief confirmation that the plan file is saved and end the turn
|
|
51
|
-
- **If the user asks for another document review** (either from the contextual prompt when P0/P1 findings remain, or by free-form request) -> Load the `
|
|
51
|
+
- **If the user asks for another document review** (either from the contextual prompt when P0/P1 findings remain, or by free-form request) -> Load the `document-review` skill with the plan path for another pass, then return to the options
|
|
52
52
|
- **Other** -> Accept free text for revisions and loop back to options
|
|
53
53
|
|
|
54
54
|
## Issue Creation
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
# Universal Planning Workflow
|
|
2
2
|
|
|
3
|
-
This file is loaded when ce
|
|
3
|
+
This file is loaded when ce:plan detects a non-software task (Phase 0.1b). It replaces the software-specific phases (0.2 through 5.1) with a domain-agnostic planning workflow.
|
|
4
4
|
|
|
5
5
|
## Before starting: verify classification
|
|
6
6
|
|
|
@@ -8,9 +8,9 @@ The detection stub in SKILL.md routes here for anything that isn't clearly softw
|
|
|
8
8
|
|
|
9
9
|
- **Is this actually a software task?** The key distinction is task-type, not topic-domain. A study guide about Rust is non-software (producing educational content). A Rust library refactor is software (modifying code). If this is actually software, return to Phase 0.2 in the main SKILL.md.
|
|
10
10
|
- **Is this a quick-help request, not a planning task?** Error messages, factual questions, and single-step tasks don't need a plan. Respond directly and exit. Examples: "zsh: command not found: brew", "what's the capital of France."
|
|
11
|
-
- **Pipeline mode?** If invoked from LFG or any `disable-model-invocation` context: output "This is a non-software task. The LFG pipeline requires ce
|
|
11
|
+
- **Pipeline mode?** If invoked from LFG or any `disable-model-invocation` context: output "This is a non-software task. The LFG pipeline requires ce:work, which only supports software tasks. Use `ce:plan` directly for non-software planning." and stop.
|
|
12
12
|
|
|
13
|
-
Once past these checks, commit to producing a plan. Do not exit because the task looks like a "lookup" or "research question" — the user invoked `ce
|
|
13
|
+
Once past these checks, commit to producing a plan. Do not exit because the task looks like a "lookup" or "research question" — the user invoked `ce:plan` because they want a structured output.
|
|
14
14
|
|
|
15
15
|
---
|
|
16
16
|
|
|
@@ -6,9 +6,9 @@
|
|
|
6
6
|
|
|
7
7
|
The `agents/review/` directory is a shared persona pool, not `ce:review`'s roster. Directory placement does not imply that a persona is selectable by `ce:review`. These shared personas are dispatched by other workflows and intentionally do not appear in this catalog's `ce:review` selection tables:
|
|
8
8
|
|
|
9
|
-
- `systematic:review:architecture-strategist` — dispatched by `deepen-plan` and `ce
|
|
10
|
-
- `systematic:review:pattern-recognition-specialist` — dispatched by `deepen-plan`, `ce
|
|
11
|
-
- `systematic:review:code-simplicity-reviewer` — dispatched by `ce
|
|
9
|
+
- `systematic:review:architecture-strategist` — dispatched by `deepen-plan` and `ce:plan`'s deepening workflow for architectural analysis.
|
|
10
|
+
- `systematic:review:pattern-recognition-specialist` — dispatched by `deepen-plan`, `ce:plan`'s deepening workflow, and `ce:compound` for consistency, duplication, and pattern analysis.
|
|
11
|
+
- `systematic:review:code-simplicity-reviewer` — dispatched by `ce:compound` for code-heavy issues.
|
|
12
12
|
|
|
13
13
|
## Always-on (3 core personas)
|
|
14
14
|
|
|
@@ -20,7 +20,7 @@ This file contains the shipping workflow (Phase 3-4). Load it only when all Phas
|
|
|
20
20
|
|
|
21
21
|
Every change gets reviewed before shipping. The depth scales with the change's risk profile, but review itself is never skipped.
|
|
22
22
|
|
|
23
|
-
**Tier 2: Full review (default)** -- REQUIRED unless Tier 1 criteria are explicitly met. Invoke the `ce
|
|
23
|
+
**Tier 2: Full review (default)** -- REQUIRED unless Tier 1 criteria are explicitly met. Invoke the `ce:review` skill with `mode:autofix` to run specialized reviewer agents, auto-apply safe fixes, and record residual downstream work in the per-run artifact. When the plan file path is known, pass it as `plan:<path>`. This is the mandatory default -- proceed to Tier 1 only after confirming every criterion below.
|
|
24
24
|
|
|
25
25
|
**Tier 1: Inline self-review** -- A lighter alternative permitted only when **all four** criteria are true. Before choosing Tier 1, explicitly state which criteria apply and why. If any criterion is uncertain, use Tier 2.
|
|
26
26
|
- Purely additive (new files only, no existing behavior modified)
|
|
@@ -39,7 +39,7 @@ This file contains the shipping workflow (Phase 3-4). Load it only when all Phas
|
|
|
39
39
|
Options (four or fewer, self-contained labels):
|
|
40
40
|
- `Apply/fix now` — loop back into review with focused fixes; the agent investigates each finding, applies changes where safe, and re-runs review.
|
|
41
41
|
- `File tickets via project tracker` — load `references/tracker-defer.md` in Interactive mode; the agent files tickets in the project's detected tracker (or `gh` fallback, or leaves them in the report if no sink exists) and proceeds to Final Validation.
|
|
42
|
-
- `Accept and proceed` — record the residual findings verbatim in a durable "Known Residuals" sink before shipping. If a PR will be created or updated in Phase 4, include them in the PR description's "Known Residuals" section (the agent owns this when calling `
|
|
42
|
+
- `Accept and proceed` — record the residual findings verbatim in a durable "Known Residuals" sink before shipping. If a PR will be created or updated in Phase 4, include them in the PR description's "Known Residuals" section (the agent owns this when calling `systematic:git-commit-push-pr`). If the user later chooses the no-PR `systematic:git-commit` path, create `docs/residual-review-findings/<branch-or-head-sha>.md`, include the accepted findings and source review-run context, stage it with the implementation commit, and mention the file path in the final summary. The user has acknowledged the risk, but the findings must not live only in the transient session.
|
|
43
43
|
- `Stop — do not ship` — abort the shipping workflow. The user will handle findings manually before re-invoking.
|
|
44
44
|
|
|
45
45
|
Skip this gate entirely when the review reported `Residual actionable work: none.` or when only Tier 1 (inline self-review) was used. Do not proceed past this gate on an `Accept and proceed` decision until the agent has recorded whether the durable sink is `PR Known Residuals` or `docs/residual-review-findings/<branch-or-head-sha>.md`.
|
|
@@ -68,9 +68,9 @@ This file contains the shipping workflow (Phase 3-4). Load it only when all Phas
|
|
|
68
68
|
|
|
69
69
|
1. **Prepare Evidence Context**
|
|
70
70
|
|
|
71
|
-
Do not
|
|
71
|
+
Do not capture evidence directly in this step. Evidence capture belongs to the PR creation or PR description update flow, where the final PR diff and description context are available.
|
|
72
72
|
|
|
73
|
-
Note whether the completed work has observable behavior (UI rendering, CLI output, API/library behavior with a runnable example, generated artifacts, or workflow output). The `
|
|
73
|
+
Note whether the completed work has observable behavior (UI rendering, CLI output, API/library behavior with a runnable example, generated artifacts, or workflow output). The `systematic:git-commit-push-pr` skill will ask whether to capture evidence only when evidence is possible.
|
|
74
74
|
|
|
75
75
|
2. **Update Plan Status**
|
|
76
76
|
|
|
@@ -81,17 +81,17 @@ This file contains the shipping workflow (Phase 3-4). Load it only when all Phas
|
|
|
81
81
|
|
|
82
82
|
3. **Commit and Create Pull Request**
|
|
83
83
|
|
|
84
|
-
Load the `
|
|
84
|
+
Load the `systematic:git-commit-push-pr` skill to handle committing, pushing, and PR creation. The skill handles convention detection, branch safety, logical commit splitting, adaptive PR descriptions, and attribution badges.
|
|
85
85
|
|
|
86
86
|
When providing context for the PR description, include:
|
|
87
87
|
- The plan's summary and key decisions
|
|
88
88
|
- Testing notes (tests added/modified, manual testing performed)
|
|
89
|
-
- Evidence context from step 1, so `
|
|
89
|
+
- Evidence context from step 1, so `systematic:git-commit-push-pr` can decide whether to ask about capturing evidence
|
|
90
90
|
- Figma design link (if applicable)
|
|
91
91
|
- The Post-Deploy Monitoring & Validation section (see Phase 3 Step 5)
|
|
92
92
|
- Any "Known Residuals" accepted in the Phase 3 Residual Work Gate, rendered as a dedicated section in the PR body with severity, file:line, and title per finding
|
|
93
93
|
|
|
94
|
-
If the user prefers to commit without creating a PR, load the `
|
|
94
|
+
If the user prefers to commit without creating a PR, load the `systematic:git-commit` skill instead.
|
|
95
95
|
|
|
96
96
|
4. **Notify User**
|
|
97
97
|
- Summarize what was completed
|
|
@@ -109,10 +109,10 @@ Before creating PR, verify:
|
|
|
109
109
|
- [ ] Linting passes (use linting-agent)
|
|
110
110
|
- [ ] Code follows existing patterns
|
|
111
111
|
- [ ] Figma designs match implementation (if applicable)
|
|
112
|
-
- [ ] Evidence decision handled by `
|
|
112
|
+
- [ ] Evidence decision handled by `systematic:git-commit-push-pr` when the change has observable behavior
|
|
113
113
|
- [ ] Commit messages follow conventional format
|
|
114
114
|
- [ ] PR description includes Post-Deploy Monitoring & Validation section (or explicit no-impact rationale)
|
|
115
|
-
- [ ] Code review completed (inline self-review or full `ce
|
|
115
|
+
- [ ] Code review completed (inline self-review or full `ce:review`)
|
|
116
116
|
- [ ] PR description includes summary, testing notes, and evidence when captured
|
|
117
117
|
- [ ] PR description includes Compound Engineered badge with accurate model and harness
|
|
118
118
|
|
|
@@ -120,7 +120,7 @@ Before creating PR, verify:
|
|
|
120
120
|
|
|
121
121
|
Every change gets reviewed. The tier determines depth, not whether review happens.
|
|
122
122
|
|
|
123
|
-
**Tier 2 (full review)** -- REQUIRED default. Invoke `ce
|
|
123
|
+
**Tier 2 (full review)** -- REQUIRED default. Invoke `ce:review mode:autofix` with `plan:<path>` when available. Safe fixes are applied automatically; residual work is recorded in the run artifact for downstream routing. Always use this tier unless all four Tier 1 criteria are explicitly confirmed.
|
|
124
124
|
|
|
125
125
|
**Tier 1 (inline self-review)** -- permitted only when all four are true (state each explicitly before choosing):
|
|
126
126
|
- Purely additive (new files only, no existing behavior modified)
|
|
@@ -127,7 +127,7 @@ Run this step after 3.5b (recommended_action normalized) and before 3.6 (auto-pr
|
|
|
127
127
|
- Severity is `P0` or `P1` (premise-level issues carry high priority by nature)
|
|
128
128
|
- `autofix_class` is `manual` (the root itself requires judgment — a safe/gated root is acted on, not cascaded)
|
|
129
129
|
- `why_it_matters` or `title` challenges a foundational premise, not a detail. Signal phrases (shape, not vocabulary): "premise unsupported", "justification missing", "do-nothing baseline not evaluated", "is X justified", "unsupported by evidence", "is the proposed solution the right approach"
|
|
130
|
-
- The finding's `section` is framing-level (Problem Frame, Summary, Overview, Why, Motivation, Goals — `Summary` is the new ce
|
|
130
|
+
- The finding's `section` is framing-level (Problem Frame, Summary, Overview, Why, Motivation, Goals — `Summary` is the new ce:plan / ce:brainstorm template heading; `Overview` retained as legacy) OR the finding explicitly questions whether a named component should exist
|
|
131
131
|
|
|
132
132
|
If multiple candidates match the criteria, elevate ALL of them. The criteria above (P0/P1, manual, framing-level section, premise-challenge signal phrases) are restrictive enough that this list will be short for any well-formed document; do not impose a further numerical cap. Picking only one root when two valid roots exist leaves the second root's natural dependents stranded as independent manual findings — the exact UX problem chains are meant to solve.
|
|
133
133
|
|
|
@@ -380,12 +380,12 @@ B. Exit without further action
|
|
|
380
380
|
|
|
381
381
|
The `<next stage>` substitution uses the document type from Phase 1:
|
|
382
382
|
|
|
383
|
-
- Requirements document → `ce
|
|
384
|
-
- Plan document → `ce
|
|
383
|
+
- Requirements document → `ce:plan`
|
|
384
|
+
- Plan document → `ce:work`
|
|
385
385
|
|
|
386
386
|
**Label adaptation:** when no decisions are queued to apply, the primary option drops the `Apply decisions and` prefix — the label should match what the system is doing. `Apply decisions and proceed` when fixes are queued; `Proceed` when nothing is queued.
|
|
387
387
|
|
|
388
|
-
**Caller-context handling (implicit):** the terminal question's "Proceed to <next stage>" option is interpreted contextually by the agent from the visible conversation state. When
|
|
388
|
+
**Caller-context handling (implicit):** the terminal question's "Proceed to <next stage>" option is interpreted contextually by the agent from the visible conversation state. When document-review is invoked from inside another skill's flow (e.g., ce:brainstorm Phase 4 re-review, ce:plan phase 5.3.8), the agent does not fire a nested `/ce:plan` or `/ce:work` dispatch — it returns control to the caller's flow which continues its own logic. When invoked standalone, "Proceed" dispatches the appropriate next skill. No explicit caller-hint argument is required; if this implicit handling proves unreliable in practice, an explicit `nested:true` flag can be added as a follow-up.
|
|
389
389
|
|
|
390
390
|
### Iteration limit
|
|
391
391
|
|
|
@@ -399,7 +399,7 @@ Return "Review complete" as the terminal signal for callers, regardless of which
|
|
|
399
399
|
- Do not add new sections or requirements the user didn't discuss
|
|
400
400
|
- Do not over-engineer or add complexity
|
|
401
401
|
- Do not create separate review files or add metadata sections
|
|
402
|
-
- Do not modify caller skills (ce
|
|
402
|
+
- Do not modify caller skills (ce:brainstorm, ce:plan, or external plugin skills that invoke document-review)
|
|
403
403
|
|
|
404
404
|
## Iteration Guidance
|
|
405
405
|
|