@fro.bot/systematic 3.16.4 → 3.17.0

package/dist/cli.js

@@ -33,7 +33,7 @@ import {
   findCommandsInDir,
   findSkillsInDir,
   discoverSkills
-} from "./index-65g87tgr.js";
+} from "./index-y33enbkc.js";
 var __defProp = Object.defineProperty;
 var __returnValue = (v) => v;
 function __exportSetter(name, newValue) {

package/dist/{index-65g87tgr.js → index-y33enbkc.js}

@@ -197,7 +197,8 @@ function readOpencodeLayerField(agentOverlay, categoryOverlay, layer, field) {
 }
 function resolveOpencodeModelAndVariant(agentOverlay, categoryOverlay) {
   const modelLayerIndex = OPENCODE_MODEL_VARIANT_LAYERS.findIndex((layer) => readOpencodeLayerField(agentOverlay, categoryOverlay, layer, "model") !== undefined);
-  const rawModel = modelLayerIndex === -1 ? undefined : readOpencodeLayerField(agentOverlay, categoryOverlay, OPENCODE_MODEL_VARIANT_LAYERS[modelLayerIndex], "model");
+  const modelLayer = modelLayerIndex === -1 ? undefined : OPENCODE_MODEL_VARIANT_LAYERS[modelLayerIndex];
+  const rawModel = modelLayer === undefined ? undefined : readOpencodeLayerField(agentOverlay, categoryOverlay, modelLayer, "model");
   const model = narrowModelValue(rawModel);
   const hasModel = model !== undefined;
   const modelSource = hasModel ? OPENCODE_MODEL_VARIANT_LAYERS[modelLayerIndex] : undefined;
@@ -205,8 +206,7 @@ function resolveOpencodeModelAndVariant(agentOverlay, categoryOverlay) {
   let qualifierSource;
   if (model !== null) {
     const eligibleLayerCount = hasModel ? modelLayerIndex + 1 : OPENCODE_MODEL_VARIANT_LAYERS.length;
-    for (let i = 0;i < eligibleLayerCount; i++) {
-      const layer = OPENCODE_MODEL_VARIANT_LAYERS[i];
+    for (const layer of OPENCODE_MODEL_VARIANT_LAYERS.slice(0, eligibleLayerCount)) {
       const narrowed = narrowQualifierValue(readOpencodeLayerField(agentOverlay, categoryOverlay, layer, "variant"));
       if (narrowed !== undefined) {
         qualifier = narrowed;
@@ -1761,6 +1761,7 @@ var BUNDLED_SKILL_NAMES = [
   "ce:ideate",
   "ce:plan",
   "ce:review",
+  "ce:review-cleanup",
   "ce:work",
   "compound-docs",
   "deepen-plan",
@@ -8686,8 +8687,7 @@ function parseFrontmatter(content) {
       parseError: false
     };
   }
-  const yamlContent = match[1];
-  const body = match[2];
+  const [, yamlContent = "", body = ""] = match;
   try {
     const parsed = yaml.load(yamlContent, { schema: yaml.JSON_SCHEMA });
     const data = parsed ?? {};

package/dist/index.js

@@ -19,7 +19,7 @@ import {
   extractCommandFrontmatter,
   findSkillsInDir,
   discoverSkills
-} from "./index-65g87tgr.js";
+} from "./index-y33enbkc.js";
 
 // src/index.ts
 import { createHash as createHash4 } from "crypto";
@@ -75,14 +75,14 @@ var removeCompleteBootstrapBlocks = (entry) => {
   return result;
 };
 var applyBootstrapContent = (output, content) => {
-  for (let i2 = 0;i2 < output.system.length; i2++) {
-    output.system[i2] = removeCompleteBootstrapBlocks(output.system[i2]);
+  for (const [i2, entry] of output.system.entries()) {
+    output.system[i2] = removeCompleteBootstrapBlocks(entry);
   }
-  if (output.system.length === 0) {
+  const [first] = output.system;
+  if (first === undefined) {
     output.system.push(content);
     return;
   }
-  const first = output.system[0];
   output.system[0] = first.length > 0 ? `${first}
 
 ${content}` : content;
@@ -265,6 +265,9 @@ function parseOverlayShape(overlay, targetType) {
   return { skills: result.data.skills };
 }
 function throwOverlaySchemaError(overlay, issue) {
+  if (!issue) {
+    throwConfigError(overlay.sourcePath, overlay.keyPath, "schema validation failed");
+  }
   const zodPath = issue.code === "unrecognized_keys" ? issue.message.match(/"([^"]+)"/)?.[1] ?? issue.path.join(".") : issue.path.join(".");
   const fullPath = zodPath ? `${overlay.keyPath}.${zodPath}` : overlay.keyPath;
   throwConfigError(overlay.sourcePath, fullPath, issue.message);
@@ -332,7 +335,8 @@ $ARGUMENTS
 }
 function extractSkillBody(wrappedTemplate) {
   const match = wrappedTemplate.match(/<skill-instruction>([\s\S]*?)<\/skill-instruction>/);
-  return match ? match[1].trim() : wrappedTemplate;
+  const [, body2] = match ?? [];
+  return body2 !== undefined ? body2.trim() : wrappedTemplate;
 }
 function loadSkill(skillInfo) {
   try {
@@ -956,7 +960,8 @@ function readGitfileTarget(gitfilePath, realPath = fs6.realpathSync) {
   const match = /^gitdir:\s*(.+?)\s*$/im.exec(contents);
   if (!match)
     return;
-  const target = path5.isAbsolute(match[1]) ? match[1] : path5.resolve(path5.dirname(gitfilePath), match[1]);
+  const [, gitdirTarget = ""] = match;
+  const target = path5.isAbsolute(gitdirTarget) ? gitdirTarget : path5.resolve(path5.dirname(gitfilePath), gitdirTarget);
   return canonicalPath(target, realPath);
 }
 function readGitdirBacklink(backlinkPath, realPath) {
@@ -7869,7 +7874,7 @@ function parseCommand(node) {
   const commandName = node.childForFieldName("name");
   if (commandName?.type !== "command_name")
     return;
-  const executable = parsePlainToken(commandName.namedChildren[0]);
+  const executable = parsePlainToken(commandName.namedChildren[0] ?? null);
   if (!executable)
     return;
   if (!hasSafeCommandChildren(node))
@@ -7936,13 +7941,14 @@ function containsDynamicSyntax(node) {
   return false;
 }
 function classifyCommands(commands) {
-  if (commands.length === 0)
+  const lastCommand = commands.at(-1);
+  if (lastCommand === undefined)
     return;
   for (const prefix of commands.slice(0, -1)) {
     if (!isAllowedPrefix(prefix))
       return;
   }
-  return classifyFinalCommand(commands[commands.length - 1]);
+  return classifyFinalCommand(lastCommand);
 }
 function isAllowedPrefix(command) {
   return PREFIX_COMMANDS.has(command.executable) && command.arguments.length === 1 && isSafeRelativeCwd(command.arguments[0] ?? "");
@@ -8015,7 +8021,7 @@ function isDestructivePushArgument(value) {
 function classifyGhCommand(args2) {
   if (args2[0] !== "pr")
     return;
-  if (args2.length === 6 && args2[1] === "create" && args2[2] === "--title" && args2[3]?.length > 0 && args2[4] === "--body" && args2[5]?.length > 0 && !isEmptyShellString(args2[3]) && !isEmptyShellString(args2[5])) {
+  if (args2.length === 6 && args2[1] === "create" && args2[2] === "--title" && (args2[3]?.length ?? 0) > 0 && args2[4] === "--body" && (args2[5]?.length ?? 0) > 0 && !isEmptyShellString(args2[3]) && !isEmptyShellString(args2[5])) {
     return "pr-creation";
   }
   if (args2.length === 3 && args2[1] === "checks" && isPullRequestNumber(args2[2]))
@@ -10726,8 +10732,7 @@ function canonicalPatchText(patchText, sessionLocation) {
   if (patchTextFileTargets(patchText) === undefined)
     return;
   const segments = patchText.split(/(\r?\n)/);
-  for (let index = 0;index < segments.length; index += 1) {
-    const line = segments[index];
+  for (const [index, line] of segments.entries()) {
     if (line === `
 ` || line === `\r
 `)
@@ -11776,6 +11781,15 @@ function createSessionRuntime(options, operationObservers, recoveredOperationCon
     }
     return source;
   }
+  function withoutStaleConditionalMetadata(existingMetadata) {
+    if (!("questionAttestation" in existingMetadata))
+      return existingMetadata;
+    if (existingMetadata.sourceDigest !== currentMarkerSource().source) {
+      return existingMetadata;
+    }
+    const { questionAttestation: _stale, ...rest } = existingMetadata;
+    return rest;
+  }
   function metadata2() {
     const source = currentMarkerSource();
     const result = {
@@ -11821,7 +11835,7 @@ function createSessionRuntime(options, operationObservers, recoveredOperationCon
       output.title = "Workflow unit started";
       output.output = JSON.stringify({ status: "started" });
       output.metadata = {
-        ...existingMetadata,
+        ...withoutStaleConditionalMetadata(existingMetadata),
         ...metadata2(),
         workflowGuard: { status: "started" }
       };
@@ -11834,7 +11848,7 @@ function createSessionRuntime(options, operationObservers, recoveredOperationCon
       reasonCode
     });
     output.metadata = {
-      ...existingMetadata,
+      ...withoutStaleConditionalMetadata(existingMetadata),
       ...metadata2(),
       workflowGuard: {
         status: "rejected",
@@ -11842,46 +11856,49 @@ function createSessionRuntime(options, operationObservers, recoveredOperationCon
       }
     };
   }
-  function writeCompletionResult(output, result, target) {
+  function targetMetadataField(target) {
+    return target ? { target } : {};
+  }
+  function writeSuccessfulCompletionResult(output, target) {
     if (!isRecord7(output))
       return;
     const existingMetadata = isRecord7(output.metadata) ? output.metadata : {};
-    if (result.status === "completed" || result.status === "duplicate") {
-      output.title = "Workflow transition completed";
-      output.output = `workflow guard completed ${target}`;
-      output.metadata = {
-        ...existingMetadata,
-        ...metadata2(),
-        workflowGuard: { status: "completed", target }
-      };
+    output.title = "Workflow transition completed";
+    output.output = `workflow guard completed ${target}`;
+    output.metadata = {
+      ...withoutStaleConditionalMetadata(existingMetadata),
+      ...metadata2(),
+      workflowGuard: { status: "completed", target }
+    };
+  }
+  function writeTerminalCompletionResult(output, result, target) {
+    if (!isRecord7(output))
       return;
-    }
-    const reasonCode = "reasonCode" in result ? result.reasonCode : "guard-unavailable";
-    const resultStatus = result.status === "waiting" ? "unavailable" : result.status;
+    const existingMetadata = isRecord7(output.metadata) ? output.metadata : {};
     output.title = "Workflow transition unavailable";
     output.output = JSON.stringify({
-      status: resultStatus,
-      reasonCode
+      status: result.status,
+      reasonCode: result.reasonCode
     });
     output.metadata = {
-      ...existingMetadata,
+      ...withoutStaleConditionalMetadata(existingMetadata),
       ...metadata2(),
       workflowGuard: {
-        status: resultStatus,
-        target,
-        reasonCode
+        status: result.status,
+        ...targetMetadataField(target),
+        reasonCode: result.reasonCode
       }
     };
   }
   function writeAbandonedCompletionResult(output, target, reasonCode) {
-    writeCompletionResult(output, { target, status: "unavailable", reasonCode }, target);
+    writeTerminalCompletionResult(output, { target, status: "unavailable", reasonCode }, target);
   }
   function writeAbandonedCompletionMetadata(output, target, reasonCode) {
     if (!isRecord7(output))
       return;
     const existingMetadata = isRecord7(output.metadata) ? output.metadata : {};
     output.metadata = {
-      ...existingMetadata,
+      ...withoutStaleConditionalMetadata(existingMetadata),
       ...metadata2(),
       workflowGuard: { status: "unavailable", target, reasonCode }
     };
@@ -12303,6 +12320,13 @@ function createSessionRuntime(options, operationObservers, recoveredOperationCon
         transitionId: pending.transitionId
       });
       writeAbandonedCompletionMetadata(output, pending.target, "failed-operation");
+      abandonedCompletes.set(callDigest, pending.target);
+      terminalCompletes.set(callDigest, {
+        target: pending.target,
+        status: "unavailable",
+        reasonCode: "failed-operation",
+        metadataOnly: true
+      });
       return;
     }
     const result = guard.finalizeTransition({
@@ -12312,7 +12336,7 @@ function createSessionRuntime(options, operationObservers, recoveredOperationCon
     });
     if (result.status === "completed" || result.status === "duplicate") {
       finalizedCompletes.set(callDigest, pending);
-      writeCompletionResult(output, result, pending.target);
+      writeSuccessfulCompletionResult(output, pending.target);
       return;
     }
     markUnavailable();
@@ -12324,7 +12348,14 @@ function createSessionRuntime(options, operationObservers, recoveredOperationCon
     };
     abandonedCompletes.set(callDigest, pending.target);
     terminalCompletes.set(callDigest, terminal);
-    writeCompletionResult(output, terminal, pending.target);
+    writeTerminalCompletionResult(output, terminal, pending.target);
+  }
+  function writeTerminalReplay(output, terminal, target) {
+    if (terminal.metadataOnly) {
+      writeAbandonedCompletionMetadata(output, target, terminal.reasonCode);
+      return;
+    }
+    writeTerminalCompletionResult(output, terminal, target);
   }
   function replayTerminalComplete(callDigest, finalTarget, output) {
     const questionChallengeID = blockedQuestionCalls.get(callDigest);
@@ -12335,10 +12366,15 @@ function createSessionRuntime(options, operationObservers, recoveredOperationCon
         return true;
       }
     }
+    const terminal = terminalCompletes.get(callDigest);
+    if (terminal?.target) {
+      writeTerminalReplay(output, terminal, terminal.target);
+      blockedCompletes.delete(callDigest);
+      return true;
+    }
     const replay = finalizedCompletes.get(callDigest);
     const abandonedTarget = abandonedCompletes.get(callDigest);
     const blockedTarget = blockedCompletes.get(callDigest);
-    const terminal = terminalCompletes.get(callDigest);
     const expectedTarget = replay?.target ?? abandonedTarget ?? blockedTarget;
     if (!expectedTarget)
       return false;
@@ -12348,8 +12384,6 @@ function createSessionRuntime(options, operationObservers, recoveredOperationCon
     }
     if (replay)
       replayComplete(callDigest);
-    if (terminal)
-      writeCompletionResult(output, terminal, expectedTarget);
     blockedCompletes.delete(callDigest);
     return true;
   }
@@ -12458,13 +12492,18 @@ function createSessionRuntime(options, operationObservers, recoveredOperationCon
     return readbacks;
   }
   function finishMismatchedTarget(callDigest, pending, output) {
-    abandonComplete(callDigest, pending, false);
+    abandonComplete(callDigest, pending, true);
+    terminalCompletes.set(callDigest, {
+      target: pending.target,
+      status: "unavailable",
+      reasonCode: "invalid-transition"
+    });
     markUnavailable();
     writeAbandonedCompletionResult(output, pending.target, "invalid-transition");
   }
   function finishUnreplayableComplete(finalTarget, output) {
     markUnavailable();
-    writeAbandonedCompletionResult(output, finalTarget ?? "unit", "guard-unavailable");
+    writeAbandonedCompletionResult(output, finalTarget, "guard-unavailable");
   }
   function finishUnavailableReadback(callDigest, pending, output) {
     abandonComplete(callDigest, pending, true);

package/dist/lib/bundled-names.d.ts

@@ -1,5 +1,5 @@
 export declare const BUNDLED_AGENT_NAMES: readonly ['adversarial-document-reviewer', 'adversarial-reviewer', 'agent-native-reviewer', 'api-contract-reviewer', 'architecture-strategist', 'best-practices-researcher', 'bug-reproduction-validator', 'cli-readiness-reviewer', 'code-simplicity-reviewer', 'coherence-reviewer', 'correctness-reviewer', 'data-migrations-reviewer', 'deployment-verification-agent', 'design-iterator', 'design-lens-reviewer', 'feasibility-reviewer', 'framework-docs-researcher', 'git-history-analyzer', 'issue-intelligence-analyst', 'kieran-typescript-reviewer', 'learnings-researcher', 'maintainability-reviewer', 'pattern-recognition-specialist', 'performance-reviewer', 'pr-comment-resolver', 'previous-comments-reviewer', 'product-lens-reviewer', 'project-standards-reviewer', 'reliability-reviewer', 'repo-research-analyst', 'scope-guardian-reviewer', 'security-lens-reviewer', 'security-reviewer', 'slack-researcher', 'spec-flow-analyzer', 'systematic-implementer', 'testing-reviewer'];
 export declare const BUNDLED_AGENT_QUALIFIED_IDS: readonly ['design/design-iterator', 'document-review/adversarial-document-reviewer', 'document-review/coherence-reviewer', 'document-review/design-lens-reviewer', 'document-review/feasibility-reviewer', 'document-review/product-lens-reviewer', 'document-review/scope-guardian-reviewer', 'document-review/security-lens-reviewer', 'research/best-practices-researcher', 'research/framework-docs-researcher', 'research/git-history-analyzer', 'research/issue-intelligence-analyst', 'research/learnings-researcher', 'research/repo-research-analyst', 'research/slack-researcher', 'review/adversarial-reviewer', 'review/agent-native-reviewer', 'review/api-contract-reviewer', 'review/architecture-strategist', 'review/cli-readiness-reviewer', 'review/code-simplicity-reviewer', 'review/correctness-reviewer', 'review/data-migrations-reviewer', 'review/deployment-verification-agent', 'review/kieran-typescript-reviewer', 'review/maintainability-reviewer', 'review/pattern-recognition-specialist', 'review/performance-reviewer', 'review/previous-comments-reviewer', 'review/project-standards-reviewer', 'review/reliability-reviewer', 'review/security-reviewer', 'review/testing-reviewer', 'workflow/bug-reproduction-validator', 'workflow/pr-comment-resolver', 'workflow/spec-flow-analyzer', 'workflow/systematic-implementer'];
-export declare const BUNDLED_SKILL_NAMES: readonly ['agent-browser', 'agent-native-architecture', 'agent-native-audit', 'ce:brainstorm', 'ce:compound', 'ce:compound-refresh', 'ce:ideate', 'ce:plan', 'ce:review', 'ce:work', 'compound-docs', 'deepen-plan', 'deploy-docs', 'document-review', 'frontend-design', 'git-clean-gone-branches', 'git-commit', 'git-commit-push-pr', 'git-worktree', 'lfg', 'onboarding', 'orchestrating-subagents', 'report-bug-ce', 'reproduce-bug', 'resolve-pr-feedback', 'slfg', 'test-browser', 'test-driven-development', 'todos', 'using-systematic', 'writing-skills'];
+export declare const BUNDLED_SKILL_NAMES: readonly ['agent-browser', 'agent-native-architecture', 'agent-native-audit', 'ce:brainstorm', 'ce:compound', 'ce:compound-refresh', 'ce:ideate', 'ce:plan', 'ce:review', 'ce:review-cleanup', 'ce:work', 'compound-docs', 'deepen-plan', 'deploy-docs', 'document-review', 'frontend-design', 'git-clean-gone-branches', 'git-commit', 'git-commit-push-pr', 'git-worktree', 'lfg', 'onboarding', 'orchestrating-subagents', 'report-bug-ce', 'reproduce-bug', 'resolve-pr-feedback', 'slfg', 'test-browser', 'test-driven-development', 'todos', 'using-systematic', 'writing-skills'];
 export type BundledAgentName = (typeof BUNDLED_AGENT_NAMES)[number];
 export type BundledSkillName = (typeof BUNDLED_SKILL_NAMES)[number];