@fro.bot/systematic 2.33.3 → 3.0.1

package/agents/review/security-sentinel.md

@@ -1,95 +0,0 @@
----
-name: security-sentinel
-description: "Performs security audits for vulnerabilities, input validation, auth/authz, hardcoded secrets, and OWASP compliance. Use when reviewing code for security issues or before deployment."
-tools: Read, Grep, Glob, Bash
-mode: subagent
-temperature: 0.1
----
-
-You are an elite Application Security Specialist with deep expertise in identifying and mitigating security vulnerabilities. You think like an attacker, constantly asking: Where are the vulnerabilities? What could go wrong? How could this be exploited?
-
-Your mission is to perform comprehensive security audits with laser focus on finding and reporting vulnerabilities before they can be exploited.
-
-## Core Security Scanning Protocol
-
-You will systematically execute these security scans:
-
-1. **Input Validation Analysis**
-   - Search for all input points: `grep -r "req\.\(body\|params\|query\)" --include="*.js"`
-   - For Rails projects: `grep -r "params\[" --include="*.rb"`
-   - Verify each input is properly validated and sanitized
-   - Check for type validation, length limits, and format constraints
-
-2. **SQL Injection Risk Assessment**
-   - Scan for raw queries: `grep -r "query\|execute" --include="*.js" | grep -v "?"`
-   - For Rails: Check for raw SQL in models and controllers
-   - Ensure all queries use parameterization or prepared statements
-   - Flag any string concatenation in SQL contexts
-
-3. **XSS Vulnerability Detection**
-   - Identify all output points in views and templates
-   - Check for proper escaping of user-generated content
-   - Verify Content Security Policy headers
-   - Look for dangerous innerHTML or dangerouslySetInnerHTML usage
-
-4. **Authentication & Authorization Audit**
-   - Map all endpoints and verify authentication requirements
-   - Check for proper session management
-   - Verify authorization checks at both route and resource levels
-   - Look for privilege escalation possibilities
-
-5. **Sensitive Data Exposure**
-   - Execute: `grep -r "password\|secret\|key\|token" --include="*.js"`
-   - Scan for hardcoded credentials, API keys, or secrets
-   - Check for sensitive data in logs or error messages
-   - Verify proper encryption for sensitive data at rest and in transit
-
-6. **OWASP Top 10 Compliance**
-   - Systematically check against each OWASP Top 10 vulnerability
-   - Document compliance status for each category
-   - Provide specific remediation steps for any gaps
-
-## Security Requirements Checklist
-
-For every review, you will verify:
-
-- [ ] All inputs validated and sanitized
-- [ ] No hardcoded secrets or credentials
-- [ ] Proper authentication on all endpoints
-- [ ] SQL queries use parameterization
-- [ ] XSS protection implemented
-- [ ] HTTPS enforced where needed
-- [ ] CSRF protection enabled
-- [ ] Security headers properly configured
-- [ ] Error messages don't leak sensitive information
-- [ ] Dependencies are up-to-date and vulnerability-free
-
-## Reporting Protocol
-
-Your security reports will include:
-
-1. **Executive Summary**: High-level risk assessment with severity ratings
-2. **Detailed Findings**: For each vulnerability:
-   - Description of the issue
-   - Potential impact and exploitability
-   - Specific code location
-   - Proof of concept (if applicable)
-   - Remediation recommendations
-3. **Risk Matrix**: Categorize findings by severity (Critical, High, Medium, Low)
-4. **Remediation Roadmap**: Prioritized action items with implementation guidance
-
-## Operational Guidelines
-
-- Always assume the worst-case scenario
-- Test edge cases and unexpected inputs
-- Consider both external and internal threat actors
-- Don't just find problems—provide actionable solutions
-- Use automated tools but verify findings manually
-- Stay current with latest attack vectors and security best practices
-- When reviewing Rails applications, pay special attention to:
-  - Strong parameters usage
-  - CSRF token implementation
-  - Mass assignment vulnerabilities
-  - Unsafe redirects
-
-You are the last line of defense. Be thorough, be paranoid, and leave no stone unturned in your quest to secure the application.

package/agents/workflow/lint.md

@@ -1,17 +0,0 @@
----
-name: lint
-description: Use this agent when you need to run linting and code quality checks on Ruby and ERB files. Run before pushing to origin.
-color: warning
-mode: subagent
-temperature: 0.1
----
-
-Your workflow process:
-
-1. **Initial Assessment**: Determine which checks are needed based on the files changed or the specific request
-2. **Execute Appropriate Tools**:
-   - For Ruby files: `bundle exec standardrb` for checking, `bundle exec standardrb --fix` for auto-fixing
-   - For ERB templates: `bundle exec erblint --lint-all` for checking, `bundle exec erblint --lint-all --autocorrect` for auto-fixing
-   - For security: `bin/brakeman` for vulnerability scanning
-3. **Analyze Results**: Parse tool outputs to identify patterns and prioritize issues
-4. **Take Action**: Commit fixes with `style: linting`

package/dist/lib/converter.d.ts

@@ -1,14 +0,0 @@
-import { type AgentMode } from './validation.js';
-export type ContentType = 'skill' | 'agent' | 'command';
-export type SourceType = 'bundled' | 'external';
-export interface ConvertOptions {
-    source?: SourceType;
-    agentMode?: AgentMode;
-    /** Skip body content transformations (tool names, paths, etc.) */
-    skipBodyTransform?: boolean;
-}
-export declare const CONVERTER_VERSION = 2;
-export declare const TOOL_NAME_MAP: Record<string, string>;
-export declare function convertContent(content: string, type: ContentType, options?: ConvertOptions): string;
-export declare function convertFileWithCache(filePath: string, type: ContentType, options?: ConvertOptions): string;
-export declare function clearConverterCache(): void;

package/skills/andrew-kane-gem-writer/SKILL.md

@@ -1,184 +0,0 @@
----
-name: andrew-kane-gem-writer
-description: This skill should be used when writing Ruby gems following Andrew Kane's proven patterns and philosophy. It applies when creating new Ruby gems, refactoring existing gems, designing gem APIs, or when clean, minimal, production-ready Ruby library code is needed. Triggers on requests like "create a gem", "write a Ruby library", "design a gem API", or mentions of Andrew Kane's style.
----
-
-# Andrew Kane Gem Writer
-
-Write Ruby gems following Andrew Kane's battle-tested patterns from 100+ gems with 374M+ downloads (Searchkick, PgHero, Chartkick, Strong Migrations, Lockbox, Ahoy, Blazer, Groupdate, Neighbor, Blind Index).
-
-## Core Philosophy
-
-**Simplicity over cleverness.** Zero or minimal dependencies. Explicit code over metaprogramming. Rails integration without Rails coupling. Every pattern serves production use cases.
-
-## Entry Point Structure
-
-Every gem follows this exact pattern in `lib/gemname.rb`:
-
-```ruby
-# 1. Dependencies (stdlib preferred)
-require "forwardable"
-
-# 2. Internal modules
-require_relative "gemname/model"
-require_relative "gemname/version"
-
-# 3. Conditional Rails (CRITICAL - never require Rails directly)
-require_relative "gemname/railtie" if defined?(Rails)
-
-# 4. Module with config and errors
-module GemName
-  class Error < StandardError; end
-  class InvalidConfigError < Error; end
-
-  class << self
-    attr_accessor :timeout, :logger
-    attr_writer :client
-  end
-
-  self.timeout = 10  # Defaults set immediately
-end
-```
-
-## Class Macro DSL Pattern
-
-The signature Kane pattern—single method call configures everything:
-
-```ruby
-# Usage
-class Product < ApplicationRecord
-  searchkick word_start: [:name]
-end
-
-# Implementation
-module GemName
-  module Model
-    def gemname(**options)
-      unknown = options.keys - KNOWN_KEYWORDS
-      raise ArgumentError, "unknown keywords: #{unknown.join(", ")}" if unknown.any?
-
-      mod = Module.new
-      mod.module_eval do
-        define_method :some_method do
-          # implementation
-        end unless method_defined?(:some_method)
-      end
-      include mod
-
-      class_eval do
-        cattr_reader :gemname_options, instance_reader: false
-        class_variable_set :@@gemname_options, options.dup
-      end
-    end
-  end
-end
-```
-
-## Rails Integration
-
-**Always use `ActiveSupport.on_load`—never require Rails gems directly:**
-
-```ruby
-# WRONG
-require "active_record"
-ActiveRecord::Base.include(MyGem::Model)
-
-# CORRECT
-ActiveSupport.on_load(:active_record) do
-  extend GemName::Model
-end
-
-# Use prepend for behavior modification
-ActiveSupport.on_load(:active_record) do
-  ActiveRecord::Migration.prepend(GemName::Migration)
-end
-```
-
-## Configuration Pattern
-
-Use `class << self` with `attr_accessor`, not Configuration objects:
-
-```ruby
-module GemName
-  class << self
-    attr_accessor :timeout, :logger
-    attr_writer :master_key
-  end
-
-  def self.master_key
-    @master_key ||= ENV["GEMNAME_MASTER_KEY"]
-  end
-
-  self.timeout = 10
-  self.logger = nil
-end
-```
-
-## Error Handling
-
-Simple hierarchy with informative messages:
-
-```ruby
-module GemName
-  class Error < StandardError; end
-  class ConfigError < Error; end
-  class ValidationError < Error; end
-end
-
-# Validate early with ArgumentError
-def initialize(key:)
-  raise ArgumentError, "Key must be 32 bytes" unless key&.bytesize == 32
-end
-```
-
-## Testing (Minitest Only)
-
-```ruby
-# test/test_helper.rb
-require "bundler/setup"
-Bundler.require(:default)
-require "minitest/autorun"
-require "minitest/pride"
-
-# test/model_test.rb
-class ModelTest < Minitest::Test
-  def test_basic_functionality
-    assert_equal expected, actual
-  end
-end
-```
-
-## Gemspec Pattern
-
-Zero runtime dependencies when possible:
-
-```ruby
-Gem::Specification.new do |spec|
-  spec.name = "gemname"
-  spec.version = GemName::VERSION
-  spec.required_ruby_version = ">= 3.1"
-  spec.files = Dir["*.{md,txt}", "{lib}/**/*"]
-  spec.require_path = "lib"
-  # NO add_dependency lines - dev deps go in Gemfile
-end
-```
-
-## Anti-Patterns to Avoid
-
-- `method_missing` (use `define_method` instead)
-- Configuration objects (use class accessors)
-- `@@class_variables` (use `class << self`)
-- Requiring Rails gems directly
-- Many runtime dependencies
-- Committing Gemfile.lock in gems
-- RSpec (use Minitest)
-- Heavy DSLs (prefer explicit Ruby)
-
-## Reference Files
-
-For deeper patterns, see:
-- `references/module-organization.md` - Directory layouts, method decomposition
-- `references/rails-integration.md` - Railtie, Engine, on_load patterns
-- `references/database-adapters.md` - Multi-database support patterns
-- `references/testing-patterns.md` - Multi-version testing, CI setup
-- `references/resources.md` - Links to Kane's repos and articles

package/skills/andrew-kane-gem-writer/references/database-adapters.md

@@ -1,231 +0,0 @@
-# Database Adapter Patterns
-
-## Abstract Base Class Pattern
-
-```ruby
-# lib/strong_migrations/adapters/abstract_adapter.rb
-module StrongMigrations
-  module Adapters
-    class AbstractAdapter
-      def initialize(checker)
-        @checker = checker
-      end
-
-      def min_version
-        nil
-      end
-
-      def set_statement_timeout(timeout)
-        # no-op by default
-      end
-
-      def check_lock_timeout
-        # no-op by default
-      end
-
-      private
-
-      def connection
-        @checker.send(:connection)
-      end
-
-      def quote(value)
-        connection.quote(value)
-      end
-    end
-  end
-end
-```
-
-## PostgreSQL Adapter
-
-```ruby
-# lib/strong_migrations/adapters/postgresql_adapter.rb
-module StrongMigrations
-  module Adapters
-    class PostgreSQLAdapter < AbstractAdapter
-      def min_version
-        "12"
-      end
-
-      def set_statement_timeout(timeout)
-        select_all("SET statement_timeout = #{timeout.to_i * 1000}")
-      end
-
-      def set_lock_timeout(timeout)
-        select_all("SET lock_timeout = #{timeout.to_i * 1000}")
-      end
-
-      def check_lock_timeout
-        lock_timeout = connection.select_value("SHOW lock_timeout")
-        lock_timeout_sec = timeout_to_sec(lock_timeout)
-        # validation logic
-      end
-
-      private
-
-      def select_all(sql)
-        connection.select_all(sql)
-      end
-
-      def timeout_to_sec(timeout)
-        units = {"us" => 1e-6, "ms" => 1e-3, "s" => 1, "min" => 60}
-        timeout.to_f * (units[timeout.gsub(/\d+/, "")] || 1e-3)
-      end
-    end
-  end
-end
-```
-
-## MySQL Adapter
-
-```ruby
-# lib/strong_migrations/adapters/mysql_adapter.rb
-module StrongMigrations
-  module Adapters
-    class MySQLAdapter < AbstractAdapter
-      def min_version
-        "8.0"
-      end
-
-      def set_statement_timeout(timeout)
-        select_all("SET max_execution_time = #{timeout.to_i * 1000}")
-      end
-
-      def check_lock_timeout
-        lock_timeout = connection.select_value("SELECT @@lock_wait_timeout")
-        # validation logic
-      end
-    end
-  end
-end
-```
-
-## MariaDB Adapter (MySQL variant)
-
-```ruby
-# lib/strong_migrations/adapters/mariadb_adapter.rb
-module StrongMigrations
-  module Adapters
-    class MariaDBAdapter < MySQLAdapter
-      def min_version
-        "10.5"
-      end
-
-      # Override MySQL-specific behavior
-      def set_statement_timeout(timeout)
-        select_all("SET max_statement_time = #{timeout.to_i}")
-      end
-    end
-  end
-end
-```
-
-## Adapter Detection Pattern
-
-Use regex matching on adapter name:
-
-```ruby
-def adapter
-  @adapter ||= case connection.adapter_name
-    when /postg/i
-      Adapters::PostgreSQLAdapter.new(self)
-    when /mysql|trilogy/i
-      if connection.try(:mariadb?)
-        Adapters::MariaDBAdapter.new(self)
-      else
-        Adapters::MySQLAdapter.new(self)
-      end
-    when /sqlite/i
-      Adapters::SQLiteAdapter.new(self)
-    else
-      Adapters::AbstractAdapter.new(self)
-    end
-end
-```
-
-## Multi-Database Support (PgHero pattern)
-
-```ruby
-module PgHero
-  class << self
-    attr_accessor :databases
-  end
-
-  self.databases = {}
-
-  def self.primary_database
-    databases.values.first
-  end
-
-  def self.capture_query_stats(database: nil)
-    db = database ? databases[database] : primary_database
-    db.capture_query_stats
-  end
-
-  class Database
-    attr_reader :id, :config
-
-    def initialize(id, config)
-      @id = id
-      @config = config
-    end
-
-    def connection_model
-      @connection_model ||= begin
-        Class.new(ActiveRecord::Base) do
-          self.abstract_class = true
-        end.tap do |model|
-          model.establish_connection(config)
-        end
-      end
-    end
-
-    def connection
-      connection_model.connection
-    end
-  end
-end
-```
-
-## Connection Switching
-
-```ruby
-def with_connection(database_name)
-  db = databases[database_name.to_s]
-  raise Error, "Unknown database: #{database_name}" unless db
-
-  yield db.connection
-end
-
-# Usage
-PgHero.with_connection(:replica) do |conn|
-  conn.execute("SELECT * FROM users")
-end
-```
-
-## SQL Dialect Handling
-
-```ruby
-def quote_column(column)
-  case adapter_name
-  when /postg/i
-    %("#{column}")
-  when /mysql/i
-    "`#{column}`"
-  else
-    column
-  end
-end
-
-def boolean_value(value)
-  case adapter_name
-  when /postg/i
-    value ? "true" : "false"
-  when /mysql/i
-    value ? "1" : "0"
-  else
-    value.to_s
-  end
-end
-```

package/skills/andrew-kane-gem-writer/references/module-organization.md

@@ -1,121 +0,0 @@
-# Module Organization Patterns
-
-## Simple Gem Layout
-
-```
-lib/
-├── gemname.rb          # Entry point, config, errors
-└── gemname/
-    ├── helper.rb       # Core functionality
-    ├── engine.rb       # Rails engine (if needed)
-    └── version.rb      # VERSION constant only
-```
-
-## Complex Gem Layout (PgHero pattern)
-
-```
-lib/
-├── pghero.rb
-└── pghero/
-    ├── database.rb     # Main class
-    ├── engine.rb       # Rails engine
-    └── methods/        # Functional decomposition
-        ├── basic.rb
-        ├── connections.rb
-        ├── indexes.rb
-        ├── queries.rb
-        └── replication.rb
-```
-
-## Method Decomposition Pattern
-
-Break large classes into includable modules by feature:
-
-```ruby
-# lib/pghero/database.rb
-module PgHero
-  class Database
-    include Methods::Basic
-    include Methods::Connections
-    include Methods::Indexes
-    include Methods::Queries
-  end
-end
-
-# lib/pghero/methods/indexes.rb
-module PgHero
-  module Methods
-    module Indexes
-      def index_hit_rate
-        # implementation
-      end
-
-      def unused_indexes
-        # implementation
-      end
-    end
-  end
-end
-```
-
-## Version File Pattern
-
-Keep version.rb minimal:
-
-```ruby
-# lib/gemname/version.rb
-module GemName
-  VERSION = "2.0.0"
-end
-```
-
-## Require Order in Entry Point
-
-```ruby
-# lib/searchkick.rb
-
-# 1. Standard library
-require "forwardable"
-require "json"
-
-# 2. External dependencies (minimal)
-require "active_support"
-
-# 3. Internal files via require_relative
-require_relative "searchkick/index"
-require_relative "searchkick/model"
-require_relative "searchkick/query"
-require_relative "searchkick/version"
-
-# 4. Conditional Rails loading (LAST)
-require_relative "searchkick/railtie" if defined?(Rails)
-```
-
-## Autoload vs Require
-
-Kane uses explicit `require_relative`, not autoload:
-
-```ruby
-# CORRECT
-require_relative "gemname/model"
-require_relative "gemname/query"
-
-# AVOID
-autoload :Model, "gemname/model"
-autoload :Query, "gemname/query"
-```
-
-## Comments Style
-
-Minimal section headers only:
-
-```ruby
-# dependencies
-require "active_support"
-
-# adapters
-require_relative "adapters/postgresql_adapter"
-
-# modules
-require_relative "migration"
-```