@fro.bot/systematic 1.18.7 → 1.19.0

package/commands/test-xcode.md

@@ -0,0 +1,333 @@
+---
+name: test-xcode
+description: Build and test iOS apps on simulator using XcodeBuildMCP
+argument-hint: '[scheme name or ''current'' to use default]'
+disable-model-invocation: true
+---
+
+# Xcode Test Command
+
+<command_purpose>Build, install, and test iOS apps on the simulator using XcodeBuildMCP. Captures screenshots, logs, and verifies app behavior.</command_purpose>
+
+## Introduction
+
+<role>iOS QA Engineer specializing in simulator-based testing</role>
+
+This command tests iOS/macOS apps by:
+- Building for simulator
+- Installing and launching the app
+- Taking screenshots of key screens
+- Capturing console logs for errors
+- Supporting human verification for external flows
+
+## Prerequisites
+
+<requirements>
+- Xcode installed with command-line tools
+- XcodeBuildMCP server connected
+- Valid Xcode project or workspace
+- At least one iOS Simulator available
+</requirements>
+
+## Main Tasks
+
+### 0. Verify XcodeBuildMCP is Installed
+
+<check_mcp_installed>
+
+**First, check if XcodeBuildMCP tools are available.**
+
+Try calling:
+```
+mcp__xcodebuildmcp__list_simulators({})
+```
+
+**If the tool is not found or errors:**
+
+Tell the user:
+```markdown
+**XcodeBuildMCP not installed**
+
+Please install the XcodeBuildMCP server first:
+
+\`\`\`bash
+claude mcp add XcodeBuildMCP -- npx xcodebuildmcp@latest
+\`\`\`
+
+Then restart OpenCode and run `/xcode-test` again.
+```
+
+**Do NOT proceed** until XcodeBuildMCP is confirmed working.
+
+</check_mcp_installed>
+
+### 1. Discover Project and Scheme
+
+<discover_project>
+
+**Find available projects:**
+```
+mcp__xcodebuildmcp__discover_projs({})
+```
+
+**List schemes for the project:**
+```
+mcp__xcodebuildmcp__list_schemes({ project_path: "/path/to/Project.xcodeproj" })
+```
+
+**If argument provided:**
+- Use the specified scheme name
+- Or "current" to use the default/last-used scheme
+
+</discover_project>
+
+### 2. Boot Simulator
+
+<boot_simulator>
+
+**List available simulators:**
+```
+mcp__xcodebuildmcp__list_simulators({})
+```
+
+**Boot preferred simulator (iPhone 15 Pro recommended):**
+```
+mcp__xcodebuildmcp__boot_simulator({ simulator_id: "[uuid]" })
+```
+
+**Wait for simulator to be ready:**
+Check simulator state before proceeding with installation.
+
+</boot_simulator>
+
+### 3. Build the App
+
+<build_app>
+
+**Build for iOS Simulator:**
+```
+mcp__xcodebuildmcp__build_ios_sim_app({
+  project_path: "/path/to/Project.xcodeproj",
+  scheme: "[scheme_name]"
+})
+```
+
+**Handle build failures:**
+- Capture build errors
+- Create P1 todo for each build error
+- Report to user with specific error details
+
+**On success:**
+- Note the built app path for installation
+- Proceed to installation step
+
+</build_app>
+
+### 4. Install and Launch
+
+<install_launch>
+
+**Install app on simulator:**
+```
+mcp__xcodebuildmcp__install_app_on_simulator({
+  app_path: "/path/to/built/App.app",
+  simulator_id: "[uuid]"
+})
+```
+
+**Launch the app:**
+```
+mcp__xcodebuildmcp__launch_app_on_simulator({
+  bundle_id: "[app.bundle.id]",
+  simulator_id: "[uuid]"
+})
+```
+
+**Start capturing logs:**
+```
+mcp__xcodebuildmcp__capture_sim_logs({
+  simulator_id: "[uuid]",
+  bundle_id: "[app.bundle.id]"
+})
+```
+
+</install_launch>
+
+### 5. Test Key Screens
+
+<test_screens>
+
+For each key screen in the app:
+
+**Take screenshot:**
+```
+mcp__xcodebuildmcp__take_screenshot({
+  simulator_id: "[uuid]",
+  filename: "screen-[name].png"
+})
+```
+
+**Review screenshot for:**
+- UI elements rendered correctly
+- No error messages visible
+- Expected content displayed
+- Layout looks correct
+
+**Check logs for errors:**
+```
+mcp__xcodebuildmcp__get_sim_logs({ simulator_id: "[uuid]" })
+```
+
+Look for:
+- Crashes
+- Exceptions
+- Error-level log messages
+- Failed network requests
+
+</test_screens>
+
+### 6. Human Verification (When Required)
+
+<human_verification>
+
+Pause for human input when testing touches:
+
+| Flow Type | What to Ask |
+|-----------|-------------|
+| Sign in with Apple | "Please complete Sign in with Apple on the simulator" |
+| Push notifications | "Send a test push and confirm it appears" |
+| In-app purchases | "Complete a sandbox purchase" |
+| Camera/Photos | "Grant permissions and verify camera works" |
+| Location | "Allow location access and verify map updates" |
+
+Use question:
+```markdown
+**Human Verification Needed**
+
+This test requires [flow type]. Please:
+1. [Action to take on simulator]
+2. [What to verify]
+
+Did it work correctly?
+1. Yes - continue testing
+2. No - describe the issue
+```
+
+</human_verification>
+
+### 7. Handle Failures
+
+<failure_handling>
+
+When a test fails:
+
+1. **Document the failure:**
+   - Take screenshot of error state
+   - Capture console logs
+   - Note reproduction steps
+
+2. **Ask user how to proceed:**
+   ```markdown
+   **Test Failed: [screen/feature]**
+
+   Issue: [description]
+   Logs: [relevant error messages]
+
+   How to proceed?
+   1. Fix now - I'll help debug and fix
+   2. Create todo - Add to todos/ for later
+   3. Skip - Continue testing other screens
+   ```
+
+3. **If "Fix now":**
+   - Investigate the issue in code
+   - Propose a fix
+   - Rebuild and retest
+
+4. **If "Create todo":**
+   - Create `{id}-pending-p1-xcode-{description}.md`
+   - Continue testing
+
+</failure_handling>
+
+### 8. Test Summary
+
+<test_summary>
+
+After all tests complete, present summary:
+
+```markdown
+## 📱 Xcode Test Results
+
+**Project:** [project name]
+**Scheme:** [scheme name]
+**Simulator:** [simulator name]
+
+### Build: ✅ Success / ❌ Failed
+
+### Screens Tested: [count]
+
+| Screen | Status | Notes |
+|--------|--------|-------|
+| Launch | ✅ Pass | |
+| Home | ✅ Pass | |
+| Settings | ❌ Fail | Crash on tap |
+| Profile | ⏭️ Skip | Requires login |
+
+### Console Errors: [count]
+- [List any errors found]
+
+### Human Verifications: [count]
+- Sign in with Apple: ✅ Confirmed
+- Push notifications: ✅ Confirmed
+
+### Failures: [count]
+- Settings screen - crash on navigation
+
+### Created Todos: [count]
+- `006-pending-p1-xcode-settings-crash.md`
+
+### Result: [PASS / FAIL / PARTIAL]
+```
+
+</test_summary>
+
+### 9. Cleanup
+
+<cleanup>
+
+After testing:
+
+**Stop log capture:**
+```
+mcp__xcodebuildmcp__stop_log_capture({ simulator_id: "[uuid]" })
+```
+
+**Optionally shut down simulator:**
+```
+mcp__xcodebuildmcp__shutdown_simulator({ simulator_id: "[uuid]" })
+```
+
+</cleanup>
+
+## Quick Usage Examples
+
+```bash
+# Test with default scheme
+/xcode-test
+
+# Test specific scheme
+/xcode-test MyApp-Debug
+
+# Test after making changes
+/xcode-test current
+```
+
+## Integration with /workflows:review
+
+When reviewing PRs that touch iOS code, the `/workflows:review` command can spawn this as a subagent:
+
+```
+Task general-purpose("Run /xcode-test for scheme [name]. Build, install on simulator, test key screens, check for crashes.")
+```
+

package/commands/triage.md

@@ -0,0 +1,311 @@
+---
+name: triage
+description: Triage and categorize findings for the CLI todo system
+argument-hint: '[findings list or source type]'
+disable-model-invocation: true
+---
+
+- First set the /model to Haiku
+- Then read all pending todos in the todos/ directory
+
+Present all findings, decisions, or issues here one by one for triage. The goal is to go through each item and decide whether to add it to the CLI todo system.
+
+**IMPORTANT: DO NOT CODE ANYTHING DURING TRIAGE!**
+
+This command is for:
+
+- Triaging code review findings
+- Processing security audit results
+- Reviewing performance analysis
+- Handling any other categorized findings that need tracking
+
+## Workflow
+
+### Step 1: Present Each Finding
+
+For each finding, present in this format:
+
+```
+---
+Issue #X: [Brief Title]
+
+Severity: 🔴 P1 (CRITICAL) / 🟡 P2 (IMPORTANT) / 🔵 P3 (NICE-TO-HAVE)
+
+Category: [Security/Performance/Architecture/Bug/Feature/etc.]
+
+Description:
+[Detailed explanation of the issue or improvement]
+
+Location: [file_path:line_number]
+
+Problem Scenario:
+[Step by step what's wrong or could happen]
+
+Proposed Solution:
+[How to fix it]
+
+Estimated Effort: [Small (< 2 hours) / Medium (2-8 hours) / Large (> 8 hours)]
+
+---
+Do you want to add this to the todo list?
+1. yes - create todo file
+2. next - skip this item
+3. custom - modify before creating
+```
+
+### Step 2: Handle User Decision
+
+**When user says "yes":**
+
+1. **Update existing todo file** (if it exists) or **Create new filename:**
+
+   If todo already exists (from code review):
+
+   - Rename file from `{id}-pending-{priority}-{desc}.md` → `{id}-ready-{priority}-{desc}.md`
+   - Update YAML frontmatter: `status: pending` → `status: ready`
+   - Keep issue_id, priority, and description unchanged
+
+   If creating new todo:
+
+   ```
+   {next_id}-ready-{priority}-{brief-description}.md
+   ```
+
+   Priority mapping:
+
+   - 🔴 P1 (CRITICAL) → `p1`
+   - 🟡 P2 (IMPORTANT) → `p2`
+   - 🔵 P3 (NICE-TO-HAVE) → `p3`
+
+   Example: `042-ready-p1-transaction-boundaries.md`
+
+2. **Update YAML frontmatter:**
+
+   ```yaml
+   ---
+   status: ready # IMPORTANT: Change from "pending" to "ready"
+   priority: p1 # or p2, p3 based on severity
+   issue_id: "042"
+   tags: [category, relevant-tags]
+   dependencies: []
+   ---
+   ```
+
+3. **Populate or update the file:**
+
+   ```yaml
+   # [Issue Title]
+
+   ## Problem Statement
+   [Description from finding]
+
+   ## Findings
+   - [Key discoveries]
+   - Location: [file_path:line_number]
+   - [Scenario details]
+
+   ## Proposed Solutions
+
+   ### Option 1: [Primary solution]
+   - **Pros**: [Benefits]
+   - **Cons**: [Drawbacks if any]
+   - **Effort**: [Small/Medium/Large]
+   - **Risk**: [Low/Medium/High]
+
+   ## Recommended Action
+   [Filled during triage - specific action plan]
+
+   ## Technical Details
+   - **Affected Files**: [List files]
+   - **Related Components**: [Components affected]
+   - **Database Changes**: [Yes/No - describe if yes]
+
+   ## Resources
+   - Original finding: [Source of this issue]
+   - Related issues: [If any]
+
+   ## Acceptance Criteria
+   - [ ] [Specific success criteria]
+   - [ ] Tests pass
+   - [ ] Code reviewed
+
+   ## Work Log
+
+   ### {date} - Approved for Work
+   **By:** Systematic Triage System
+   **Actions:**
+   - Issue approved during triage session
+   - Status changed from pending → ready
+   - Ready to be picked up and worked on
+
+   **Learnings:**
+   - [Context and insights]
+
+   ## Notes
+   Source: Triage session on {date}
+   ```
+
+4. **Confirm approval:** "✅ Approved: `{new_filename}` (Issue #{issue_id}) - Status: **ready** → Ready to work on"
+
+**When user says "next":**
+
+- **Delete the todo file** - Remove it from todos/ directory since it's not relevant
+- Skip to the next item
+- Track skipped items for summary
+
+**When user says "custom":**
+
+- Ask what to modify (priority, description, details)
+- Update the information
+- Present revised version
+- Ask again: yes/next/custom
+
+### Step 3: Continue Until All Processed
+
+- Process all items one by one
+- Track using todowrite for visibility
+- Don't wait for approval between items - keep moving
+
+### Step 4: Final Summary
+
+After all items processed:
+
+````markdown
+## Triage Complete
+
+**Total Items:** [X] **Todos Approved (ready):** [Y] **Skipped:** [Z]
+
+### Approved Todos (Ready for Work):
+
+- `042-ready-p1-transaction-boundaries.md` - Transaction boundary issue
+- `043-ready-p2-cache-optimization.md` - Cache performance improvement ...
+
+### Skipped Items (Deleted):
+
+- Item #5: [reason] - Removed from todos/
+- Item #12: [reason] - Removed from todos/
+
+### Summary of Changes Made:
+
+During triage, the following status updates occurred:
+
+- **Pending → Ready:** Filenames and frontmatter updated to reflect approved status
+- **Deleted:** Todo files for skipped findings removed from todos/ directory
+- Each approved file now has `status: ready` in YAML frontmatter
+
+### Next Steps:
+
+1. View approved todos ready for work:
+   ```bash
+   ls todos/*-ready-*.md
+   ```
+````
+
+2. Start work on approved items:
+
+   ```bash
+   /resolve_todo_parallel  # Work on multiple approved items efficiently
+   ```
+
+3. Or pick individual items to work on
+
+4. As you work, update todo status:
+   - Ready → In Progress (in your local context as you work)
+   - In Progress → Complete (rename file: ready → complete, update frontmatter)
+
+```
+
+## Example Response Format
+
+```
+
+---
+
+Issue #5: Missing Transaction Boundaries for Multi-Step Operations
+
+Severity: 🔴 P1 (CRITICAL)
+
+Category: Data Integrity / Security
+
+Description: The google_oauth2_connected callback in GoogleOauthCallbacks concern performs multiple database operations without transaction protection. If any step fails midway, the database is left in an inconsistent state.
+
+Location: app/controllers/concerns/google_oauth_callbacks.rb:13-50
+
+Problem Scenario:
+
+1. User.update succeeds (email changed)
+2. Account.save! fails (validation error)
+3. Result: User has changed email but no associated Account
+4. Next login attempt fails completely
+
+Operations Without Transaction:
+
+- User confirmation (line 13)
+- Waitlist removal (line 14)
+- User profile update (line 21-23)
+- Account creation (line 28-37)
+- Avatar attachment (line 39-45)
+- Journey creation (line 47)
+
+Proposed Solution: Wrap all operations in ApplicationRecord.transaction do ... end block
+
+Estimated Effort: Small (30 minutes)
+
+---
+
+Do you want to add this to the todo list?
+
+1. yes - create todo file
+2. next - skip this item
+3. custom - modify before creating
+
+```
+
+## Important Implementation Details
+
+### Status Transitions During Triage
+
+**When "yes" is selected:**
+1. Rename file: `{id}-pending-{priority}-{desc}.md` → `{id}-ready-{priority}-{desc}.md`
+2. Update YAML frontmatter: `status: pending` → `status: ready`
+3. Update Work Log with triage approval entry
+4. Confirm: "✅ Approved: `{filename}` (Issue #{issue_id}) - Status: **ready**"
+
+**When "next" is selected:**
+1. Delete the todo file from todos/ directory
+2. Skip to next item
+3. No file remains in the system
+
+### Progress Tracking
+
+Every time you present a todo as a header, include:
+- **Progress:** X/Y completed (e.g., "3/10 completed")
+- **Estimated time remaining:** Based on how quickly you're progressing
+- **Pacing:** Monitor time per finding and adjust estimate accordingly
+
+Example:
+```
+
+Progress: 3/10 completed | Estimated time: ~2 minutes remaining
+
+```
+
+### Do Not Code During Triage
+
+- ✅ Present findings
+- ✅ Make yes/next/custom decisions
+- ✅ Update todo files (rename, frontmatter, work log)
+- ❌ Do NOT implement fixes or write code
+- ❌ Do NOT add detailed implementation details
+- ❌ That's for /resolve_todo_parallel phase
+```
+
+When done give these options
+
+```markdown
+What would you like to do next?
+
+1. run /resolve_todo_parallel to resolve the todos
+2. commit the todos
+3. nothing, go chill
+```

package/commands/workflows/brainstorm.md

@@ -78,6 +78,8 @@ Write a brainstorm document to `docs/brainstorms/YYYY-MM-DD-<topic>-brainstorm.m
 
 Ensure `docs/brainstorms/` directory exists before writing.
 
+**IMPORTANT:** Before proceeding to Phase 4, check if there are any Open Questions listed in the brainstorm document. If there are open questions, YOU MUST ask the user about each one using question before offering to proceed to planning. Move resolved questions to a "Resolved Questions" section.
+
 ### Phase 4: Handoff
 
 Use the **question tool** to present next steps:
@@ -87,7 +89,10 @@ Use the **question tool** to present next steps:
 **Options:**
 1. **Review and refine** - Improve the document through structured self-review
 2. **Proceed to planning** - Run `/workflows:plan` (will auto-detect this brainstorm)
-3. **Done for now** - Return later
+3. **Ask more questions** - I have more questions to clarify before moving on
+4. **Done for now** - Return later
+
+**If user selects "Ask more questions":** Return to Phase 1.2 (Collaborative Dialogue) and continue asking the USER questions one at a time to further refine the design. Probe deeper - ask about edge cases, constraints, preferences, or areas not yet explored. Continue until the user is satisfied, then return to Phase 4.
 
 **If user selects "Review and refine":**
 

package/commands/workflows/compound.md

@@ -1,7 +1,7 @@
 ---
 name: workflows:compound
 description: Document a recently solved problem to compound your team's knowledge
-argument-hint: "[optional: brief context about the fix]"
+argument-hint: '[optional: brief context about the fix]'
 ---
 
 # /compound
@@ -142,27 +142,29 @@ Based on problem type, optionally invoke specialized agents to review the docume
 
 ## Common Mistakes to Avoid
 
-| Wrong | Correct |
-|----------|-----------:|
+| ❌ Wrong | ✅ Correct |
+|----------|-----------|
 | Subagents write files like `context-analysis.md`, `solution-draft.md` | Subagents return text data; orchestrator writes one final file |
-| Research and assembly run in parallel | Research completes, then assembly runs |
+| Research and assembly run in parallel | Research completes → then assembly runs |
 | Multiple files created during workflow | Single file: `docs/solutions/[category]/[filename].md` |
 
 ## Success Output
 
 ```
+✓ Documentation complete
+
 Subagent Results:
-  Context Analyzer: Identified performance_issue in brief_system
-  Solution Extractor: 3 code fixes
-  Related Docs Finder: 2 related issues
-  Prevention Strategist: Prevention strategies, test suggestions
-  Category Classifier: `performance-issues`
+  ✓ Context Analyzer: Identified performance_issue in brief_system
+  ✓ Solution Extractor: 3 code fixes
+  ✓ Related Docs Finder: 2 related issues
+  ✓ Prevention Strategist: Prevention strategies, test suggestions
+  ✓ Category Classifier: `performance-issues`
 
 Specialized Agent Reviews (Auto-Triggered):
-  performance-oracle: Validated query optimization approach
-  kieran-rails-reviewer: Code examples meet Rails standards
-  code-simplicity-reviewer: Solution is appropriately minimal
-  every-style-editor: Documentation style verified
+  ✓ performance-oracle: Validated query optimization approach
+  ✓ kieran-rails-reviewer: Code examples meet Rails standards
+  ✓ code-simplicity-reviewer: Solution is appropriately minimal
+  ✓ every-style-editor: Documentation style verified
 
 File created:
 - docs/solutions/performance-issues/n-plus-one-brief-generation.md
@@ -230,6 +232,7 @@ Based on problem type, these agents can enhance documentation:
 ### When to Invoke
 - **Auto-triggered** (optional): Agents can run post-documentation for enhancement
 - **Manual trigger**: User can invoke agents after /workflows:compound completes for deeper review
+- **Customize agents**: Edit `systematic.local.md` or invoke the `setup` skill to configure which review agents are used across all workflows
 
 ## Related Commands