@frihet/mcp-server 1.16.6 → 2.0.0

package/dist/tools/impuesto_sociedades.js

@@ -5,63 +5,42 @@
  *   1. frihet_modelo_200_summary — Modelo 200 IS anual (annual corporate tax return)
  *   2. frihet_modelo_202_summary — Modelo 202 IS pagos fraccionados (3 installment payments)
  *
- * REST surface: /v1/is/* — service-layer reads of workspace IS data.
- *   Backend callables: #392 Modelo 200/202 IS (Frihet-ERP PR #392).
- *   Tools surface 404 until REST shell ships.
+ * REST surface: Frihet-ERP functions/src/publicApi.ts has NO /v1/is/* route,
+ * so both tools return NOT_DEPLOYED without calling (capability truth:
+ * `unavailable`, src/capability-truth.ts).
  *
  * Scope: Spanish SLs (Sociedad Limitada) and SAs filing corporate tax with AEAT.
- * Canary Islands variant: same models apply; ATC collects IS with territorial adjustments.
  */
 import { z } from "zod/v4";
-import { withToolLogging, formatRecord, getContent, openObjectOutput, READ_ONLY_ANNOTATIONS, } from "./shared.js";
-import { withBackendGuard } from "./backend-availability.js";
-export function registerImpuestoSociedadesTools(server, client) {
+import { withToolLogging, openObjectOutput, READ_ONLY_ANNOTATIONS, } from "./shared.js";
+import { notDeployedError } from "./backend-availability.js";
+export function registerImpuestoSociedadesTools(server, _client) {
     // -- frihet_modelo_200_summary -------------------------------------------
     server.registerTool("frihet_modelo_200_summary", {
         title: "Get Modelo 200 Summary (Corporate Tax — Annual IS)",
-        description: "Get Modelo 200 summary — annual corporate income tax return (Impuesto sobre Sociedades) " +
-            "for Spanish SLs and SAs. Returns taxable base, deductions, tax rate, withholdings, " +
-            "installment payments made (M202), and net payable/refundable. " +
-            "Filing deadline: 25 days after 6 months from fiscal year end (typically 25 July for Dec FY). " +
-            "Example: year='2025'. " +
-            "/ Resumen Modelo 200 — declaracion anual del Impuesto sobre Sociedades para SL/SA. " +
-            "Devuelve base imponible, deducciones, tipo, retenciones, pagos fraccionados y cuota.",
+        description: "NOT DEPLOYED: Modelo 200 (annual corporate income tax return, Impuesto sobre Sociedades) has no Frihet backend yet; " +
+            "calling this tool returns a NOT_DEPLOYED error and never data. " +
+            "/ NO DESPLEGADO: el Modelo 200 (declaracion anual del Impuesto sobre Sociedades) aun no tiene backend en Frihet; " +
+            "devuelve un error NOT_DEPLOYED y nunca datos.",
         annotations: READ_ONLY_ANNOTATIONS,
         inputSchema: {
             year: z.string().optional().describe("Fiscal year (e.g. '2025', defaults to last closed year) / Ejercicio fiscal (ej. '2025', por defecto ultimo ejercicio cerrado)"),
         },
         outputSchema: openObjectOutput("Modelo 200 annual corporate tax summary: taxable base, deductions, rate, net payable / Resumen anual IS: base, deducciones, tipo, cuota"),
-    }, async ({ year }) => withToolLogging("frihet_modelo_200_summary", () => withBackendGuard("frihet_modelo_200_summary", "/v1/is/200", async () => {
-        const result = await client.getISSummary("200", { year });
-        return {
-            content: [getContent(formatRecord("Modelo 200 Summary (IS Anual)", result))],
-            structuredContent: result,
-        };
-    })));
+    }, async () => withToolLogging("frihet_modelo_200_summary", async () => notDeployedError("frihet_modelo_200_summary", "/v1/is/modelo/200")));
     // -- frihet_modelo_202_summary -------------------------------------------
     server.registerTool("frihet_modelo_202_summary", {
         title: "Get Modelo 202 Summary (Corporate Tax — Installment Payments)",
-        description: "Get Modelo 202 summary — installment payments (pagos fraccionados) for Impuesto sobre Sociedades. " +
-            "Three annual payments: April (1P), October (2P), December (3P). " +
-            "Returns each installment amount, due date, payment status, and cumulative total vs M200 projection. " +
-            "Example: year='2026', installment='1P'. " +
-            "/ Resumen Modelo 202 — pagos fraccionados del Impuesto sobre Sociedades. " +
-            "Tres plazos: abril (1P), octubre (2P), diciembre (3P). Devuelve importes, plazos y estado de pago.",
+        description: "NOT DEPLOYED: Modelo 202 (Impuesto sobre Sociedades installment payments, 1P/2P/3P) has no Frihet backend yet; " +
+            "calling this tool returns a NOT_DEPLOYED error and never data. " +
+            "/ NO DESPLEGADO: el Modelo 202 (pagos fraccionados del Impuesto sobre Sociedades) aun no tiene backend en Frihet; " +
+            "devuelve un error NOT_DEPLOYED y nunca datos.",
         annotations: READ_ONLY_ANNOTATIONS,
         inputSchema: {
             year: z.string().optional().describe("Fiscal year of the installments (e.g. '2026') / Ejercicio de los pagos fraccionados (ej. '2026')"),
             installment: z.enum(["1P", "2P", "3P"]).optional().describe("Specific installment (1P=April, 2P=October, 3P=December) or omit for all three / Plazo especifico (1P=abril, 2P=octubre, 3P=diciembre) u omitir para los tres"),
         },
         outputSchema: openObjectOutput("Modelo 202 installment payments: amounts, due dates, payment status / Pagos fraccionados Modelo 202: importes, plazos, estado"),
-    }, async ({ year, installment }) => withToolLogging("frihet_modelo_202_summary", () => withBackendGuard("frihet_modelo_202_summary", "/v1/is/202", async () => {
-        const result = await client.getISSummary("202", { year, installment });
-        const label = installment
-            ? `Modelo 202 Summary (${installment} ${year ?? ""})`
-            : `Modelo 202 Summary (all installments ${year ?? ""})`;
-        return {
-            content: [getContent(formatRecord(label.trim(), result))],
-            structuredContent: result,
-        };
-    })));
+    }, async () => withToolLogging("frihet_modelo_202_summary", async () => notDeployedError("frihet_modelo_202_summary", "/v1/is/modelo/202")));
 }
 //# sourceMappingURL=impuesto_sociedades.js.map

package/dist/tools/intelligence.js

@@ -66,7 +66,7 @@ const businessContextOutput = z.object({
         invoiceCount: z.number(),
         expenseCount: z.number(),
     }).passthrough(),
-}).passthrough().describe("Business context snapshot: workspace profile, fiscal setup, plan usage, recent activity and current-month performance");
+}).passthrough().describe("Business context snapshot: workspace profile, defaults, plan usage, recent activity and current-month performance");
 const monthlySummaryOutput = z.object({
     period: z.string(),
     revenue: z.object({
@@ -101,7 +101,7 @@ const monthlySummaryOutput = z.object({
         irpfRetained: z.number(),
         estimatedModel303: z.number(),
     }).passthrough(),
-}).passthrough().describe("Monthly financial summary with revenue, expenses, profit, invoice status, top clients and estimated tax liability");
+}).passthrough().describe("Monthly business summary with revenue, expenses, profit, invoice status, top clients and expense categories");
 export function registerIntelligenceTools(server, client) {
     // -- get_business_context --
     server.registerTool("get_business_context", {
@@ -194,14 +194,40 @@ export function registerIntelligenceTools(server, client) {
         },
         outputSchema: invoiceItemOutput.describe("The newly created draft invoice, cloned from the original / La nueva factura borrador, clonada de la original"),
     }, async ({ id, newIssueDate, newDueDate }) => withToolLogging("duplicate_invoice", async () => {
-        // 1. Fetch the original invoice (returns the FULL raw stored document —
-        //    payments, verifactu, eInvoice, operationType, createdBy, etc.)
+        // 1. Validate caller-supplied newIssueDate before touching the API.
+        if (newIssueDate !== undefined) {
+            const match = /^(\d{4})-(\d{2})-(\d{2})$/.exec(newIssueDate);
+            const validCalendar = (() => {
+                if (!match)
+                    return false;
+                const y = Number(match[1]);
+                const m = Number(match[2]);
+                const d = Number(match[3]);
+                if (m < 1 || m > 12 || d < 1 || d > 31)
+                    return false;
+                const dt = new Date(Date.UTC(y, m - 1, d));
+                return dt.getUTCFullYear() === y && dt.getUTCMonth() === m - 1 && dt.getUTCDate() === d;
+            })();
+            if (!validCalendar) {
+                return {
+                    content: [
+                        {
+                            type: "text",
+                            text: `Error: invalid newIssueDate "${newIssueDate}". Use a real calendar date in YYYY-MM-DD format.`,
+                        },
+                    ],
+                    isError: true,
+                };
+            }
+        }
+        // 2. Fetch the original invoice (returns the FULL raw stored document —
+        //    payments, verifactu, eInvoice, createdBy, etc.)
         const original = await client.getInvoice(id);
-        // 2. Allowlist-PICK only the fields the create endpoint actually accepts.
+        // 3. Allowlist-PICK only the fields the create endpoint actually accepts.
         //    The create POST validates against a Zod `.strict()` schema that
         //    REJECTS unknown keys (HTTP 400). Spreading the raw GET doc and only
         //    blacklisting a handful of fields left stored-only fields (payments,
-        //    amountPaid, verifactu, eInvoice, operationType, poNumber, createdBy,
+        //    amountPaid, verifactu, eInvoice, createdBy,
         //    sentTo/sentAt, cancelled*, attachments, …) in the body, so any paid /
         //    sent / cancelled / e-invoiced invoice failed to duplicate. Picking
         //    the writable subset mirrors the create schema and never 400s.
@@ -220,23 +246,151 @@ export function registerIntelligenceTools(server, client) {
             "irpfRate",
             "equivalenceSurchargeRate",
             "clientLocation",
+            "operationType",
+            "fiscalTreatment",
             "prepayment",
             "seriesId",
         ];
-        // 3. Build the duplicate from the writable subset + new values.
+        const ALLOWED_ADDRESS_KEYS = [
+            "street",
+            "city",
+            "zip",
+            "province",
+            "country",
+            "countryCode",
+            "state",
+            "postalCode",
+        ];
+        // 4. Build the duplicate from the writable subset + new values.
+        //    Note: Firestore documents frequently store `null` for unset optional
+        //    fields (e.g. `notes: null`, `seriesId: null`, `clientTaxId: null`), and
+        //    stored `items` often carry computed/UI keys (`total`, `taxRate`,
+        //    `discount`, `productId`) that `invoiceItemSchema.strict()` rejects.
+        //    Economic integrity invariant: NEVER fabricate `0` when `quantity` or
+        //    `unitPrice` is missing, null, non-finite, or invalid. Preserve `0` only
+        //    when it is an explicit finite number (or explicit numeric string).
+        const parseExplicitFiniteNumber = (raw) => {
+            if (typeof raw === "number") {
+                return Number.isFinite(raw) ? raw : undefined;
+            }
+            if (typeof raw === "string") {
+                const trimmed = raw.trim();
+                if (trimmed === "")
+                    return undefined;
+                const parsed = Number(trimmed);
+                return Number.isFinite(parsed) ? parsed : undefined;
+            }
+            return undefined;
+        };
+        if (typeof original.clientName !== "string" || !original.clientName.trim()) {
+            return {
+                content: [{
+                        type: "text",
+                        text: "Error: cannot duplicate invoice because it is missing a valid clientName. / Error: no se puede duplicar la factura porque falta el nombre del cliente.",
+                    }],
+                isError: true,
+            };
+        }
+        if (!Array.isArray(original.items) || original.items.length === 0) {
+            return {
+                content: [{
+                        type: "text",
+                        text: "Error: cannot duplicate invoice because it has no valid line items. / Error: no se puede duplicar la factura porque no tiene lineas validas.",
+                    }],
+                isError: true,
+            };
+        }
+        const sanitizedItems = [];
+        for (let i = 0; i < original.items.length; i++) {
+            const rawItem = original.items[i];
+            if (!rawItem || typeof rawItem !== "object" || Array.isArray(rawItem)) {
+                return {
+                    content: [{
+                            type: "text",
+                            text: `Error: cannot duplicate invoice: line item ${i + 1} is not a valid object. / Error: no se puede duplicar la factura: la linea ${i + 1} es invalida.`,
+                        }],
+                    isError: true,
+                };
+            }
+            const itemObj = rawItem;
+            const description = typeof itemObj.description === "string" ? itemObj.description.trim() : "";
+            if (!description) {
+                return {
+                    content: [{
+                            type: "text",
+                            text: `Error: cannot duplicate invoice: line item ${i + 1} is missing a description. / Error: no se puede duplicar la factura: falta la descripcion en la linea ${i + 1}.`,
+                        }],
+                    isError: true,
+                };
+            }
+            const quantity = parseExplicitFiniteNumber(itemObj.quantity);
+            if (quantity === undefined) {
+                return {
+                    content: [{
+                            type: "text",
+                            text: `Error: cannot duplicate invoice: line item ${i + 1} has a missing or invalid quantity. Refusing to fabricate economic values. / Error: no se puede duplicar la factura: la linea ${i + 1} carece de cantidad valida.`,
+                        }],
+                    isError: true,
+                };
+            }
+            const unitPrice = parseExplicitFiniteNumber(itemObj.unitPrice);
+            if (unitPrice === undefined) {
+                return {
+                    content: [{
+                            type: "text",
+                            text: `Error: cannot duplicate invoice: line item ${i + 1} has a missing or invalid unitPrice. Refusing to fabricate economic values. / Error: no se puede duplicar la factura: la linea ${i + 1} carece de precio unitario valido.`,
+                        }],
+                    isError: true,
+                };
+            }
+            sanitizedItems.push({
+                ...(typeof itemObj.id === "string" && itemObj.id.trim() ? { id: itemObj.id.trim() } : {}),
+                description: itemObj.description,
+                quantity,
+                unitPrice,
+            });
+        }
         const today = new Date().toISOString().split("T")[0];
-        const invoiceData = {};
+        const invoiceData = {
+            clientName: original.clientName,
+            items: sanitizedItems,
+        };
         for (const field of COPYABLE_INVOICE_FIELDS) {
-            if (original[field] !== undefined)
-                invoiceData[field] = original[field];
+            if (field === "items")
+                continue;
+            const val = original[field];
+            if (val === undefined || val === null || val === "")
+                continue;
+            if (field === "clientAddress" && typeof val === "object" && !Array.isArray(val)) {
+                const addrObj = val;
+                const cleanAddr = {};
+                for (const k of ALLOWED_ADDRESS_KEYS) {
+                    if (typeof addrObj[k] === "string" && addrObj[k].trim()) {
+                        cleanAddr[k] = addrObj[k].trim();
+                    }
+                }
+                if (Object.keys(cleanAddr).length > 0) {
+                    invoiceData.clientAddress = cleanAddr;
+                }
+                continue;
+            }
+            invoiceData[field] = val;
         }
         invoiceData.status = "draft";
         invoiceData.issueDate = newIssueDate || today;
         if (newDueDate) {
             invoiceData.dueDate = newDueDate;
         }
-        // 4. Create the duplicate
-        const result = await client.createInvoice(invoiceData);
+        // 5. Create the duplicate (always as draft, never issued or sent)
+        const rawResult = await client.createInvoice(invoiceData);
+        const result = {
+            ...(rawResult && typeof rawResult === "object" ? rawResult : {}),
+        };
+        for (const nullableField of ["clientId", "issueDate", "dueDate", "status", "notes", "createdAt", "updatedAt"]) {
+            if (result[nullableField] === null) {
+                delete result[nullableField];
+            }
+        }
         return {
             content: [
                 mutateContent(formatRecord("Invoice duplicated", result) +