@friggframework/devtools 2.0.0--canary.656.4fb07b4.0 → 2.0.0--canary.657.6a81b60.0

package/infrastructure/domains/integration/integration-builder.test.js

@@ -10,6 +10,8 @@ const {
 } = require('@friggframework/core/queues/queue-delivery');
 const { IntegrationBuilder } = require('./integration-builder');
 const { ValidationResult } = require('../shared/base-builder');
+const { BuilderOrchestrator } = require('../shared/builder-orchestrator');
+const { SchedulerBuilder } = require('../scheduler/scheduler-builder');
 
 describe('IntegrationBuilder', () => {
     let integrationBuilder;
@@ -259,6 +261,37 @@ describe('IntegrationBuilder', () => {
             ).toBeUndefined();
         });
 
+        it('adds no resource, function or env var when no module declares rateLimit', async () => {
+            class Api {}
+            const { merged } = await new BuilderOrchestrator([
+                new IntegrationBuilder(),
+                new SchedulerBuilder(),
+            ]).buildAll({
+                integrations: [
+                    {
+                        Definition: {
+                            name: 'test',
+                            modules: { crm: { definition: { API: Api } } },
+                        },
+                    },
+                ],
+            });
+            const before = await integrationBuilder.build(
+                { integrations: [{ Definition: { name: 'test' } }] },
+                {}
+            );
+
+            expect(Object.keys(merged.resources)).toEqual(
+                Object.keys(before.resources)
+            );
+            expect(Object.keys(merged.functions)).toEqual(
+                Object.keys(before.functions)
+            );
+            expect(Object.keys(merged.environment)).toEqual(
+                Object.keys(before.environment)
+            );
+        });
+
         it('should create queue worker function', async () => {
             const appDefinition = {
                 integrations: [

package/infrastructure/domains/scheduler/scheduler-builder.js

@@ -19,6 +19,11 @@ const {
     getAdminFunctionNames,
 } = require('../shared/function-environments');
 
+const declaresRateLimit = (integration) =>
+    Object.values(integration?.Definition?.modules ?? {}).some((module) =>
+        Boolean(module?.definition?.API?.rateLimit)
+    );
+
 class SchedulerBuilder extends InfrastructureBuilder {
     constructor() {
         super();
@@ -37,7 +42,8 @@ class SchedulerBuilder extends InfrastructureBuilder {
             return appDefinition.integrations.some(
                 (integration) =>
                     integration?.Definition?.webhooks?.enabled === true ||
-                    integration?.Definition?.webhooks === true
+                    integration?.Definition?.webhooks === true ||
+                    declaresRateLimit(integration)
             );
         }
 

package/infrastructure/domains/scheduler/scheduler-builder.test.js

@@ -38,6 +38,61 @@ describe('SchedulerBuilder', () => {
             ).toBe(true);
         });
 
+        it('runs when any module declares a rate limit', () => {
+            class Api {
+                static rateLimit = { minRetryAfterMs: 1_000 };
+            }
+            expect(
+                schedulerBuilder.shouldExecute({
+                    integrations: [
+                        { Definition: { name: 'a' } },
+                        {
+                            Definition: {
+                                name: 'b',
+                                modules: { crm: { definition: { API: Api } } },
+                            },
+                        },
+                    ],
+                })
+            ).toBe(true);
+        });
+
+        it('skips a module whose API declares no rate limit', () => {
+            class Api {}
+            expect(
+                schedulerBuilder.shouldExecute({
+                    integrations: [
+                        {
+                            Definition: {
+                                name: 'a',
+                                modules: { crm: { definition: { API: Api } } },
+                            },
+                        },
+                    ],
+                })
+            ).toBe(false);
+        });
+
+        it.each([
+            ['no modules', { name: 'a' }],
+            ['an empty modules object', { name: 'a', modules: {} }],
+            [
+                'a module with no definition',
+                { name: 'a', modules: { crm: {} } },
+            ],
+            ['a null module', { name: 'a', modules: { crm: null } }],
+            [
+                'a definition with no API',
+                { name: 'a', modules: { crm: { definition: {} } } },
+            ],
+        ])('skips an integration with %s', (_label, Definition) => {
+            expect(
+                schedulerBuilder.shouldExecute({
+                    integrations: [{ Definition }],
+                })
+            ).toBe(false);
+        });
+
         it('skips otherwise', () => {
             expect(
                 schedulerBuilder.shouldExecute({

package/infrastructure/domains/shared/utilities/base-definition-factory.js

@@ -195,6 +195,7 @@ function createBaseDefinition(
                         'sqs:SendMessageBatch',
                         'sqs:GetQueueUrl',
                         'sqs:GetQueueAttributes',
+                        'sqs:ChangeMessageVisibility',
                     ],
                     Resource: [
                         { 'Fn::GetAtt': ['InternalErrorQueue', 'Arn'] },

package/infrastructure/domains/shared/utilities/base-definition-factory.test.js

@@ -135,6 +135,18 @@ describe('Base Definition Factory', () => {
             expect(sqsPermission).toBeDefined();
         });
 
+        it('should let a function extend the visibility timeout of a message on an integration queue', () => {
+            const result = createBaseDefinition({}, {}, {});
+
+            const sqsPermission = result.provider.iamRoleStatements.find(
+                (stmt) => stmt.Action.includes('sqs:SendMessage')
+            );
+            expect(sqsPermission.Action).toContain(
+                'sqs:ChangeMessageVisibility'
+            );
+            expect(JSON.stringify(sqsPermission.Resource)).toContain('*Queue');
+        });
+
         it('should include required plugins', () => {
             const result = createBaseDefinition({}, {}, {});
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@friggframework/devtools",
   "prettier": "@friggframework/prettier-config",
-  "version": "2.0.0--canary.656.4fb07b4.0",
+  "version": "2.0.0--canary.657.6a81b60.0",
   "bin": {
     "frigg": "./frigg-cli/index.js"
   },
@@ -26,9 +26,9 @@
     "@babel/eslint-parser": "^7.18.9",
     "@babel/parser": "^7.25.3",
     "@babel/traverse": "^7.25.3",
-    "@friggframework/core": "2.0.0--canary.656.4fb07b4.0",
-    "@friggframework/schemas": "2.0.0--canary.656.4fb07b4.0",
-    "@friggframework/test": "2.0.0--canary.656.4fb07b4.0",
+    "@friggframework/core": "2.0.0--canary.657.6a81b60.0",
+    "@friggframework/schemas": "2.0.0--canary.657.6a81b60.0",
+    "@friggframework/test": "2.0.0--canary.657.6a81b60.0",
     "@hapi/boom": "^10.0.1",
     "@inquirer/prompts": "^5.3.8",
     "axios": "^1.18.0",
@@ -56,8 +56,8 @@
     "validate-npm-package-name": "^5.0.0"
   },
   "devDependencies": {
-    "@friggframework/eslint-config": "2.0.0--canary.656.4fb07b4.0",
-    "@friggframework/prettier-config": "2.0.0--canary.656.4fb07b4.0",
+    "@friggframework/eslint-config": "2.0.0--canary.657.6a81b60.0",
+    "@friggframework/prettier-config": "2.0.0--canary.657.6a81b60.0",
     "aws-sdk-client-mock": "^4.1.0",
     "aws-sdk-client-mock-jest": "^4.1.0",
     "jest": "^30.1.3",
@@ -89,5 +89,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "4fb07b4e92324bbbf0d19153e2168642facc1182"
+  "gitHead": "6a81b603e102e18dd02eaca5cb89bf04f43b18a0"
 }