@friggframework/devtools 2.0.0--canary.625.0de0db4.0 → 2.0.0--canary.625.6bef7de.0

package/frigg-cli/ssm-command/index.js

@@ -163,21 +163,59 @@ async function pushOffloadedParameters(appDefinition, stage, options = {}) {
         options
     );
 
-    for (const key of skipped) {
-        console.warn(
-            `⚠️  Skipping ${key}: no value in the environment (--allow-empty)`
-        );
-    }
-
-    if (specs.length === 0) {
+    if (specs.length === 0 && skipped.length === 0) {
         return { pushed: [], skipped };
     }
 
-    const { SSMClient, PutParameterCommand } = require('@aws-sdk/client-ssm');
+    const {
+        SSMClient,
+        PutParameterCommand,
+        GetParametersCommand,
+    } = require('@aws-sdk/client-ssm');
     const client = new SSMClient({
         region: resolvePushRegion(options),
     });
 
+    // --allow-empty only rotates keys that already exist. A skipped key still
+    // ships in FRIGG_SSM_OFFLOADED_KEYS, so if its parameter does not exist the
+    // runtime fails fast at cold start on every function — a green deploy that
+    // bricks the fleet. Verify existence and abort instead.
+    if (skipped.length > 0) {
+        const prefix = resolveParameterPrefix(appDefinition, stage);
+        const names = skipped.map((key) => `${prefix}/${key}`);
+        const existing = new Set();
+        for (let i = 0; i < names.length; i += 10) {
+            const { Parameters = [] } = await client.send(
+                new GetParametersCommand({ Names: names.slice(i, i + 10) })
+            );
+            for (const param of Parameters) {
+                existing.add(param.Name);
+            }
+        }
+        const orphaned = skipped.filter(
+            (key) => !existing.has(`${prefix}/${key}`)
+        );
+        if (orphaned.length > 0) {
+            throw new Error(
+                `--allow-empty skipped ${orphaned.join(
+                    ', '
+                )}, but no such parameter exists in Parameter Store. --allow-empty ` +
+                    `only rotates keys that already have a value; a skipped key with no ` +
+                    `parameter stays in FRIGG_SSM_OFFLOADED_KEYS and fails every function ` +
+                    `at cold start. Set a value and push without --allow-empty.`
+            );
+        }
+        for (const key of skipped) {
+            console.warn(
+                `⚠️  Skipping ${key}: no value in the environment; keeping the existing Parameter Store value (--allow-empty)`
+            );
+        }
+    }
+
+    if (specs.length === 0) {
+        return { pushed: [], skipped };
+    }
+
     const pushed = [];
     for (const spec of specs) {
         const input = {

package/frigg-cli/ssm-command/index.test.js

@@ -1,5 +1,9 @@
 const { mockClient } = require('aws-sdk-client-mock');
-const { SSMClient, PutParameterCommand } = require('@aws-sdk/client-ssm');
+const {
+    SSMClient,
+    PutParameterCommand,
+    GetParametersCommand,
+} = require('@aws-sdk/client-ssm');
 const { pushOffloadedParameters, resolvePushRegion } = require('./index');
 
 describe('ssm-command pushOffloadedParameters', () => {
@@ -95,8 +99,11 @@ describe('ssm-command pushOffloadedParameters', () => {
         expect(ssmMock.commandCalls(PutParameterCommand)).toHaveLength(0);
     });
 
-    it('skips missing values with allowEmpty instead of throwing', async () => {
+    it('skips missing values with allowEmpty when the parameter already exists', async () => {
         delete process.env.MY_SECRET;
+        ssmMock.on(GetParametersCommand).resolves({
+            Parameters: [{ Name: '/frigg/my-app/dev/MY_SECRET' }],
+        });
 
         const result = await pushOffloadedParameters(appDefinition, 'dev', {
             allowEmpty: true,
@@ -105,6 +112,16 @@ describe('ssm-command pushOffloadedParameters', () => {
         expect(ssmMock.commandCalls(PutParameterCommand)).toHaveLength(1);
     });
 
+    it('aborts when allowEmpty skips a key that does not exist in Parameter Store', async () => {
+        delete process.env.MY_SECRET;
+        ssmMock.on(GetParametersCommand).resolves({ Parameters: [] });
+
+        await expect(
+            pushOffloadedParameters(appDefinition, 'dev', { allowEmpty: true })
+        ).rejects.toThrow(/MY_SECRET.*no such parameter|--allow-empty/s);
+        expect(ssmMock.commandCalls(PutParameterCommand)).toHaveLength(0);
+    });
+
     it('rejects values over the standard tier limit and suggests advanced', async () => {
         process.env.MY_CONFIG = 'x'.repeat(4097);
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@friggframework/devtools",
   "prettier": "@friggframework/prettier-config",
-  "version": "2.0.0--canary.625.0de0db4.0",
+  "version": "2.0.0--canary.625.6bef7de.0",
   "bin": {
     "frigg": "./frigg-cli/index.js"
   },
@@ -26,9 +26,9 @@
     "@babel/eslint-parser": "^7.18.9",
     "@babel/parser": "^7.25.3",
     "@babel/traverse": "^7.25.3",
-    "@friggframework/core": "2.0.0--canary.625.0de0db4.0",
-    "@friggframework/schemas": "2.0.0--canary.625.0de0db4.0",
-    "@friggframework/test": "2.0.0--canary.625.0de0db4.0",
+    "@friggframework/core": "2.0.0--canary.625.6bef7de.0",
+    "@friggframework/schemas": "2.0.0--canary.625.6bef7de.0",
+    "@friggframework/test": "2.0.0--canary.625.6bef7de.0",
     "@hapi/boom": "^10.0.1",
     "@inquirer/prompts": "^5.3.8",
     "axios": "^1.18.0",
@@ -56,8 +56,8 @@
     "validate-npm-package-name": "^5.0.0"
   },
   "devDependencies": {
-    "@friggframework/eslint-config": "2.0.0--canary.625.0de0db4.0",
-    "@friggframework/prettier-config": "2.0.0--canary.625.0de0db4.0",
+    "@friggframework/eslint-config": "2.0.0--canary.625.6bef7de.0",
+    "@friggframework/prettier-config": "2.0.0--canary.625.6bef7de.0",
     "aws-sdk-client-mock": "^4.1.0",
     "aws-sdk-client-mock-jest": "^4.1.0",
     "jest": "^30.1.3",
@@ -89,5 +89,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "0de0db43a6403eb99de205e24fcde7e9761ba4f6"
+  "gitHead": "6bef7de84e4deea31c8dea40c177e2f7343eea4c"
 }