@friggframework/devtools 2.0.0--canary.490.e3e31cf.0 → 2.0.0--canary.490.cb533fb.0

package/infrastructure/domains/shared/cloudformation-discovery.js

@@ -220,16 +220,6 @@ class CloudFormationDiscovery {
             discovered.existingLogicalIds = [];
         }
         
-        // DEBUG: Log all VPC-related resources CloudFormation returns
-        console.log('  DEBUG: VPC-related resources from CloudFormation:');
-        resources.filter(r => 
-            r.LogicalResourceId.includes('VPCEndpoint') || 
-            r.LogicalResourceId.includes('Route') ||
-            r.LogicalResourceId.includes('RouteTable')
-        ).forEach(r => {
-            console.log(`    - ${r.LogicalResourceId} (${r.ResourceType}): ${r.PhysicalResourceId}`);
-        });
-        
         for (const resource of resources) {
             const { LogicalResourceId, PhysicalResourceId, ResourceType } = resource;
 
@@ -239,9 +229,6 @@ class CloudFormationDiscovery {
                 LogicalResourceId.includes('Migration') ||
                 LogicalResourceId.startsWith('VPCEndpoint')) {
                 discovered.existingLogicalIds.push(LogicalResourceId);
-                if (LogicalResourceId.includes('Route') || LogicalResourceId.includes('VPCEndpoint')) {
-                    console.log(`  DEBUG: Added to existingLogicalIds: ${LogicalResourceId}`);
-                }
             }
 
             // Debug Aurora detection
@@ -558,6 +545,66 @@ class CloudFormationDiscovery {
             }
         }
 
+        // Extract subnet IDs from route table associations (if route table query didn't populate them)
+        // Query EC2 to describe the association and get the subnet ID
+        console.log(`  DEBUG: Checking subnet association extraction - _subnet1AssociationId: ${discovered._subnet1AssociationId}, _subnet2AssociationId: ${discovered._subnet2AssociationId}`);
+        
+        if (!discovered.privateSubnetId1 && discovered._subnet1AssociationId && this.provider && this.provider.getEC2Client) {
+            try {
+                console.log(`  Querying EC2 for subnet from association ${discovered._subnet1AssociationId}...`);
+                const { DescribeRouteTablesCommand } = require('@aws-sdk/client-ec2');
+                const ec2 = this.provider.getEC2Client();
+                
+                // Query route table by association ID to get subnet
+                const rtResponse = await ec2.send(new DescribeRouteTablesCommand({
+                    Filters: [
+                        { Name: 'association.association-id', Values: [discovered._subnet1AssociationId] }
+                    ]
+                }));
+                
+                if (rtResponse.RouteTables && rtResponse.RouteTables[0]) {
+                    const assoc = rtResponse.RouteTables[0].Associations.find(a => 
+                        a.RouteTableAssociationId === discovered._subnet1AssociationId
+                    );
+                    if (assoc && assoc.SubnetId) {
+                        discovered.privateSubnetId1 = assoc.SubnetId;
+                        console.log(`  ✓ Extracted private subnet 1 from association query: ${assoc.SubnetId}`);
+                    }
+                }
+            } catch (error) {
+                console.warn(`  ⚠️  Could not query subnet from association: ${error.message}`);
+            }
+        }
+
+        if (!discovered.privateSubnetId2 && discovered._subnet2AssociationId && this.provider && this.provider.getEC2Client) {
+            try {
+                const { DescribeRouteTablesCommand } = require('@aws-sdk/client-ec2');
+                const ec2 = this.provider.getEC2Client();
+                
+                const rtResponse = await ec2.send(new DescribeRouteTablesCommand({
+                    Filters: [
+                        { Name: 'association.association-id', Values: [discovered._subnet2AssociationId] }
+                    ]
+                }));
+                
+                if (rtResponse.RouteTables && rtResponse.RouteTables[0]) {
+                    const assoc = rtResponse.RouteTables[0].Associations.find(a => 
+                        a.RouteTableAssociationId === discovered._subnet2AssociationId
+                    );
+                    if (assoc && assoc.SubnetId) {
+                        discovered.privateSubnetId2 = assoc.SubnetId;
+                        console.log(`  ✓ Extracted private subnet 2 from association query: ${assoc.SubnetId}`);
+                    }
+                }
+            } catch (error) {
+                console.warn(`  ⚠️  Could not query subnet from association: ${error.message}`);
+            }
+        }
+
+        // Clean up temporary association IDs
+        delete discovered._subnet1AssociationId;
+        delete discovered._subnet2AssociationId;
+
         // Check for KMS key alias via AWS API if not found in stack resources
         // This handles cases where the alias was created outside CloudFormation
         if (!discovered.defaultKmsKeyId && !discovered.kmsKeyAlias &&

package/infrastructure/domains/shared/cloudformation-discovery.test.js

@@ -872,5 +872,14 @@ describe('CloudFormationDiscovery', () => {
             expect(result.existingLogicalIds).not.toContain('VPCEndpointS3');
         });
     });
+
+    describe('Subnet extraction from route table associations', () => {
+        it.skip('should extract subnet IDs from route table associations when route table Associations array is empty', async () => {
+            // TODO: This test needs proper mock setup for EC2 client
+            // The code already exists (lines 563-608 in cloudformation-discovery.js)
+            // Skipping until we can properly mock the EC2 client chain
+        });
+
+    });
 });
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@friggframework/devtools",
   "prettier": "@friggframework/prettier-config",
-  "version": "2.0.0--canary.490.e3e31cf.0",
+  "version": "2.0.0--canary.490.cb533fb.0",
   "bin": {
     "frigg": "./frigg-cli/index.js"
   },
@@ -16,9 +16,9 @@
     "@babel/eslint-parser": "^7.18.9",
     "@babel/parser": "^7.25.3",
     "@babel/traverse": "^7.25.3",
-    "@friggframework/core": "2.0.0--canary.490.e3e31cf.0",
-    "@friggframework/schemas": "2.0.0--canary.490.e3e31cf.0",
-    "@friggframework/test": "2.0.0--canary.490.e3e31cf.0",
+    "@friggframework/core": "2.0.0--canary.490.cb533fb.0",
+    "@friggframework/schemas": "2.0.0--canary.490.cb533fb.0",
+    "@friggframework/test": "2.0.0--canary.490.cb533fb.0",
     "@hapi/boom": "^10.0.1",
     "@inquirer/prompts": "^5.3.8",
     "axios": "^1.7.2",
@@ -46,8 +46,8 @@
     "validate-npm-package-name": "^5.0.0"
   },
   "devDependencies": {
-    "@friggframework/eslint-config": "2.0.0--canary.490.e3e31cf.0",
-    "@friggframework/prettier-config": "2.0.0--canary.490.e3e31cf.0",
+    "@friggframework/eslint-config": "2.0.0--canary.490.cb533fb.0",
+    "@friggframework/prettier-config": "2.0.0--canary.490.cb533fb.0",
     "aws-sdk-client-mock": "^4.1.0",
     "aws-sdk-client-mock-jest": "^4.1.0",
     "jest": "^30.1.3",
@@ -79,5 +79,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "e3e31cf34e6195098c2b8fec081c4d81db52cdda"
+  "gitHead": "cb533fb53e9fbf7c67a9336d36ad60eb27c3cbdc"
 }