@friggframework/devtools 2.0.0--canary.490.84409c6.0 → 2.0.0--canary.490.c46b045.0

package/frigg-cli/deploy-command/index.js

@@ -284,8 +284,13 @@ async function deployCommand(options) {
 
     console.log('\n✓ Deployment completed successfully!');
 
-    // Run post-deployment health check (unless --skip-doctor)
-    if (!options.skipDoctor) {
+    // Run post-deployment health check (unless disabled)
+    // Can be disabled via:
+    // 1. CLI flag: --skip-doctor
+    // 2. AppDefinition: deployment.skipPostDeploymentHealthCheck: true
+    const skipHealthCheck = options.skipDoctor || appDefinition?.deployment?.skipPostDeploymentHealthCheck;
+    
+    if (!skipHealthCheck) {
         const stackName = getStackName(appDefinition, options);
 
         if (stackName) {
@@ -295,7 +300,8 @@ async function deployCommand(options) {
             console.log('   Run "frigg doctor <stack-name>" manually to check stack health');
         }
     } else {
-        console.log('\n⏭️  Skipping post-deployment health check (--skip-doctor)');
+        const reason = options.skipDoctor ? '--skip-doctor flag' : 'deployment.skipPostDeploymentHealthCheck: true';
+        console.log(`\n⏭️  Skipping post-deployment health check (${reason})`);
     }
 }
 

package/infrastructure/domains/networking/vpc-builder.js

@@ -1151,7 +1151,6 @@ class VpcBuilder extends InfrastructureBuilder {
         // CRITICAL: Frontify production uses OLD naming (VPCEndpointS3, not FriggS3VPCEndpoint)
         const existingLogicalIds = discoveredResources?.existingLogicalIds || [];
         
-        console.log(`    DEBUG: existingLogicalIds for VPC endpoints = ${JSON.stringify(existingLogicalIds.filter(id => id.includes('VPCEndpoint')))}`);
         
         const logicalIdMap = {
             s3: existingLogicalIds.includes('VPCEndpointS3') ? 'VPCEndpointS3' : 'FriggS3VPCEndpoint',

package/infrastructure/domains/shared/cloudformation-discovery.js

@@ -163,9 +163,6 @@ class CloudFormationDiscovery {
                         const associations = routeTable.Associations || [];
                         const subnetAssociations = associations.filter(a => a.SubnetId);
                         
-                        console.log(`  DEBUG: Route table has ${associations.length} associations, ${subnetAssociations.length} with SubnetId`);
-                        console.log(`  DEBUG: Route table structure:`, JSON.stringify(routeTable, null, 2).substring(0, 500));
-                        console.log(`  DEBUG: discovered.privateSubnetId1 = ${discovered.privateSubnetId1}, discovered.privateSubnetId2 = ${discovered.privateSubnetId2}`);
                         
                         if (subnetAssociations.length >= 1 && !discovered.privateSubnetId1) {
                             discovered.privateSubnetId1 = subnetAssociations[0].SubnetId;
@@ -213,7 +210,6 @@ class CloudFormationDiscovery {
      * @param {Object} discovered - Object to populate with discovered resources
      */
     async _extractFromResources(resources, discovered) {
-        console.log(`  DEBUG: Processing ${resources.length} CloudFormation resources...`);
 
         // Initialize existingLogicalIds array if not present
         if (!discovered.existingLogicalIds) {
@@ -231,10 +227,6 @@ class CloudFormationDiscovery {
                 discovered.existingLogicalIds.push(LogicalResourceId);
             }
 
-            // Debug Aurora detection
-            if (LogicalResourceId.includes('Aurora')) {
-                console.log(`  DEBUG: Found Aurora resource: ${LogicalResourceId} (${ResourceType})`);
-            }
 
             // Security Group - use to get VPC ID
             if (LogicalResourceId === 'FriggLambdaSecurityGroup' && ResourceType === 'AWS::EC2::SecurityGroup') {
@@ -360,21 +352,14 @@ class CloudFormationDiscovery {
                 discovered.routeTableAssociations.push(PhysicalResourceId);
                 console.log(`  ✓ Found route table association: ${LogicalResourceId}`);
                 
-                // CRITICAL: Extract subnet ID from association physical ID by querying EC2
-                // Physical ID is the association ID (rtbassoc-xxx), need to query to get subnet
-                console.log(`  DEBUG: Checking if this is subnet 1 association: LogicalResourceId="${LogicalResourceId}", matches=${LogicalResourceId === 'FriggSubnet1RouteAssociation' || LogicalResourceId === 'FriggPrivateSubnet1RouteTableAssociation'}`);
-                console.log(`  DEBUG: this.provider=${!!this.provider}, getEC2Client=${!!(this.provider && this.provider.getEC2Client)}`);
-                
+                // Store association ID to query later for subnet extraction (after loop)
                 if (this.provider && this.provider.getEC2Client && 
                     (LogicalResourceId === 'FriggSubnet1RouteAssociation' || LogicalResourceId === 'FriggPrivateSubnet1RouteTableAssociation')) {
-                    // Store association ID to query later (after loop)
                     discovered._subnet1AssociationId = PhysicalResourceId;
-                    console.log(`  DEBUG: Set _subnet1AssociationId = ${PhysicalResourceId}`);
                 }
                 if (this.provider && this.provider.getEC2Client && 
                     (LogicalResourceId === 'FriggSubnet2RouteAssociation' || LogicalResourceId === 'FriggPrivateSubnet2RouteTableAssociation')) {
                     discovered._subnet2AssociationId = PhysicalResourceId;
-                    console.log(`  DEBUG: Set _subnet2AssociationId = ${PhysicalResourceId}`);
                 }
             }
 
@@ -460,9 +445,6 @@ class CloudFormationDiscovery {
                 discovered.s3VpcEndpointId = PhysicalResourceId;
                 discovered.vpcEndpoints.s3 = PhysicalResourceId;
                 console.log(`  ✓ Found S3 VPC endpoint in stack: ${PhysicalResourceId}`);
-                console.log(`  DEBUG: S3 VPC endpoint LogicalResourceId = "${LogicalResourceId}"`);
-                console.log(`  DEBUG: Should have been added to existingLogicalIds at top of loop!`);
-                console.log(`  DEBUG: existingLogicalIds.includes('VPCEndpointS3') = ${discovered.existingLogicalIds.includes('VPCEndpointS3')}`);
             }
             
             // DynamoDB Endpoint (both naming patterns)
@@ -607,9 +589,6 @@ class CloudFormationDiscovery {
         }
         
         // FALLBACK: Extract subnet IDs from route table associations (if VPC query didn't work)
-        // Query EC2 to describe the association and get the subnet ID
-        console.log(`  DEBUG: Checking subnet association extraction - _subnet1AssociationId: ${discovered._subnet1AssociationId}, _subnet2AssociationId: ${discovered._subnet2AssociationId}`);
-        
         if (!discovered.privateSubnetId1 && discovered._subnet1AssociationId && this.provider && this.provider.getEC2Client) {
             try {
                 console.log(`  Querying EC2 for subnet from association ${discovered._subnet1AssociationId}...`);
@@ -623,21 +602,14 @@ class CloudFormationDiscovery {
                     ]
                 }));
                 
-                console.log(`  DEBUG: Query returned ${rtResponse.RouteTables?.length || 0} route tables`);
                 if (rtResponse.RouteTables && rtResponse.RouteTables[0]) {
-                    console.log(`  DEBUG: First route table has ${rtResponse.RouteTables[0].Associations?.length || 0} associations`);
                     const assoc = rtResponse.RouteTables[0].Associations.find(a => 
                         a.RouteTableAssociationId === discovered._subnet1AssociationId
                     );
-                    console.log(`  DEBUG: Found matching association: ${!!assoc}, has SubnetId: ${!!assoc?.SubnetId}`);
                     if (assoc && assoc.SubnetId) {
                         discovered.privateSubnetId1 = assoc.SubnetId;
                         console.log(`  ✓ Extracted private subnet 1 from association query: ${assoc.SubnetId}`);
-                    } else {
-                        console.warn(`  ⚠️  Association found but no SubnetId in response`);
                     }
-                } else {
-                    console.warn(`  ⚠️  No route tables returned for association ${discovered._subnet1AssociationId}`);
                 }
             } catch (error) {
                 console.warn(`  ⚠️  Could not query subnet from association: ${error.message}`);
@@ -655,21 +627,14 @@ class CloudFormationDiscovery {
                     ]
                 }));
                 
-                console.log(`  DEBUG: Query returned ${rtResponse.RouteTables?.length || 0} route tables for subnet 2`);
                 if (rtResponse.RouteTables && rtResponse.RouteTables[0]) {
-                    console.log(`  DEBUG: First route table has ${rtResponse.RouteTables[0].Associations?.length || 0} associations`);
                     const assoc = rtResponse.RouteTables[0].Associations.find(a => 
                         a.RouteTableAssociationId === discovered._subnet2AssociationId
                     );
-                    console.log(`  DEBUG: Found matching association for subnet 2: ${!!assoc}, has SubnetId: ${!!assoc?.SubnetId}`);
                     if (assoc && assoc.SubnetId) {
                         discovered.privateSubnetId2 = assoc.SubnetId;
                         console.log(`  ✓ Extracted private subnet 2 from association query: ${assoc.SubnetId}`);
-                    } else {
-                        console.warn(`  ⚠️  Association found but no SubnetId in response for subnet 2`);
                     }
-                } else {
-                    console.warn(`  ⚠️  No route tables returned for association ${discovered._subnet2AssociationId}`);
                 }
             } catch (error) {
                 console.warn(`  ⚠️  Could not query subnet from association: ${error.message}`);

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@friggframework/devtools",
   "prettier": "@friggframework/prettier-config",
-  "version": "2.0.0--canary.490.84409c6.0",
+  "version": "2.0.0--canary.490.c46b045.0",
   "bin": {
     "frigg": "./frigg-cli/index.js"
   },
@@ -16,9 +16,9 @@
     "@babel/eslint-parser": "^7.18.9",
     "@babel/parser": "^7.25.3",
     "@babel/traverse": "^7.25.3",
-    "@friggframework/core": "2.0.0--canary.490.84409c6.0",
-    "@friggframework/schemas": "2.0.0--canary.490.84409c6.0",
-    "@friggframework/test": "2.0.0--canary.490.84409c6.0",
+    "@friggframework/core": "2.0.0--canary.490.c46b045.0",
+    "@friggframework/schemas": "2.0.0--canary.490.c46b045.0",
+    "@friggframework/test": "2.0.0--canary.490.c46b045.0",
     "@hapi/boom": "^10.0.1",
     "@inquirer/prompts": "^5.3.8",
     "axios": "^1.7.2",
@@ -46,8 +46,8 @@
     "validate-npm-package-name": "^5.0.0"
   },
   "devDependencies": {
-    "@friggframework/eslint-config": "2.0.0--canary.490.84409c6.0",
-    "@friggframework/prettier-config": "2.0.0--canary.490.84409c6.0",
+    "@friggframework/eslint-config": "2.0.0--canary.490.c46b045.0",
+    "@friggframework/prettier-config": "2.0.0--canary.490.c46b045.0",
     "aws-sdk-client-mock": "^4.1.0",
     "aws-sdk-client-mock-jest": "^4.1.0",
     "jest": "^30.1.3",
@@ -79,5 +79,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "84409c6304ea14a6b9789ed8fc9ca07fe2385b17"
+  "gitHead": "c46b04556cfd984038f38d98274100a0551bb470"
 }