@friggframework/devtools 2.0.0--canary.490.6e556a4.0 → 2.0.0--canary.490.df708d7.0

package/infrastructure/domains/networking/vpc-resolver.js

@@ -300,9 +300,23 @@ class VpcResourceResolver extends BaseResourceResolver {
         const encryptionMethod = appDefinition.encryption?.fieldLevelEncryptionMethod;
         const needsKms = encryptionMethod === 'kms';
 
+        // DynamoDB endpoint only needed if using DynamoDB (not MongoDB or PostgreSQL)
+        // Currently framework only supports MongoDB (via Prisma) and PostgreSQL (via Aurora)
+        // DynamoDB support is not implemented, so endpoint is not needed
+        const usesDynamoDB = appDefinition.database?.dynamodb?.enable === true;
+        
+        // Special case: If DynamoDB endpoint exists in stack but not needed, preserve it
+        // to avoid deletion (user may have enabled it previously)
+        const dynamoDbInStack = this.isInStack('FriggDynamoDBVPCEndpoint', discovery);
+        const shouldPreserveDynamoDB = !usesDynamoDB && dynamoDbInStack;
+
         const endpoints = {
             s3: this._resolveEndpoint('FriggS3VPCEndpoint', 's3', userIntent, appDefinition, discovery),
-            dynamodb: this._resolveEndpoint('FriggDynamoDBVPCEndpoint', 'dynamodb', userIntent, appDefinition, discovery),
+            dynamodb: usesDynamoDB
+                ? this._resolveEndpoint('FriggDynamoDBVPCEndpoint', 'dynamodb', userIntent, appDefinition, discovery)
+                : shouldPreserveDynamoDB
+                    ? this._resolveEndpoint('FriggDynamoDBVPCEndpoint', 'dynamodb', userIntent, appDefinition, discovery)
+                    : { ownership: null, reason: 'DynamoDB endpoint not needed (application uses MongoDB/PostgreSQL, not DynamoDB)' },
             kms: needsKms
                 ? this._resolveEndpoint('FriggKMSVPCEndpoint', 'kms', userIntent, appDefinition, discovery)
                 : { ownership: null, reason: 'KMS endpoint not needed (encryption method is not KMS)' },
@@ -340,13 +354,27 @@ class VpcResourceResolver extends BaseResourceResolver {
             );
         }
 
-        // Auto-decide
-        return this.resolveResourceOwnership(
+        // Auto-decide - check if in stack first for more informative logging
+        const inStack = this.isInStack(logicalId, discovery);
+        const stackResource = inStack ? this.findInStack(logicalId, discovery) : null;
+        
+        const decision = this.resolveResourceOwnership(
             'auto',
             logicalId,
             'AWS::EC2::VPCEndpoint',
             discovery
         );
+        
+        // Override reason with more detailed explanation
+        if (decision.ownership === 'stack' && decision.physicalId) {
+            decision.reason = `Found in CloudFormation stack (must keep in template to avoid deletion)`;
+        } else if (decision.ownership === 'stack' && !decision.physicalId) {
+            decision.reason = `No existing ${endpointType} endpoint found - will create in stack`;
+        } else if (decision.ownership === 'external') {
+            decision.reason = `Found external ${endpointType} endpoint via discovery`;
+        }
+        
+        return decision;
     }
 
     /**

package/infrastructure/domains/networking/vpc-resolver.test.js

@@ -300,6 +300,82 @@ describe('VpcResourceResolver', () => {
     });
 
     describe('resolveVpcEndpoints', () => {
+        it('should skip DynamoDB endpoint when application uses MongoDB', () => {
+            const appDefinition = {
+                vpc: { ownership: { vpcEndpoints: 'auto' } },
+                database: { mongoDB: { enable: true } }, // Using MongoDB, not DynamoDB
+                encryption: { fieldLevelEncryptionMethod: 'kms' }
+            };
+            const discovery = {
+                stackManaged: [],
+                external: [],
+                fromCloudFormation: false
+            };
+
+            const decisions = resolver.resolveVpcEndpoints(appDefinition, discovery);
+
+            expect(decisions.s3.ownership).toBe('stack'); // S3 always needed
+            expect(decisions.dynamodb.ownership).toBeNull(); // DynamoDB NOT needed
+            expect(decisions.dynamodb.reason).toContain('MongoDB/PostgreSQL');
+            expect(decisions.kms.ownership).toBe('stack'); // KMS needed (encryption enabled)
+            expect(decisions.secretsManager.ownership).toBe('stack'); // SM always needed
+            expect(decisions.sqs.ownership).toBe('stack'); // SQS always needed
+        });
+
+        it('should skip DynamoDB endpoint when application uses PostgreSQL', () => {
+            const appDefinition = {
+                vpc: { ownership: { vpcEndpoints: 'auto' } },
+                database: { postgres: { enable: true } }, // Using PostgreSQL, not DynamoDB
+            };
+            const discovery = {
+                stackManaged: [],
+                external: [],
+                fromCloudFormation: false
+            };
+
+            const decisions = resolver.resolveVpcEndpoints(appDefinition, discovery);
+
+            expect(decisions.dynamodb.ownership).toBeNull();
+            expect(decisions.dynamodb.reason).toContain('MongoDB/PostgreSQL');
+        });
+
+        it('should create DynamoDB endpoint when explicitly enabled', () => {
+            const appDefinition = {
+                vpc: { ownership: { vpcEndpoints: 'auto' } },
+                database: { dynamodb: { enable: true } }, // Explicitly using DynamoDB
+            };
+            const discovery = {
+                stackManaged: [],
+                external: [],
+                fromCloudFormation: false
+            };
+
+            const decisions = resolver.resolveVpcEndpoints(appDefinition, discovery);
+
+            expect(decisions.dynamodb.ownership).toBe('stack'); // DynamoDB needed
+        });
+
+        it('should preserve DynamoDB endpoint if exists in stack even when not needed', () => {
+            const appDefinition = {
+                vpc: { ownership: { vpcEndpoints: 'auto' } },
+                database: { mongoDB: { enable: true } }, // Using MongoDB (DynamoDB not needed)
+            };
+            const discovery = {
+                stackManaged: [
+                    { logicalId: 'FriggDynamoDBVPCEndpoint', physicalId: 'vpce-ddb-legacy', resourceType: 'AWS::EC2::VPCEndpoint' }
+                ],
+                external: [],
+                fromCloudFormation: true
+            };
+
+            const decisions = resolver.resolveVpcEndpoints(appDefinition, discovery);
+
+            // Should preserve (not delete) even though not actively needed
+            expect(decisions.dynamodb.ownership).toBe('stack');
+            expect(decisions.dynamodb.physicalId).toBe('vpce-ddb-legacy');
+        });
+
+
         it('should return null decisions when endpoints disabled', () => {
             const appDefinition = {
                 vpc: {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@friggframework/devtools",
   "prettier": "@friggframework/prettier-config",
-  "version": "2.0.0--canary.490.6e556a4.0",
+  "version": "2.0.0--canary.490.df708d7.0",
   "bin": {
     "frigg": "./frigg-cli/index.js"
   },
@@ -16,9 +16,9 @@
     "@babel/eslint-parser": "^7.18.9",
     "@babel/parser": "^7.25.3",
     "@babel/traverse": "^7.25.3",
-    "@friggframework/core": "2.0.0--canary.490.6e556a4.0",
-    "@friggframework/schemas": "2.0.0--canary.490.6e556a4.0",
-    "@friggframework/test": "2.0.0--canary.490.6e556a4.0",
+    "@friggframework/core": "2.0.0--canary.490.df708d7.0",
+    "@friggframework/schemas": "2.0.0--canary.490.df708d7.0",
+    "@friggframework/test": "2.0.0--canary.490.df708d7.0",
     "@hapi/boom": "^10.0.1",
     "@inquirer/prompts": "^5.3.8",
     "axios": "^1.7.2",
@@ -46,8 +46,8 @@
     "validate-npm-package-name": "^5.0.0"
   },
   "devDependencies": {
-    "@friggframework/eslint-config": "2.0.0--canary.490.6e556a4.0",
-    "@friggframework/prettier-config": "2.0.0--canary.490.6e556a4.0",
+    "@friggframework/eslint-config": "2.0.0--canary.490.df708d7.0",
+    "@friggframework/prettier-config": "2.0.0--canary.490.df708d7.0",
     "aws-sdk-client-mock": "^4.1.0",
     "aws-sdk-client-mock-jest": "^4.1.0",
     "jest": "^30.1.3",
@@ -79,5 +79,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "6e556a4ddd243fe9163916341b1d70c31dd86ca0"
+  "gitHead": "df708d7b3a84f180a3edc5267375f9210e6a585a"
 }