@friggframework/devtools 2.0.0--canary.474.884529c.0 → 2.0.0--canary.474.82fd52e.0

package/infrastructure/domains/health/application/use-cases/reconcile-properties-use-case.js

@@ -0,0 +1,146 @@
+/**
+ * ReconcilePropertiesUseCase - Reconcile Property Drift
+ *
+ * Application Layer - Use Case
+ *
+ * Business logic for the "frigg repair --reconcile" command. Orchestrates property
+ * drift reconciliation to fix mutable property mismatches between CloudFormation
+ * template and actual cloud resources.
+ *
+ * Responsibilities:
+ * - Validate properties can be reconciled
+ * - Preview reconciliation impact
+ * - Execute reconciliation (template mode or resource mode)
+ * - Handle batch reconciliations
+ * - Skip immutable properties
+ */
+
+class ReconcilePropertiesUseCase {
+    /**
+     * Create use case with required dependencies
+     *
+     * @param {Object} params
+     * @param {IPropertyReconciler} params.propertyReconciler - Property reconciliation operations
+     */
+    constructor({ propertyReconciler }) {
+        if (!propertyReconciler) {
+            throw new Error('propertyReconciler is required');
+        }
+
+        this.propertyReconciler = propertyReconciler;
+    }
+
+    /**
+     * Reconcile a single property mismatch
+     *
+     * @param {Object} params
+     * @param {StackIdentifier} params.stackIdentifier - Stack identifier
+     * @param {string} params.logicalId - Logical resource ID
+     * @param {PropertyMismatch} params.mismatch - Property mismatch to reconcile
+     * @param {string} [params.mode='template'] - Reconciliation mode
+     * @returns {Promise<Object>} Reconciliation result
+     */
+    async reconcileSingleProperty({ stackIdentifier, logicalId, mismatch, mode = 'template' }) {
+        // 1. Check if property can be reconciled
+        const canReconcile = await this.propertyReconciler.canReconcile(mismatch);
+
+        if (!canReconcile) {
+            throw new Error(
+                `Property ${mismatch.propertyPath} cannot be reconciled automatically (immutable property requires replacement)`
+            );
+        }
+
+        // 2. Execute reconciliation
+        const result = await this.propertyReconciler.reconcileProperty({
+            stackIdentifier,
+            logicalId,
+            mismatch,
+            mode,
+        });
+
+        return result;
+    }
+
+    /**
+     * Reconcile multiple property mismatches for a resource
+     *
+     * @param {Object} params
+     * @param {StackIdentifier} params.stackIdentifier - Stack identifier
+     * @param {string} params.logicalId - Logical resource ID
+     * @param {PropertyMismatch[]} params.mismatches - Property mismatches to reconcile
+     * @param {string} [params.mode='template'] - Reconciliation mode
+     * @returns {Promise<Object>} Batch reconciliation result
+     */
+    async reconcileMultipleProperties({
+        stackIdentifier,
+        logicalId,
+        mismatches,
+        mode = 'template',
+    }) {
+        // 1. Filter out immutable properties (cannot be reconciled)
+        const reconcilableProperties = [];
+        const skippedProperties = [];
+
+        for (const mismatch of mismatches) {
+            const canReconcile = await this.propertyReconciler.canReconcile(mismatch);
+
+            if (canReconcile) {
+                reconcilableProperties.push(mismatch);
+            } else {
+                skippedProperties.push(mismatch);
+            }
+        }
+
+        // 2. If no properties can be reconciled, return early
+        if (reconcilableProperties.length === 0) {
+            return {
+                reconciledCount: 0,
+                failedCount: 0,
+                skippedCount: skippedProperties.length,
+                reconcilableCount: 0,
+                message: `All ${mismatches.length} property mismatch(es) require resource replacement (immutable)`,
+                results: [],
+            };
+        }
+
+        // 3. Reconcile the reconcilable properties
+        const batchResult = await this.propertyReconciler.reconcileMultipleProperties({
+            stackIdentifier,
+            logicalId,
+            mismatches: reconcilableProperties,
+            mode,
+        });
+
+        // 4. Return combined result
+        return {
+            reconciledCount: batchResult.reconciledCount,
+            failedCount: batchResult.failedCount,
+            skippedCount: skippedProperties.length,
+            reconcilableCount: reconcilableProperties.length,
+            message: batchResult.message,
+            results: batchResult.results,
+            skippedProperties: skippedProperties.length > 0 ? skippedProperties : undefined,
+        };
+    }
+
+    /**
+     * Preview reconciliation without applying changes
+     *
+     * @param {Object} params
+     * @param {StackIdentifier} params.stackIdentifier - Stack identifier
+     * @param {string} params.logicalId - Logical resource ID
+     * @param {PropertyMismatch} params.mismatch - Property mismatch to preview
+     * @param {string} [params.mode='template'] - Reconciliation mode
+     * @returns {Promise<Object>} Preview result
+     */
+    async previewReconciliation({ stackIdentifier, logicalId, mismatch, mode = 'template' }) {
+        return await this.propertyReconciler.previewReconciliation({
+            stackIdentifier,
+            logicalId,
+            mismatch,
+            mode,
+        });
+    }
+}
+
+module.exports = ReconcilePropertiesUseCase;

package/infrastructure/domains/health/application/use-cases/reconcile-properties-use-case.test.js

@@ -0,0 +1,343 @@
+/**
+ * Tests for ReconcilePropertiesUseCase
+ *
+ * Use case for reconciling property drift between CloudFormation template
+ * and actual cloud resources (frigg repair --reconcile command)
+ */
+
+const ReconcilePropertiesUseCase = require('./reconcile-properties-use-case');
+const StackIdentifier = require('../../domain/value-objects/stack-identifier');
+const PropertyMismatch = require('../../domain/entities/property-mismatch');
+const PropertyMutability = require('../../domain/value-objects/property-mutability');
+
+describe('ReconcilePropertiesUseCase', () => {
+    let useCase;
+    let mockPropertyReconciler;
+
+    beforeEach(() => {
+        // Mock property reconciler
+        mockPropertyReconciler = {
+            canReconcile: jest.fn(),
+            reconcileProperty: jest.fn(),
+            reconcileMultipleProperties: jest.fn(),
+            previewReconciliation: jest.fn(),
+        };
+
+        useCase = new ReconcilePropertiesUseCase({
+            propertyReconciler: mockPropertyReconciler,
+        });
+    });
+
+    describe('reconcileSingleProperty', () => {
+        it('should reconcile a single mutable property mismatch', async () => {
+            const stackIdentifier = new StackIdentifier({
+                stackName: 'my-app-prod',
+                region: 'us-east-1',
+            });
+
+            const mismatch = new PropertyMismatch({
+                propertyPath: 'Properties.EnableDnsSupport',
+                expectedValue: true,
+                actualValue: false,
+                mutability: PropertyMutability.MUTABLE,
+            });
+
+            // Mock reconciler can handle this mismatch
+            mockPropertyReconciler.canReconcile.mockResolvedValue(true);
+
+            // Mock reconciliation result
+            mockPropertyReconciler.reconcileProperty.mockResolvedValue({
+                success: true,
+                mode: 'template',
+                propertyPath: 'Properties.EnableDnsSupport',
+                oldValue: true,
+                newValue: false,
+                message: 'Template updated to match actual resource state',
+            });
+
+            const result = await useCase.reconcileSingleProperty({
+                stackIdentifier,
+                logicalId: 'MyVPC',
+                mismatch,
+                mode: 'template',
+            });
+
+            expect(result.success).toBe(true);
+            expect(result.mode).toBe('template');
+            expect(result.propertyPath).toBe('Properties.EnableDnsSupport');
+            expect(mockPropertyReconciler.canReconcile).toHaveBeenCalledWith(mismatch);
+            expect(mockPropertyReconciler.reconcileProperty).toHaveBeenCalled();
+        });
+
+        it('should fail if property cannot be reconciled', async () => {
+            const stackIdentifier = new StackIdentifier({
+                stackName: 'my-app-prod',
+                region: 'us-east-1',
+            });
+
+            const mismatch = new PropertyMismatch({
+                propertyPath: 'Properties.CidrBlock',
+                expectedValue: '10.0.0.0/16',
+                actualValue: '10.1.0.0/16',
+                mutability: PropertyMutability.IMMUTABLE,
+            });
+
+            // Mock reconciler cannot handle immutable property
+            mockPropertyReconciler.canReconcile.mockResolvedValue(false);
+
+            await expect(
+                useCase.reconcileSingleProperty({
+                    stackIdentifier,
+                    logicalId: 'MyVPC',
+                    mismatch,
+                    mode: 'template',
+                })
+            ).rejects.toThrow('Property Properties.CidrBlock cannot be reconciled automatically');
+        });
+
+        it('should use resource mode when specified', async () => {
+            const stackIdentifier = new StackIdentifier({
+                stackName: 'my-app-prod',
+                region: 'us-east-1',
+            });
+
+            const mismatch = new PropertyMismatch({
+                propertyPath: 'Properties.EnableDnsSupport',
+                expectedValue: true,
+                actualValue: false,
+                mutability: PropertyMutability.MUTABLE,
+            });
+
+            mockPropertyReconciler.canReconcile.mockResolvedValue(true);
+
+            mockPropertyReconciler.reconcileProperty.mockResolvedValue({
+                success: true,
+                mode: 'resource',
+                propertyPath: 'Properties.EnableDnsSupport',
+                oldValue: false,
+                newValue: true,
+                message: 'Resource updated to match template definition',
+            });
+
+            const result = await useCase.reconcileSingleProperty({
+                stackIdentifier,
+                logicalId: 'MyVPC',
+                mismatch,
+                mode: 'resource',
+            });
+
+            expect(result.success).toBe(true);
+            expect(result.mode).toBe('resource');
+            expect(mockPropertyReconciler.reconcileProperty).toHaveBeenCalledWith({
+                stackIdentifier,
+                logicalId: 'MyVPC',
+                mismatch,
+                mode: 'resource',
+            });
+        });
+    });
+
+    describe('reconcileMultipleProperties', () => {
+        it('should reconcile multiple property mismatches for a resource', async () => {
+            const stackIdentifier = new StackIdentifier({
+                stackName: 'my-app-prod',
+                region: 'us-east-1',
+            });
+
+            const mismatches = [
+                new PropertyMismatch({
+                    propertyPath: 'Properties.EnableDnsSupport',
+                    expectedValue: true,
+                    actualValue: false,
+                    mutability: PropertyMutability.MUTABLE,
+                }),
+                new PropertyMismatch({
+                    propertyPath: 'Properties.EnableDnsHostnames',
+                    expectedValue: true,
+                    actualValue: false,
+                    mutability: PropertyMutability.MUTABLE,
+                }),
+            ];
+
+            // Mock all mismatches can be reconciled
+            mockPropertyReconciler.canReconcile.mockResolvedValue(true);
+
+            // Mock batch reconciliation
+            mockPropertyReconciler.reconcileMultipleProperties.mockResolvedValue({
+                reconciledCount: 2,
+                failedCount: 0,
+                results: [
+                    {
+                        success: true,
+                        mode: 'template',
+                        propertyPath: 'Properties.EnableDnsSupport',
+                        oldValue: true,
+                        newValue: false,
+                        message: 'Template updated',
+                    },
+                    {
+                        success: true,
+                        mode: 'template',
+                        propertyPath: 'Properties.EnableDnsHostnames',
+                        oldValue: true,
+                        newValue: false,
+                        message: 'Template updated',
+                    },
+                ],
+                message: 'Reconciled 2 of 2 properties',
+            });
+
+            const result = await useCase.reconcileMultipleProperties({
+                stackIdentifier,
+                logicalId: 'MyVPC',
+                mismatches,
+                mode: 'template',
+            });
+
+            expect(result.reconciledCount).toBe(2);
+            expect(result.failedCount).toBe(0);
+            expect(result.results).toHaveLength(2);
+        });
+
+        it('should skip immutable properties and reconcile mutable ones', async () => {
+            const stackIdentifier = new StackIdentifier({
+                stackName: 'my-app-prod',
+                region: 'us-east-1',
+            });
+
+            const mismatches = [
+                new PropertyMismatch({
+                    propertyPath: 'Properties.EnableDnsSupport',
+                    expectedValue: true,
+                    actualValue: false,
+                    mutability: PropertyMutability.MUTABLE,
+                }),
+                new PropertyMismatch({
+                    propertyPath: 'Properties.CidrBlock',
+                    expectedValue: '10.0.0.0/16',
+                    actualValue: '10.1.0.0/16',
+                    mutability: PropertyMutability.IMMUTABLE,
+                }),
+            ];
+
+            // Mock first can be reconciled, second cannot
+            mockPropertyReconciler.canReconcile
+                .mockResolvedValueOnce(true)
+                .mockResolvedValueOnce(false);
+
+            // Mock reconciliation of the mutable property
+            mockPropertyReconciler.reconcileMultipleProperties.mockResolvedValue({
+                reconciledCount: 1,
+                failedCount: 0,
+                results: [
+                    {
+                        success: true,
+                        mode: 'template',
+                        propertyPath: 'Properties.EnableDnsSupport',
+                        oldValue: true,
+                        newValue: false,
+                        message: 'Template updated',
+                    },
+                ],
+                message: 'Reconciled 1 of 1 properties',
+            });
+
+            const result = await useCase.reconcileMultipleProperties({
+                stackIdentifier,
+                logicalId: 'MyVPC',
+                mismatches,
+                mode: 'template',
+            });
+
+            expect(result.reconciledCount).toBe(1); // One mutable property reconciled
+            expect(result.skippedCount).toBe(1); // One immutable property skipped
+            expect(result.reconcilableCount).toBe(1);
+            expect(result.results).toHaveLength(1);
+        });
+    });
+
+    describe('previewReconciliation', () => {
+        it('should preview reconciliation changes', async () => {
+            const stackIdentifier = new StackIdentifier({
+                stackName: 'my-app-prod',
+                region: 'us-east-1',
+            });
+
+            const mismatch = new PropertyMismatch({
+                propertyPath: 'Properties.EnableDnsSupport',
+                expectedValue: true,
+                actualValue: false,
+                mutability: PropertyMutability.MUTABLE,
+            });
+
+            // Mock preview
+            mockPropertyReconciler.previewReconciliation.mockResolvedValue({
+                canReconcile: true,
+                mode: 'template',
+                propertyPath: 'Properties.EnableDnsSupport',
+                currentValue: true,
+                proposedValue: false,
+                impact: 'Will update CloudFormation template to match actual resource state',
+                warnings: [],
+            });
+
+            const preview = await useCase.previewReconciliation({
+                stackIdentifier,
+                logicalId: 'MyVPC',
+                mismatch,
+                mode: 'template',
+            });
+
+            expect(preview.canReconcile).toBe(true);
+            expect(preview.mode).toBe('template');
+            expect(preview.impact).toContain('CloudFormation template');
+        });
+
+        it('should include warnings for risky reconciliations', async () => {
+            const stackIdentifier = new StackIdentifier({
+                stackName: 'my-app-prod',
+                region: 'us-east-1',
+            });
+
+            const mismatch = new PropertyMismatch({
+                propertyPath: 'Properties.EngineVersion',
+                expectedValue: '13.7',
+                actualValue: '13.8',
+                mutability: PropertyMutability.CONDITIONAL,
+            });
+
+            // Mock preview with warnings
+            mockPropertyReconciler.previewReconciliation.mockResolvedValue({
+                canReconcile: true,
+                mode: 'resource',
+                propertyPath: 'Properties.EngineVersion',
+                currentValue: '13.7',
+                proposedValue: '13.8',
+                impact: 'Will update database engine version - may cause downtime',
+                warnings: [
+                    'Engine version downgrade may not be supported',
+                    'Downtime may occur during version change',
+                ],
+            });
+
+            const preview = await useCase.previewReconciliation({
+                stackIdentifier,
+                logicalId: 'MyDBCluster',
+                mismatch,
+                mode: 'resource',
+            });
+
+            expect(preview.canReconcile).toBe(true);
+            expect(preview.warnings).toHaveLength(2);
+            expect(preview.warnings[0]).toContain('Engine version');
+        });
+    });
+
+    describe('constructor', () => {
+        it('should require propertyReconciler', () => {
+            expect(() => {
+                new ReconcilePropertiesUseCase({});
+            }).toThrow('propertyReconciler is required');
+        });
+    });
+});