@friggframework/devtools 2.0.0--canary.474.28f4860.0 → 2.0.0--canary.474.97bfcf0.0

package/infrastructure/domains/health/domain/value-objects/stack-identifier.test.js

@@ -0,0 +1,233 @@
+/**
+ * Tests for StackIdentifier Value Object
+ */
+
+const StackIdentifier = require('./stack-identifier');
+
+describe('StackIdentifier', () => {
+    describe('constructor', () => {
+        it('should create a valid stack identifier', () => {
+            const identifier = new StackIdentifier({
+                stackName: 'my-app-prod',
+                region: 'us-east-1',
+                accountId: '123456789012',
+            });
+
+            expect(identifier.stackName).toBe('my-app-prod');
+            expect(identifier.region).toBe('us-east-1');
+            expect(identifier.accountId).toBe('123456789012');
+        });
+
+        it('should require stackName', () => {
+            expect(() => {
+                new StackIdentifier({
+                    region: 'us-east-1',
+                    accountId: '123456789012',
+                });
+            }).toThrow('stackName is required');
+        });
+
+        it('should require region', () => {
+            expect(() => {
+                new StackIdentifier({
+                    stackName: 'my-app-prod',
+                    accountId: '123456789012',
+                });
+            }).toThrow('region is required');
+        });
+
+        it('should allow accountId to be optional', () => {
+            const identifier = new StackIdentifier({
+                stackName: 'my-app-prod',
+                region: 'us-east-1',
+            });
+
+            expect(identifier.stackName).toBe('my-app-prod');
+            expect(identifier.region).toBe('us-east-1');
+            expect(identifier.accountId).toBeNull();
+        });
+
+        it('should validate stackName format', () => {
+            expect(() => {
+                new StackIdentifier({
+                    stackName: '',
+                    region: 'us-east-1',
+                });
+            }).toThrow('stackName cannot be empty');
+        });
+
+        it('should validate region format', () => {
+            expect(() => {
+                new StackIdentifier({
+                    stackName: 'my-app-prod',
+                    region: 'invalid-region',
+                });
+            }).toThrow('region must be a valid AWS region');
+        });
+
+        it('should validate accountId format when provided', () => {
+            expect(() => {
+                new StackIdentifier({
+                    stackName: 'my-app-prod',
+                    region: 'us-east-1',
+                    accountId: '123',
+                });
+            }).toThrow('accountId must be a 12-digit number');
+        });
+
+        it('should accept valid AWS regions', () => {
+            const validRegions = [
+                'us-east-1',
+                'us-east-2',
+                'us-west-1',
+                'us-west-2',
+                'eu-west-1',
+                'eu-central-1',
+                'ap-southeast-1',
+                'ap-northeast-1',
+            ];
+
+            validRegions.forEach(region => {
+                expect(() => {
+                    new StackIdentifier({
+                        stackName: 'my-app-prod',
+                        region,
+                    });
+                }).not.toThrow();
+            });
+        });
+    });
+
+    describe('equals', () => {
+        it('should return true for identical identifiers', () => {
+            const id1 = new StackIdentifier({
+                stackName: 'my-app-prod',
+                region: 'us-east-1',
+                accountId: '123456789012',
+            });
+
+            const id2 = new StackIdentifier({
+                stackName: 'my-app-prod',
+                region: 'us-east-1',
+                accountId: '123456789012',
+            });
+
+            expect(id1.equals(id2)).toBe(true);
+        });
+
+        it('should return false for different stack names', () => {
+            const id1 = new StackIdentifier({
+                stackName: 'my-app-prod',
+                region: 'us-east-1',
+            });
+
+            const id2 = new StackIdentifier({
+                stackName: 'my-app-dev',
+                region: 'us-east-1',
+            });
+
+            expect(id1.equals(id2)).toBe(false);
+        });
+
+        it('should return false for different regions', () => {
+            const id1 = new StackIdentifier({
+                stackName: 'my-app-prod',
+                region: 'us-east-1',
+            });
+
+            const id2 = new StackIdentifier({
+                stackName: 'my-app-prod',
+                region: 'us-west-2',
+            });
+
+            expect(id1.equals(id2)).toBe(false);
+        });
+
+        it('should return false for different account IDs', () => {
+            const id1 = new StackIdentifier({
+                stackName: 'my-app-prod',
+                region: 'us-east-1',
+                accountId: '123456789012',
+            });
+
+            const id2 = new StackIdentifier({
+                stackName: 'my-app-prod',
+                region: 'us-east-1',
+                accountId: '987654321098',
+            });
+
+            expect(id1.equals(id2)).toBe(false);
+        });
+
+        it('should handle null accountId comparison', () => {
+            const id1 = new StackIdentifier({
+                stackName: 'my-app-prod',
+                region: 'us-east-1',
+            });
+
+            const id2 = new StackIdentifier({
+                stackName: 'my-app-prod',
+                region: 'us-east-1',
+            });
+
+            expect(id1.equals(id2)).toBe(true);
+        });
+    });
+
+    describe('toString', () => {
+        it('should return string representation with account ID', () => {
+            const identifier = new StackIdentifier({
+                stackName: 'my-app-prod',
+                region: 'us-east-1',
+                accountId: '123456789012',
+            });
+
+            expect(identifier.toString()).toBe('my-app-prod (us-east-1, 123456789012)');
+        });
+
+        it('should return string representation without account ID', () => {
+            const identifier = new StackIdentifier({
+                stackName: 'my-app-prod',
+                region: 'us-east-1',
+            });
+
+            expect(identifier.toString()).toBe('my-app-prod (us-east-1)');
+        });
+    });
+
+    describe('immutability', () => {
+        it('should not allow modification of stackName', () => {
+            const identifier = new StackIdentifier({
+                stackName: 'my-app-prod',
+                region: 'us-east-1',
+            });
+
+            expect(() => {
+                identifier.stackName = 'modified';
+            }).toThrow();
+        });
+
+        it('should not allow modification of region', () => {
+            const identifier = new StackIdentifier({
+                stackName: 'my-app-prod',
+                region: 'us-east-1',
+            });
+
+            expect(() => {
+                identifier.region = 'us-west-2';
+            }).toThrow();
+        });
+
+        it('should not allow modification of accountId', () => {
+            const identifier = new StackIdentifier({
+                stackName: 'my-app-prod',
+                region: 'us-east-1',
+                accountId: '123456789012',
+            });
+
+            expect(() => {
+                identifier.accountId = '987654321098';
+            }).toThrow();
+        });
+    });
+});

package/infrastructure/domains/security/kms-builder.js

@@ -121,7 +121,10 @@ class KmsBuilder extends InfrastructureBuilder {
 
             // Infer logical IDs from physical IDs if needed
             if (hasExistingStackResources && existingLogicalIds.length === 0) {
-                if (flatDiscovery.defaultKmsKeyId) existingLogicalIds.push('FriggKMSKey');
+                if (flatDiscovery.defaultKmsKeyId) {
+                    existingLogicalIds.push('FriggKMSKey');
+                    existingLogicalIds.push('FriggKMSKeyAlias');
+                }
             }
 
             existingLogicalIds.forEach(logicalId => {
@@ -131,6 +134,12 @@ class KmsBuilder extends InfrastructureBuilder {
                 if (logicalId === 'FriggKMSKey') {
                     resourceType = 'AWS::KMS::Key';
                     physicalId = flatDiscovery.defaultKmsKeyId;
+                } else if (logicalId === 'FriggKMSKeyAlias') {
+                    resourceType = 'AWS::KMS::Alias';
+                    // Extract alias name from KMS key ARN or use default pattern
+                    const stackName = flatDiscovery.stackName || 'unknown';
+                    const stage = appDefinition.stage || 'dev';
+                    physicalId = `alias/${stackName.replace(`-${stage}`, '')}-${stage}-frigg-kms`;
                 }
 
                 if (physicalId && typeof physicalId === 'string') {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@friggframework/devtools",
   "prettier": "@friggframework/prettier-config",
-  "version": "2.0.0--canary.474.28f4860.0",
+  "version": "2.0.0--canary.474.97bfcf0.0",
   "dependencies": {
     "@aws-sdk/client-ec2": "^3.835.0",
     "@aws-sdk/client-kms": "^3.835.0",
@@ -11,8 +11,8 @@
     "@babel/eslint-parser": "^7.18.9",
     "@babel/parser": "^7.25.3",
     "@babel/traverse": "^7.25.3",
-    "@friggframework/schemas": "2.0.0--canary.474.28f4860.0",
-    "@friggframework/test": "2.0.0--canary.474.28f4860.0",
+    "@friggframework/schemas": "2.0.0--canary.474.97bfcf0.0",
+    "@friggframework/test": "2.0.0--canary.474.97bfcf0.0",
     "@hapi/boom": "^10.0.1",
     "@inquirer/prompts": "^5.3.8",
     "axios": "^1.7.2",
@@ -34,8 +34,8 @@
     "serverless-http": "^2.7.0"
   },
   "devDependencies": {
-    "@friggframework/eslint-config": "2.0.0--canary.474.28f4860.0",
-    "@friggframework/prettier-config": "2.0.0--canary.474.28f4860.0",
+    "@friggframework/eslint-config": "2.0.0--canary.474.97bfcf0.0",
+    "@friggframework/prettier-config": "2.0.0--canary.474.97bfcf0.0",
     "aws-sdk-client-mock": "^4.1.0",
     "aws-sdk-client-mock-jest": "^4.1.0",
     "jest": "^30.1.3",
@@ -70,5 +70,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "28f4860ca94c7be7c382490f9678bca73bad123f"
+  "gitHead": "97bfcf0665c0e5d99e5f129de468a77e21fbe227"
 }