@friggframework/devtools 2.0.0--canary.461.44b70fc.0 → 2.0.0--canary.461.e679ea5.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
@@ -148,8 +148,8 @@ class VpcBuilder extends InfrastructureBuilder {
148
148
  break;
149
149
  }
150
150
 
151
- // Build subnets
152
- await this.buildSubnets(appDefinition, discoveredResources, result);
151
+ // Build subnets - pass normalized management mode for correct CIDR generation
152
+ await this.buildSubnets(appDefinition, discoveredResources, result, management);
153
153
 
154
154
  // Build NAT Gateway if needed
155
155
  await this.buildNatGateway(appDefinition, discoveredResources, result);
@@ -385,9 +385,9 @@ class VpcBuilder extends InfrastructureBuilder {
385
385
 
386
386
  /**
387
387
  * Build subnet infrastructure
388
+ * @param {Object} vpcManagement - Normalized VPC management mode (passed from build() to ensure consistency)
388
389
  */
389
- async buildSubnets(appDefinition, discoveredResources, result) {
390
- const vpcManagement = appDefinition.vpc.management || 'discover';
390
+ async buildSubnets(appDefinition, discoveredResources, result, vpcManagement) {
391
391
  // Default subnet management depends on context:
392
392
  // - use-existing mode with subnet IDs provided: use-existing
393
393
  // - create-new mode: create
@@ -855,11 +855,20 @@ describe('VpcBuilder', () => {
855
855
  // Should create new VPC (ignore discovered resources)
856
856
  expect(result.vpcId).toEqual({ Ref: 'FriggVPC' });
857
857
  expect(result.resources.FriggVPC).toBeDefined();
858
+ expect(result.resources.FriggVPC.Properties.CidrBlock).toBe('10.0.0.0/16');
858
859
 
859
- // Should create stage-specific subnets
860
+ // Should create stage-specific subnets with Fn::Cidr (dynamic from VPC CIDR)
860
861
  expect(result.resources.FriggPrivateSubnet1).toBeDefined();
861
862
  expect(result.resources.FriggPrivateSubnet2).toBeDefined();
862
863
 
864
+ // Subnets should use CloudFormation Fn::Cidr, NOT hardcoded 172.31.x.x
865
+ expect(result.resources.FriggPrivateSubnet1.Properties.CidrBlock).toEqual({
866
+ 'Fn::Select': [0, { 'Fn::Cidr': ['10.0.0.0/16', 4, 8] }]
867
+ });
868
+ expect(result.resources.FriggPrivateSubnet2.Properties.CidrBlock).toEqual({
869
+ 'Fn::Select': [1, { 'Fn::Cidr': ['10.0.0.0/16', 4, 8] }]
870
+ });
871
+
863
872
  // Should create new NAT Gateway
864
873
  expect(result.resources.FriggNATGateway).toBeDefined();
865
874
  });
package/package.json CHANGED
@@ -1,7 +1,7 @@
1
1
  {
2
2
  "name": "@friggframework/devtools",
3
3
  "prettier": "@friggframework/prettier-config",
4
- "version": "2.0.0--canary.461.44b70fc.0",
4
+ "version": "2.0.0--canary.461.e679ea5.0",
5
5
  "dependencies": {
6
6
  "@aws-sdk/client-ec2": "^3.835.0",
7
7
  "@aws-sdk/client-kms": "^3.835.0",
@@ -11,8 +11,8 @@
11
11
  "@babel/eslint-parser": "^7.18.9",
12
12
  "@babel/parser": "^7.25.3",
13
13
  "@babel/traverse": "^7.25.3",
14
- "@friggframework/schemas": "2.0.0--canary.461.44b70fc.0",
15
- "@friggframework/test": "2.0.0--canary.461.44b70fc.0",
14
+ "@friggframework/schemas": "2.0.0--canary.461.e679ea5.0",
15
+ "@friggframework/test": "2.0.0--canary.461.e679ea5.0",
16
16
  "@hapi/boom": "^10.0.1",
17
17
  "@inquirer/prompts": "^5.3.8",
18
18
  "axios": "^1.7.2",
@@ -34,8 +34,8 @@
34
34
  "serverless-http": "^2.7.0"
35
35
  },
36
36
  "devDependencies": {
37
- "@friggframework/eslint-config": "2.0.0--canary.461.44b70fc.0",
38
- "@friggframework/prettier-config": "2.0.0--canary.461.44b70fc.0",
37
+ "@friggframework/eslint-config": "2.0.0--canary.461.e679ea5.0",
38
+ "@friggframework/prettier-config": "2.0.0--canary.461.e679ea5.0",
39
39
  "aws-sdk-client-mock": "^4.1.0",
40
40
  "aws-sdk-client-mock-jest": "^4.1.0",
41
41
  "jest": "^30.1.3",
@@ -70,5 +70,5 @@
70
70
  "publishConfig": {
71
71
  "access": "public"
72
72
  },
73
- "gitHead": "44b70fce55d47259bf67cc71056376941940ba9b"
73
+ "gitHead": "e679ea5502f29133d25b93b6f5b36f9b3099f82c"
74
74
  }