@friggframework/admin-scripts 2.0.0--canary.517.7e78259.0 → 2.0.0--canary.517.2239974.0

package/src/application/script-runner.js

@@ -29,10 +29,9 @@ class ScriptRunner {
      * @param {string} options.executionId - Reuse existing AdminProcess record ID (NOT the Lambda execution ID).
      *   This is the database ID from the AdminProcess collection/table that tracks script executions.
      *   Pass this when resuming a queued execution to continue using the same execution record.
-     * @param {boolean} options.dryRun - Dry-run mode: validate and preview without executing
      */
     async execute(scriptName, params = {}, options = {}) {
-        const { trigger, audit = {}, executionId: existingExecutionId, dryRun = false } = options;
+        const { trigger, audit = {}, executionId: existingExecutionId } = options;
 
         if (!trigger) {
             throw new Error('options.trigger is required (MANUAL | SCHEDULED | QUEUE)');
@@ -49,11 +48,6 @@ class ScriptRunner {
             );
         }
 
-        // Dry-run mode: validate and return preview without executing
-        if (dryRun) {
-            return this.createDryRunPreview(scriptName, definition, params);
-        }
-
         let executionId = existingExecutionId;
 
         // Create execution record if not provided
@@ -141,110 +135,6 @@ class ScriptRunner {
             };
         }
     }
-
-    /**
-     * Create dry-run preview without executing the script
-     * Validates inputs and shows what would be executed
-     *
-     * @param {string} scriptName - Script name
-     * @param {Object} definition - Script definition
-     * @param {Object} params - Input parameters
-     * @returns {Object} Dry-run preview
-     */
-    createDryRunPreview(scriptName, definition, params) {
-        const validation = this.validateParams(definition, params);
-
-        return {
-            dryRun: true,
-            status: validation.valid ? 'DRY_RUN_VALID' : 'DRY_RUN_INVALID',
-            scriptName,
-            preview: {
-                script: {
-                    name: definition.name,
-                    version: definition.version,
-                    description: definition.description,
-                    requireIntegrationInstance: definition.config?.requireIntegrationInstance || false,
-                },
-                input: params,
-                inputSchema: definition.inputSchema || null,
-                validation,
-            },
-            message: validation.valid
-                ? 'Dry-run validation passed. Script is ready to execute with provided parameters.'
-                : `Dry-run validation failed: ${validation.errors.join(', ')}`,
-        };
-    }
-
-    /**
-     * Validate parameters against script's input schema
-     *
-     * @param {Object} definition - Script definition
-     * @param {Object} params - Input parameters
-     * @returns {Object} Validation result { valid, errors }
-     */
-    validateParams(definition, params) {
-        const errors = [];
-        const schema = definition.inputSchema;
-
-        if (!schema) {
-            return { valid: true, errors: [] };
-        }
-
-        // Check required fields
-        if (schema.required && Array.isArray(schema.required)) {
-            for (const field of schema.required) {
-                if (params[field] === undefined || params[field] === null) {
-                    errors.push(`Missing required parameter: ${field}`);
-                }
-            }
-        }
-
-        // Basic type validation for properties
-        if (schema.properties) {
-            for (const [key, prop] of Object.entries(schema.properties)) {
-                const value = params[key];
-                if (value !== undefined && value !== null) {
-                    const typeError = this.validateType(key, value, prop);
-                    if (typeError) {
-                        errors.push(typeError);
-                    }
-                }
-            }
-        }
-
-        return { valid: errors.length === 0, errors };
-    }
-
-    /**
-     * Validate a single parameter type
-     */
-    validateType(key, value, schema) {
-        const expectedType = schema.type;
-        if (!expectedType) return null;
-
-        const actualType = Array.isArray(value) ? 'array' : typeof value;
-
-        if (expectedType === 'integer' && (typeof value !== 'number' || !Number.isInteger(value))) {
-            return `Parameter "${key}" must be an integer`;
-        }
-        if (expectedType === 'number' && typeof value !== 'number') {
-            return `Parameter "${key}" must be a number`;
-        }
-        if (expectedType === 'string' && typeof value !== 'string') {
-            return `Parameter "${key}" must be a string`;
-        }
-        if (expectedType === 'boolean' && typeof value !== 'boolean') {
-            return `Parameter "${key}" must be a boolean`;
-        }
-        if (expectedType === 'array' && !Array.isArray(value)) {
-            return `Parameter "${key}" must be an array`;
-        }
-        if (expectedType === 'object' && (typeof value !== 'object' || Array.isArray(value))) {
-            return `Parameter "${key}" must be an object`;
-        }
-
-        return null;
-    }
 }
 
 function createScriptRunner(params = {}) {

package/src/application/validate-script-input.js

@@ -0,0 +1,116 @@
+/**
+ * Validate Script Input
+ *
+ * Application Layer - Standalone validation for script inputs.
+ * Used by the /validate endpoint to preview what would be executed
+ * without actually running the script.
+ */
+
+/**
+ * Validate script input parameters against the script's definition and schema.
+ *
+ * @param {Object} scriptFactory - Script factory instance
+ * @param {string} scriptName - Name of the script to validate
+ * @param {Object} params - Input parameters to validate
+ * @returns {Object} Validation preview result
+ */
+function validateScriptInput(scriptFactory, scriptName, params = {}) {
+    const scriptClass = scriptFactory.get(scriptName);
+    const definition = scriptClass.Definition;
+    const validation = validateParams(definition, params);
+
+    return {
+        status: validation.valid ? 'VALID' : 'INVALID',
+        scriptName,
+        preview: {
+            script: {
+                name: definition.name,
+                version: definition.version,
+                description: definition.description,
+                requireIntegrationInstance: definition.config?.requireIntegrationInstance || false,
+            },
+            input: params,
+            inputSchema: definition.inputSchema || null,
+            validation,
+        },
+        message: validation.valid
+            ? 'Validation passed. Script is ready to execute with provided parameters.'
+            : `Validation failed: ${validation.errors.join(', ')}`,
+    };
+}
+
+/**
+ * Validate parameters against a script's input schema.
+ *
+ * @param {Object} definition - Script definition
+ * @param {Object} params - Input parameters
+ * @returns {Object} { valid: boolean, errors: string[] }
+ */
+function validateParams(definition, params) {
+    const errors = [];
+    const schema = definition.inputSchema;
+
+    if (!schema) {
+        return { valid: true, errors: [] };
+    }
+
+    // Check required fields
+    if (schema.required && Array.isArray(schema.required)) {
+        for (const field of schema.required) {
+            if (params[field] === undefined || params[field] === null) {
+                errors.push(`Missing required parameter: ${field}`);
+            }
+        }
+    }
+
+    // Basic type validation for properties
+    if (schema.properties) {
+        for (const [key, prop] of Object.entries(schema.properties)) {
+            const value = params[key];
+            if (value !== undefined && value !== null) {
+                const typeError = validateType(key, value, prop);
+                if (typeError) {
+                    errors.push(typeError);
+                }
+            }
+        }
+    }
+
+    return { valid: errors.length === 0, errors };
+}
+
+/**
+ * Validate a single parameter type.
+ *
+ * @param {string} key - Parameter name
+ * @param {*} value - Parameter value
+ * @param {Object} schema - JSON Schema property definition
+ * @returns {string|null} Error message or null if valid
+ */
+function validateType(key, value, schema) {
+    const expectedType = schema.type;
+    if (!expectedType) return null;
+
+    if (expectedType === 'integer' && (typeof value !== 'number' || !Number.isInteger(value))) {
+        return `Parameter "${key}" must be an integer`;
+    }
+    if (expectedType === 'number' && typeof value !== 'number') {
+        return `Parameter "${key}" must be a number`;
+    }
+    if (expectedType === 'string' && typeof value !== 'string') {
+        return `Parameter "${key}" must be a string`;
+    }
+    if (expectedType === 'boolean' && typeof value !== 'boolean') {
+        return `Parameter "${key}" must be a boolean`;
+    }
+    if (expectedType === 'array' && !Array.isArray(value)) {
+        return `Parameter "${key}" must be an array`;
+    }
+    if (expectedType === 'object' && (typeof value !== 'object' || Array.isArray(value))) {
+        return `Parameter "${key}" must be an object`;
+    }
+
+    return null;
+}
+
+module.exports = { validateScriptInput, validateParams, validateType };

package/src/builtins/__tests__/integration-health-check.test.js

@@ -52,16 +52,18 @@ describe('IntegrationHealthCheckScript', () => {
         beforeEach(() => {
             mockContext = {
                 log: jest.fn(),
-                listIntegrations: jest.fn(),
-                findIntegrationById: jest.fn(),
+                integrationRepository: {
+                    findIntegrations: jest.fn(),
+                    findIntegrationById: jest.fn(),
+                    updateIntegrationStatus: jest.fn(),
+                },
                 instantiate: jest.fn(),
-                updateIntegrationStatus: jest.fn(),
             };
             script = new IntegrationHealthCheckScript({ context: mockContext });
         });
 
         it('should return empty results when no integrations found', async () => {
-            mockContext.listIntegrations.mockResolvedValue([]);
+            mockContext.integrationRepository.findIntegrations.mockResolvedValue([]);
 
             const result = await script.execute({});
 
@@ -91,7 +93,7 @@ describe('IntegrationHealthCheckScript', () => {
                 }
             };
 
-            mockContext.listIntegrations.mockResolvedValue([integration]);
+            mockContext.integrationRepository.findIntegrations.mockResolvedValue([integration]);
             mockContext.instantiate.mockResolvedValue(mockInstance);
 
             const result = await script.execute({
@@ -118,7 +120,7 @@ describe('IntegrationHealthCheckScript', () => {
                 }
             };
 
-            mockContext.listIntegrations.mockResolvedValue([integration]);
+            mockContext.integrationRepository.findIntegrations.mockResolvedValue([integration]);
 
             const result = await script.execute({
                 checkCredentials: true,
@@ -147,7 +149,7 @@ describe('IntegrationHealthCheckScript', () => {
                 }
             };
 
-            mockContext.listIntegrations.mockResolvedValue([integration]);
+            mockContext.integrationRepository.findIntegrations.mockResolvedValue([integration]);
 
             const result = await script.execute({
                 checkCredentials: true,
@@ -182,7 +184,7 @@ describe('IntegrationHealthCheckScript', () => {
                 }
             };
 
-            mockContext.listIntegrations.mockResolvedValue([integration]);
+            mockContext.integrationRepository.findIntegrations.mockResolvedValue([integration]);
             mockContext.instantiate.mockResolvedValue(mockInstance);
 
             const result = await script.execute({
@@ -215,9 +217,9 @@ describe('IntegrationHealthCheckScript', () => {
                 }
             };
 
-            mockContext.listIntegrations.mockResolvedValue([integration]);
+            mockContext.integrationRepository.findIntegrations.mockResolvedValue([integration]);
             mockContext.instantiate.mockResolvedValue(mockInstance);
-            mockContext.updateIntegrationStatus.mockResolvedValue(undefined);
+            mockContext.integrationRepository.updateIntegrationStatus.mockResolvedValue(undefined);
 
             const result = await script.execute({
                 checkCredentials: true,
@@ -226,7 +228,7 @@ describe('IntegrationHealthCheckScript', () => {
             });
 
             expect(result.healthy).toBe(1);
-            expect(mockContext.updateIntegrationStatus).toHaveBeenCalledWith('int-1', 'ACTIVE');
+            expect(mockContext.integrationRepository.updateIntegrationStatus).toHaveBeenCalledWith('int-1', 'ACTIVE');
         });
 
         it('should update integration status to ERROR for unhealthy integrations', async () => {
@@ -238,8 +240,8 @@ describe('IntegrationHealthCheckScript', () => {
                 }
             };
 
-            mockContext.listIntegrations.mockResolvedValue([integration]);
-            mockContext.updateIntegrationStatus.mockResolvedValue(undefined);
+            mockContext.integrationRepository.findIntegrations.mockResolvedValue([integration]);
+            mockContext.integrationRepository.updateIntegrationStatus.mockResolvedValue(undefined);
 
             const result = await script.execute({
                 checkCredentials: true,
@@ -248,7 +250,7 @@ describe('IntegrationHealthCheckScript', () => {
             });
 
             expect(result.unhealthy).toBe(1);
-            expect(mockContext.updateIntegrationStatus).toHaveBeenCalledWith('int-1', 'ERROR');
+            expect(mockContext.integrationRepository.updateIntegrationStatus).toHaveBeenCalledWith('int-1', 'ERROR');
         });
 
         it('should not update status when updateStatus is false', async () => {
@@ -271,7 +273,7 @@ describe('IntegrationHealthCheckScript', () => {
                 }
             };
 
-            mockContext.listIntegrations.mockResolvedValue([integration]);
+            mockContext.integrationRepository.findIntegrations.mockResolvedValue([integration]);
             mockContext.instantiate.mockResolvedValue(mockInstance);
 
             await script.execute({
@@ -280,7 +282,7 @@ describe('IntegrationHealthCheckScript', () => {
                 updateStatus: false
             });
 
-            expect(mockContext.updateIntegrationStatus).not.toHaveBeenCalled();
+            expect(mockContext.integrationRepository.updateIntegrationStatus).not.toHaveBeenCalled();
         });
 
         it('should handle status update failures gracefully', async () => {
@@ -303,9 +305,9 @@ describe('IntegrationHealthCheckScript', () => {
                 }
             };
 
-            mockContext.listIntegrations.mockResolvedValue([integration]);
+            mockContext.integrationRepository.findIntegrations.mockResolvedValue([integration]);
             mockContext.instantiate.mockResolvedValue(mockInstance);
-            mockContext.updateIntegrationStatus.mockRejectedValue(new Error('Update failed'));
+            mockContext.integrationRepository.updateIntegrationStatus.mockRejectedValue(new Error('Update failed'));
 
             const result = await script.execute({
                 checkCredentials: true,
@@ -331,7 +333,7 @@ describe('IntegrationHealthCheckScript', () => {
                 config: { type: 'salesforce', credentials: { access_token: 'token2' } }
             };
 
-            mockContext.findIntegrationById.mockImplementation((id) => {
+            mockContext.integrationRepository.findIntegrationById.mockImplementation((id) => {
                 if (id === 'int-1') return Promise.resolve(integration1);
                 if (id === 'int-2') return Promise.resolve(integration2);
                 return Promise.reject(new Error('Not found'));
@@ -343,9 +345,9 @@ describe('IntegrationHealthCheckScript', () => {
                 checkConnectivity: false
             });
 
-            expect(mockContext.findIntegrationById).toHaveBeenCalledWith('int-1');
-            expect(mockContext.findIntegrationById).toHaveBeenCalledWith('int-2');
-            expect(mockContext.listIntegrations).not.toHaveBeenCalled();
+            expect(mockContext.integrationRepository.findIntegrationById).toHaveBeenCalledWith('int-1');
+            expect(mockContext.integrationRepository.findIntegrationById).toHaveBeenCalledWith('int-2');
+            expect(mockContext.integrationRepository.findIntegrations).not.toHaveBeenCalled();
             expect(result.results).toHaveLength(2);
         });
 
@@ -361,7 +363,7 @@ describe('IntegrationHealthCheckScript', () => {
                 }
             };
 
-            mockContext.listIntegrations.mockResolvedValue([integration]);
+            mockContext.integrationRepository.findIntegrations.mockResolvedValue([integration]);
             mockContext.instantiate.mockRejectedValue(new Error('Instantiation failed'));
 
             const result = await script.execute({
@@ -391,7 +393,7 @@ describe('IntegrationHealthCheckScript', () => {
                 }
             };
 
-            mockContext.listIntegrations.mockResolvedValue([integration]);
+            mockContext.integrationRepository.findIntegrations.mockResolvedValue([integration]);
             mockContext.instantiate.mockResolvedValue(mockInstance);
 
             const result = await script.execute({
@@ -415,7 +417,7 @@ describe('IntegrationHealthCheckScript', () => {
                 }
             };
 
-            mockContext.listIntegrations.mockResolvedValue([integration]);
+            mockContext.integrationRepository.findIntegrations.mockResolvedValue([integration]);
 
             const result = await script.execute({
                 checkCredentials: true,

package/src/builtins/__tests__/oauth-token-refresh.test.js

@@ -46,15 +46,17 @@ describe('OAuthTokenRefreshScript', () => {
         beforeEach(() => {
             mockContext = {
                 log: jest.fn(),
-                listIntegrations: jest.fn(),
-                findIntegrationById: jest.fn(),
+                integrationRepository: {
+                    findIntegrations: jest.fn(),
+                    findIntegrationById: jest.fn(),
+                },
                 instantiate: jest.fn(),
             };
             script = new OAuthTokenRefreshScript({ context: mockContext });
         });
 
         it('should return empty results when no integrations found', async () => {
-            mockContext.listIntegrations.mockResolvedValue([]);
+            mockContext.integrationRepository.findIntegrations.mockResolvedValue([]);
 
             const result = await script.execute({});
 
@@ -70,7 +72,7 @@ describe('OAuthTokenRefreshScript', () => {
                 id: 'int-1',
                 config: {} // No credentials
             };
-            mockContext.listIntegrations.mockResolvedValue([integration]);
+            mockContext.integrationRepository.findIntegrations.mockResolvedValue([integration]);
 
             const result = await script.execute({});
 
@@ -93,7 +95,7 @@ describe('OAuthTokenRefreshScript', () => {
                     }
                 }
             };
-            mockContext.listIntegrations.mockResolvedValue([integration]);
+            mockContext.integrationRepository.findIntegrations.mockResolvedValue([integration]);
 
             const result = await script.execute({});
 
@@ -116,7 +118,7 @@ describe('OAuthTokenRefreshScript', () => {
                     }
                 }
             };
-            mockContext.listIntegrations.mockResolvedValue([integration]);
+            mockContext.integrationRepository.findIntegrations.mockResolvedValue([integration]);
 
             const result = await script.execute({
                 expiryThresholdHours: 24
@@ -150,7 +152,7 @@ describe('OAuthTokenRefreshScript', () => {
                 }
             };
 
-            mockContext.listIntegrations.mockResolvedValue([integration]);
+            mockContext.integrationRepository.findIntegrations.mockResolvedValue([integration]);
             mockContext.instantiate.mockResolvedValue(mockInstance);
 
             const result = await script.execute({
@@ -178,7 +180,7 @@ describe('OAuthTokenRefreshScript', () => {
                 }
             };
 
-            mockContext.listIntegrations.mockResolvedValue([integration]);
+            mockContext.integrationRepository.findIntegrations.mockResolvedValue([integration]);
 
             const result = await script.execute({
                 expiryThresholdHours: 24,
@@ -215,7 +217,7 @@ describe('OAuthTokenRefreshScript', () => {
                 }
             };
 
-            mockContext.listIntegrations.mockResolvedValue([integration]);
+            mockContext.integrationRepository.findIntegrations.mockResolvedValue([integration]);
             mockContext.instantiate.mockResolvedValue(mockInstance);
 
             const result = await script.execute({
@@ -251,7 +253,7 @@ describe('OAuthTokenRefreshScript', () => {
                 }
             };
 
-            mockContext.listIntegrations.mockResolvedValue([integration]);
+            mockContext.integrationRepository.findIntegrations.mockResolvedValue([integration]);
             mockContext.instantiate.mockResolvedValue(mockInstance);
 
             const result = await script.execute({
@@ -276,7 +278,7 @@ describe('OAuthTokenRefreshScript', () => {
                 config: { credentials: { access_token: 'token2' } }
             };
 
-            mockContext.findIntegrationById.mockImplementation((id) => {
+            mockContext.integrationRepository.findIntegrationById.mockImplementation((id) => {
                 if (id === 'int-1') return Promise.resolve(integration1);
                 if (id === 'int-2') return Promise.resolve(integration2);
                 return Promise.reject(new Error('Not found'));
@@ -286,9 +288,9 @@ describe('OAuthTokenRefreshScript', () => {
                 integrationIds: ['int-1', 'int-2']
             });
 
-            expect(mockContext.findIntegrationById).toHaveBeenCalledWith('int-1');
-            expect(mockContext.findIntegrationById).toHaveBeenCalledWith('int-2');
-            expect(mockContext.listIntegrations).not.toHaveBeenCalled();
+            expect(mockContext.integrationRepository.findIntegrationById).toHaveBeenCalledWith('int-1');
+            expect(mockContext.integrationRepository.findIntegrationById).toHaveBeenCalledWith('int-2');
+            expect(mockContext.integrationRepository.findIntegrations).not.toHaveBeenCalled();
             expect(result.details).toHaveLength(2);
         });
 
@@ -303,7 +305,7 @@ describe('OAuthTokenRefreshScript', () => {
                 }
             };
 
-            mockContext.listIntegrations.mockResolvedValue([integration]);
+            mockContext.integrationRepository.findIntegrations.mockResolvedValue([integration]);
             mockContext.instantiate.mockRejectedValue(new Error('Instantiation failed'));
 
             const result = await script.execute({

package/src/builtins/integration-health-check.js

@@ -94,7 +94,7 @@ class IntegrationHealthCheckScript extends AdminScriptBase {
         let integrations;
         if (integrationIds && integrationIds.length > 0) {
             integrations = await Promise.all(
-                integrationIds.map(id => this.context.findIntegrationById(id).catch(() => null))
+                integrationIds.map(id => this.context.integrationRepository.findIntegrationById(id).catch(() => null))
             );
             integrations = integrations.filter(Boolean);
         } else {
@@ -123,7 +123,7 @@ class IntegrationHealthCheckScript extends AdminScriptBase {
             if (updateStatus && result.status !== 'unknown') {
                 try {
                     const newStatus = result.status === 'healthy' ? 'ACTIVE' : 'ERROR';
-                    await this.context.updateIntegrationStatus(integration.id, newStatus);
+                    await this.context.integrationRepository.updateIntegrationStatus(integration.id, newStatus);
                     this.context.log('info', `Updated status for ${integration.id} to ${newStatus}`);
                 } catch (error) {
                     this.context.log('warn', `Failed to update status for ${integration.id}`, {
@@ -143,7 +143,7 @@ class IntegrationHealthCheckScript extends AdminScriptBase {
     }
 
     async getAllIntegrations() {
-        return this.context.listIntegrations({});
+        return this.context.integrationRepository.findIntegrations({});
     }
 
     async checkIntegration(integration, options) {

package/src/builtins/oauth-token-refresh.js

@@ -80,7 +80,7 @@ class OAuthTokenRefreshScript extends AdminScriptBase {
         let integrations;
         if (integrationIds && integrationIds.length > 0) {
             integrations = await Promise.all(
-                integrationIds.map(id => this.context.findIntegrationById(id).catch(() => null))
+                integrationIds.map(id => this.context.integrationRepository.findIntegrationById(id).catch(() => null))
             );
             integrations = integrations.filter(Boolean);
         } else {
@@ -131,7 +131,7 @@ class OAuthTokenRefreshScript extends AdminScriptBase {
     async getAllIntegrations() {
         // This is a simplified implementation
         // In production, would need pagination for large datasets
-        return this.context.listIntegrations({});
+        return this.context.integrationRepository.findIntegrations({});
     }
 
     async processIntegration(integration, options) {

package/src/infrastructure/__tests__/admin-script-router.test.js

@@ -181,7 +181,7 @@ describe('Admin Script Router', () => {
                 });
 
             expect(response.status).toBe(202);
-            expect(response.body.status).toBe('PENDING');
+            expect(response.body.status).toBe('QUEUED');
             expect(response.body.executionId).toBe('exec-456');
             expect(QueuerUtil.send).toHaveBeenCalledWith(
                 expect.objectContaining({
@@ -204,7 +204,7 @@ describe('Admin Script Router', () => {
                 });
 
             expect(response.status).toBe(202);
-            expect(response.body.status).toBe('PENDING');
+            expect(response.body.status).toBe('QUEUED');
         });
 
         it('should return 404 for non-existent script', async () => {