@fresh-editor/fresh-editor 0.3.8 → 0.3.9

package/CHANGELOG.md

@@ -1,5 +1,54 @@
 # Release Notes
 
+## 0.3.9
+
+### Features
+
+#### Universal Search (multi-scope Live Grep)
+
+Live Grep grows into a universal search overlay: search across multiple **scopes** — project files, open **Buffers**, and **Terminals** scrollback — with **Word** and **Regex** search modes (each keybindable). The overlay gets a clickable widget toolbar (focusable provider button, toggle controls), a full-width header band, and inline status shown in the overlay itself. Closed-terminal scrollback is retained so it stays searchable (#2099).
+
+#### Orchestrator & git worktrees
+
+* **Attach sessions to existing git worktrees** and discover them automatically (#2095).
+* Multi-select **bulk actions**, worktree ordering, and a *Show all worktrees* filter toggle.
+* Draggable scrollbars on the picker lists, with bulk-pane reorder.
+
+#### Editor
+
+* **Move to Next / Previous Paragraph** actions, including translations (#2084, contributed by @PavelLoparev; requested in #2083).
+
+#### Language Support
+
+* **C3** (`.c3`) syntax highlighting and LSP (#2101, requested by @data-man).
+
+#### Plugins & API
+
+* New `getWorkingDataDir()` (per-working-dir data root) and `getTerminalDir()` plugin APIs.
+* Overlay toolbar widget APIs — clickable `Toggle`/`Button` controls, `toggleOverlayToolbarWidget`, and a `Row { wrap }` layout that reflows toolbars across lines.
+
+### Improvements
+
+* The **dashboard no longer opens automatically** on startup by default. To re-enable it, open **Settings**, select **Plugin: dashboard**, and turn on **AutoOpen** ("Show the dashboard automatically when Fresh starts with no real files open."). The dashboard remains available any time via the **Show Dashboard** command.
+* Homebrew install simplified now that fresh-editor is in homebrew-core — `brew install fresh-editor`, no tap step.
+
+### Bug Fixes
+
+* Plugin `getCursorLine()` now returns the real cursor line instead of `0` (#2076, reported by @pmburov).
+* **Reduced serial-console lag** by not repainting on non-visual plugin async events (#2100, reported by @jetpax).
+* **Custom theme colours** no longer silently ignored for many UI fields (#2080, contributed by @flexiondotorg; reported in #2079).
+* `PageDown`/`PageUp` no longer overshoot on a single soft-wrapped line (#2085).
+* **Workspace restore** no longer mixes tabs from multiple projects in one window (#2056, reported by @mandolyte).
+* **Live Grep**: *Resume* keeps the query and opens the selected result; overlay preview and input-box undo/redo corrected; Buffers scope finds unmodified open buffers; non-file-scope previews and read-only data-dir files fixed.
+* `getKeybindingLabel` resolves correctly for bound plugin actions.
+
+### Internal
+
+* Major window refactor: window-scoped save/restore (`Window::from_workspace`), `WindowId`-parameterized persistence, `working_dir` derived from the active window, and `open_file`/LSP/watch helpers moved onto `Window`.
+* Orchestrator bring-up characterization tests and fixtures across persistence layouts.
+* Serial-console lag benchmark/diagnostic scripts; theme-key resolver schema-drift guard.
+* Internal docs excluded from the public docs build.
+
 ## 0.3.8
 
 ### Features / Improvements

package/README.md

@@ -84,7 +84,6 @@ On macOS and some linux distros (Bazzite/Bluefin/Aurora):
 > **Note:** On macOS, see [macOS Terminal Tips](https://getfresh.dev/docs/configuration/keyboard#macos-terminal-tips) for recommended terminal configuration.
 
 ```bash
-brew tap sinelaw/fresh
 brew install fresh-editor
 ```
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fresh-editor/fresh-editor",
-  "version": "0.3.8",
+  "version": "0.3.9",
   "description": "A modern terminal-based text editor with plugin support",
   "repository": {
     "type": "git",

package/plugins/dashboard.ts

@@ -16,7 +16,7 @@ const editor = getEditor();
 //   it is never loaded, so no buffers are created, no timers run,
 //   and no network fetches fire.
 //
-//   A second flag `plugins.dashboard.auto-open` (default true) gates
+//   A second flag `plugins.dashboard.auto-open` (default false) gates
 //   only the ambient open paths (startup + last-buffer-closed). When
 //   false the plugin still loads and the "Show Dashboard" command is
 //   still available — it just won't appear on its own.
@@ -1590,7 +1590,7 @@ registerHandler("dashboardShowOrFocus", dashboardShowOrFocus);
 // comes from the typed plugin-config field declared below. The field
 // shows up in the Settings UI under "Plugin Settings → dashboard".
 editor.defineConfigBoolean("autoOpen", {
-    default: true,
+    default: false,
     description: "Show the dashboard automatically when Fresh starts with no real files open.",
 });
 
@@ -1599,7 +1599,7 @@ let autoOpenOverride: boolean | null = null;
 function autoOpenEnabled(): boolean {
     if (autoOpenOverride !== null) return autoOpenOverride;
     const cfg = (editor.getPluginConfig() ?? {}) as { autoOpen?: boolean };
-    return cfg.autoOpen !== false;
+    return cfg.autoOpen === true;
 }
 
 function shouldShowDashboard(): boolean {

package/plugins/examples/bookmarks.ts

@@ -46,8 +46,9 @@ function getCurrentLocation(): {
 
 // Helper: Get actual line number using the API
 function getCurrentLineCol(): { line: number; column: number } {
-  // Use the actual getCursorLine API for accurate line number
-  const lineNumber = editor.getCursorLine();
+  // Read the primary cursor's line from the snapshot. `line` is null when the
+  // buffer has no line index yet (huge files); fall back to 0 there.
+  const lineNumber = editor.getPrimaryCursor()?.line ?? 0;
 
   // Get cursor position within the line by reading buffer content
   const bufferId = editor.getActiveBufferId();

package/plugins/lib/finder.ts

@@ -447,6 +447,33 @@ export class Finder<T> {
   // Mode flags
   private isPromptMode = false;
   private isPanelMode = false;
+  /** True when the active prompt is a centred floating overlay. Search
+   *  status then goes to the overlay's own footer (visible inside the frame)
+   *  rather than the editor status bar (off at the bottom, easy to miss). */
+  private isOverlay = false;
+
+  /** Present a search-status message where the user is actually looking: on
+   *  the overlay's input row (right-aligned by the match count) for a
+   *  floating overlay, else the editor status bar. */
+  private setSearchStatus(message: string): void {
+    if (this.isOverlay) {
+      this.editor.setPromptStatus(message);
+    } else {
+      this.editor.setStatus(message);
+    }
+  }
+
+  /** Report a successful search with `count` matches. In overlay mode the
+   *  "N / total" count on the input row already conveys this, so the status
+   *  is cleared to avoid duplicating it; the status bar (non-overlay) still
+   *  shows "Found N matches". */
+  private reportFound(count: number): void {
+    if (this.isOverlay) {
+      this.editor.setPromptStatus("");
+    } else {
+      this.editor.setStatus(`Found ${count} matches`);
+    }
+  }
 
   // Handler names (for cleanup)
   private handlerPrefix: string;
@@ -513,6 +540,7 @@ export class Finder<T> {
 
     // Start the prompt
     const overlay = options.floatingOverlay === true;
+    this.isOverlay = overlay;
     if (options.initialQuery) {
       this.editor.startPromptWithInitial(
         options.title,
@@ -525,7 +553,7 @@ export class Finder<T> {
       const result = this.editor.startPrompt(options.title, this.config.id, overlay);
       this.editor.debug(`[Finder] startPrompt returned: ${result}`);
     }
-    this.editor.setStatus("Type to search...");
+    this.setSearchStatus("Type to search…");
   }
 
   /**
@@ -545,6 +573,11 @@ export class Finder<T> {
     // unchanged query.
     this.promptState.lastQuery = "";
     if (query.length === 0) return;
+    // The backend (or scope set) changed, so the on-screen results are now
+    // stale. Clear them and show progress immediately rather than leaving the
+    // previous output up while the (possibly slow) new search runs.
+    this.updatePromptResults([]);
+    this.setSearchStatus("Searching…");
     await this.runSearch(query, this.currentSource);
   }
 
@@ -713,9 +746,9 @@ export class Finder<T> {
       this.updatePromptResults(filtered);
 
       if (filtered.length > 0) {
-        this.editor.setStatus(`Found ${filtered.length} matches`);
+        this.reportFound(filtered.length);
       } else {
-        this.editor.setStatus("No matches");
+        this.setSearchStatus("No matches");
       }
     } else {
       // Search mode: run external search
@@ -745,6 +778,7 @@ export class Finder<T> {
       }
       this.editor.setPromptSuggestions([]);
       this.promptState.results = [];
+      this.setSearchStatus("");
       return;
     }
 
@@ -768,6 +802,11 @@ export class Finder<T> {
     }
     this.promptState.lastQuery = query;
 
+    // A search is now actually starting (every query change that gets here —
+    // typing, deleting, provider/scope refresh). Show pending status so the
+    // user sees the re-scan in progress rather than a stale result count.
+    this.setSearchStatus("Searching…");
+
     try {
       const searchResult = source.search(query);
 
@@ -793,21 +832,21 @@ export class Finder<T> {
           this.updatePromptResults(parsed);
 
           if (parsed.length > 0) {
-            this.editor.setStatus(`Found ${parsed.length} matches`);
+            this.reportFound(parsed.length);
             // Show preview of first result
             if (this.shouldShowPreview()) {
               await this.updatePreview(this.promptState.entries[0]);
             }
           } else {
-            this.editor.setStatus("No matches");
+            this.setSearchStatus("No matches");
           }
         } else if (result.exit_code === 1) {
           // No matches
           this.updatePromptResults([]);
-          this.editor.setStatus("No matches");
+          this.setSearchStatus("No matches");
         } else if (result.exit_code !== -1) {
           // Error (ignore -1 which means killed)
-          this.editor.setStatus(`Search error: ${result.stderr}`);
+          this.setSearchStatus(`Search error: ${result.stderr}`);
         }
       } else {
         // Promise<T[]>
@@ -821,12 +860,12 @@ export class Finder<T> {
         this.updatePromptResults(results);
 
         if (results.length > 0) {
-          this.editor.setStatus(`Found ${results.length} matches`);
+          this.reportFound(results.length);
           if (this.shouldShowPreview()) {
             await this.updatePreview(this.promptState.entries[0]);
           }
         } else {
-          this.editor.setStatus("No matches");
+          this.setSearchStatus("No matches");
         }
       }
     } catch (e) {
@@ -864,7 +903,15 @@ export class Finder<T> {
       (entry, i) => ({
         text: entry.label,
         description: entry.description,
-        value: `${i}`,
+        // The preview pane uses `value` as the authoritative
+        // `path:line:col` for the result. We must not rely on parsing the
+        // user-facing label, which may carry source badges (e.g. "[term]")
+        // that make the label unparseable as a path.
+        value: entry.location
+          ? `${entry.location.file}:${entry.location.line}:${
+            entry.location.column ?? 1
+          }`
+          : `${i}`,
         disabled: false,
       })
     );

package/plugins/lib/fresh.d.ts

@@ -735,6 +735,13 @@ type CursorInfo = {
 		start: number;
 		end: number;
 	} | null;
+	/**
+	* 0-indexed line number of the cursor. `None` when the line index is
+	* unavailable — e.g. a huge file whose line scan hasn't completed, where
+	* the editor positions purely by byte offset. Plugins must treat `null`
+	* as "unknown", never as line 0.
+	*/
+	line: number | null;
 };
 type OverlayOptions = {
 	/**
@@ -1695,7 +1702,13 @@ interface EditorAPI {
 	*/
 	listSplits(): SplitSnapshot[];
 	/**
-	* Get the line number (0-indexed) of the primary cursor
+	* Get the line number (0-indexed) of the primary cursor.
+	* 
+	* @deprecated Use `getPrimaryCursor()?.line` instead. This accessor cannot
+	* represent "line index unavailable" (huge files before their line scan) —
+	* it returns `0` in that case, indistinguishable from a real first line.
+	* `getPrimaryCursor().line` is `number | null` and also covers every cursor
+	* via `getAllCursors()`.
 	*/
 	getCursorLine(): number;
 	/**
@@ -1864,38 +1877,17 @@ interface EditorAPI {
 	*/
 	getAuthorityLabel(): string;
 	/**
-	* Current Workspace Trust level for the active project:
-	* `"restricted"`, `"trusted"`, or `"blocked"` (empty `""` when trust
-	* state is unavailable, e.g. the default local authority).
-	*
-	* Trust is a per-project, user-granted decision. Plugins that run
-	* repo-controlled work (env activation, project tooling, repo-local
-	* binaries) MUST gate on this and treat anything other than
-	* `"trusted"` as "do not execute".
-	*/
-	workspaceTrustLevel(): "restricted" | "trusted" | "blocked" | "";
-	/**
-	* Activate an environment by setting the live env recipe: an activation
-	* shell `snippet` (e.g. `eval "$(direnv export bash)"`,
-	* `source .venv/bin/activate`, or `""` for a pure login shell) run in
-	* `dir` (defaults to the workspace). It is re-evaluated on demand on the
-	* active backend and applied to every spawn — language servers,
-	* formatters, `spawnProcess` — so they see the project environment. No
-	* authority rebuild; the LSP is restarted to pick it up.
-	*
-	* Honored only when `workspaceTrustLevel() === "trusted"` (it runs
-	* repo-controlled code). Call `clearEnv()` to deactivate.
-	*/
-	setEnv(snippet: string, dir?: string): void;
-	/**
-	* Deactivate the environment set by `setEnv` — spawns return to the
-	* inherited environment.
+	* Current Workspace Trust level for the active project: `"restricted"`,
+	* `"trusted"`, or `"blocked"` (empty when unavailable). Exposed to JS as
+	* `editor.workspaceTrustLevel()`. Plugins that run repo-controlled work
+	* should treat anything other than `"trusted"` as "do not execute".
 	*/
-	clearEnv(): void;
+	workspaceTrustLevel(): string;
 	/**
-	* Whether an environment is currently active (a recipe was set via
-	* `setEnv`). Survives the restart `setEnv` triggers, so a plugin can
-	* re-establish its file watch and reflect activation after reloading.
+	* Whether an environment is currently active (set via `editor.setEnv`).
+	* Exposed to JS as `editor.envActive()`. Lets the env-manager plugin
+	* reflect activation and re-establish its file watch after the restart
+	* that `setEnv` triggers.
 	*/
 	envActive(): boolean;
 	/**
@@ -2134,6 +2126,21 @@ interface EditorAPI {
 	*/
 	getDataDir(): string;
 	/**
+	* Per-working-directory data root for plugin state that should be scoped
+	* to the current project root / worktree rather than shared across all of
+	* them (`<data_dir>/workdirs/<encoded-cwd>/`). Prefer this over
+	* `getDataDir()` for per-project state; the directory is not created for
+	* you. Note: terminal scrollback and orchestrator state use their own
+	* dedicated layouts (see `getTerminalDir()`), not this root.
+	*/
+	getWorkingDataDir(): string;
+	/**
+	* Directory holding terminal scrollback backing files for the current
+	* working directory. Each project root / worktree has its own subdir, so
+	* a search can stay scoped to the active project's terminals.
+	*/
+	getTerminalDir(): string;
+	/**
 	* Get themes directory path
 	*/
 	getThemesDir(): string;
@@ -2472,6 +2479,29 @@ interface EditorAPI {
 	*/
 	setPromptFooter(footer: StyledText[]): boolean;
 	/**
+	* Set the floating-overlay prompt's header toolbar as a `WidgetSpec`
+	* (real, clickable `Toggle`/`Button` widgets), rendered in place of the
+	* styled-text title. Give each control a `key` equal to the action it
+	* should fire on click (e.g. `"live_grep_toggle_files"`). Pass `null` to
+	* clear it. No visible effect on non-overlay prompts.
+	*/
+	setPromptToolbar(spec: WidgetSpec | null): boolean;
+	/**
+	* Set the floating-overlay prompt's input-row status text, shown
+	* right-aligned just left of the `selected / total` count (e.g.
+	* "Searching…", "No matches"). Empty string clears it. No effect on
+	* non-overlay prompts.
+	*/
+	setPromptStatus(status: string): boolean;
+	/**
+	* Toggle a floating-overlay toolbar control by its widget `key`. The host
+	* owns the toggle's checked state, flips it in place, and emits a
+	* `widget_event` (`event_type: "toggle"`, payload `{ checked }`). Use this
+	* to route a plugin's own keyboard shortcut through the same host path as
+	* a click or Space on the toggle, then react in your `widget_event` handler.
+	*/
+	toggleOverlayToolbarWidget(key: string): boolean;
+	/**
 	* Override the currently-highlighted suggestion row in the
 	* open prompt. The editor clamps `index` to the suggestion
 	* list's bounds and the renderer scrolls it into view on
@@ -2860,6 +2890,16 @@ interface EditorAPI {
 	*/
 	clearAuthority(): void;
 	/**
+	* Activate an environment: set the live env recipe (`snippet` run in
+	* `dir`). Applied to every spawn, re-evaluated on demand — no restart.
+	* Honored only when the workspace is Trusted.
+	*/
+	setEnv(snippet: string, dir: string | null): void;
+	/**
+	* Deactivate the environment — spawns return to the inherited env.
+	*/
+	clearEnv(): void;
+	/**
 	* Override the Remote Indicator's displayed state. Plugins call
 	* this to surface lifecycle transitions that the authority layer
 	* doesn't know about yet — "Connecting" while `devcontainer up`

package/plugins/lib/widgets.ts

@@ -60,6 +60,14 @@ export function row(...children: WidgetSpec[]): WidgetSpec {
   return { kind: "row", children };
 }
 
+/** Horizontal layout that **wraps**: children that don't fit on one line
+ * reflow onto additional lines (growing the row's height) instead of being
+ * truncated. Children are never split, so wrap a logical group (e.g. a
+ * toggle + its accelerator) in a nested `row(...)` to keep it intact. */
+export function wrappingRow(...children: WidgetSpec[]): WidgetSpec {
+  return { kind: "row", children, wrap: true };
+}
+
 /** Vertical layout. Children stacked top-to-bottom. */
 export function col(...children: WidgetSpec[]): WidgetSpec {
   return { kind: "col", children };